* [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH
@ 2021-04-02 16:17 Randy Dunlap
2021-04-02 16:38 ` Andy Shevchenko
2021-04-02 18:20 ` Andy Shevchenko
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-04-02 16:17 UTC (permalink / raw)
Cc: Randy Dunlap, Andy Shevchenko, Andy Shevchenko, Linus Walleij,
linux-gpio, Bartosz Golaszewski, Denis Turischev
Since LPC_SCH provides GPIO functionality, GPIO_SCH should depend on
LPC_SCH to prevent kconfig warning and build errors:
WARNING: unmet direct dependencies detected for LPC_SCH
Depends on [n]: HAS_IOMEM [=y] && PCI [=n]
Selected by [y]:
- GPIO_SCH [=y] && GPIOLIB [=y] && X86 [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
and
../drivers/mfd/lpc_sch.c:204:1: warning: data definition has no type or storage class
module_pci_driver(lpc_sch_driver);
^~~~~~~~~~~~~~~~~
../drivers/mfd/lpc_sch.c:204:1: error: type defaults to ‘int’ in declaration of ‘module_pci_driver’ [-Werror=implicit-int]
../drivers/mfd/lpc_sch.c:204:1: warning: parameter names (without types) in function declaration
../drivers/mfd/lpc_sch.c:197:26: warning: ‘lpc_sch_driver’ defined but not used [-Wunused-variable]
static struct pci_driver lpc_sch_driver = {
^~~~~~~~~~~~~~
Fixes: 6c46215d6b62 ("gpio: sch: Hook into ACPI GPE handler to catch GPIO edge events")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Denis Turischev <denis@compulab.co.il>
---
v2: change to "depends on LPC_SCH" as suggested by Andy
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20210401.orig/drivers/gpio/Kconfig
+++ linux-next-20210401/drivers/gpio/Kconfig
@@ -861,9 +861,9 @@ config GPIO_IT87
config GPIO_SCH
tristate "Intel SCH/TunnelCreek/Centerton/Quark X1000 GPIO"
depends on (X86 || COMPILE_TEST) && ACPI
+ depends on LPC_SCH
select GPIOLIB_IRQCHIP
select MFD_CORE
- select LPC_SCH
help
Say yes here to support GPIO interface on Intel Poulsbo SCH,
Intel Tunnel Creek processor, Intel Centerton processor or
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH
2021-04-02 16:17 [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH Randy Dunlap
@ 2021-04-02 16:38 ` Andy Shevchenko
2021-04-02 18:15 ` Andy Shevchenko
2021-04-02 18:20 ` Andy Shevchenko
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2021-04-02 16:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: Andy Shevchenko, Linus Walleij, open list:GPIO SUBSYSTEM,
Bartosz Golaszewski, Denis Turischev
On Fri, Apr 2, 2021 at 7:18 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Since LPC_SCH provides GPIO functionality, GPIO_SCH should depend on
> LPC_SCH to prevent kconfig warning and build errors:
>
> WARNING: unmet direct dependencies detected for LPC_SCH
> Depends on [n]: HAS_IOMEM [=y] && PCI [=n]
> Selected by [y]:
> - GPIO_SCH [=y] && GPIOLIB [=y] && X86 [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
>
> and
>
> ../drivers/mfd/lpc_sch.c:204:1: warning: data definition has no type or storage class
> module_pci_driver(lpc_sch_driver);
> ^~~~~~~~~~~~~~~~~
> ../drivers/mfd/lpc_sch.c:204:1: error: type defaults to ‘int’ in declaration of ‘module_pci_driver’ [-Werror=implicit-int]
> ../drivers/mfd/lpc_sch.c:204:1: warning: parameter names (without types) in function declaration
> ../drivers/mfd/lpc_sch.c:197:26: warning: ‘lpc_sch_driver’ defined but not used [-Wunused-variable]
> static struct pci_driver lpc_sch_driver = {
> ^~~~~~~~~~~~~~
Thanks!
Bart, please, take it in your tree directly, or if you wish I may
collect this one together with Hans' one and send a PR.
> Fixes: 6c46215d6b62 ("gpio: sch: Hook into ACPI GPE handler to catch GPIO edge events")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Denis Turischev <denis@compulab.co.il>
> ---
> v2: change to "depends on LPC_SCH" as suggested by Andy
>
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210401.orig/drivers/gpio/Kconfig
> +++ linux-next-20210401/drivers/gpio/Kconfig
> @@ -861,9 +861,9 @@ config GPIO_IT87
> config GPIO_SCH
> tristate "Intel SCH/TunnelCreek/Centerton/Quark X1000 GPIO"
> depends on (X86 || COMPILE_TEST) && ACPI
> + depends on LPC_SCH
> select GPIOLIB_IRQCHIP
> select MFD_CORE
> - select LPC_SCH
> help
> Say yes here to support GPIO interface on Intel Poulsbo SCH,
> Intel Tunnel Creek processor, Intel Centerton processor or
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH
2021-04-02 16:38 ` Andy Shevchenko
@ 2021-04-02 18:15 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-04-02 18:15 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linus Walleij, open list:GPIO SUBSYSTEM, Bartosz Golaszewski,
Denis Turischev
On Fri, Apr 02, 2021 at 07:38:41PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 2, 2021 at 7:18 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > Since LPC_SCH provides GPIO functionality, GPIO_SCH should depend on
> > LPC_SCH to prevent kconfig warning and build errors:
> >
> > WARNING: unmet direct dependencies detected for LPC_SCH
> > Depends on [n]: HAS_IOMEM [=y] && PCI [=n]
> > Selected by [y]:
> > - GPIO_SCH [=y] && GPIOLIB [=y] && X86 [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
> >
> > and
> >
> > ../drivers/mfd/lpc_sch.c:204:1: warning: data definition has no type or storage class
> > module_pci_driver(lpc_sch_driver);
> > ^~~~~~~~~~~~~~~~~
> > ../drivers/mfd/lpc_sch.c:204:1: error: type defaults to ‘int’ in declaration of ‘module_pci_driver’ [-Werror=implicit-int]
> > ../drivers/mfd/lpc_sch.c:204:1: warning: parameter names (without types) in function declaration
> > ../drivers/mfd/lpc_sch.c:197:26: warning: ‘lpc_sch_driver’ defined but not used [-Wunused-variable]
> > static struct pci_driver lpc_sch_driver = {
> > ^~~~~~~~~~~~~~
>
> Thanks!
>
> Bart, please, take it in your tree directly, or if you wish I may
> collect this one together with Hans' one and send a PR.
Bart, nevermind. Same answer as to Hans' patch: I'll take care as usual.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH
2021-04-02 16:17 [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH Randy Dunlap
2021-04-02 16:38 ` Andy Shevchenko
@ 2021-04-02 18:20 ` Andy Shevchenko
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-04-02 18:20 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linus Walleij, linux-gpio, Bartosz Golaszewski, Denis Turischev
On Fri, Apr 02, 2021 at 09:17:51AM -0700, Randy Dunlap wrote:
> Since LPC_SCH provides GPIO functionality, GPIO_SCH should depend on
> LPC_SCH to prevent kconfig warning and build errors:
>
> WARNING: unmet direct dependencies detected for LPC_SCH
> Depends on [n]: HAS_IOMEM [=y] && PCI [=n]
> Selected by [y]:
> - GPIO_SCH [=y] && GPIOLIB [=y] && X86 [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
>
> and
>
> ../drivers/mfd/lpc_sch.c:204:1: warning: data definition has no type or storage class
> module_pci_driver(lpc_sch_driver);
> ^~~~~~~~~~~~~~~~~
> ../drivers/mfd/lpc_sch.c:204:1: error: type defaults to ‘int’ in declaration of ‘module_pci_driver’ [-Werror=implicit-int]
> ../drivers/mfd/lpc_sch.c:204:1: warning: parameter names (without types) in function declaration
> ../drivers/mfd/lpc_sch.c:197:26: warning: ‘lpc_sch_driver’ defined but not used [-Wunused-variable]
> static struct pci_driver lpc_sch_driver = {
> ^~~~~~~~~~~~~~
Pushed to my review and testing queue, thanks!
> Fixes: 6c46215d6b62 ("gpio: sch: Hook into ACPI GPE handler to catch GPIO edge events")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
I have dropped these two since my SoB will be there. But also I think it's
better to narrow down this kind of Cc list as much as possible (for example, we
know that Bart and Linus are maintainers of GPIO, no need to include them
explicitly here, just use --cc parameter when sending).
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Denis Turischev <denis@compulab.co.il>
> ---
> v2: change to "depends on LPC_SCH" as suggested by Andy
>
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210401.orig/drivers/gpio/Kconfig
> +++ linux-next-20210401/drivers/gpio/Kconfig
> @@ -861,9 +861,9 @@ config GPIO_IT87
> config GPIO_SCH
> tristate "Intel SCH/TunnelCreek/Centerton/Quark X1000 GPIO"
> depends on (X86 || COMPILE_TEST) && ACPI
> + depends on LPC_SCH
> select GPIOLIB_IRQCHIP
> select MFD_CORE
> - select LPC_SCH
> help
> Say yes here to support GPIO interface on Intel Poulsbo SCH,
> Intel Tunnel Creek processor, Intel Centerton processor or
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-02 18:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-02 16:17 [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH Randy Dunlap
2021-04-02 16:38 ` Andy Shevchenko
2021-04-02 18:15 ` Andy Shevchenko
2021-04-02 18:20 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.