[PATCH] staging: rtl8712: fix wrong function output

[PATCH] staging: rtl8712: fix wrong function output

[Sergei Krainov]

Function r8712_find_network() were returning wlan_network even if it
didn't match required address. This happened due to not checking if
list end was reached and returning last processed wlan_network.

Signed-off-by: Sergei Krainov <sergei.krainov.lkd@gmail.com>
---
 drivers/staging/rtl8712/rtl871x_mlme.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 8a97307fbbd6..c38161114b80 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -146,6 +146,8 @@ static struct wlan_network *r8712_find_network(struct  __queue *scanned_queue,
 		if (!memcmp(addr, pnetwork->network.MacAddress, ETH_ALEN))
 			break;
 	}
+	if (plist == phead)
+		pnetwork = NULL;
 	spin_unlock_irqrestore(&scanned_queue->lock, irqL);
 	return pnetwork;
 }
-- 
2.25.1

Re: [PATCH] staging: rtl8712: fix wrong function output

[Greg KH]

On Fri, Apr 09, 2021 at 01:45:27AM +0200, Sergei Krainov wrote:
> Function r8712_find_network() were returning wlan_network even if it
> didn't match required address. This happened due to not checking if
> list end was reached and returning last processed wlan_network.
> 
> Signed-off-by: Sergei Krainov <sergei.krainov.lkd@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_mlme.c | 2 ++
>  1 file changed, 2 insertions(+)

What commit does this "fix"?  Or has this bug been there always?

thanks,

greg k-h

Re: [PATCH] staging: rtl8712: fix wrong function output

[Sergei Krainov]

On Fri, Apr 09, 2021 at 08:33:23AM +0200, Greg KH wrote:
> On Fri, Apr 09, 2021 at 01:45:27AM +0200, Sergei Krainov wrote:
> > Function r8712_find_network() were returning wlan_network even if it
> > didn't match required address. This happened due to not checking if
> > list end was reached and returning last processed wlan_network.
> > 
> > Signed-off-by: Sergei Krainov <sergei.krainov.lkd@gmail.com>
> > ---
> >  drivers/staging/rtl8712/rtl871x_mlme.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> What commit does this "fix"?  Or has this bug been there always?
> 
> thanks,
> 
> greg k-h

This commit fixes the bug mentioned. 

And this commit is based on staging-next and has nothing to do
with my previous patches, for which I'm sorry, I was wrong.

Thanks a lot for review and your time,

Sergei

Re: [PATCH] staging: rtl8712: fix wrong function output

[Greg KH]

On Fri, Apr 09, 2021 at 01:41:59PM +0200, Sergei Krainov wrote:
> On Fri, Apr 09, 2021 at 08:33:23AM +0200, Greg KH wrote:
> > On Fri, Apr 09, 2021 at 01:45:27AM +0200, Sergei Krainov wrote:
> > > Function r8712_find_network() were returning wlan_network even if it
> > > didn't match required address. This happened due to not checking if
> > > list end was reached and returning last processed wlan_network.
> > > 
> > > Signed-off-by: Sergei Krainov <sergei.krainov.lkd@gmail.com>
> > > ---
> > >  drivers/staging/rtl8712/rtl871x_mlme.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > 
> > What commit does this "fix"?  Or has this bug been there always?
> > 
> > thanks,
> > 
> > greg k-h
> 
> This commit fixes the bug mentioned. 

What bug mentioned?

> And this commit is based on staging-next and has nothing to do
> with my previous patches, for which I'm sorry, I was wrong.

I do not understand at all, sorry.

Please resend with a "Fixes:" tag that shows the commit that this fixes.

thanks,

greg k-h