* [PATCH] drm/i915: Disable gpu relocations @ 2021-05-26 16:37 ` Daniel Vetter 0 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2021-05-26 16:37 UTC (permalink / raw) To: Intel Graphics Development Cc: Thomas Hellström, Daniel Vetter, DRI Development, Chris Wilson, Jon Bloomfield, Matthew Auld, Jason Ekstrand, Dave Airlie, Daniel Vetter Media userspace was the last userspace to still use them, and they converted now too: https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 This means no reason anymore to make relocations faster than they've been for the first 9 years of gem. This code was added in commit 7dd4f6729f9243bd7046c6f04c107a456bda38eb Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Fri Jun 16 15:05:24 2017 +0100 drm/i915: Async GPU relocation processing Furthermore there's pretty strong indications it's buggy, since the code to use it by default as the only option had to be reverted: commit ad5d95e4d538737ed3fa25493777decf264a3011 Author: Dave Airlie <airlied@redhat.com> Date: Tue Sep 8 15:41:17 2020 +1000 Revert "drm/i915/gem: Async GPU relocations only" This code just disables gpu relocations, leaving the garbage collection for later patches and more importantly, much less confusing diff. Also given how much headaches this code has caused in the past, letting this soak for a bit seems justified. Cc: Jon Bloomfield <jon.bloomfield@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: Dave Airlie <airlied@redhat.com> Cc: Jason Ekstrand <jason@jlekstrand.net> --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 43 ++++++++----------- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 297143511f99..31e904f79d0a 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -1571,7 +1571,7 @@ static int __reloc_entry_gpu(struct i915_execbuffer *eb, return true; } -static int reloc_entry_gpu(struct i915_execbuffer *eb, +static int __maybe_unused reloc_entry_gpu(struct i915_execbuffer *eb, struct i915_vma *vma, u64 offset, u64 target_addr) @@ -1593,32 +1593,25 @@ relocate_entry(struct i915_vma *vma, { u64 target_addr = relocation_target(reloc, target); u64 offset = reloc->offset; - int reloc_gpu = reloc_entry_gpu(eb, vma, offset, target_addr); - - if (reloc_gpu < 0) - return reloc_gpu; - - if (!reloc_gpu) { - bool wide = eb->reloc_cache.use_64bit_reloc; - void *vaddr; + bool wide = eb->reloc_cache.use_64bit_reloc; + void *vaddr; repeat: - vaddr = reloc_vaddr(vma->obj, eb, - offset >> PAGE_SHIFT); - if (IS_ERR(vaddr)) - return PTR_ERR(vaddr); - - GEM_BUG_ON(!IS_ALIGNED(offset, sizeof(u32))); - clflush_write32(vaddr + offset_in_page(offset), - lower_32_bits(target_addr), - eb->reloc_cache.vaddr); - - if (wide) { - offset += sizeof(u32); - target_addr >>= 32; - wide = false; - goto repeat; - } + vaddr = reloc_vaddr(vma->obj, eb, + offset >> PAGE_SHIFT); + if (IS_ERR(vaddr)) + return PTR_ERR(vaddr); + + GEM_BUG_ON(!IS_ALIGNED(offset, sizeof(u32))); + clflush_write32(vaddr + offset_in_page(offset), + lower_32_bits(target_addr), + eb->reloc_cache.vaddr); + + if (wide) { + offset += sizeof(u32); + target_addr >>= 32; + wide = false; + goto repeat; } return target->node.start | UPDATE; -- 2.31.0 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Disable gpu relocations @ 2021-05-26 16:37 ` Daniel Vetter 0 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2021-05-26 16:37 UTC (permalink / raw) To: Intel Graphics Development Cc: Thomas Hellström, Daniel Vetter, DRI Development, Chris Wilson, Matthew Auld, Dave Airlie, Daniel Vetter Media userspace was the last userspace to still use them, and they converted now too: https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 This means no reason anymore to make relocations faster than they've been for the first 9 years of gem. This code was added in commit 7dd4f6729f9243bd7046c6f04c107a456bda38eb Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Fri Jun 16 15:05:24 2017 +0100 drm/i915: Async GPU relocation processing Furthermore there's pretty strong indications it's buggy, since the code to use it by default as the only option had to be reverted: commit ad5d95e4d538737ed3fa25493777decf264a3011 Author: Dave Airlie <airlied@redhat.com> Date: Tue Sep 8 15:41:17 2020 +1000 Revert "drm/i915/gem: Async GPU relocations only" This code just disables gpu relocations, leaving the garbage collection for later patches and more importantly, much less confusing diff. Also given how much headaches this code has caused in the past, letting this soak for a bit seems justified. Cc: Jon Bloomfield <jon.bloomfield@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: Dave Airlie <airlied@redhat.com> Cc: Jason Ekstrand <jason@jlekstrand.net> --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 43 ++++++++----------- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 297143511f99..31e904f79d0a 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -1571,7 +1571,7 @@ static int __reloc_entry_gpu(struct i915_execbuffer *eb, return true; } -static int reloc_entry_gpu(struct i915_execbuffer *eb, +static int __maybe_unused reloc_entry_gpu(struct i915_execbuffer *eb, struct i915_vma *vma, u64 offset, u64 target_addr) @@ -1593,32 +1593,25 @@ relocate_entry(struct i915_vma *vma, { u64 target_addr = relocation_target(reloc, target); u64 offset = reloc->offset; - int reloc_gpu = reloc_entry_gpu(eb, vma, offset, target_addr); - - if (reloc_gpu < 0) - return reloc_gpu; - - if (!reloc_gpu) { - bool wide = eb->reloc_cache.use_64bit_reloc; - void *vaddr; + bool wide = eb->reloc_cache.use_64bit_reloc; + void *vaddr; repeat: - vaddr = reloc_vaddr(vma->obj, eb, - offset >> PAGE_SHIFT); - if (IS_ERR(vaddr)) - return PTR_ERR(vaddr); - - GEM_BUG_ON(!IS_ALIGNED(offset, sizeof(u32))); - clflush_write32(vaddr + offset_in_page(offset), - lower_32_bits(target_addr), - eb->reloc_cache.vaddr); - - if (wide) { - offset += sizeof(u32); - target_addr >>= 32; - wide = false; - goto repeat; - } + vaddr = reloc_vaddr(vma->obj, eb, + offset >> PAGE_SHIFT); + if (IS_ERR(vaddr)) + return PTR_ERR(vaddr); + + GEM_BUG_ON(!IS_ALIGNED(offset, sizeof(u32))); + clflush_write32(vaddr + offset_in_page(offset), + lower_32_bits(target_addr), + eb->reloc_cache.vaddr); + + if (wide) { + offset += sizeof(u32); + target_addr >>= 32; + wide = false; + goto repeat; } return target->node.start | UPDATE; -- 2.31.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Disable gpu relocations 2021-05-26 16:37 ` [Intel-gfx] " Daniel Vetter (?) @ 2021-05-26 22:21 ` Patchwork -1 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2021-05-26 22:21 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx == Series Details == Series: drm/i915: Disable gpu relocations URL : https://patchwork.freedesktop.org/series/90619/ State : warning == Summary == $ dim checkpatch origin/drm-tip b90d93e39441 drm/i915: Disable gpu relocations -:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #12: https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 -:17: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7dd4f6729f92 ("drm/i915: Async GPU relocation processing")' #17: commit 7dd4f6729f9243bd7046c6f04c107a456bda38eb -:26: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit ad5d95e4d538 ("Revert "drm/i915/gem: Async GPU relocations only"")' #26: commit ad5d95e4d538737ed3fa25493777decf264a3011 -:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #59: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1575: +static int __maybe_unused reloc_entry_gpu(struct i915_execbuffer *eb, struct i915_vma *vma, -:111: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>' total: 2 errors, 2 warnings, 1 checks, 57 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable gpu relocations 2021-05-26 16:37 ` [Intel-gfx] " Daniel Vetter (?) (?) @ 2021-05-26 22:51 ` Patchwork -1 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2021-05-26 22:51 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 5436 bytes --] == Series Details == Series: drm/i915: Disable gpu relocations URL : https://patchwork.freedesktop.org/series/90619/ State : success == Summary == CI Bug Log - changes from CI_DRM_10138 -> Patchwork_20210 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/index.html Known issues ------------ Here are the changes found in Patchwork_20210 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@core_hotunplug@unbind-rebind: - fi-bdw-5557u: NOTRUN -> [WARN][1] ([i915#2283]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html * igt@i915_selftest@live@execlists: - fi-bdw-5557u: NOTRUN -> [INCOMPLETE][2] ([i915#2940] / [i915#3462]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/fi-bdw-5557u/igt@i915_selftest@live@execlists.html * igt@kms_chamelium@dp-crc-fast: - fi-bdw-5557u: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827]) +8 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html * igt@kms_psr@cursor_plane_move: - fi-bdw-5557u: NOTRUN -> [SKIP][4] ([fdo#109271]) +9 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html #### Warnings #### * igt@i915_selftest@live@execlists: - fi-icl-u2: [DMESG-FAIL][5] ([i915#3462]) -> [INCOMPLETE][6] ([i915#2782] / [i915#3462]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-icl-u2/igt@i915_selftest@live@execlists.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/fi-icl-u2/igt@i915_selftest@live@execlists.html - fi-tgl-u2: [DMESG-FAIL][7] ([i915#3462]) -> [INCOMPLETE][8] ([i915#3462]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-tgl-u2/igt@i915_selftest@live@execlists.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/fi-tgl-u2/igt@i915_selftest@live@execlists.html * igt@runner@aborted: - fi-icl-u2: [FAIL][9] ([i915#2426] / [i915#2782] / [i915#3363]) -> [FAIL][10] ([i915#2782] / [i915#3363]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-icl-u2/igt@runner@aborted.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/fi-icl-u2/igt@runner@aborted.html - fi-bdw-5557u: [FAIL][11] ([i915#1602] / [i915#2029]) -> [FAIL][12] ([i915#3462]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-bdw-5557u/igt@runner@aborted.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/fi-bdw-5557u/igt@runner@aborted.html - fi-cml-u2: [FAIL][13] ([i915#2082] / [i915#2426] / [i915#3363] / [i915#3462]) -> [FAIL][14] ([i915#3363] / [i915#3462]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-cml-u2/igt@runner@aborted.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/fi-cml-u2/igt@runner@aborted.html - fi-kbl-7567u: [FAIL][15] ([i915#1436] / [i915#3363]) -> [FAIL][16] ([i915#1436] / [i915#2426] / [i915#3363]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-kbl-7567u/igt@runner@aborted.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/fi-kbl-7567u/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082 [i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782 [i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932 [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940 [i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966 [i915#3277]: https://gitlab.freedesktop.org/drm/intel/issues/3277 [i915#3283]: https://gitlab.freedesktop.org/drm/intel/issues/3283 [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363 [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462 Participating hosts (44 -> 40) ------------------------------ Missing (4): fi-cml-drallion fi-ilk-m540 fi-bdw-samus fi-hsw-4200u Build changes ------------- * Linux: CI_DRM_10138 -> Patchwork_20210 CI-20190529: 20190529 CI_DRM_10138: 041f69e539b30565783cd1298842cc269f5005cb @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6094: f62d8953c0bc5ed68ea978662e62f9dbb46cf101 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_20210: b90d93e39441d206fe837f7986d6dc803ac410f0 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == b90d93e39441 drm/i915: Disable gpu relocations == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/index.html [-- Attachment #1.2: Type: text/html, Size: 7143 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Disable gpu relocations 2021-05-26 16:37 ` [Intel-gfx] " Daniel Vetter @ 2021-05-26 23:57 ` Dave Airlie -1 siblings, 0 replies; 11+ messages in thread From: Dave Airlie @ 2021-05-26 23:57 UTC (permalink / raw) To: Daniel Vetter Cc: Thomas Hellström, Intel Graphics Development, DRI Development, Chris Wilson, Matthew Auld, Daniel Vetter, Dave Airlie On Thu, 27 May 2021 at 02:37, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > Media userspace was the last userspace to still use them, and they > converted now too: > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 > > This means no reason anymore to make relocations faster than they've > been for the first 9 years of gem. This code was added in > > commit 7dd4f6729f9243bd7046c6f04c107a456bda38eb > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Fri Jun 16 15:05:24 2017 +0100 > > drm/i915: Async GPU relocation processing > > Furthermore there's pretty strong indications it's buggy, since the > code to use it by default as the only option had to be reverted: > > commit ad5d95e4d538737ed3fa25493777decf264a3011 > Author: Dave Airlie <airlied@redhat.com> > Date: Tue Sep 8 15:41:17 2020 +1000 > > Revert "drm/i915/gem: Async GPU relocations only" > > This code just disables gpu relocations, leaving the garbage > collection for later patches and more importantly, much less confusing > diff. Also given how much headaches this code has caused in the past, > letting this soak for a bit seems justified. > > Cc: Jon Bloomfield <jon.bloomfield@intel.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > Cc: Dave Airlie <airlied@redhat.com> Acked-by: Dave Airlie <airlied@redhat.com> Thanks for making this happen, hope the softpin world is a happier future. Dave. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Disable gpu relocations @ 2021-05-26 23:57 ` Dave Airlie 0 siblings, 0 replies; 11+ messages in thread From: Dave Airlie @ 2021-05-26 23:57 UTC (permalink / raw) To: Daniel Vetter Cc: Thomas Hellström, Intel Graphics Development, DRI Development, Chris Wilson, Matthew Auld, Daniel Vetter, Dave Airlie On Thu, 27 May 2021 at 02:37, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > Media userspace was the last userspace to still use them, and they > converted now too: > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 > > This means no reason anymore to make relocations faster than they've > been for the first 9 years of gem. This code was added in > > commit 7dd4f6729f9243bd7046c6f04c107a456bda38eb > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Fri Jun 16 15:05:24 2017 +0100 > > drm/i915: Async GPU relocation processing > > Furthermore there's pretty strong indications it's buggy, since the > code to use it by default as the only option had to be reverted: > > commit ad5d95e4d538737ed3fa25493777decf264a3011 > Author: Dave Airlie <airlied@redhat.com> > Date: Tue Sep 8 15:41:17 2020 +1000 > > Revert "drm/i915/gem: Async GPU relocations only" > > This code just disables gpu relocations, leaving the garbage > collection for later patches and more importantly, much less confusing > diff. Also given how much headaches this code has caused in the past, > letting this soak for a bit seems justified. > > Cc: Jon Bloomfield <jon.bloomfield@intel.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > Cc: Dave Airlie <airlied@redhat.com> Acked-by: Dave Airlie <airlied@redhat.com> Thanks for making this happen, hope the softpin world is a happier future. Dave. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Disable gpu relocations 2021-05-26 16:37 ` [Intel-gfx] " Daniel Vetter ` (3 preceding siblings ...) (?) @ 2021-05-27 11:01 ` Patchwork -1 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2021-05-27 11:01 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30256 bytes --] == Series Details == Series: drm/i915: Disable gpu relocations URL : https://patchwork.freedesktop.org/series/90619/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10138_full -> Patchwork_20210_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_20210_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_20210_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20210_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_reloc@basic-spin@bcs0: - shard-tglb: [PASS][1] -> [FAIL][2] +8 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-tglb3/igt@gem_exec_reloc@basic-spin@bcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb1/igt@gem_exec_reloc@basic-spin@bcs0.html - shard-snb: [PASS][3] -> [FAIL][4] +2 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-snb7/igt@gem_exec_reloc@basic-spin@bcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-snb7/igt@gem_exec_reloc@basic-spin@bcs0.html * igt@gem_exec_reloc@basic-spin@vcs0: - shard-kbl: [PASS][5] -> [FAIL][6] +4 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-kbl3/igt@gem_exec_reloc@basic-spin@vcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl4/igt@gem_exec_reloc@basic-spin@vcs0.html * igt@gem_exec_schedule@deep@rcs0: - shard-glk: [PASS][7] -> [FAIL][8] +6 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-glk2/igt@gem_exec_schedule@deep@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk5/igt@gem_exec_schedule@deep@rcs0.html - shard-skl: [PASS][9] -> [FAIL][10] +6 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-skl2/igt@gem_exec_schedule@deep@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl2/igt@gem_exec_schedule@deep@rcs0.html * igt@gem_exec_schedule@deep@vcs0: - shard-kbl: NOTRUN -> [FAIL][11] +3 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl3/igt@gem_exec_schedule@deep@vcs0.html - shard-apl: [PASS][12] -> [FAIL][13] +2 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-apl8/igt@gem_exec_schedule@deep@vcs0.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl7/igt@gem_exec_schedule@deep@vcs0.html * igt@gem_exec_schedule@deep@vcs1: - shard-iclb: [PASS][14] -> [FAIL][15] +7 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-iclb4/igt@gem_exec_schedule@deep@vcs1.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb4/igt@gem_exec_schedule@deep@vcs1.html Known issues ------------ Here are the changes found in Patchwork_20210_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@feature_discovery@display-3x: - shard-tglb: NOTRUN -> [SKIP][16] ([i915#1839]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@feature_discovery@display-3x.html * igt@gem_ctx_persistence@legacy-engines-mixed: - shard-snb: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#1099]) +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-snb2/igt@gem_ctx_persistence@legacy-engines-mixed.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][18] -> [TIMEOUT][19] ([i915#2369] / [i915#3063]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-tglb3/igt@gem_eio@unwedge-stress.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb2/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-deadline: - shard-apl: NOTRUN -> [FAIL][20] ([i915#2846]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl6/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-kbl: [PASS][21] -> [SKIP][22] ([fdo#109271]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_fence@parallel@rcs0: - shard-glk: [PASS][23] -> [DMESG-WARN][24] ([i915#118] / [i915#95]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-glk6/igt@gem_exec_fence@parallel@rcs0.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk4/igt@gem_exec_fence@parallel@rcs0.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-apl: NOTRUN -> [FAIL][25] ([i915#2389]) +3 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl3/igt@gem_exec_reloc@basic-many-active@rcs0.html - shard-skl: [PASS][26] -> [FAIL][27] ([i915#2389]) +3 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-skl4/igt@gem_exec_reloc@basic-many-active@rcs0.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl3/igt@gem_exec_reloc@basic-many-active@rcs0.html - shard-tglb: [PASS][28] -> [FAIL][29] ([i915#2389]) +4 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-tglb6/igt@gem_exec_reloc@basic-many-active@rcs0.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb6/igt@gem_exec_reloc@basic-many-active@rcs0.html - shard-glk: [PASS][30] -> [FAIL][31] ([i915#2389]) +3 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-glk6/igt@gem_exec_reloc@basic-many-active@rcs0.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk6/igt@gem_exec_reloc@basic-many-active@rcs0.html - shard-iclb: [PASS][32] -> [FAIL][33] ([i915#2389]) +3 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-iclb1/igt@gem_exec_reloc@basic-many-active@rcs0.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb5/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@gem_exec_reloc@basic-many-active@vcs0: - shard-kbl: [PASS][34] -> [FAIL][35] ([i915#2389]) +4 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-kbl4/igt@gem_exec_reloc@basic-many-active@vcs0.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl4/igt@gem_exec_reloc@basic-many-active@vcs0.html * igt@gem_exec_reloc@basic-parallel: - shard-tglb: NOTRUN -> [TIMEOUT][36] ([i915#3183]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@gem_exec_reloc@basic-parallel.html - shard-apl: NOTRUN -> [TIMEOUT][37] ([i915#3183]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl2/igt@gem_exec_reloc@basic-parallel.html * igt@gem_exec_reloc@basic-wide-active@rcs0: - shard-snb: NOTRUN -> [FAIL][38] ([i915#2389]) +2 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-snb2/igt@gem_exec_reloc@basic-wide-active@rcs0.html * igt@gem_exec_schedule@deep@vecs0: - shard-iclb: [PASS][39] -> [FAIL][40] ([i915#2624]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-iclb4/igt@gem_exec_schedule@deep@vecs0.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb4/igt@gem_exec_schedule@deep@vecs0.html - shard-kbl: NOTRUN -> [FAIL][41] ([i915#2624]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl3/igt@gem_exec_schedule@deep@vecs0.html - shard-apl: [PASS][42] -> [FAIL][43] ([i915#2624]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-apl8/igt@gem_exec_schedule@deep@vecs0.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl7/igt@gem_exec_schedule@deep@vecs0.html - shard-skl: [PASS][44] -> [FAIL][45] ([i915#2624]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-skl2/igt@gem_exec_schedule@deep@vecs0.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl2/igt@gem_exec_schedule@deep@vecs0.html - shard-tglb: [PASS][46] -> [FAIL][47] ([i915#2624]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-tglb3/igt@gem_exec_schedule@deep@vecs0.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb2/igt@gem_exec_schedule@deep@vecs0.html - shard-glk: [PASS][48] -> [FAIL][49] ([i915#2624]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-glk2/igt@gem_exec_schedule@deep@vecs0.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk5/igt@gem_exec_schedule@deep@vecs0.html * igt@gem_mmap_gtt@big-copy-xy: - shard-glk: [PASS][50] -> [FAIL][51] ([i915#307]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-glk4/igt@gem_mmap_gtt@big-copy-xy.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk5/igt@gem_mmap_gtt@big-copy-xy.html * igt@gem_mmap_gtt@cpuset-basic-small-copy: - shard-apl: [PASS][52] -> [INCOMPLETE][53] ([i915#3468]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-apl6/igt@gem_mmap_gtt@cpuset-basic-small-copy.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl3/igt@gem_mmap_gtt@cpuset-basic-small-copy.html * igt@gem_mmap_gtt@cpuset-basic-small-copy-odd: - shard-apl: NOTRUN -> [INCOMPLETE][54] ([i915#3468]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl6/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html - shard-kbl: [PASS][55] -> [INCOMPLETE][56] ([i915#3468]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-kbl2/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl2/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html * igt@gem_mmap_gtt@cpuset-basic-small-copy-xy: - shard-iclb: [PASS][57] -> [INCOMPLETE][58] ([i915#3468]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-iclb6/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb5/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html * igt@gem_mmap_gtt@cpuset-medium-copy-xy: - shard-tglb: [PASS][59] -> [INCOMPLETE][60] ([i915#3468] / [i915#750]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-tglb7/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb5/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html * igt@gem_mmap_gtt@fault-concurrent-x: - shard-skl: NOTRUN -> [INCOMPLETE][61] ([i915#198] / [i915#3468]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl3/igt@gem_mmap_gtt@fault-concurrent-x.html - shard-kbl: NOTRUN -> [INCOMPLETE][62] ([i915#3468]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl1/igt@gem_mmap_gtt@fault-concurrent-x.html * igt@gem_mmap_gtt@fault-concurrent-y: - shard-skl: NOTRUN -> [INCOMPLETE][63] ([i915#3468]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl1/igt@gem_mmap_gtt@fault-concurrent-y.html * igt@gem_mmap_gtt@medium-copy-xy: - shard-glk: NOTRUN -> [INCOMPLETE][64] ([i915#2055] / [i915#2502] / [i915#3468]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk8/igt@gem_mmap_gtt@medium-copy-xy.html * igt@gem_mmap_offset@clear: - shard-skl: [PASS][65] -> [FAIL][66] ([i915#3160]) +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-skl4/igt@gem_mmap_offset@clear.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl7/igt@gem_mmap_offset@clear.html * igt@gem_pread@exhaustion: - shard-snb: NOTRUN -> [WARN][67] ([i915#2658]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-snb7/igt@gem_pread@exhaustion.html * igt@gem_userptr_blits@dmabuf-sync: - shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#3323]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl3/igt@gem_userptr_blits@dmabuf-sync.html * igt@gem_userptr_blits@unsync-unmap: - shard-iclb: NOTRUN -> [SKIP][69] ([i915#3297]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb4/igt@gem_userptr_blits@unsync-unmap.html * igt@gem_userptr_blits@vma-merge: - shard-apl: NOTRUN -> [FAIL][70] ([i915#3318]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl2/igt@gem_userptr_blits@vma-merge.html * igt@gen7_exec_parse@batch-without-end: - shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109289]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb4/igt@gen7_exec_parse@batch-without-end.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [PASS][72] -> [DMESG-WARN][73] ([i915#1436] / [i915#716]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-glk7/igt@gen9_exec_parse@allowed-all.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk4/igt@gen9_exec_parse@allowed-all.html * igt@kms_big_joiner@invalid-modeset: - shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#2705]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl8/igt@kms_big_joiner@invalid-modeset.html * igt@kms_ccs@pipe-c-ccs-on-another-bo: - shard-skl: NOTRUN -> [SKIP][75] ([fdo#109271] / [fdo#111304]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl3/igt@kms_ccs@pipe-c-ccs-on-another-bo.html * igt@kms_chamelium@dp-frame-dump: - shard-iclb: NOTRUN -> [SKIP][76] ([fdo#109284] / [fdo#111827]) +2 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb4/igt@kms_chamelium@dp-frame-dump.html * igt@kms_chamelium@hdmi-aspect-ratio: - shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271] / [fdo#111827]) +5 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl3/igt@kms_chamelium@hdmi-aspect-ratio.html - shard-kbl: NOTRUN -> [SKIP][78] ([fdo#109271] / [fdo#111827]) +4 similar issues [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl1/igt@kms_chamelium@hdmi-aspect-ratio.html * igt@kms_chamelium@vga-edid-read: - shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [fdo#111827]) +26 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl3/igt@kms_chamelium@vga-edid-read.html * igt@kms_chamelium@vga-hpd-for-each-pipe: - shard-glk: NOTRUN -> [SKIP][80] ([fdo#109271] / [fdo#111827]) +2 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk2/igt@kms_chamelium@vga-hpd-for-each-pipe.html * igt@kms_color_chamelium@pipe-a-ctm-0-75: - shard-tglb: NOTRUN -> [SKIP][81] ([fdo#109284] / [fdo#111827]) +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@kms_color_chamelium@pipe-a-ctm-0-75.html * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red: - shard-snb: NOTRUN -> [SKIP][82] ([fdo#109271] / [fdo#111827]) +13 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-snb2/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html * igt@kms_color_chamelium@pipe-d-gamma: - shard-iclb: NOTRUN -> [SKIP][83] ([fdo#109278] / [fdo#109284] / [fdo#111827]) +1 similar issue [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb4/igt@kms_color_chamelium@pipe-d-gamma.html * igt@kms_content_protection@atomic-dpms: - shard-apl: NOTRUN -> [TIMEOUT][84] ([i915#1319]) +1 similar issue [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl3/igt@kms_content_protection@atomic-dpms.html * igt@kms_content_protection@dp-mst-lic-type-0: - shard-tglb: NOTRUN -> [SKIP][85] ([i915#3116]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@kms_content_protection@dp-mst-lic-type-0.html * igt@kms_cursor_crc@pipe-a-cursor-32x32-sliding: - shard-tglb: NOTRUN -> [SKIP][86] ([i915#3319]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@kms_cursor_crc@pipe-a-cursor-32x32-sliding.html * igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][87] ([fdo#109279] / [i915#3359]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement.html * igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen: - shard-kbl: NOTRUN -> [FAIL][88] ([i915#3444]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html - shard-apl: NOTRUN -> [FAIL][89] ([i915#3444]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html * igt@kms_cursor_crc@pipe-d-cursor-32x10-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][90] ([i915#3359]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@kms_cursor_crc@pipe-d-cursor-32x10-rapid-movement.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-tglb: NOTRUN -> [CRASH][91] ([i915#3494]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [PASS][92] -> [INCOMPLETE][93] ([i915#155] / [i915#180] / [i915#636]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-flip-vs-rmfb: - shard-tglb: NOTRUN -> [SKIP][94] ([fdo#111825]) +4 similar issues [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@kms_flip@2x-flip-vs-rmfb.html * igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@b-edp1: - shard-skl: [PASS][95] -> [FAIL][96] ([i915#2122]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-skl10/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@b-edp1.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl3/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@b-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][97] -> [DMESG-WARN][98] ([i915#180]) +4 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend@c-dp1: - shard-apl: [PASS][99] -> [DMESG-WARN][100] ([i915#180]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-apl6/igt@kms_flip@flip-vs-suspend@c-dp1.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl1/igt@kms_flip@flip-vs-suspend@c-dp1.html * igt@kms_flip_tiling@flip-x-tiled@edp-1-pipe-c: - shard-skl: [PASS][101] -> [FAIL][102] ([i915#2767]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-skl7/igt@kms_flip_tiling@flip-x-tiled@edp-1-pipe-c.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl7/igt@kms_flip_tiling@flip-x-tiled@edp-1-pipe-c.html * igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt: - shard-skl: NOTRUN -> [SKIP][103] ([fdo#109271]) +62 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl3/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite: - shard-snb: NOTRUN -> [SKIP][104] ([fdo#109271]) +257 similar issues [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-snb7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc: - shard-glk: NOTRUN -> [SKIP][105] ([fdo#109271]) +27 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-cpu: - shard-iclb: [PASS][106] -> [FAIL][107] ([i915#49]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-cpu.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-indfb-plflip-blt: - shard-iclb: NOTRUN -> [SKIP][108] ([fdo#109280]) +2 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-indfb-plflip-blt.html * igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c: - shard-tglb: NOTRUN -> [SKIP][109] ([fdo#109289]) [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c.html * igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d: - shard-apl: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#533]) +1 similar issue [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html * igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence: - shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#533]) [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl3/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html * igt@kms_plane_alpha_blend@pipe-a-alpha-basic: - shard-apl: NOTRUN -> [FAIL][112] ([fdo#108145] / [i915#265]) +5 similar issues [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][113] ([i915#265]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [PASS][114] -> [FAIL][115] ([fdo#108145] / [i915#265]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-kbl: NOTRUN -> [FAIL][116] ([i915#265]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4: - shard-apl: NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#658]) +7 similar issues [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1: - shard-skl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#658]) +1 similar issue [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html - shard-kbl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#658]) +1 similar issue [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html * igt@kms_psr2_su@page_flip: - shard-glk: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#658]) +1 similar issue [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk8/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_dpms: - shard-iclb: [PASS][121] -> [SKIP][122] ([fdo#109441]) +1 similar issue [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-iclb2/igt@kms_psr@psr2_dpms.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb1/igt@kms_psr@psr2_dpms.html * igt@kms_setmode@basic: - shard-snb: NOTRUN -> [FAIL][123] ([i915#31]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-snb5/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-d-wait-forked: - shard-iclb: NOTRUN -> [SKIP][124] ([fdo#109278]) +1 similar issue [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb4/igt@kms_vblank@pipe-d-wait-forked.html * igt@kms_vblank@pipe-d-wait-idle: - shard-glk: NOTRUN -> [SKIP][125] ([fdo#109271] / [i915#533]) [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk2/igt@kms_vblank@pipe-d-wait-idle.html * igt@kms_writeback@writeback-fb-id: - shard-skl: NOTRUN -> [SKIP][126] ([fdo#109271] / [i915#2437]) [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl1/igt@kms_writeback@writeback-fb-id.html * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame: - shard-apl: NOTRUN -> [SKIP][127] ([fdo#109271]) +269 similar issues [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl6/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html * igt@nouveau_crc@pipe-b-source-outp-complete: - shard-tglb: NOTRUN -> [SKIP][128] ([i915#2530]) [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@nouveau_crc@pipe-b-source-outp-complete.html * igt@perf@polling-small-buf: - shard-skl: [PASS][129] -> [FAIL][130] ([i915#1722]) [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-skl3/igt@perf@polling-small-buf.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl1/igt@perf@polling-small-buf.html * igt@prime_nv_pcopy@test2: - shard-kbl: NOTRUN -> [SKIP][131] ([fdo#109271]) +76 similar issues [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl3/igt@prime_nv_pcopy@test2.html * igt@prime_nv_pcopy@test3_3: - shard-iclb: NOTRUN -> [SKIP][132] ([fdo#109291]) [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-iclb4/igt@prime_nv_pcopy@test3_3.html * igt@prime_nv_pcopy@test3_4: - shard-tglb: NOTRUN -> [SKIP][133] ([fdo#109291]) [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb8/igt@prime_nv_pcopy@test3_4.html * igt@sysfs_clients@create: - shard-skl: NOTRUN -> [SKIP][134] ([fdo#109271] / [i915#2994]) [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-skl3/igt@sysfs_clients@create.html * igt@sysfs_clients@recycle: - shard-glk: NOTRUN -> [SKIP][135] ([fdo#109271] / [i915#2994]) [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk2/igt@sysfs_clients@recycle.html * igt@sysfs_clients@recycle-many: - shard-apl: NOTRUN -> [SKIP][136] ([fdo#109271] / [i915#2994]) +3 similar issues [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-apl6/igt@sysfs_clients@recycle-many.html * igt@sysfs_clients@split-50: - shard-kbl: NOTRUN -> [SKIP][137] ([fdo#109271] / [i915#2994]) +2 similar issues [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-kbl7/igt@sysfs_clients@split-50.html #### Possible fixes #### * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][138] ([i915#2842]) -> [PASS][139] +1 similar issue [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-tglb: [FAIL][140] ([i915#2842]) -> [PASS][141] +1 similar issue [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-tglb7/igt@gem_exec_fair@basic-pace-solo@rcs0.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-tglb7/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_mmap_gtt@cpuset-basic-small-copy: - shard-glk: [INCOMPLETE][142] ([i915#2055] / [i915#3468]) -> [PASS][143] [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/shard-glk9/igt@gem_mmap_gtt@cpuset-basic-small-copy.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/shard-glk2/igt@gem_mmap_gtt@cpuset-basic-small-copy.html * igt@gem_mmap_gtt@cpuset-basic-small-copy-xy: - shard-tglb == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20210/index.html [-- Attachment #1.2: Type: text/html, Size: 33584 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Disable gpu relocations 2021-05-26 16:37 ` [Intel-gfx] " Daniel Vetter @ 2021-05-27 11:16 ` Maarten Lankhorst -1 siblings, 0 replies; 11+ messages in thread From: Maarten Lankhorst @ 2021-05-27 11:16 UTC (permalink / raw) To: Daniel Vetter, Intel Graphics Development Cc: Thomas Hellström, DRI Development, Chris Wilson, Jon Bloomfield, Matthew Auld, Jason Ekstrand, Dave Airlie, Daniel Vetter Op 2021-05-26 om 18:37 schreef Daniel Vetter: > Media userspace was the last userspace to still use them, and they > converted now too: > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 > > This means no reason anymore to make relocations faster than they've > been for the first 9 years of gem. This code was added in > > commit 7dd4f6729f9243bd7046c6f04c107a456bda38eb > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Fri Jun 16 15:05:24 2017 +0100 > > drm/i915: Async GPU relocation processing > > Furthermore there's pretty strong indications it's buggy, since the > code to use it by default as the only option had to be reverted: > > commit ad5d95e4d538737ed3fa25493777decf264a3011 > Author: Dave Airlie <airlied@redhat.com> > Date: Tue Sep 8 15:41:17 2020 +1000 > > Revert "drm/i915/gem: Async GPU relocations only" > > This code just disables gpu relocations, leaving the garbage > collection for later patches and more importantly, much less confusing > diff. Also given how much headaches this code has caused in the past, > letting this soak for a bit seems justified. > > Cc: Jon Bloomfield <jon.bloomfield@intel.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > Cc: Dave Airlie <airlied@redhat.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 43 ++++++++----------- > 1 file changed, 18 insertions(+), 25 deletions(-) Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Note that a lot of complexity may be removed with gpu relocations gone. Some igt tests might also start to fail, as they expect relocations to complete asynchronously. Is it kept in case we need to revive it? ~Maarten ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Disable gpu relocations @ 2021-05-27 11:16 ` Maarten Lankhorst 0 siblings, 0 replies; 11+ messages in thread From: Maarten Lankhorst @ 2021-05-27 11:16 UTC (permalink / raw) To: Daniel Vetter, Intel Graphics Development Cc: Thomas Hellström, DRI Development, Chris Wilson, Matthew Auld, Dave Airlie, Daniel Vetter Op 2021-05-26 om 18:37 schreef Daniel Vetter: > Media userspace was the last userspace to still use them, and they > converted now too: > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 > > This means no reason anymore to make relocations faster than they've > been for the first 9 years of gem. This code was added in > > commit 7dd4f6729f9243bd7046c6f04c107a456bda38eb > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Fri Jun 16 15:05:24 2017 +0100 > > drm/i915: Async GPU relocation processing > > Furthermore there's pretty strong indications it's buggy, since the > code to use it by default as the only option had to be reverted: > > commit ad5d95e4d538737ed3fa25493777decf264a3011 > Author: Dave Airlie <airlied@redhat.com> > Date: Tue Sep 8 15:41:17 2020 +1000 > > Revert "drm/i915/gem: Async GPU relocations only" > > This code just disables gpu relocations, leaving the garbage > collection for later patches and more importantly, much less confusing > diff. Also given how much headaches this code has caused in the past, > letting this soak for a bit seems justified. > > Cc: Jon Bloomfield <jon.bloomfield@intel.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > Cc: Dave Airlie <airlied@redhat.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 43 ++++++++----------- > 1 file changed, 18 insertions(+), 25 deletions(-) Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Note that a lot of complexity may be removed with gpu relocations gone. Some igt tests might also start to fail, as they expect relocations to complete asynchronously. Is it kept in case we need to revive it? ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Disable gpu relocations 2021-05-27 11:16 ` [Intel-gfx] " Maarten Lankhorst @ 2021-05-27 11:22 ` Daniel Vetter -1 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2021-05-27 11:22 UTC (permalink / raw) To: Maarten Lankhorst Cc: Thomas Hellström, Daniel Vetter, Intel Graphics Development, DRI Development, Chris Wilson, Jon Bloomfield, Matthew Auld, Jason Ekstrand, Dave Airlie, Daniel Vetter On Thu, May 27, 2021 at 01:16:13PM +0200, Maarten Lankhorst wrote: > Op 2021-05-26 om 18:37 schreef Daniel Vetter: > > Media userspace was the last userspace to still use them, and they > > converted now too: > > > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 > > > > This means no reason anymore to make relocations faster than they've > > been for the first 9 years of gem. This code was added in > > > > commit 7dd4f6729f9243bd7046c6f04c107a456bda38eb > > Author: Chris Wilson <chris@chris-wilson.co.uk> > > Date: Fri Jun 16 15:05:24 2017 +0100 > > > > drm/i915: Async GPU relocation processing > > > > Furthermore there's pretty strong indications it's buggy, since the > > code to use it by default as the only option had to be reverted: > > > > commit ad5d95e4d538737ed3fa25493777decf264a3011 > > Author: Dave Airlie <airlied@redhat.com> > > Date: Tue Sep 8 15:41:17 2020 +1000 > > > > Revert "drm/i915/gem: Async GPU relocations only" > > > > This code just disables gpu relocations, leaving the garbage > > collection for later patches and more importantly, much less confusing > > diff. Also given how much headaches this code has caused in the past, > > letting this soak for a bit seems justified. > > > > Cc: Jon Bloomfield <jon.bloomfield@intel.com> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> > > Cc: Matthew Auld <matthew.auld@intel.com> > > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > > Cc: Dave Airlie <airlied@redhat.com> > > Cc: Jason Ekstrand <jason@jlekstrand.net> > > --- > > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 43 ++++++++----------- > > 1 file changed, 18 insertions(+), 25 deletions(-) > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Note that a lot of complexity may be removed with gpu relocations gone. > Some igt tests might also start to fail, as they expect relocations to > complete asynchronously. Yeah I have the kernel side patch for that, at least in the execbuf code + selftests. For igt I'm wawiting on CI to tell me what I all need to look at and decide what to do with it. > Is it kept in case we need to revive it? I don't want to revive it, but I want to split the huge code changes from the functional changes at least. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Disable gpu relocations @ 2021-05-27 11:22 ` Daniel Vetter 0 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2021-05-27 11:22 UTC (permalink / raw) To: Maarten Lankhorst Cc: Thomas Hellström, Daniel Vetter, Intel Graphics Development, DRI Development, Chris Wilson, Matthew Auld, Dave Airlie, Daniel Vetter On Thu, May 27, 2021 at 01:16:13PM +0200, Maarten Lankhorst wrote: > Op 2021-05-26 om 18:37 schreef Daniel Vetter: > > Media userspace was the last userspace to still use them, and they > > converted now too: > > > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 > > > > This means no reason anymore to make relocations faster than they've > > been for the first 9 years of gem. This code was added in > > > > commit 7dd4f6729f9243bd7046c6f04c107a456bda38eb > > Author: Chris Wilson <chris@chris-wilson.co.uk> > > Date: Fri Jun 16 15:05:24 2017 +0100 > > > > drm/i915: Async GPU relocation processing > > > > Furthermore there's pretty strong indications it's buggy, since the > > code to use it by default as the only option had to be reverted: > > > > commit ad5d95e4d538737ed3fa25493777decf264a3011 > > Author: Dave Airlie <airlied@redhat.com> > > Date: Tue Sep 8 15:41:17 2020 +1000 > > > > Revert "drm/i915/gem: Async GPU relocations only" > > > > This code just disables gpu relocations, leaving the garbage > > collection for later patches and more importantly, much less confusing > > diff. Also given how much headaches this code has caused in the past, > > letting this soak for a bit seems justified. > > > > Cc: Jon Bloomfield <jon.bloomfield@intel.com> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> > > Cc: Matthew Auld <matthew.auld@intel.com> > > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > > Cc: Dave Airlie <airlied@redhat.com> > > Cc: Jason Ekstrand <jason@jlekstrand.net> > > --- > > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 43 ++++++++----------- > > 1 file changed, 18 insertions(+), 25 deletions(-) > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Note that a lot of complexity may be removed with gpu relocations gone. > Some igt tests might also start to fail, as they expect relocations to > complete asynchronously. Yeah I have the kernel side patch for that, at least in the execbuf code + selftests. For igt I'm wawiting on CI to tell me what I all need to look at and decide what to do with it. > Is it kept in case we need to revive it? I don't want to revive it, but I want to split the huge code changes from the functional changes at least. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-05-27 11:22 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-26 16:37 [PATCH] drm/i915: Disable gpu relocations Daniel Vetter 2021-05-26 16:37 ` [Intel-gfx] " Daniel Vetter 2021-05-26 22:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2021-05-26 22:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-05-26 23:57 ` [Intel-gfx] [PATCH] " Dave Airlie 2021-05-26 23:57 ` Dave Airlie 2021-05-27 11:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork 2021-05-27 11:16 ` [PATCH] " Maarten Lankhorst 2021-05-27 11:16 ` [Intel-gfx] " Maarten Lankhorst 2021-05-27 11:22 ` Daniel Vetter 2021-05-27 11:22 ` [Intel-gfx] " Daniel Vetter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.