From: Daniel Vetter <daniel@ffwll.ch> To: Paul Cercueil <paul@crapouillou.net> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Sam Ravnborg <sam@ravnborg.org>, od@zcrc.me, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels Date: Mon, 17 May 2021 15:15:59 +0200 [thread overview] Message-ID: <YKJsj+dDUshm/ZiT@phenom.ffwll.local> (raw) In-Reply-To: <6DP1TQ.W6B9JRRW1OY5@crapouillou.net> On Thu, May 13, 2021 at 01:29:30PM +0100, Paul Cercueil wrote: > Hi, > > Almost two months later, Since you're committer it's expected that you go actively out to look for review or trade with someone else who has some patches that need a quick look. It will not happen automatically, this is on you. Also generally after 2 weeks the patch is lost and you need to ping it. -Daniel > > > Le mar., mars 23 2021 at 14:40:08 +0000, Paul Cercueil > <paul@crapouillou.net> a écrit : > > When using a 24-bit panel on a 8-bit serial bus, the pixel clock > > requested by the panel has to be multiplied by 3, since the subpixels > > are shifted sequentially. > > > > The code (in ingenic_drm_encoder_atomic_check) already computed > > crtc_state->adjusted_mode->crtc_clock accordingly, but clk_set_rate() > > used crtc_state->adjusted_mode->clock instead. > > > > Fixes: 28ab7d35b6e0 ("drm/ingenic: Properly compute timings when using a > > 3x8-bit panel") > > Cc: stable@vger.kernel.org # v5.10 > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > Can I get an ACK for my patch? > > Thanks! > -Paul > > > --- > > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > index d60e1eefc9d1..cba68bf52ec5 100644 > > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > @@ -342,7 +342,7 @@ static void ingenic_drm_crtc_atomic_flush(struct > > drm_crtc *crtc, > > if (priv->update_clk_rate) { > > mutex_lock(&priv->clk_mutex); > > clk_set_rate(priv->pix_clk, > > - crtc_state->adjusted_mode.clock * 1000); > > + crtc_state->adjusted_mode.crtc_clock * 1000); > > priv->update_clk_rate = false; > > mutex_unlock(&priv->clk_mutex); > > } > > -- > > 2.30.2 > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Paul Cercueil <paul@crapouillou.net> Cc: David Airlie <airlied@linux.ie>, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, od@zcrc.me, stable@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels Date: Mon, 17 May 2021 15:15:59 +0200 [thread overview] Message-ID: <YKJsj+dDUshm/ZiT@phenom.ffwll.local> (raw) In-Reply-To: <6DP1TQ.W6B9JRRW1OY5@crapouillou.net> On Thu, May 13, 2021 at 01:29:30PM +0100, Paul Cercueil wrote: > Hi, > > Almost two months later, Since you're committer it's expected that you go actively out to look for review or trade with someone else who has some patches that need a quick look. It will not happen automatically, this is on you. Also generally after 2 weeks the patch is lost and you need to ping it. -Daniel > > > Le mar., mars 23 2021 at 14:40:08 +0000, Paul Cercueil > <paul@crapouillou.net> a écrit : > > When using a 24-bit panel on a 8-bit serial bus, the pixel clock > > requested by the panel has to be multiplied by 3, since the subpixels > > are shifted sequentially. > > > > The code (in ingenic_drm_encoder_atomic_check) already computed > > crtc_state->adjusted_mode->crtc_clock accordingly, but clk_set_rate() > > used crtc_state->adjusted_mode->clock instead. > > > > Fixes: 28ab7d35b6e0 ("drm/ingenic: Properly compute timings when using a > > 3x8-bit panel") > > Cc: stable@vger.kernel.org # v5.10 > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > Can I get an ACK for my patch? > > Thanks! > -Paul > > > --- > > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > index d60e1eefc9d1..cba68bf52ec5 100644 > > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > @@ -342,7 +342,7 @@ static void ingenic_drm_crtc_atomic_flush(struct > > drm_crtc *crtc, > > if (priv->update_clk_rate) { > > mutex_lock(&priv->clk_mutex); > > clk_set_rate(priv->pix_clk, > > - crtc_state->adjusted_mode.clock * 1000); > > + crtc_state->adjusted_mode.crtc_clock * 1000); > > priv->update_clk_rate = false; > > mutex_unlock(&priv->clk_mutex); > > } > > -- > > 2.30.2 > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
next prev parent reply other threads:[~2021-05-17 13:16 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-23 14:40 [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels Paul Cercueil 2021-03-23 14:40 ` Paul Cercueil 2021-04-12 14:34 ` Paul Cercueil 2021-04-12 14:34 ` Paul Cercueil 2021-04-12 14:53 ` H. Nikolaus Schaller 2021-04-12 14:53 ` H. Nikolaus Schaller 2021-05-13 12:29 ` Paul Cercueil 2021-05-13 12:29 ` Paul Cercueil 2021-05-14 17:26 ` Thomas Zimmermann 2021-05-14 17:26 ` Thomas Zimmermann 2021-05-17 13:15 ` Daniel Vetter [this message] 2021-05-17 13:15 ` Daniel Vetter 2021-05-17 14:30 ` Paul Cercueil 2021-05-17 14:30 ` Paul Cercueil 2021-05-17 14:37 ` Daniel Vetter 2021-05-17 14:37 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YKJsj+dDUshm/ZiT@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=od@zcrc.me \ --cc=paul@crapouillou.net \ --cc=sam@ravnborg.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.