From: Joerg Roedel <joro@8bytes.org>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
iommu@lists.linux-foundation.org, linuxarm@huawei.com,
lorenzo.pieralisi@arm.com, robin.murphy@arm.com,
wanghuiqiang@huawei.com, guohanjun@huawei.com,
steven.price@arm.com, Sami.Mujawar@arm.com, jon@solid-run.com,
eric.auger@redhat.com, yangyicong@huawei.com
Subject: Re: [PATCH v4 2/8] iommu/dma: Introduce generic helper to retrieve RMR info
Date: Tue, 18 May 2021 10:49:37 +0200 [thread overview]
Message-ID: <YKN/ocoHvOdbH43j@8bytes.org> (raw)
In-Reply-To: <20210513134550.2117-3-shameerali.kolothum.thodi@huawei.com>
On Thu, May 13, 2021 at 02:45:44PM +0100, Shameer Kolothum wrote:
> +/**
> + * struct iommu_rmr - Reserved Memory Region details per IOMMU
> + * @list: Linked list pointers to hold RMR region info
> + * @base_address: base address of Reserved Memory Region
> + * @length: length of memory region
> + * @sid: associated stream id
> + * @flags: flags that apply to the RMR node
> + */
> +struct iommu_rmr {
> + struct list_head list;
> + phys_addr_t base_address;
> + u64 length;
> + u32 sid;
> + u32 flags;
> +};
> +
> +/* RMR Remap permitted */
> +#define IOMMU_RMR_REMAP_PERMITTED (1 << 0)
> +
This struct has lots of overlap with 'struct iommu_resv_region'. Any
reason the existing struct can't be used here?
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc: jon@solid-run.com, linuxarm@huawei.com, steven.price@arm.com,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org,
wanghuiqiang@huawei.com, guohanjun@huawei.com,
yangyicong@huawei.com, Sami.Mujawar@arm.com,
robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/8] iommu/dma: Introduce generic helper to retrieve RMR info
Date: Tue, 18 May 2021 10:49:37 +0200 [thread overview]
Message-ID: <YKN/ocoHvOdbH43j@8bytes.org> (raw)
In-Reply-To: <20210513134550.2117-3-shameerali.kolothum.thodi@huawei.com>
On Thu, May 13, 2021 at 02:45:44PM +0100, Shameer Kolothum wrote:
> +/**
> + * struct iommu_rmr - Reserved Memory Region details per IOMMU
> + * @list: Linked list pointers to hold RMR region info
> + * @base_address: base address of Reserved Memory Region
> + * @length: length of memory region
> + * @sid: associated stream id
> + * @flags: flags that apply to the RMR node
> + */
> +struct iommu_rmr {
> + struct list_head list;
> + phys_addr_t base_address;
> + u64 length;
> + u32 sid;
> + u32 flags;
> +};
> +
> +/* RMR Remap permitted */
> +#define IOMMU_RMR_REMAP_PERMITTED (1 << 0)
> +
This struct has lots of overlap with 'struct iommu_resv_region'. Any
reason the existing struct can't be used here?
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
iommu@lists.linux-foundation.org, linuxarm@huawei.com,
lorenzo.pieralisi@arm.com, robin.murphy@arm.com,
wanghuiqiang@huawei.com, guohanjun@huawei.com,
steven.price@arm.com, Sami.Mujawar@arm.com, jon@solid-run.com,
eric.auger@redhat.com, yangyicong@huawei.com
Subject: Re: [PATCH v4 2/8] iommu/dma: Introduce generic helper to retrieve RMR info
Date: Tue, 18 May 2021 10:49:37 +0200 [thread overview]
Message-ID: <YKN/ocoHvOdbH43j@8bytes.org> (raw)
In-Reply-To: <20210513134550.2117-3-shameerali.kolothum.thodi@huawei.com>
On Thu, May 13, 2021 at 02:45:44PM +0100, Shameer Kolothum wrote:
> +/**
> + * struct iommu_rmr - Reserved Memory Region details per IOMMU
> + * @list: Linked list pointers to hold RMR region info
> + * @base_address: base address of Reserved Memory Region
> + * @length: length of memory region
> + * @sid: associated stream id
> + * @flags: flags that apply to the RMR node
> + */
> +struct iommu_rmr {
> + struct list_head list;
> + phys_addr_t base_address;
> + u64 length;
> + u32 sid;
> + u32 flags;
> +};
> +
> +/* RMR Remap permitted */
> +#define IOMMU_RMR_REMAP_PERMITTED (1 << 0)
> +
This struct has lots of overlap with 'struct iommu_resv_region'. Any
reason the existing struct can't be used here?
Regards,
Joerg
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-18 8:49 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 13:45 [PATCH v4 0/8] ACPI/IORT: Support for IORT RMR node Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` [PATCH v4 1/8] ACPI/IORT: Add support for RMR node parsing Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-06-03 11:36 ` Lorenzo Pieralisi
2021-06-03 11:36 ` Lorenzo Pieralisi
2021-06-03 11:36 ` Lorenzo Pieralisi
2021-06-03 11:48 ` Shameerali Kolothum Thodi
2021-06-03 11:48 ` Shameerali Kolothum Thodi
2021-06-03 11:48 ` Shameerali Kolothum Thodi
2021-05-13 13:45 ` [PATCH v4 2/8] iommu/dma: Introduce generic helper to retrieve RMR info Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-18 8:49 ` Joerg Roedel [this message]
2021-05-18 8:49 ` Joerg Roedel
2021-05-18 8:49 ` Joerg Roedel
2021-05-19 9:30 ` Shameerali Kolothum Thodi
2021-05-19 9:30 ` Shameerali Kolothum Thodi
2021-05-19 9:30 ` Shameerali Kolothum Thodi
2021-05-19 11:48 ` Robin Murphy
2021-05-19 11:48 ` Robin Murphy
2021-05-19 11:48 ` Robin Murphy
2021-05-13 13:45 ` [PATCH v4 3/8] ACPI/IORT: Add a helper to retrieve RMR memory regions Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-06-03 11:20 ` Lorenzo Pieralisi
2021-06-03 11:20 ` Lorenzo Pieralisi
2021-06-03 11:20 ` Lorenzo Pieralisi
2021-05-13 13:45 ` [PATCH v4 4/8] iommu/arm-smmu-v3: Introduce strtab init helper Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` [PATCH v4 5/8] iommu/arm-smmu-v3: Add bypass flag to arm_smmu_write_strtab_ent() Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` [PATCH v4 6/8] iommu/arm-smmu-v3: Get associated RMR info and install bypass STE Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` [PATCH v4 7/8] iommu/arm-smmu: Get associated RMR info and install bypass SMR Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` [PATCH v4 8/8] iommu/dma: Reserve any RMR regions associated with a dev Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-13 13:45 ` Shameer Kolothum
2021-05-21 12:55 ` [PATCH v4 0/8] ACPI/IORT: Support for IORT RMR node Steven Price
2021-05-21 12:55 ` Steven Price
2021-05-21 12:55 ` Steven Price
2021-05-21 13:12 ` Shameerali Kolothum Thodi
2021-05-21 13:12 ` Shameerali Kolothum Thodi
2021-05-21 13:12 ` Shameerali Kolothum Thodi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKN/ocoHvOdbH43j@8bytes.org \
--to=joro@8bytes.org \
--cc=Sami.Mujawar@arm.com \
--cc=eric.auger@redhat.com \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jon@solid-run.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=steven.price@arm.com \
--cc=wanghuiqiang@huawei.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.