* [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue
@ 2021-06-03 22:07 Manasi Navare
2021-06-04 1:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Manasi Navare @ 2021-06-03 22:07 UTC (permalink / raw)
To: intel-gfx
Static analysis identified an issue in skl_crtc_allocate_ddb where
mbus_offset may be used uninitialized.
This patch fixes it.
Fixes: 835c176cb1c4 ("drm/i915: Introduce MBUS relative dbuf offsets")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 00f3dead20ad..a385b8b7414f 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4163,7 +4163,7 @@ skl_crtc_allocate_ddb(struct intel_atomic_state *state, struct intel_crtc *crtc)
struct intel_crtc_state *crtc_state;
struct skl_ddb_entry ddb_slices;
enum pipe pipe = crtc->pipe;
- unsigned int mbus_offset;
+ unsigned int mbus_offset = 0;
u32 ddb_range_size;
u32 dbuf_slice_mask;
u32 start, end;
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Initialize the mbus_offset to fix static analysis issue 2021-06-03 22:07 [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue Manasi Navare @ 2021-06-04 1:12 ` Patchwork 2021-06-04 3:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-06-04 12:50 ` [Intel-gfx] [PATCH v2] " Rodrigo Vivi 2 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-06-04 1:12 UTC (permalink / raw) To: Manasi Navare; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 4431 bytes --] == Series Details == Series: drm/i915: Initialize the mbus_offset to fix static analysis issue URL : https://patchwork.freedesktop.org/series/90975/ State : success == Summary == CI Bug Log - changes from CI_DRM_10168 -> Patchwork_20281 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/index.html Known issues ------------ Here are the changes found in Patchwork_20281 that come from known issues: ### IGT changes ### #### Possible fixes #### * igt@i915_selftest@live@gt_heartbeat: - fi-glk-dsi: [DMESG-FAIL][1] ([i915#2291] / [i915#541]) -> [PASS][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/fi-glk-dsi/igt@i915_selftest@live@gt_heartbeat.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/fi-glk-dsi/igt@i915_selftest@live@gt_heartbeat.html #### Warnings #### * igt@runner@aborted: - fi-skl-6600u: [FAIL][3] ([i915#1436] / [i915#3363]) -> [FAIL][4] ([i915#1436] / [i915#2426] / [i915#3363]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/fi-skl-6600u/igt@runner@aborted.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/fi-skl-6600u/igt@runner@aborted.html - fi-glk-dsi: [FAIL][5] ([i915#2426] / [i915#3363] / [k.org#202321]) -> [FAIL][6] ([i915#3363] / [k.org#202321]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/fi-glk-dsi/igt@runner@aborted.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/fi-glk-dsi/igt@runner@aborted.html - fi-kbl-soraka: [FAIL][7] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][8] ([i915#1436] / [i915#3363]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/fi-kbl-soraka/igt@runner@aborted.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/fi-kbl-soraka/igt@runner@aborted.html - fi-cml-s: [FAIL][9] ([i915#2082] / [i915#2426] / [i915#3363] / [i915#3462]) -> [FAIL][10] ([i915#3363] / [i915#3462]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/fi-cml-s/igt@runner@aborted.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/fi-cml-s/igt@runner@aborted.html - fi-cfl-guc: [FAIL][11] ([i915#3363]) -> [FAIL][12] ([i915#2426] / [i915#3363]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/fi-cfl-guc/igt@runner@aborted.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/fi-cfl-guc/igt@runner@aborted.html - fi-kbl-7567u: [FAIL][13] ([i915#1436] / [i915#3363]) -> [FAIL][14] ([i915#1436] / [i915#2426] / [i915#3363]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/fi-kbl-7567u/igt@runner@aborted.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/fi-kbl-7567u/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363 [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462 [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541 [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321 Participating hosts (45 -> 40) ------------------------------ Missing (5): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-bsw-cyan fi-bdw-samus Build changes ------------- * Linux: CI_DRM_10168 -> Patchwork_20281 CI-20190529: 20190529 CI_DRM_10168: ad6cb7b043355cf535e0027ff90c4a6aacb790d1 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6098: 1fbc1e7d602f96a7f4e2b95057eef994656b8e74 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_20281: c446f63666afe4de5514dde3acbb41d9cb96e974 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == c446f63666af drm/i915: Initialize the mbus_offset to fix static analysis issue == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/index.html [-- Attachment #1.2: Type: text/html, Size: 6557 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Initialize the mbus_offset to fix static analysis issue 2021-06-03 22:07 [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue Manasi Navare 2021-06-04 1:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2021-06-04 3:38 ` Patchwork 2021-06-04 12:50 ` [Intel-gfx] [PATCH v2] " Rodrigo Vivi 2 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-06-04 3:38 UTC (permalink / raw) To: Manasi Navare; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30287 bytes --] == Series Details == Series: drm/i915: Initialize the mbus_offset to fix static analysis issue URL : https://patchwork.freedesktop.org/series/90975/ State : success == Summary == CI Bug Log - changes from CI_DRM_10168_full -> Patchwork_20281_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_20281_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_create@create-massive: - shard-apl: NOTRUN -> [DMESG-WARN][1] ([i915#3002]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl2/igt@gem_create@create-massive.html * igt@gem_ctx_isolation@preservation-s3@vcs0: - shard-kbl: [PASS][2] -> [DMESG-WARN][3] ([i915#180]) +4 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vcs0.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@gem_ctx_isolation@preservation-s3@vcs0.html * igt@gem_ctx_persistence@legacy-engines-mixed: - shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +3 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-snb7/igt@gem_ctx_persistence@legacy-engines-mixed.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [PASS][5] -> [FAIL][6] ([i915#2842]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html - shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-tglb6/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl4/igt@gem_exec_fair@basic-none-solo@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl7/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-none@rcs0: - shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-glk7/igt@gem_exec_fair@basic-none@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-glk8/igt@gem_exec_fair@basic-none@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [PASS][13] -> [FAIL][14] ([i915#2849]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-apl: NOTRUN -> [FAIL][15] ([i915#2389]) +3 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl2/igt@gem_exec_reloc@basic-wide-active@bcs0.html * igt@gem_exec_whisper@basic-contexts-all: - shard-glk: [PASS][16] -> [DMESG-WARN][17] ([i915#118] / [i915#95]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-glk3/igt@gem_exec_whisper@basic-contexts-all.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-glk8/igt@gem_exec_whisper@basic-contexts-all.html * igt@gem_huc_copy@huc-copy: - shard-kbl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#2190]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@gem_huc_copy@huc-copy.html * igt@gem_mmap_gtt@cpuset-medium-copy-odd: - shard-iclb: [PASS][19] -> [FAIL][20] ([i915#2428]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-iclb7/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-iclb7/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html * igt@gem_pread@exhaustion: - shard-apl: NOTRUN -> [WARN][21] ([i915#2658]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl6/igt@gem_pread@exhaustion.html * igt@gem_userptr_blits@vma-merge: - shard-apl: NOTRUN -> [FAIL][22] ([i915#3318]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl7/igt@gem_userptr_blits@vma-merge.html * igt@gen9_exec_parse@allowed-all: - shard-skl: [PASS][23] -> [DMESG-WARN][24] ([i915#1436] / [i915#716]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl8/igt@gen9_exec_parse@allowed-all.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl2/igt@gen9_exec_parse@allowed-all.html * igt@i915_module_load@reload-with-fault-injection: - shard-snb: [PASS][25] -> [DMESG-WARN][26] ([i915#3389]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-snb6/igt@i915_module_load@reload-with-fault-injection.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-snb6/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_dc@dc6-psr: - shard-skl: NOTRUN -> [FAIL][27] ([i915#454]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl4/igt@i915_pm_dc@dc6-psr.html * igt@i915_selftest@live@execlists: - shard-kbl: NOTRUN -> [INCOMPLETE][28] ([i915#2782] / [i915#3462] / [i915#794]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@i915_selftest@live@execlists.html * igt@i915_suspend@sysfs-reader: - shard-skl: [PASS][29] -> [INCOMPLETE][30] ([i915#198]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl3/igt@i915_suspend@sysfs-reader.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl10/igt@i915_suspend@sysfs-reader.html * igt@kms_big_joiner@invalid-modeset: - shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#2705]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl2/igt@kms_big_joiner@invalid-modeset.html * igt@kms_chamelium@hdmi-hpd-fast: - shard-snb: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +16 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-snb7/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_color_chamelium@pipe-c-ctm-0-25: - shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +23 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl6/igt@kms_color_chamelium@pipe-c-ctm-0-25.html * igt@kms_color_chamelium@pipe-c-ctm-limited-range: - shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +8 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl7/igt@kms_color_chamelium@pipe-c-ctm-limited-range.html * igt@kms_color_chamelium@pipe-d-ctm-0-25: - shard-skl: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +3 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl4/igt@kms_color_chamelium@pipe-d-ctm-0-25.html * igt@kms_content_protection@atomic-dpms: - shard-kbl: NOTRUN -> [TIMEOUT][36] ([i915#1319]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@kms_content_protection@atomic-dpms.html * igt@kms_cursor_crc@pipe-a-cursor-max-size-onscreen: - shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271]) +50 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-max-size-onscreen.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: NOTRUN -> [FAIL][38] ([i915#2346]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: NOTRUN -> [INCOMPLETE][39] ([i915#180] / [i915#1982]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html - shard-kbl: [PASS][40] -> [INCOMPLETE][41] ([i915#155] / [i915#180] / [i915#636]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl2/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-suspend@c-dp1: - shard-kbl: NOTRUN -> [DMESG-WARN][42] ([i915#180]) +2 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl4/igt@kms_flip@flip-vs-suspend@c-dp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs: - shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#2672]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs: - shard-kbl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#2672]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render: - shard-snb: NOTRUN -> [SKIP][45] ([fdo#109271]) +276 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-snb2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt: - shard-skl: NOTRUN -> [SKIP][46] ([fdo#109271]) +32 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-pwrite: - shard-skl: [PASS][47] -> [DMESG-WARN][48] ([i915#1982]) +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl5/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-pwrite.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl5/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-pwrite.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: [PASS][49] -> [FAIL][50] ([i915#1188]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl2/igt@kms_hdr@bpc-switch-suspend.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl5/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#533]) +2 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl6/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#533]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl4/igt@kms_pipe_crc_basic@read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-a-alpha-basic: - shard-apl: NOTRUN -> [FAIL][53] ([fdo#108145] / [i915#265]) +3 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: - shard-skl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [PASS][55] -> [FAIL][56] ([fdo#108145] / [i915#265]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_plane_alpha_blend@pipe-b-alpha-basic: - shard-kbl: NOTRUN -> [FAIL][57] ([fdo#108145] / [i915#265]) +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3: - shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#658]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#658]) +3 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4: - shard-skl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [PASS][61] -> [SKIP][62] ([fdo#109441]) +2 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-iclb2/igt@kms_psr@psr2_no_drrs.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-iclb4/igt@kms_psr@psr2_no_drrs.html * igt@kms_sysfs_edid_timing: - shard-kbl: NOTRUN -> [FAIL][63] ([IGT#2]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl7/igt@kms_sysfs_edid_timing.html * igt@kms_vblank@pipe-d-wait-forked-hang: - shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271]) +220 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl1/igt@kms_vblank@pipe-d-wait-forked-hang.html * igt@kms_writeback@writeback-pixel-formats: - shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#2437]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl7/igt@kms_writeback@writeback-pixel-formats.html * igt@sysfs_clients@create: - shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#2994]) +3 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl1/igt@sysfs_clients@create.html * igt@sysfs_clients@fair-0: - shard-kbl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#2994]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@sysfs_clients@fair-0.html * igt@sysfs_clients@fair-1: - shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2994]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl4/igt@sysfs_clients@fair-1.html #### Possible fixes #### * igt@gem_ctx_isolation@preservation-s3@vcs0: - shard-skl: [INCOMPLETE][69] ([i915#198]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl7/igt@gem_ctx_isolation@preservation-s3@vcs0.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl4/igt@gem_ctx_isolation@preservation-s3@vcs0.html * igt@gem_ctx_persistence@many-contexts: - shard-tglb: [FAIL][71] ([i915#2410]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-tglb2/igt@gem_ctx_persistence@many-contexts.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-tglb2/igt@gem_ctx_persistence@many-contexts.html * igt@gem_exec_fair@basic-deadline: - shard-kbl: [FAIL][73] ([i915#2846]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl2/igt@gem_exec_fair@basic-deadline.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl7/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-iclb: [FAIL][75] ([i915#2842]) -> [PASS][76] +2 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-iclb2/igt@gem_exec_fair@basic-none-rrul@rcs0.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-iclb8/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-apl: [SKIP][77] ([fdo#109271]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl8/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [FAIL][79] ([i915#2842]) -> [PASS][80] +2 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-tglb: [FAIL][81] ([i915#2842]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-tglb6/igt@gem_exec_fair@basic-pace@vcs0.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-tglb6/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [FAIL][83] ([i915#2842]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-glk8/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [FAIL][85] ([i915#454]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-iclb4/igt@i915_pm_dc@dc6-psr.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-iclb1/igt@i915_pm_dc@dc6-psr.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-skl: [FAIL][87] ([i915#2521]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl9/igt@kms_async_flips@alternate-sync-async-flip.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen: - shard-skl: [FAIL][89] ([i915#3444]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: [DMESG-WARN][91] ([i915#180]) -> [PASS][92] +4 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size: - shard-skl: [FAIL][93] ([i915#2346]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl3/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl10/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2: - shard-glk: [FAIL][95] ([i915#2122]) -> [PASS][96] +1 similar issue [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-glk9/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-glk4/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [FAIL][97] ([fdo#108145] / [i915#265]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@psr2_primary_mmap_gtt: - shard-iclb: [SKIP][99] ([fdo#109441]) -> [PASS][100] +1 similar issue [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-iclb6/igt@kms_psr@psr2_primary_mmap_gtt.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html * igt@sysfs_preempt_timeout@timeout@rcs0: - shard-skl: [FAIL][101] ([i915#2821]) -> [PASS][102] [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl7/igt@sysfs_preempt_timeout@timeout@rcs0.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl3/igt@sysfs_preempt_timeout@timeout@rcs0.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][103] ([i915#1804] / [i915#2684]) -> [WARN][104] ([i915#2684]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html * igt@i915_selftest@live@execlists: - shard-tglb: [DMESG-FAIL][105] ([i915#3462]) -> [INCOMPLETE][106] ([i915#3462]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-tglb7/igt@i915_selftest@live@execlists.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-tglb1/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@gt_pm: - shard-skl: [DMESG-FAIL][107] ([i915#2291]) -> [DMESG-FAIL][108] ([i915#1886] / [i915#2291]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-skl1/igt@i915_selftest@live@gt_pm.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-skl8/igt@i915_selftest@live@gt_pm.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1: - shard-iclb: [SKIP][109] ([i915#658]) -> [SKIP][110] ([i915#2920]) +1 similar issue [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: - shard-iclb: [SKIP][111] ([i915#2920]) -> [SKIP][112] ([i915#658]) +2 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html * igt@runner@aborted: - shard-kbl: ([FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602]) -> ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134]) ([i915#1436] / [i915#180] / [i915#3002] / [i915#3363] / [i915#92]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl4/igt@runner@aborted.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl4/igt@runner@aborted.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl3/igt@runner@aborted.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl3/igt@runner@aborted.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl7/igt@runner@aborted.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl1/igt@runner@aborted.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl3/igt@runner@aborted.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl1/igt@runner@aborted.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl1/igt@runner@aborted.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl2/igt@runner@aborted.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-kbl3/igt@runner@aborted.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl2/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl2/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl2/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl4/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl4/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl4/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl3/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-kbl7/igt@runner@aborted.html - shard-apl: ([FAIL][135], [FAIL][136]) ([fdo#109271] / [i915#3002] / [i915#3363]) -> ([FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#3363]) [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-apl7/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-apl3/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl7/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl2/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl1/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-apl1/igt@runner@aborted.html - shard-tglb: ([FAIL][141], [FAIL][142], [FAIL][143]) ([i915#1436] / [i915#2426] / [i915#2966] / [i915#3002]) -> ([FAIL][144], [FAIL][145], [FAIL][146]) ([i915#1436] / [i915#2966] / [i915#3002]) [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-tglb5/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-tglb6/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-tglb7/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-tglb1/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-tglb8/igt@runner@aborted.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-tglb7/igt@runner@aborted.html - shard-snb: ([FAIL][147], [FAIL][148]) ([i915#3002] / [i915#698]) -> [FAIL][149] ([i915#2292] / [i915#2426]) [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-snb6/igt@runner@aborted.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10168/shard-snb6/igt@runner@aborted.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/shard-snb6/igt@runner@aborted.html [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2428]: https://gitlab.freedesktop.org/drm/intel/issues/2428 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20281/index.html [-- Attachment #1.2: Type: text/html, Size: 36650 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue 2021-06-03 22:07 [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue Manasi Navare 2021-06-04 1:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-06-04 3:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2021-06-04 12:50 ` Rodrigo Vivi 2021-06-04 15:22 ` Mika Kuoppala 2 siblings, 1 reply; 6+ messages in thread From: Rodrigo Vivi @ 2021-06-04 12:50 UTC (permalink / raw) To: Manasi Navare; +Cc: intel-gfx On Thu, Jun 03, 2021 at 03:07:54PM -0700, Manasi Navare wrote: > Static analysis identified an issue in skl_crtc_allocate_ddb where > mbus_offset may be used uninitialized. > This patch fixes it. I'm sorry, but I really cannot see what this tool is seeing... I even tried to look to our internal branch to see if it was an issue there. But I'm failing to see how it is possible... > > Fixes: 835c176cb1c4 ("drm/i915: Introduce MBUS relative dbuf offsets") > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> > --- > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 00f3dead20ad..a385b8b7414f 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -4163,7 +4163,7 @@ skl_crtc_allocate_ddb(struct intel_atomic_state *state, struct intel_crtc *crtc) > struct intel_crtc_state *crtc_state; > struct skl_ddb_entry ddb_slices; > enum pipe pipe = crtc->pipe; > - unsigned int mbus_offset; > + unsigned int mbus_offset = 0; > u32 ddb_range_size; > u32 dbuf_slice_mask; > u32 start, end; > -- > 2.19.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue 2021-06-04 12:50 ` [Intel-gfx] [PATCH v2] " Rodrigo Vivi @ 2021-06-04 15:22 ` Mika Kuoppala 2021-06-04 15:37 ` Rodrigo Vivi 0 siblings, 1 reply; 6+ messages in thread From: Mika Kuoppala @ 2021-06-04 15:22 UTC (permalink / raw) To: Rodrigo Vivi, Manasi Navare; +Cc: intel-gfx Rodrigo Vivi <rodrigo.vivi@intel.com> writes: > On Thu, Jun 03, 2021 at 03:07:54PM -0700, Manasi Navare wrote: >> Static analysis identified an issue in skl_crtc_allocate_ddb where >> mbus_offset may be used uninitialized. >> This patch fixes it. > > I'm sorry, but I really cannot see what this tool is seeing... > I even tried to look to our internal branch to see if it was an issue > there. > But I'm failing to see how it is possible... It is in the goto out; path. -Mika > >> >> Fixes: 835c176cb1c4 ("drm/i915: Introduce MBUS relative dbuf offsets") >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> >> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> >> --- >> drivers/gpu/drm/i915/intel_pm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c >> index 00f3dead20ad..a385b8b7414f 100644 >> --- a/drivers/gpu/drm/i915/intel_pm.c >> +++ b/drivers/gpu/drm/i915/intel_pm.c >> @@ -4163,7 +4163,7 @@ skl_crtc_allocate_ddb(struct intel_atomic_state *state, struct intel_crtc *crtc) >> struct intel_crtc_state *crtc_state; >> struct skl_ddb_entry ddb_slices; >> enum pipe pipe = crtc->pipe; >> - unsigned int mbus_offset; >> + unsigned int mbus_offset = 0; >> u32 ddb_range_size; >> u32 dbuf_slice_mask; >> u32 start, end; >> -- >> 2.19.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue 2021-06-04 15:22 ` Mika Kuoppala @ 2021-06-04 15:37 ` Rodrigo Vivi 0 siblings, 0 replies; 6+ messages in thread From: Rodrigo Vivi @ 2021-06-04 15:37 UTC (permalink / raw) To: Mika Kuoppala; +Cc: intel-gfx On Fri, Jun 04, 2021 at 06:22:49PM +0300, Mika Kuoppala wrote: > Rodrigo Vivi <rodrigo.vivi@intel.com> writes: > > > On Thu, Jun 03, 2021 at 03:07:54PM -0700, Manasi Navare wrote: > >> Static analysis identified an issue in skl_crtc_allocate_ddb where > >> mbus_offset may be used uninitialized. > >> This patch fixes it. > > > > I'm sorry, but I really cannot see what this tool is seeing... > > I even tried to look to our internal branch to see if it was an issue > > there. > > But I'm failing to see how it is possible... > > It is in the goto out; path. indeed... thanks what a huge "out" block. For me it looks like another function and not just an "out". Could we get a refactor here? I'm afraid that setting mbus_offset = 0 silence the static analysis tool, but this might not be right for this "out" section. Because offset gets totally ignored. The condition to call the goto out is not that clear on why we want one or another path, so a refactor there to make things more clear is probably the best. > -Mika > > > > >> > >> Fixes: 835c176cb1c4 ("drm/i915: Introduce MBUS relative dbuf offsets") > >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > >> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> > >> --- > >> drivers/gpu/drm/i915/intel_pm.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > >> index 00f3dead20ad..a385b8b7414f 100644 > >> --- a/drivers/gpu/drm/i915/intel_pm.c > >> +++ b/drivers/gpu/drm/i915/intel_pm.c > >> @@ -4163,7 +4163,7 @@ skl_crtc_allocate_ddb(struct intel_atomic_state *state, struct intel_crtc *crtc) > >> struct intel_crtc_state *crtc_state; > >> struct skl_ddb_entry ddb_slices; > >> enum pipe pipe = crtc->pipe; > >> - unsigned int mbus_offset; > >> + unsigned int mbus_offset = 0; > >> u32 ddb_range_size; > >> u32 dbuf_slice_mask; > >> u32 start, end; > >> -- > >> 2.19.1 > >> > >> _______________________________________________ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-04 15:38 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-03 22:07 [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue Manasi Navare 2021-06-04 1:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-06-04 3:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-06-04 12:50 ` [Intel-gfx] [PATCH v2] " Rodrigo Vivi 2021-06-04 15:22 ` Mika Kuoppala 2021-06-04 15:37 ` Rodrigo Vivi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.