All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, mst@redhat.com,
	sgarzare@redhat.com, jasowang@redhat.com, christian@brauner.io,
	akpm@linux-foundation.org, peterz@infradead.org,
	christian.brauner@ubuntu.com
Subject: Re: [PATCH 0/3] kthread: pass in user and check RLIMIT_NPROC
Date: Thu, 24 Jun 2021 10:40:52 +0100	[thread overview]
Message-ID: <YNRTJFHxSlUSEqL5@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210624030804.4932-1-michael.christie@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

On Wed, Jun 23, 2021 at 10:08:01PM -0500, Mike Christie wrote:
> The vhost driver will create a kthread when userspace does a
> VHOST_SET_OWNER ioctl, but the thread is charged to the kthreadd thread.
> We can then end up violating the userspace process's RLIMIT_NPROC. This
> patchset allows drivers to pass in the user to charge/check.
> 
> The patches were made over Linus's current tree.

Makes sense from a vhost perspective and for future users, but I'm not
familiar with the kthread internals:

Acked-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: mst@redhat.com, peterz@infradead.org,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	akpm@linux-foundation.org, christian.brauner@ubuntu.com,
	christian@brauner.io
Subject: Re: [PATCH 0/3] kthread: pass in user and check RLIMIT_NPROC
Date: Thu, 24 Jun 2021 10:40:52 +0100	[thread overview]
Message-ID: <YNRTJFHxSlUSEqL5@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210624030804.4932-1-michael.christie@oracle.com>


[-- Attachment #1.1: Type: text/plain, Size: 562 bytes --]

On Wed, Jun 23, 2021 at 10:08:01PM -0500, Mike Christie wrote:
> The vhost driver will create a kthread when userspace does a
> VHOST_SET_OWNER ioctl, but the thread is charged to the kthreadd thread.
> We can then end up violating the userspace process's RLIMIT_NPROC. This
> patchset allows drivers to pass in the user to charge/check.
> 
> The patches were made over Linus's current tree.

Makes sense from a vhost perspective and for future users, but I'm not
familiar with the kthread internals:

Acked-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2021-06-28 13:01 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  3:08 [PATCH 0/3] kthread: pass in user and check RLIMIT_NPROC Mike Christie
2021-06-24  3:08 ` Mike Christie
2021-06-24  3:08 ` [PATCH 1/3] kthread: allow caller to pass in user_struct Mike Christie
2021-06-24  3:08   ` Mike Christie
2021-06-24  4:34   ` kernel test robot
2021-06-24  4:34     ` kernel test robot
2021-06-24  4:34     ` kernel test robot
2021-06-24 16:19     ` Mike Christie
2021-06-24 16:19       ` Mike Christie
2021-06-24 16:19       ` Mike Christie
2021-06-24  3:08 ` [PATCH 2/3] kernel/fork, cred.c: allow copy_process to take user Mike Christie
2021-06-24  3:08   ` Mike Christie
2021-06-29 13:04   ` Christian Brauner
2021-06-29 16:53     ` Mike Christie
2021-06-29 16:53       ` Mike Christie
2021-07-01 23:59       ` michael.christie
2021-07-01 23:59         ` michael.christie
2021-06-24  3:08 ` [PATCH 3/3] vhost: pass kthread user to check RLIMIT_NPROC Mike Christie
2021-06-24  3:08   ` Mike Christie
2021-06-24  8:26   ` kernel test robot
2021-06-24  8:26     ` kernel test robot
2021-06-24  8:26     ` kernel test robot
2021-06-24 16:18     ` Mike Christie
2021-06-24 16:18       ` Mike Christie
2021-06-24 16:18       ` Mike Christie
2021-06-24  7:34 ` [PATCH 0/3] kthread: pass in user and " Michael S. Tsirkin
2021-06-24  7:34   ` Michael S. Tsirkin
2021-06-24  9:40 ` Stefan Hajnoczi [this message]
2021-06-24  9:40   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNRTJFHxSlUSEqL5@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=christian@brauner.io \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.