All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Max Filippov <jcmvbkbc@gmail.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	alsa-devel@alsa-project.org, Leon Romanovsky <leon@kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update()
Date: Thu, 8 Jul 2021 19:12:17 +0900	[thread overview]
Message-ID: <YObPgQd9208Qmp2M@google.com> (raw)
In-Reply-To: <s5h5yxl6uzo.wl-tiwai@suse.de>

On (21/07/08 11:00), Takashi Iwai wrote:
> > > --- a/sound/pci/intel8x0.c
> > > +++ b/sound/pci/intel8x0.c
> > > @@ -694,7 +694,7 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich
> > >         int status, civ, i, step;
> > >         int ack = 0;
> > >
> > > -       if (!ichdev->prepared || ichdev->suspended)
> > > +       if (!(ichdev->prepared || ichdev->in_measurement) || ichdev->suspended)
> > 
> > There's no ichdev::in_measurement, but if replaced with
> > chip->in_measurement it indeed fixes my issue.
> 
> One must compile the code before sending out :-<
> 
> > So with this change:
> > Tested-by: Max Filippov <jcmvbkbc@gmail.com>
> 
> Great, thanks for quick testing, I'll prepare the fix patch now.

Tested-by: Sergey Senozhatsky <senozhatsky@chromium.org>

WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Leon Romanovsky <leon@kernel.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>, Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update()
Date: Thu, 8 Jul 2021 19:12:17 +0900	[thread overview]
Message-ID: <YObPgQd9208Qmp2M@google.com> (raw)
In-Reply-To: <s5h5yxl6uzo.wl-tiwai@suse.de>

On (21/07/08 11:00), Takashi Iwai wrote:
> > > --- a/sound/pci/intel8x0.c
> > > +++ b/sound/pci/intel8x0.c
> > > @@ -694,7 +694,7 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich
> > >         int status, civ, i, step;
> > >         int ack = 0;
> > >
> > > -       if (!ichdev->prepared || ichdev->suspended)
> > > +       if (!(ichdev->prepared || ichdev->in_measurement) || ichdev->suspended)
> > 
> > There's no ichdev::in_measurement, but if replaced with
> > chip->in_measurement it indeed fixes my issue.
> 
> One must compile the code before sending out :-<
> 
> > So with this change:
> > Tested-by: Max Filippov <jcmvbkbc@gmail.com>
> 
> Great, thanks for quick testing, I'll prepare the fix patch now.

Tested-by: Sergey Senozhatsky <senozhatsky@chromium.org>

  reply	other threads:[~2021-07-08 10:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14  8:17 ALSA: intel8x0: div by zero in snd_intel8x0_update() Sergey Senozhatsky
2021-05-14  8:17 ` Sergey Senozhatsky
2021-05-14 11:05 ` Takashi Iwai
2021-05-14 11:05   ` Takashi Iwai
2021-05-14 11:16   ` Sergey Senozhatsky
2021-05-14 11:16     ` Sergey Senozhatsky
2021-05-16  8:30     ` Sergey Senozhatsky
2021-05-16  8:30       ` Sergey Senozhatsky
2021-05-16  8:31       ` Sergey Senozhatsky
2021-05-16  8:31         ` Sergey Senozhatsky
2021-05-16  9:49         ` Takashi Iwai
2021-05-16  9:49           ` Takashi Iwai
2021-05-16 10:59           ` Sergey Senozhatsky
2021-05-16 10:59             ` Sergey Senozhatsky
2021-05-16 11:23           ` Sergey Senozhatsky
2021-05-16 11:23             ` Sergey Senozhatsky
2021-05-16 12:07             ` Takashi Iwai
2021-05-16 12:07               ` Takashi Iwai
2021-05-16 12:55               ` Sergey Senozhatsky
2021-05-16 12:55                 ` Sergey Senozhatsky
2021-07-06 17:50           ` Max Filippov
2021-07-06 17:50             ` Max Filippov
2021-07-07  7:02             ` Takashi Iwai
2021-07-07  7:02               ` Takashi Iwai
2021-07-07 17:50               ` Max Filippov
2021-07-07 17:50                 ` Max Filippov
2021-07-07 18:14                 ` Takashi Iwai
2021-07-07 18:14                   ` Takashi Iwai
2021-07-07 20:33                   ` Max Filippov
2021-07-07 20:33                     ` Max Filippov
2021-07-08  7:13                     ` Takashi Iwai
2021-07-08  7:13                       ` Takashi Iwai
2021-07-08  8:41                       ` Max Filippov
2021-07-08  8:41                         ` Max Filippov
2021-07-08  9:00                         ` Takashi Iwai
2021-07-08  9:00                           ` Takashi Iwai
2021-07-08 10:12                           ` Sergey Senozhatsky [this message]
2021-07-08 10:12                             ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YObPgQd9208Qmp2M@google.com \
    --to=senozhatsky@chromium.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=gustavoars@kernel.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.