From: Takashi Iwai <tiwai@suse.de> To: Max Filippov <jcmvbkbc@gmail.com> Cc: Sergey Senozhatsky <senozhatsky@chromium.org>, alsa-devel@alsa-project.org, Leon Romanovsky <leon@kernel.org>, Takashi Iwai <tiwai@suse.com>, LKML <linux-kernel@vger.kernel.org>, "Gustavo A. R. Silva" <gustavoars@kernel.org> Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() Date: Thu, 08 Jul 2021 11:00:11 +0200 [thread overview] Message-ID: <s5h5yxl6uzo.wl-tiwai@suse.de> (raw) In-Reply-To: <CAMo8Bf+bGujLN7H5yBqy-AkPCN7LgfmGSiWEGdjW6ZWeFoXs9A@mail.gmail.com> On Thu, 08 Jul 2021 10:41:50 +0200, Max Filippov wrote: > > On Thu, Jul 8, 2021 at 12:13 AM Takashi Iwai <tiwai@suse.de> wrote: > > On Wed, 07 Jul 2021 22:33:22 +0200, > > Max Filippov wrote: > > > > > > On Wed, Jul 7, 2021 at 11:14 AM Takashi Iwai <tiwai@suse.de> wrote: > > > > On Wed, 07 Jul 2021 19:50:07 +0200, Max Filippov wrote: > > > > > It didn't change anything in my case. My further observation is that > > > > > the snd_intel8x0_update is called before the ichdev->prepared > > > > > is set to one and as a result IRQ is apparently never cleared. > > > > > > > > So it's broken in anyway no matter whether > > > > intel8x0_measure_ac97_clock() is called or not, right? > > > > > > The change that you suggested didn't eliminate the call to > > > intel8x0_measure_ac97_clock, it's still called and an interrupt > > > flood happens at the same place. > > > > Ah I see the point. Then the fix would be a oneliner like below. > > > > > > Takashi > > > > --- a/sound/pci/intel8x0.c > > +++ b/sound/pci/intel8x0.c > > @@ -694,7 +694,7 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich > > int status, civ, i, step; > > int ack = 0; > > > > - if (!ichdev->prepared || ichdev->suspended) > > + if (!(ichdev->prepared || ichdev->in_measurement) || ichdev->suspended) > > There's no ichdev::in_measurement, but if replaced with > chip->in_measurement it indeed fixes my issue. One must compile the code before sending out :-< > So with this change: > Tested-by: Max Filippov <jcmvbkbc@gmail.com> Great, thanks for quick testing, I'll prepare the fix patch now. Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: Max Filippov <jcmvbkbc@gmail.com> Cc: alsa-devel@alsa-project.org, Leon Romanovsky <leon@kernel.org>, LKML <linux-kernel@vger.kernel.org>, "Gustavo A. R. Silva" <gustavoars@kernel.org>, Takashi Iwai <tiwai@suse.com>, Sergey Senozhatsky <senozhatsky@chromium.org> Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() Date: Thu, 08 Jul 2021 11:00:11 +0200 [thread overview] Message-ID: <s5h5yxl6uzo.wl-tiwai@suse.de> (raw) In-Reply-To: <CAMo8Bf+bGujLN7H5yBqy-AkPCN7LgfmGSiWEGdjW6ZWeFoXs9A@mail.gmail.com> On Thu, 08 Jul 2021 10:41:50 +0200, Max Filippov wrote: > > On Thu, Jul 8, 2021 at 12:13 AM Takashi Iwai <tiwai@suse.de> wrote: > > On Wed, 07 Jul 2021 22:33:22 +0200, > > Max Filippov wrote: > > > > > > On Wed, Jul 7, 2021 at 11:14 AM Takashi Iwai <tiwai@suse.de> wrote: > > > > On Wed, 07 Jul 2021 19:50:07 +0200, Max Filippov wrote: > > > > > It didn't change anything in my case. My further observation is that > > > > > the snd_intel8x0_update is called before the ichdev->prepared > > > > > is set to one and as a result IRQ is apparently never cleared. > > > > > > > > So it's broken in anyway no matter whether > > > > intel8x0_measure_ac97_clock() is called or not, right? > > > > > > The change that you suggested didn't eliminate the call to > > > intel8x0_measure_ac97_clock, it's still called and an interrupt > > > flood happens at the same place. > > > > Ah I see the point. Then the fix would be a oneliner like below. > > > > > > Takashi > > > > --- a/sound/pci/intel8x0.c > > +++ b/sound/pci/intel8x0.c > > @@ -694,7 +694,7 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich > > int status, civ, i, step; > > int ack = 0; > > > > - if (!ichdev->prepared || ichdev->suspended) > > + if (!(ichdev->prepared || ichdev->in_measurement) || ichdev->suspended) > > There's no ichdev::in_measurement, but if replaced with > chip->in_measurement it indeed fixes my issue. One must compile the code before sending out :-< > So with this change: > Tested-by: Max Filippov <jcmvbkbc@gmail.com> Great, thanks for quick testing, I'll prepare the fix patch now. Takashi
next prev parent reply other threads:[~2021-07-08 9:00 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-14 8:17 ALSA: intel8x0: div by zero in snd_intel8x0_update() Sergey Senozhatsky 2021-05-14 8:17 ` Sergey Senozhatsky 2021-05-14 11:05 ` Takashi Iwai 2021-05-14 11:05 ` Takashi Iwai 2021-05-14 11:16 ` Sergey Senozhatsky 2021-05-14 11:16 ` Sergey Senozhatsky 2021-05-16 8:30 ` Sergey Senozhatsky 2021-05-16 8:30 ` Sergey Senozhatsky 2021-05-16 8:31 ` Sergey Senozhatsky 2021-05-16 8:31 ` Sergey Senozhatsky 2021-05-16 9:49 ` Takashi Iwai 2021-05-16 9:49 ` Takashi Iwai 2021-05-16 10:59 ` Sergey Senozhatsky 2021-05-16 10:59 ` Sergey Senozhatsky 2021-05-16 11:23 ` Sergey Senozhatsky 2021-05-16 11:23 ` Sergey Senozhatsky 2021-05-16 12:07 ` Takashi Iwai 2021-05-16 12:07 ` Takashi Iwai 2021-05-16 12:55 ` Sergey Senozhatsky 2021-05-16 12:55 ` Sergey Senozhatsky 2021-07-06 17:50 ` Max Filippov 2021-07-06 17:50 ` Max Filippov 2021-07-07 7:02 ` Takashi Iwai 2021-07-07 7:02 ` Takashi Iwai 2021-07-07 17:50 ` Max Filippov 2021-07-07 17:50 ` Max Filippov 2021-07-07 18:14 ` Takashi Iwai 2021-07-07 18:14 ` Takashi Iwai 2021-07-07 20:33 ` Max Filippov 2021-07-07 20:33 ` Max Filippov 2021-07-08 7:13 ` Takashi Iwai 2021-07-08 7:13 ` Takashi Iwai 2021-07-08 8:41 ` Max Filippov 2021-07-08 8:41 ` Max Filippov 2021-07-08 9:00 ` Takashi Iwai [this message] 2021-07-08 9:00 ` Takashi Iwai 2021-07-08 10:12 ` Sergey Senozhatsky 2021-07-08 10:12 ` Sergey Senozhatsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=s5h5yxl6uzo.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=gustavoars@kernel.org \ --cc=jcmvbkbc@gmail.com \ --cc=leon@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=senozhatsky@chromium.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.