All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
	Gao Xiang <hsiangkao@linux.alibaba.com>,
	linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
Subject: Re: [PATCH v6] iomap: support tail packing inline read
Date: Thu, 22 Jul 2021 17:57:06 +0100	[thread overview]
Message-ID: <YPmjYieZ57WVsQx9@casper.infradead.org> (raw)
In-Reply-To: <20210722165342.GA11435@lst.de>

On Thu, Jul 22, 2021 at 06:53:42PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 22, 2021 at 09:51:09AM -0700, Darrick J. Wong wrote:
> > The commit message is a little misleading -- this adds support for
> > inline data pages at nonzero (but page-aligned) file offsets, not file
> > offsets into the page itself.  I suggest:
> 
> It actually adds both.  pos is the offset into the file.

If you want to add support for both, then you need to call
iomap_set_range_uptodate() instead of SetPageUptodate().  Otherwise,
you can set the page uptodate before submitting the bio for the first
half of the page.

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
	Andreas Gruenbacher <andreas.gruenbacher@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v6] iomap: support tail packing inline read
Date: Thu, 22 Jul 2021 17:57:06 +0100	[thread overview]
Message-ID: <YPmjYieZ57WVsQx9@casper.infradead.org> (raw)
In-Reply-To: <20210722165342.GA11435@lst.de>

On Thu, Jul 22, 2021 at 06:53:42PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 22, 2021 at 09:51:09AM -0700, Darrick J. Wong wrote:
> > The commit message is a little misleading -- this adds support for
> > inline data pages at nonzero (but page-aligned) file offsets, not file
> > offsets into the page itself.  I suggest:
> 
> It actually adds both.  pos is the offset into the file.

If you want to add support for both, then you need to call
iomap_set_range_uptodate() instead of SetPageUptodate().  Otherwise,
you can set the page uptodate before submitting the bio for the first
half of the page.

  reply	other threads:[~2021-07-22 16:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  3:17 [PATCH v6] iomap: support tail packing inline read Gao Xiang
2021-07-22  3:17 ` Gao Xiang
2021-07-22  5:39 ` Christoph Hellwig
2021-07-22  5:39   ` Christoph Hellwig
2021-07-22  5:56   ` Gao Xiang
2021-07-22  5:56     ` Gao Xiang
2021-07-22 16:51   ` Darrick J. Wong
2021-07-22 16:51     ` Darrick J. Wong
2021-07-22 16:53     ` Christoph Hellwig
2021-07-22 16:53       ` Christoph Hellwig
2021-07-22 16:57       ` Matthew Wilcox [this message]
2021-07-22 16:57         ` Matthew Wilcox
2021-07-23  1:26     ` Gao Xiang
2021-07-23  1:26       ` Gao Xiang
2021-07-23  6:22       ` Huang Jianan
2021-07-23  6:22         ` Huang Jianan via Linux-erofs
2021-07-23 15:05   ` Matthew Wilcox
2021-07-23 15:05     ` Matthew Wilcox
2021-07-23 15:23     ` Gao Xiang
2021-07-23 15:23       ` Gao Xiang
2021-07-23 15:56       ` Matthew Wilcox
2021-07-23 16:24         ` Gao Xiang
2021-07-23 16:24           ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPmjYieZ57WVsQx9@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=andreas.gruenbacher@gmail.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.