From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: Vinod Koul <vkoul@kernel.org>,
robh+dt@kernel.org, will@kernel.org,
saiprakash.ranjan@codeaurora.org, swboyd@chromium.org,
mka@chromium.org, ohad@wizery.com, agross@kernel.org,
mathieu.poirier@linaro.org, robin.murphy@arm.com,
joro@8bytes.org, p.zabel@pengutronix.de,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, evgreen@chromium.org,
dianders@chromium.org
Subject: Re: [PATCH v3 06/10] arm64: dts: qcom: sc7280: Update reserved memory map
Date: Fri, 20 Aug 2021 10:06:13 -0700 [thread overview]
Message-ID: <YR/hBYyYuYWN68LV@ripper> (raw)
In-Reply-To: <39da02506af192de14d346cdf80d0e4c@codeaurora.org>
On Fri 20 Aug 07:09 PDT 2021, Sibi Sankar wrote:
> On 2021-08-19 10:07, Vinod Koul wrote:
> > Hi Sibi,
> >
> > On 19-08-21, 09:06, Sibi Sankar wrote:
> >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > index 5e4f4f3b738a..894106efadfe 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > @@ -48,6 +48,16 @@
> > > #size-cells = <2>;
> > > ranges;
> > >
> > > + hyp_mem: memory@80000000 {
> > > + reg = <0x0 0x80000000 0x0 0x600000>;
> > > + no-map;
> >
> > This should conflict with the memory defined in this file:
> >
> > memory@80000000 {
> > device_type = "memory";
> > /* We expect the bootloader to fill in the size */
> > reg = <0 0x80000000 0 0>;
> > };
> >
> > I think this should be updated?
>
> Vinod,
>
> I prefer we leave ^^ node untouched. For platforms using hyp_mem, the
> regions defined in the memory map are valid and for the other
> platforms not using hyp_mem we would just delete them in the board
> files anyway.
Logically this node describes where there is RAM, the reserved-memory
then subtracts blocks of memory out of that. So I think it's perfectly
legal for a region at the base to be marked as no-map.
That said, isn't the address in the memory node just a placeholder?
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: Vinod Koul <vkoul@kernel.org>,
robh+dt@kernel.org, will@kernel.org,
saiprakash.ranjan@codeaurora.org, swboyd@chromium.org,
mka@chromium.org, ohad@wizery.com, agross@kernel.org,
mathieu.poirier@linaro.org, robin.murphy@arm.com,
joro@8bytes.org, p.zabel@pengutronix.de,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, evgreen@chromium.org,
dianders@chromium.org
Subject: Re: [PATCH v3 06/10] arm64: dts: qcom: sc7280: Update reserved memory map
Date: Fri, 20 Aug 2021 10:06:13 -0700 [thread overview]
Message-ID: <YR/hBYyYuYWN68LV@ripper> (raw)
In-Reply-To: <39da02506af192de14d346cdf80d0e4c@codeaurora.org>
On Fri 20 Aug 07:09 PDT 2021, Sibi Sankar wrote:
> On 2021-08-19 10:07, Vinod Koul wrote:
> > Hi Sibi,
> >
> > On 19-08-21, 09:06, Sibi Sankar wrote:
> >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > index 5e4f4f3b738a..894106efadfe 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > @@ -48,6 +48,16 @@
> > > #size-cells = <2>;
> > > ranges;
> > >
> > > + hyp_mem: memory@80000000 {
> > > + reg = <0x0 0x80000000 0x0 0x600000>;
> > > + no-map;
> >
> > This should conflict with the memory defined in this file:
> >
> > memory@80000000 {
> > device_type = "memory";
> > /* We expect the bootloader to fill in the size */
> > reg = <0 0x80000000 0 0>;
> > };
> >
> > I think this should be updated?
>
> Vinod,
>
> I prefer we leave ^^ node untouched. For platforms using hyp_mem, the
> regions defined in the memory map are valid and for the other
> platforms not using hyp_mem we would just delete them in the board
> files anyway.
Logically this node describes where there is RAM, the reserved-memory
then subtracts blocks of memory out of that. So I think it's perfectly
legal for a region at the base to be marked as no-map.
That said, isn't the address in the memory node just a placeholder?
Regards,
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-20 17:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 3:36 [PATCH v3 00/10] Add Modem support on SC7280 SoCs Sibi Sankar
2021-08-19 3:36 ` [PATCH v3 01/10] dt-bindings: remoteproc: qcom: pas: Add SC7280 MPSS support Sibi Sankar
2021-08-23 20:14 ` Stephen Boyd
2021-08-23 20:14 ` Stephen Boyd
2021-08-19 3:36 ` [PATCH v3 02/10] remoteproc: qcom: pas: Add SC7280 Modem support Sibi Sankar
2021-08-23 20:14 ` Stephen Boyd
2021-08-23 20:14 ` Stephen Boyd
2021-08-19 3:36 ` [PATCH v3 03/10] dt-bindings: remoteproc: qcom: Update Q6V5 Modem PIL binding Sibi Sankar
2021-08-23 20:14 ` Stephen Boyd
2021-08-23 20:14 ` Stephen Boyd
2021-08-19 3:36 ` [PATCH v3 04/10] iommu/arm-smmu-qcom: Request direct mapping for modem device Sibi Sankar
2021-08-19 3:36 ` [PATCH v3 05/10] remoteproc: mss: q6v5-mss: Add modem support on SC7280 Sibi Sankar
2021-08-19 3:36 ` [PATCH v3 06/10] arm64: dts: qcom: sc7280: Update reserved memory map Sibi Sankar
2021-08-19 4:37 ` Vinod Koul
2021-08-19 4:37 ` Vinod Koul
2021-08-20 14:09 ` Sibi Sankar
2021-08-20 17:06 ` Bjorn Andersson [this message]
2021-08-20 17:06 ` Bjorn Andersson
2021-08-19 3:36 ` [PATCH v3 07/10] arm64: dts: qcom: sc7280: Add/Delete/Update reserved memory nodes Sibi Sankar
2021-08-19 3:36 ` [PATCH v3 08/10] arm64: dts: qcom: sc7280: Add nodes to boot modem Sibi Sankar
2021-08-23 20:12 ` Stephen Boyd
2021-08-23 20:12 ` Stephen Boyd
2021-08-19 3:36 ` [PATCH v3 09/10] arm64: dts: qcom: sc7280: Add Q6V5 MSS node Sibi Sankar
2021-08-19 3:36 ` [PATCH v3 10/10] arm64: dts: qcom: sc7280: Update " Sibi Sankar
2021-08-23 20:12 ` Stephen Boyd
2021-08-23 20:12 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR/hBYyYuYWN68LV@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.