All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/5] Correctly handle plaform_get_irq()'s result in the i2C drivers
@ 2021-07-04 14:32 ` Sergey Shtylyov
  0 siblings, 0 replies; 35+ messages in thread
From: Sergey Shtylyov @ 2021-07-04 14:32 UTC (permalink / raw)
  To: linux-i2c
  Cc: Qii Wang, Matthias Brugger, linux-arm-kernel, linux-mediatek,
	linux-samsung-soc, George Cherian

Here are 5 patches against the 'i2c/for-current' branch of Wolfram's 'linux.git' repo.
The affected drivers call platform_get_irq() but mis-interprete its result -- they consider
IRQ0 as error and (sometimes) the real error codes as valid IRQs... :-/

[1/5] i2c: hix5hd2: fix IRQ check
[2/5] i2c: mt65xx: fix IRQ check
[3/5] i2c: pmcmsp: fix IRQ check
[4/5] i2c: s3c2410: fix IRQ check
[5/5] i2c: xlp9xx: fix main IRQ check

^ permalink raw reply	[flat|nested] 35+ messages in thread
* Re: [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check
@ 2021-08-18  3:17 George Cherian
  0 siblings, 0 replies; 35+ messages in thread
From: George Cherian @ 2021-08-18  3:17 UTC (permalink / raw)
  To: Wolfram Sang, Sergey Shtylyov; +Cc: linux-i2c, George Cherian



> -----Original Message-----
> From: Wolfram Sang <wsa@kernel.org>
> Sent: Wednesday, August 18, 2021 1:43 AM
> To: Sergey Shtylyov <s.shtylyov@omp.ru>
> Cc: linux-i2c@vger.kernel.org; George Cherian <gcherian@marvell.com>
> Subject: [EXT] Re: [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check
> 
> On Sun, Jul 04, 2021 at 05:47:54PM +0300, Sergey Shtylyov wrote:
> > Iff platform_get_irq() returns 0 for the main IRQ, the driver's
> > probe() method will return 0 early (as if the method's call was successful).
> > Let's consider IRQ0 valid for simplicity -- devm_request_irq() can
> > always override that decision...
> >
> > Fixes: 2bbd681ba2b ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C
> > controller")
> > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> >
> 
> George, do you like this patch?
> 
Looks fine. 
Reviewed-by: George Cherian <george.cherian@marvell.com>
> > ---
> >  drivers/i2c/busses/i2c-xlp9xx.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux/drivers/i2c/busses/i2c-xlp9xx.c
> >
> ==========================================================
> =========
> > --- linux.orig/drivers/i2c/busses/i2c-xlp9xx.c
> > +++ linux/drivers/i2c/busses/i2c-xlp9xx.c
> > @@ -517,7 +517,7 @@ static int xlp9xx_i2c_probe(struct platf
> >  		return PTR_ERR(priv->base);
> >
> >  	priv->irq = platform_get_irq(pdev, 0);
> > -	if (priv->irq <= 0)
> > +	if (priv->irq < 0)
> >  		return priv->irq;
> >  	/* SMBAlert irq */
> >  	priv->alert_data.irq = platform_get_irq(pdev, 1);

^ permalink raw reply	[flat|nested] 35+ messages in thread
end of thread, other threads:[~2021-08-25 21:05 UTC | newest]

Thread overview: 35+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-04 14:32 [PATCH v2 0/5] Correctly handle plaform_get_irq()'s result in the i2C drivers Sergey Shtylyov
2021-07-04 14:32 ` Sergey Shtylyov
2021-07-04 14:32 ` Sergey Shtylyov
2021-07-04 14:35 ` [PATCH v2 1/5] i2c: hix5hd2: fix IRQ check Sergey Shtylyov
2021-08-17 20:10   ` Wolfram Sang
2021-07-04 14:38 ` [PATCH v2 2/5] i2c: mt65xx: " Sergey Shtylyov
2021-07-04 14:38   ` Sergey Shtylyov
2021-07-04 14:38   ` Sergey Shtylyov
2021-08-17 20:09   ` Wolfram Sang
2021-08-17 20:09     ` Wolfram Sang
2021-08-17 20:09     ` Wolfram Sang
2021-08-20  1:46     ` Qii Wang
2021-08-20  1:46       ` Qii Wang
2021-08-20  1:46       ` Qii Wang
2021-08-25 21:00   ` Wolfram Sang
2021-08-25 21:00     ` Wolfram Sang
2021-08-25 21:00     ` Wolfram Sang
2021-07-04 14:41 ` [PATCH v2 3/5] i2c: pmcmsp: " Sergey Shtylyov
2021-08-17 20:08   ` Wolfram Sang
2021-07-04 14:45 ` [PATCH v2 4/5] i2c: s3c2410: " Sergey Shtylyov
2021-07-04 14:45   ` Sergey Shtylyov
2021-07-05  7:46   ` Krzysztof Kozlowski
2021-07-05  7:46     ` Krzysztof Kozlowski
2021-08-17 20:08   ` Wolfram Sang
2021-08-17 20:08     ` Wolfram Sang
2021-07-04 14:47 ` [PATCH v2 5/5] i2c: xlp9xx: fix main " Sergey Shtylyov
2021-08-17 20:13   ` Wolfram Sang
2021-08-25 21:05   ` Wolfram Sang
2021-08-11 20:12 ` [PATCH v2 0/5] Correctly handle plaform_get_irq()'s result in the i2C drivers Sergey Shtylyov
2021-08-11 20:12   ` Sergey Shtylyov
2021-08-11 20:12   ` Sergey Shtylyov
2021-08-11 20:14   ` Sergey Shtylyov
2021-08-11 20:14     ` Sergey Shtylyov
2021-08-11 20:14     ` Sergey Shtylyov
2021-08-18  3:17 [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check George Cherian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.