* Re: [PATCH v4] drm: Improve the output_poll_changed description
[not found] <20210903032402.11935-1-zhangzhijie@loongson.cn>
@ 2021-09-03 9:31 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2021-09-03 9:31 UTC (permalink / raw)
To: ZhiJie.Zhang
Cc: daniel, maarten.lankhorst, mripard, tzimmermann, airlied,
dri-devel, linux-kernel, botton_zhang
On Fri, Sep 03, 2021 at 11:24:02AM +0800, ZhiJie.Zhang wrote:
> From: zhangzhijie <zhangzhijie@loongson.cn>
>
> this callback was used by drm_kms_helper_hotplug_event()
>
> V2: (Thanks for Daniel's suggestions)
> - remove the FIXME below.since with the drm_client
> - infrastructure and the generic fbdev emulation we've
> - resolved this all very neatly now.
>
> V3: Add comments that This hook is deprecated
> - new implementation methods instead of this hook
>
> v4: used by drm_kms_helper_hotplug_event()
> - drm_fb_helper_hotplug_changed() is not found
> instead by drm_kms_helper_hotplug_event()
>
> Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
Applied to drm-misc-next, thanks for the patch.
-Daniel
> ---
> include/drm/drm_mode_config.h | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index 1ddf7783fdf7..48b7de80daf5 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -103,14 +103,13 @@ struct drm_mode_config_funcs {
> * Callback used by helpers to inform the driver of output configuration
> * changes.
> *
> - * Drivers implementing fbdev emulation with the helpers can call
> - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev
> - * helper of output changes.
> + * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event()
> + * to call this hook to inform the fbdev helper of output changes.
> *
> - * FIXME:
> - *
> - * Except that there's no vtable for device-level helper callbacks
> - * there's no reason this is a core function.
> + * This hook is deprecated, drivers should instead use
> + * drm_fbdev_generic_setup() which takes care of any necessary
> + * hotplug event forwarding already without further involvement by
> + * the driver.
> */
> void (*output_poll_changed)(struct drm_device *dev);
>
> --
> 2.33.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4] drm: Improve the output_poll_changed description
@ 2021-01-21 3:09 ` ZhiJie.Zhang
0 siblings, 0 replies; 5+ messages in thread
From: ZhiJie.Zhang @ 2021-01-21 3:09 UTC (permalink / raw)
To: daniel, maarten.lankhorst, mripard, tzimmermann, airlied
Cc: dri-devel, linux-kernel, zhangzhijie
From: zhangzhijie <zhangzhijie@loongson.cn>
this callback was used by drm_kms_helper_hotplug_event()
V2: (Thanks for Daniel's suggestions)
- remove the FIXME below.since with the drm_client
- infrastructure and the generic fbdev emulation we've
- resolved this all very neatly now.
V3: Add comments that This hook is deprecated
- new implementation methods instead of this hook
Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
---
include/drm/drm_mode_config.h | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
index ab424ddd7665..fbc0da25d7c5 100644
--- a/include/drm/drm_mode_config.h
+++ b/include/drm/drm_mode_config.h
@@ -103,14 +103,13 @@ struct drm_mode_config_funcs {
* Callback used by helpers to inform the driver of output configuration
* changes.
*
- * Drivers implementing fbdev emulation with the helpers can call
- * drm_fb_helper_hotplug_changed from this hook to inform the fbdev
- * helper of output changes.
+ * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event()
+ * to call this hook to inform the fbdev helper of output changes.
*
- * FIXME:
- *
- * Except that there's no vtable for device-level helper callbacks
- * there's no reason this is a core function.
+ * This hook is deprecated, drivers should instead use
+ * drm_fbdev_generic_setup() which takes care of any necessary
+ * hotplug event forwarding already without further involvement by
+ * the driver.
*/
void (*output_poll_changed)(struct drm_device *dev);
--
2.29.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v4] drm: Improve the output_poll_changed description
@ 2021-01-21 3:09 ` ZhiJie.Zhang
0 siblings, 0 replies; 5+ messages in thread
From: ZhiJie.Zhang @ 2021-01-21 3:09 UTC (permalink / raw)
To: daniel, maarten.lankhorst, mripard, tzimmermann, airlied
Cc: zhangzhijie, linux-kernel, dri-devel
From: zhangzhijie <zhangzhijie@loongson.cn>
this callback was used by drm_kms_helper_hotplug_event()
V2: (Thanks for Daniel's suggestions)
- remove the FIXME below.since with the drm_client
- infrastructure and the generic fbdev emulation we've
- resolved this all very neatly now.
V3: Add comments that This hook is deprecated
- new implementation methods instead of this hook
Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
---
include/drm/drm_mode_config.h | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
index ab424ddd7665..fbc0da25d7c5 100644
--- a/include/drm/drm_mode_config.h
+++ b/include/drm/drm_mode_config.h
@@ -103,14 +103,13 @@ struct drm_mode_config_funcs {
* Callback used by helpers to inform the driver of output configuration
* changes.
*
- * Drivers implementing fbdev emulation with the helpers can call
- * drm_fb_helper_hotplug_changed from this hook to inform the fbdev
- * helper of output changes.
+ * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event()
+ * to call this hook to inform the fbdev helper of output changes.
*
- * FIXME:
- *
- * Except that there's no vtable for device-level helper callbacks
- * there's no reason this is a core function.
+ * This hook is deprecated, drivers should instead use
+ * drm_fbdev_generic_setup() which takes care of any necessary
+ * hotplug event forwarding already without further involvement by
+ * the driver.
*/
void (*output_poll_changed)(struct drm_device *dev);
--
2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v4] drm: Improve the output_poll_changed description
2021-01-21 3:09 ` ZhiJie.Zhang
@ 2021-01-21 11:23 ` Daniel Vetter
-1 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2021-01-21 11:23 UTC (permalink / raw)
To: ZhiJie.Zhang
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Dave Airlie,
dri-devel, Linux Kernel Mailing List
On Thu, Jan 21, 2021 at 4:09 AM ZhiJie.Zhang <zhangzhijie@loongson.cn> wrote:
>
> From: zhangzhijie <zhangzhijie@loongson.cn>
>
> this callback was used by drm_kms_helper_hotplug_event()
>
> V2: (Thanks for Daniel's suggestions)
> - remove the FIXME below.since with the drm_client
> - infrastructure and the generic fbdev emulation we've
> - resolved this all very neatly now.
>
> V3: Add comments that This hook is deprecated
> - new implementation methods instead of this hook
>
> Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
> ---
> include/drm/drm_mode_config.h | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index ab424ddd7665..fbc0da25d7c5 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -103,14 +103,13 @@ struct drm_mode_config_funcs {
> * Callback used by helpers to inform the driver of output configuration
> * changes.
> *
> - * Drivers implementing fbdev emulation with the helpers can call
> - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev
> - * helper of output changes.
Not sure why this isn't clear, but the above is important information
that we should keep. Maybe good to fix up the formatting to make it a
hyperlink, and your addition here is fine too, but the above is the
important part really.
-Daniel
> + * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event()
> + * to call this hook to inform the fbdev helper of output changes.
> *
> - * FIXME:
> - *
> - * Except that there's no vtable for device-level helper callbacks
> - * there's no reason this is a core function.
> + * This hook is deprecated, drivers should instead use
> + * drm_fbdev_generic_setup() which takes care of any necessary
> + * hotplug event forwarding already without further involvement by
> + * the driver.
> */
> void (*output_poll_changed)(struct drm_device *dev);
>
> --
> 2.29.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v4] drm: Improve the output_poll_changed description
@ 2021-01-21 11:23 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2021-01-21 11:23 UTC (permalink / raw)
To: ZhiJie.Zhang
Cc: Dave Airlie, Linux Kernel Mailing List, dri-devel, Thomas Zimmermann
On Thu, Jan 21, 2021 at 4:09 AM ZhiJie.Zhang <zhangzhijie@loongson.cn> wrote:
>
> From: zhangzhijie <zhangzhijie@loongson.cn>
>
> this callback was used by drm_kms_helper_hotplug_event()
>
> V2: (Thanks for Daniel's suggestions)
> - remove the FIXME below.since with the drm_client
> - infrastructure and the generic fbdev emulation we've
> - resolved this all very neatly now.
>
> V3: Add comments that This hook is deprecated
> - new implementation methods instead of this hook
>
> Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
> ---
> include/drm/drm_mode_config.h | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index ab424ddd7665..fbc0da25d7c5 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -103,14 +103,13 @@ struct drm_mode_config_funcs {
> * Callback used by helpers to inform the driver of output configuration
> * changes.
> *
> - * Drivers implementing fbdev emulation with the helpers can call
> - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev
> - * helper of output changes.
Not sure why this isn't clear, but the above is important information
that we should keep. Maybe good to fix up the formatting to make it a
hyperlink, and your addition here is fine too, but the above is the
important part really.
-Daniel
> + * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event()
> + * to call this hook to inform the fbdev helper of output changes.
> *
> - * FIXME:
> - *
> - * Except that there's no vtable for device-level helper callbacks
> - * there's no reason this is a core function.
> + * This hook is deprecated, drivers should instead use
> + * drm_fbdev_generic_setup() which takes care of any necessary
> + * hotplug event forwarding already without further involvement by
> + * the driver.
> */
> void (*output_poll_changed)(struct drm_device *dev);
>
> --
> 2.29.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-03 9:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210903032402.11935-1-zhangzhijie@loongson.cn>
2021-09-03 9:31 ` [PATCH v4] drm: Improve the output_poll_changed description Daniel Vetter
2021-01-21 3:09 ZhiJie.Zhang
2021-01-21 3:09 ` ZhiJie.Zhang
2021-01-21 11:23 ` Daniel Vetter
2021-01-21 11:23 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.