From: "Russell King (Oracle)" <firstname.lastname@example.org> To: Joakim Zhang <email@example.com> Cc: Andrew Lunn <firstname.lastname@example.org>, Vladimir Oltean <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, dl-linux-imx <firstname.lastname@example.org> Subject: Re: [PATCH] net: stmmac: fix MAC not working when system resume back with WoL enabled Date: Mon, 6 Sep 2021 12:21:59 +0100 [thread overview] Message-ID: <YTX515RMVNmT4qemail@example.com> (raw) In-Reply-To: <DB8PR04MB67958E22A85B15FFCA7CDA70E6D29@DB8PR04MB6795.eurprd04.prod.outlook.com> On Mon, Sep 06, 2021 at 10:41:48AM +0000, Joakim Zhang wrote: > Hi Russell, > > Thanks Russell, it works as we are expected, I test both MAC-based WoL active and inactive cases. Yay! > And I get the point you mentioned before, if link parameters changed during system suspended, what would happen? That's a problem with any setup that uses the MAC to detect WoL packets, and the MAC requires software to run if the link state changes. It is one of the fundamental problems of MAC-side WoL detection. I see two possible solutions to this problem: 1) If the link changes, the PHY needs to wake the system up from suspend so that software can run to reprogram the MAC for the new link parameters, and then go back to sleep. 2) We need to set the link to a state which reduces the chances of the link parameters changing. I don't think we have any support in the kernel for (1) - we assume if we are woken up than the system as a whole will become operational, so there's no automatic "go back to sleep". We do have the ability to place the link into the slowest mutually supported speed via phy(link)?_speed_down(). This has the advantage of reducing the power used to keep the link active while in suspend (which is its primary purpose) but also reduces the possible link modes that could be autonegotiated with the partner. I think I'd suggest to Andrew that phy_speed_down() should only advertise one capability, not "everything we support below the minimum mutually supported capability" - that way, if a link change is attempted on the partner while the system is suspended, the link will not come up and its obvious it isn't going to work. I think this is an issue for a separate patch set. > Since net-next is closed, so I would cook a patch set (keep you as the > phylink patch author) after it re-open, could you accept it? Or you plan > to prepare this patch set for stmmac? As the bug was introduced in v5.7, this is a regression, and the fix isn't too complex. I believe it's suitable for the net tree. I'll prepare a proper patch for the net tree for phylink, which I'll send you, so you can include with your patch set. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-09-06 11:22 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-01 9:02 Joakim Zhang 2021-09-01 9:13 ` Russell King (Oracle) 2021-09-01 10:21 ` Joakim Zhang 2021-09-01 12:56 ` Russell King (Oracle) 2021-09-02 7:01 ` Joakim Zhang 2021-09-01 15:40 ` Heiner Kallweit 2021-09-02 7:35 ` Joakim Zhang 2021-09-01 9:21 ` Vladimir Oltean 2021-09-01 10:25 ` Joakim Zhang 2021-09-01 10:56 ` Vladimir Oltean 2021-09-01 11:42 ` Joakim Zhang 2021-09-01 13:25 ` Russell King (Oracle) 2021-09-02 7:28 ` Joakim Zhang 2021-09-02 8:32 ` Russell King (Oracle) 2021-09-02 10:26 ` Joakim Zhang 2021-09-02 10:49 ` Russell King (Oracle) 2021-09-02 11:15 ` Joakim Zhang 2021-09-02 12:24 ` Andrew Lunn 2021-09-03 6:51 ` Joakim Zhang 2021-09-03 8:01 ` Russell King (Oracle) 2021-09-03 8:39 ` Joakim Zhang 2021-09-03 9:32 ` Russell King (Oracle) 2021-09-03 11:04 ` Joakim Zhang 2021-09-03 12:01 ` Russell King (Oracle) 2021-09-03 20:12 ` Russell King - ARM Linux admin 2021-09-06 2:29 ` Joakim Zhang 2021-09-06 9:34 ` Russell King (Oracle) 2021-09-06 10:41 ` Joakim Zhang 2021-09-06 11:21 ` Russell King (Oracle) [this message] 2021-09-06 13:23 ` Andrew Lunn 2021-09-07 8:52 ` Russell King (Oracle) 2021-09-06 2:21 ` Joakim Zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YTX515RMVNmT4qfirstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] net: stmmac: fix MAC not working when system resume back with WoL enabled' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.