From: Lee Jones <lee.jones@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Cc: Will McVicker <willmcvicker@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Tomasz Figa <tomasz.figa@gmail.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v1 3/4] pinctrl: samsung: change PINCTRL_EXYNOS default config logic Date: Tue, 21 Sep 2021 09:18:25 +0100 [thread overview] Message-ID: <YUmVUSYIQ+K4UWK/@google.com> (raw) In-Reply-To: <e178ae7b-6956-94f5-535b-067e1915c5fb@canonical.com> On Tue, 21 Sep 2021, Krzysztof Kozlowski wrote: > On 20/09/2021 21:03, Will McVicker wrote: > > Switching the default config logic of PINCTRL_EXYNOS to use "default > > y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select the config. > > This gives vendors the flexibility to disable the config or modularize > > it in the presence of a generic kernel. > > Reasoning is incorrect. This is an essential driver which CANNOT be > disabled for any kernel having ARCH_EXYNOS or ARCH_S5PV210. You are > trying to prepare it for some out-of-tree code? Please, upstream your > code instead. No additional code is required to build a generic kernel. The only difference would be a vendor's defconfig/fragment. The aim of this set is to provide more flexibility around how driver symbols can be configured via Kconfig. Currently if ARCH_EXYNOS (which is required if we wish to provide SERIAL_SAMSUNG as an option) is enabled it blindly enables lots of symbols without recourse. > > Verified this change doesn't effect the .config. > > > > Signed-off-by: Will McVicker <willmcvicker@google.com> > > --- > > arch/arm64/Kconfig.platforms | 1 - > > drivers/pinctrl/samsung/Kconfig | 1 + > > 2 files changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > > index 6a006490c9b9..a884e5da8b0f 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -93,7 +93,6 @@ config ARCH_EXYNOS > > bool "ARMv8 based Samsung Exynos SoC family" > > select HAVE_S3C_RTC if RTC_CLASS > > select PINCTRL > > - select PINCTRL_EXYNOS > > select PM_GENERIC_DOMAINS if PM > > help > > This enables support for ARMv8 based Samsung Exynos SoC family. > > diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig > > index dfd805e76862..483acb8ac1f6 100644 > > --- a/drivers/pinctrl/samsung/Kconfig > > +++ b/drivers/pinctrl/samsung/Kconfig > > @@ -12,6 +12,7 @@ config PINCTRL_EXYNOS > > bool "Pinctrl common driver part for Samsung Exynos SoCs" > > depends on OF_GPIO > > depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST > > + default y if ARCH_EXYNOS > > default ARCH_EXYNOS || ARCH_S5PV210 > ... and update all mach Kconfigs. > > > select PINCTRL_SAMSUNG > > select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) > > select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS > > > > > Best regards, > Krzysztof -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Cc: Will McVicker <willmcvicker@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Tomasz Figa <tomasz.figa@gmail.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v1 3/4] pinctrl: samsung: change PINCTRL_EXYNOS default config logic Date: Tue, 21 Sep 2021 09:18:25 +0100 [thread overview] Message-ID: <YUmVUSYIQ+K4UWK/@google.com> (raw) In-Reply-To: <e178ae7b-6956-94f5-535b-067e1915c5fb@canonical.com> On Tue, 21 Sep 2021, Krzysztof Kozlowski wrote: > On 20/09/2021 21:03, Will McVicker wrote: > > Switching the default config logic of PINCTRL_EXYNOS to use "default > > y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select the config. > > This gives vendors the flexibility to disable the config or modularize > > it in the presence of a generic kernel. > > Reasoning is incorrect. This is an essential driver which CANNOT be > disabled for any kernel having ARCH_EXYNOS or ARCH_S5PV210. You are > trying to prepare it for some out-of-tree code? Please, upstream your > code instead. No additional code is required to build a generic kernel. The only difference would be a vendor's defconfig/fragment. The aim of this set is to provide more flexibility around how driver symbols can be configured via Kconfig. Currently if ARCH_EXYNOS (which is required if we wish to provide SERIAL_SAMSUNG as an option) is enabled it blindly enables lots of symbols without recourse. > > Verified this change doesn't effect the .config. > > > > Signed-off-by: Will McVicker <willmcvicker@google.com> > > --- > > arch/arm64/Kconfig.platforms | 1 - > > drivers/pinctrl/samsung/Kconfig | 1 + > > 2 files changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > > index 6a006490c9b9..a884e5da8b0f 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -93,7 +93,6 @@ config ARCH_EXYNOS > > bool "ARMv8 based Samsung Exynos SoC family" > > select HAVE_S3C_RTC if RTC_CLASS > > select PINCTRL > > - select PINCTRL_EXYNOS > > select PM_GENERIC_DOMAINS if PM > > help > > This enables support for ARMv8 based Samsung Exynos SoC family. > > diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig > > index dfd805e76862..483acb8ac1f6 100644 > > --- a/drivers/pinctrl/samsung/Kconfig > > +++ b/drivers/pinctrl/samsung/Kconfig > > @@ -12,6 +12,7 @@ config PINCTRL_EXYNOS > > bool "Pinctrl common driver part for Samsung Exynos SoCs" > > depends on OF_GPIO > > depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST > > + default y if ARCH_EXYNOS > > default ARCH_EXYNOS || ARCH_S5PV210 > ... and update all mach Kconfigs. > > > select PINCTRL_SAMSUNG > > select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) > > select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS > > > > > Best regards, > Krzysztof -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-21 8:18 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-20 19:03 [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs Will McVicker 2021-09-20 19:03 ` Will McVicker 2021-09-20 19:03 ` [PATCH v1 1/4] clk: samsung: change COMMON_CLK_SAMSUNG default config logic Will McVicker 2021-09-20 19:03 ` Will McVicker 2021-09-21 7:29 ` Krzysztof Kozlowski 2021-09-21 7:29 ` Krzysztof Kozlowski 2021-09-21 7:50 ` Geert Uytterhoeven 2021-09-21 7:50 ` Geert Uytterhoeven 2021-09-21 8:35 ` Krzysztof Kozlowski 2021-09-21 8:35 ` Krzysztof Kozlowski 2021-09-21 17:58 ` Will McVicker 2021-09-21 17:58 ` Will McVicker 2021-09-21 18:04 ` Krzysztof Kozlowski 2021-09-21 18:04 ` Krzysztof Kozlowski 2021-09-23 12:57 ` Lee Jones 2021-09-23 12:57 ` Lee Jones 2021-09-23 13:27 ` Krzysztof Kozlowski 2021-09-23 13:27 ` Krzysztof Kozlowski 2021-09-23 14:18 ` Lee Jones 2021-09-23 14:18 ` Lee Jones 2021-09-23 16:27 ` Krzysztof Kozlowski 2021-09-23 16:27 ` Krzysztof Kozlowski 2021-09-23 16:30 ` Krzysztof Kozlowski 2021-09-23 16:30 ` Krzysztof Kozlowski 2021-09-20 19:03 ` [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG " Will McVicker 2021-09-20 19:03 ` Will McVicker 2021-09-20 20:57 ` Will McVicker 2021-09-20 20:57 ` Will McVicker 2021-09-21 7:23 ` Krzysztof Kozlowski 2021-09-21 7:23 ` Krzysztof Kozlowski 2021-09-21 8:19 ` Lee Jones 2021-09-21 8:19 ` Lee Jones 2021-09-21 17:45 ` Will McVicker 2021-09-21 17:45 ` Will McVicker 2021-09-21 18:20 ` Krzysztof Kozlowski 2021-09-21 18:20 ` Krzysztof Kozlowski 2021-09-23 12:39 ` Lee Jones 2021-09-23 12:39 ` Lee Jones 2021-09-23 12:57 ` Krzysztof Kozlowski 2021-09-23 12:57 ` Krzysztof Kozlowski 2021-09-23 13:41 ` Lee Jones 2021-09-23 13:41 ` Lee Jones 2021-09-23 16:19 ` Geert Uytterhoeven 2021-09-23 16:19 ` Geert Uytterhoeven 2021-09-23 18:05 ` Geert Uytterhoeven 2021-09-23 18:05 ` Geert Uytterhoeven 2021-09-20 19:03 ` [PATCH v1 3/4] pinctrl: samsung: change PINCTRL_EXYNOS " Will McVicker 2021-09-20 19:03 ` Will McVicker 2021-09-21 7:27 ` Krzysztof Kozlowski 2021-09-21 7:27 ` Krzysztof Kozlowski 2021-09-21 8:18 ` Lee Jones [this message] 2021-09-21 8:18 ` Lee Jones 2021-09-23 21:52 ` Linus Walleij 2021-09-23 21:52 ` Linus Walleij 2021-09-20 19:03 ` [PATCH v1 4/4] rtc: change HAVE_S3C_RTC " Will McVicker 2021-09-20 19:03 ` Will McVicker 2021-09-20 20:05 ` Alexandre Belloni 2021-09-20 20:05 ` Alexandre Belloni 2021-09-21 7:36 ` Krzysztof Kozlowski 2021-09-21 7:36 ` Krzysztof Kozlowski 2021-09-21 7:08 ` [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs Lee Jones 2021-09-21 7:08 ` Lee Jones 2021-09-21 7:19 ` Krzysztof Kozlowski 2021-09-21 7:19 ` Krzysztof Kozlowski 2021-09-21 7:22 ` Krzysztof Kozlowski 2021-09-21 7:22 ` Krzysztof Kozlowski 2021-09-21 8:11 ` Lee Jones 2021-09-21 8:11 ` Lee Jones 2021-09-21 8:25 ` Krzysztof Kozlowski 2021-09-21 8:25 ` Krzysztof Kozlowski 2021-09-21 8:41 ` Lee Jones 2021-09-21 8:41 ` Lee Jones 2021-09-25 2:17 ` Saravana Kannan 2021-09-25 2:17 ` Saravana Kannan 2021-09-27 8:08 ` Krzysztof Kozlowski 2021-09-27 8:08 ` Krzysztof Kozlowski 2021-09-27 8:16 ` Geert Uytterhoeven 2021-09-27 8:16 ` Geert Uytterhoeven 2021-09-27 18:07 ` Saravana Kannan 2021-09-27 18:07 ` Saravana Kannan 2021-09-27 19:54 ` Geert Uytterhoeven 2021-09-27 19:54 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YUmVUSYIQ+K4UWK/@google.com \ --to=lee.jones@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=kernel-team@android.com \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=tomasz.figa@gmail.com \ --cc=will@kernel.org \ --cc=willmcvicker@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.