All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Will McVicker <willmcvicker@google.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
	kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic
Date: Tue, 21 Sep 2021 09:23:55 +0200	[thread overview]
Message-ID: <2b48a41a-9130-b4cc-40d3-0bc7930ac76a@canonical.com> (raw)
In-Reply-To: <20210920190350.3860821-3-willmcvicker@google.com>

On 20/09/2021 21:03, Will McVicker wrote:
> Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to
> be enabled by default via "default y if ARCH_EXYNOS" versus being
> selected by the ARCH_EXYNOS config directly. This allows vendors to
> disable these configs if they wish and provides additional flexibility
> to modularize them in the presence of a generic kernel.

This is not true. Vendors cannot disable these options as they are not
visible. Although I understand that Arnd prefers this way and I do not
object it, but your explanation is incorrect.
> 
> There are no .config differences with this change. The configs
> SOC_SAMSUNG, EXYNOS_CHIPID, EXYNOS_PM_DOMAINS, and EXYNOS_PMU still
> remain enabled by default.
> 
> Signed-off-by: Will McVicker <willmcvicker@google.com>
> ---
>  arch/arm64/Kconfig.platforms | 4 ----
>  drivers/soc/samsung/Kconfig  | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 3a66ed43088d..6a006490c9b9 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -91,14 +91,10 @@ config ARCH_BRCMSTB
>  
>  config ARCH_EXYNOS
>  	bool "ARMv8 based Samsung Exynos SoC family"
> -	select EXYNOS_CHIPID

This will conflict with:
https://lore.kernel.org/linux-samsung-soc/CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com/T/#t

Build on top of it, please.


Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Will McVicker <willmcvicker@google.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
	kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic
Date: Tue, 21 Sep 2021 09:23:55 +0200	[thread overview]
Message-ID: <2b48a41a-9130-b4cc-40d3-0bc7930ac76a@canonical.com> (raw)
In-Reply-To: <20210920190350.3860821-3-willmcvicker@google.com>

On 20/09/2021 21:03, Will McVicker wrote:
> Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to
> be enabled by default via "default y if ARCH_EXYNOS" versus being
> selected by the ARCH_EXYNOS config directly. This allows vendors to
> disable these configs if they wish and provides additional flexibility
> to modularize them in the presence of a generic kernel.

This is not true. Vendors cannot disable these options as they are not
visible. Although I understand that Arnd prefers this way and I do not
object it, but your explanation is incorrect.
> 
> There are no .config differences with this change. The configs
> SOC_SAMSUNG, EXYNOS_CHIPID, EXYNOS_PM_DOMAINS, and EXYNOS_PMU still
> remain enabled by default.
> 
> Signed-off-by: Will McVicker <willmcvicker@google.com>
> ---
>  arch/arm64/Kconfig.platforms | 4 ----
>  drivers/soc/samsung/Kconfig  | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 3a66ed43088d..6a006490c9b9 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -91,14 +91,10 @@ config ARCH_BRCMSTB
>  
>  config ARCH_EXYNOS
>  	bool "ARMv8 based Samsung Exynos SoC family"
> -	select EXYNOS_CHIPID

This will conflict with:
https://lore.kernel.org/linux-samsung-soc/CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com/T/#t

Build on top of it, please.


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-09-21  7:24 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 19:03 [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs Will McVicker
2021-09-20 19:03 ` Will McVicker
2021-09-20 19:03 ` [PATCH v1 1/4] clk: samsung: change COMMON_CLK_SAMSUNG default config logic Will McVicker
2021-09-20 19:03   ` Will McVicker
2021-09-21  7:29   ` Krzysztof Kozlowski
2021-09-21  7:29     ` Krzysztof Kozlowski
2021-09-21  7:50     ` Geert Uytterhoeven
2021-09-21  7:50       ` Geert Uytterhoeven
2021-09-21  8:35       ` Krzysztof Kozlowski
2021-09-21  8:35         ` Krzysztof Kozlowski
2021-09-21 17:58         ` Will McVicker
2021-09-21 17:58           ` Will McVicker
2021-09-21 18:04           ` Krzysztof Kozlowski
2021-09-21 18:04             ` Krzysztof Kozlowski
2021-09-23 12:57             ` Lee Jones
2021-09-23 12:57               ` Lee Jones
2021-09-23 13:27               ` Krzysztof Kozlowski
2021-09-23 13:27                 ` Krzysztof Kozlowski
2021-09-23 14:18                 ` Lee Jones
2021-09-23 14:18                   ` Lee Jones
2021-09-23 16:27                   ` Krzysztof Kozlowski
2021-09-23 16:27                     ` Krzysztof Kozlowski
2021-09-23 16:30                     ` Krzysztof Kozlowski
2021-09-23 16:30                       ` Krzysztof Kozlowski
2021-09-20 19:03 ` [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG " Will McVicker
2021-09-20 19:03   ` Will McVicker
2021-09-20 20:57   ` Will McVicker
2021-09-20 20:57     ` Will McVicker
2021-09-21  7:23   ` Krzysztof Kozlowski [this message]
2021-09-21  7:23     ` Krzysztof Kozlowski
2021-09-21  8:19     ` Lee Jones
2021-09-21  8:19       ` Lee Jones
2021-09-21 17:45       ` Will McVicker
2021-09-21 17:45         ` Will McVicker
2021-09-21 18:20         ` Krzysztof Kozlowski
2021-09-21 18:20           ` Krzysztof Kozlowski
2021-09-23 12:39           ` Lee Jones
2021-09-23 12:39             ` Lee Jones
2021-09-23 12:57             ` Krzysztof Kozlowski
2021-09-23 12:57               ` Krzysztof Kozlowski
2021-09-23 13:41               ` Lee Jones
2021-09-23 13:41                 ` Lee Jones
2021-09-23 16:19                 ` Geert Uytterhoeven
2021-09-23 16:19                   ` Geert Uytterhoeven
2021-09-23 18:05                   ` Geert Uytterhoeven
2021-09-23 18:05                     ` Geert Uytterhoeven
2021-09-20 19:03 ` [PATCH v1 3/4] pinctrl: samsung: change PINCTRL_EXYNOS " Will McVicker
2021-09-20 19:03   ` Will McVicker
2021-09-21  7:27   ` Krzysztof Kozlowski
2021-09-21  7:27     ` Krzysztof Kozlowski
2021-09-21  8:18     ` Lee Jones
2021-09-21  8:18       ` Lee Jones
2021-09-23 21:52   ` Linus Walleij
2021-09-23 21:52     ` Linus Walleij
2021-09-20 19:03 ` [PATCH v1 4/4] rtc: change HAVE_S3C_RTC " Will McVicker
2021-09-20 19:03   ` Will McVicker
2021-09-20 20:05   ` Alexandre Belloni
2021-09-20 20:05     ` Alexandre Belloni
2021-09-21  7:36   ` Krzysztof Kozlowski
2021-09-21  7:36     ` Krzysztof Kozlowski
2021-09-21  7:08 ` [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs Lee Jones
2021-09-21  7:08   ` Lee Jones
2021-09-21  7:19 ` Krzysztof Kozlowski
2021-09-21  7:19   ` Krzysztof Kozlowski
2021-09-21  7:22   ` Krzysztof Kozlowski
2021-09-21  7:22     ` Krzysztof Kozlowski
2021-09-21  8:11   ` Lee Jones
2021-09-21  8:11     ` Lee Jones
2021-09-21  8:25     ` Krzysztof Kozlowski
2021-09-21  8:25       ` Krzysztof Kozlowski
2021-09-21  8:41       ` Lee Jones
2021-09-21  8:41         ` Lee Jones
2021-09-25  2:17       ` Saravana Kannan
2021-09-25  2:17         ` Saravana Kannan
2021-09-27  8:08         ` Krzysztof Kozlowski
2021-09-27  8:08           ` Krzysztof Kozlowski
2021-09-27  8:16           ` Geert Uytterhoeven
2021-09-27  8:16             ` Geert Uytterhoeven
2021-09-27 18:07           ` Saravana Kannan
2021-09-27 18:07             ` Saravana Kannan
2021-09-27 19:54             ` Geert Uytterhoeven
2021-09-27 19:54               ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b48a41a-9130-b4cc-40d3-0bc7930ac76a@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=catalin.marinas@arm.com \
    --cc=kernel-team@android.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=will@kernel.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.