[PATCH] Update min() to min_t()

[PATCH] Update min() to min_t()

[Philipp Hortmann]

This patch fixes the checkpatch.pl warning:
WARNING: min() should probably be min_t(size_t, count, MAX_TRANSFER)
+	size_t writesize = min(count, (size_t)MAX_TRANSFER);

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
 drivers/usb/usb-skeleton.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
index 2dc58766273a..d87deee3e26e 100644
--- a/drivers/usb/usb-skeleton.c
+++ b/drivers/usb/usb-skeleton.c
@@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
 	int retval = 0;
 	struct urb *urb = NULL;
 	char *buf = NULL;
-	size_t writesize = min(count, (size_t)MAX_TRANSFER);
+	size_t writesize = min_t(size_t, count, MAX_TRANSFER);
 
 	dev = file->private_data;
 
-- 
2.25.1

Re: [PATCH] Update min() to min_t()

[Greg KH]

On Tue, Sep 21, 2021 at 07:52:46AM +0200, Philipp Hortmann wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: min() should probably be min_t(size_t, count, MAX_TRANSFER)
> +	size_t writesize = min(count, (size_t)MAX_TRANSFER);
> 
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> ---
>  drivers/usb/usb-skeleton.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please resend with the subject line adding the subsystem and driver name
so that we can better know what you are modifying here.

> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> index 2dc58766273a..d87deee3e26e 100644
> --- a/drivers/usb/usb-skeleton.c
> +++ b/drivers/usb/usb-skeleton.c
> @@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
>  	int retval = 0;
>  	struct urb *urb = NULL;
>  	char *buf = NULL;
> -	size_t writesize = min(count, (size_t)MAX_TRANSFER);
> +	size_t writesize = min_t(size_t, count, MAX_TRANSFER);
>  
>  	dev = file->private_data;
>  
> -- 
> 2.25.1
> 

Has anyone actually built this driver in a while?

thanks,

greg k-h

Re: [PATCH] Update min() to min_t()

[Philipp Hortmann]

On 9/21/21 8:04 AM, Greg KH wrote:
> On Tue, Sep 21, 2021 at 07:52:46AM +0200, Philipp Hortmann wrote:
>> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
>> index 2dc58766273a..d87deee3e26e 100644
>> --- a/drivers/usb/usb-skeleton.c
>> +++ b/drivers/usb/usb-skeleton.c
>> @@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
>>   	int retval = 0;
>>   	struct urb *urb = NULL;
>>   	char *buf = NULL;
>> -	size_t writesize = min(count, (size_t)MAX_TRANSFER);
>> +	size_t writesize = min_t(size_t, count, MAX_TRANSFER);
>>   
>>   	dev = file->private_data;
>>   
>> -- 
>> 2.25.1
>>
> 
> Has anyone actually built this driver in a while?
> 
> thanks,
> 
> greg k-h
> 
Hi,

I have build and loaded the driver. To me this seems OK.

dmesg from loading:
usb_skeleton: loading out-of-tree module taints kernel.
usb_skeleton: module verification failed: signature and/or required key 
missing - tainting kernel
usbcore: registered new interface driver skeleton

dmesg from unloading:
usbcore: deregistering interface driver skeleton

Used kernel 5.15.0-rc1+

Bye Philipp

Re: [PATCH] Update min() to min_t()

[Greg KH]

On Tue, Sep 21, 2021 at 09:11:25PM +0200, Philipp Hortmann wrote:
> On 9/21/21 8:04 AM, Greg KH wrote:
> > On Tue, Sep 21, 2021 at 07:52:46AM +0200, Philipp Hortmann wrote:
> > > diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> > > index 2dc58766273a..d87deee3e26e 100644
> > > --- a/drivers/usb/usb-skeleton.c
> > > +++ b/drivers/usb/usb-skeleton.c
> > > @@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
> > >   	int retval = 0;
> > >   	struct urb *urb = NULL;
> > >   	char *buf = NULL;
> > > -	size_t writesize = min(count, (size_t)MAX_TRANSFER);
> > > +	size_t writesize = min_t(size_t, count, MAX_TRANSFER);
> > >   	dev = file->private_data;
> > > -- 
> > > 2.25.1
> > > 
> > 
> > Has anyone actually built this driver in a while?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> Hi,
> 
> I have build and loaded the driver. To me this seems OK.
> 
> dmesg from loading:
> usb_skeleton: loading out-of-tree module taints kernel.
> usb_skeleton: module verification failed: signature and/or required key
> missing - tainting kernel
> usbcore: registered new interface driver skeleton
> 
> dmesg from unloading:
> usbcore: deregistering interface driver skeleton
> 
> Used kernel 5.15.0-rc1+

Great, can you resend a v2 of this with a fixed up subject line please?

thanks,

greg k-h