From: Mark Brown <broonie@kernel.org>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: davem@davemloft.net, michael.riesch@wolfvision.net,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com,
p.zabel@pengutronix.de, lgirdwood@gmail.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG RESEND] net: stmmac: dwmac-rk: Ethernet broken on rockpro64 by commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
Date: Wed, 6 Oct 2021 18:32:26 +0100 [thread overview]
Message-ID: <YV3dqmLefGVAjH2T@sirena.org.uk> (raw)
In-Reply-To: <YV3Hk2R4uDKbTy43@monolith.localdoman>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Wed, Oct 06, 2021 at 04:58:11PM +0100, Alexandru Elisei wrote:
> Resending this because my previous email client inserted HTML into the email,
> which was then rejected by the linux-kernel@vger.kernel.org spam filter.
>
> After commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced
> pm_runtime_enable warnings"), the network card on my rockpro64-v2 was left
> unable to get a DHCP lease from the network. The offending commit was found by
> bisecting the kernel; I tried reverting the commit from v5.15-rc4 and the
> network card started working as expected.
I did end up glancing briefly at this (though no idea how I ended up
showing in get_maintainers...) - the revert dropped both the runtime PM
enables and the get/puts, I suspect the driver may need the get/puts
either where they are in the commit or at a level up.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: davem@davemloft.net, michael.riesch@wolfvision.net,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com,
p.zabel@pengutronix.de, lgirdwood@gmail.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG RESEND] net: stmmac: dwmac-rk: Ethernet broken on rockpro64 by commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
Date: Wed, 6 Oct 2021 18:32:26 +0100 [thread overview]
Message-ID: <YV3dqmLefGVAjH2T@sirena.org.uk> (raw)
In-Reply-To: <YV3Hk2R4uDKbTy43@monolith.localdoman>
[-- Attachment #1.1: Type: text/plain, Size: 849 bytes --]
On Wed, Oct 06, 2021 at 04:58:11PM +0100, Alexandru Elisei wrote:
> Resending this because my previous email client inserted HTML into the email,
> which was then rejected by the linux-kernel@vger.kernel.org spam filter.
>
> After commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced
> pm_runtime_enable warnings"), the network card on my rockpro64-v2 was left
> unable to get a DHCP lease from the network. The offending commit was found by
> bisecting the kernel; I tried reverting the commit from v5.15-rc4 and the
> network card started working as expected.
I did end up glancing briefly at this (though no idea how I ended up
showing in get_maintainers...) - the revert dropped both the runtime PM
enables and the get/puts, I suspect the driver may need the get/puts
either where they are in the commit or at a level up.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-06 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 15:58 [BUG RESEND] net: stmmac: dwmac-rk: Ethernet broken on rockpro64 by commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings") Alexandru Elisei
2021-10-06 15:58 ` Alexandru Elisei
2021-10-06 17:32 ` Mark Brown [this message]
2021-10-06 17:32 ` Mark Brown
2021-10-07 0:33 ` Jakub Kicinski
2021-10-07 0:33 ` Jakub Kicinski
2021-10-07 9:30 ` Alexandru Elisei
2021-10-07 9:30 ` Alexandru Elisei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV3dqmLefGVAjH2T@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=alexandru.elisei@arm.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.riesch@wolfvision.net \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.