All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ojaswin Mujoo <ojaswin98@gmail.com>
Cc: nsaenz@kernel.org, stefan.wahren@i2se.com,
	dan.carpenter@oracle.com, phil@raspberrypi.com,
	linux-arm-kernel@lists.infradead.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vchiq: Update TODO file
Date: Tue, 28 Sep 2021 09:10:44 +0200	[thread overview]
Message-ID: <YVK/9AIRQ5yzxpzb@kroah.com> (raw)
In-Reply-To: <20210927181323.10931-1-ojaswin98@gmail.com>

On Mon, Sep 27, 2021 at 11:43:23PM +0530, Ojaswin Mujoo wrote:
> Remove completed tasks from TODO and add some relevant details to task
> 14.
> 
> Signed-off-by: Ojaswin Mujoo <ojaswin98@gmail.com>
> ---
>  drivers/staging/vc04_services/interface/TODO | 43 ++++----------------
>  1 file changed, 7 insertions(+), 36 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO
> index 39810ce017cd..5a6b3fc2663a 100644
> --- a/drivers/staging/vc04_services/interface/TODO
> +++ b/drivers/staging/vc04_services/interface/TODO
> @@ -16,23 +16,6 @@ some of the ones we want:
>    to manage these buffers as dmabufs so that we can zero-copy import
>    camera images into vc4 for rendering/display.
>  
> -2) Garbage-collect unused code
> -
> -One of the reasons this driver wasn't upstreamed previously was that
> -there's a lot code that got built that's probably unnecessary these
> -days.  Once we have the set of VCHI-using drivers we want in tree, we
> -should be able to do a sweep of the code to see what's left that's
> -unused.
> -
> -3) Make driver more portable
> -
> -Building this driver with arm/multi_v7_defconfig or arm64/defconfig
> -leads to data corruption during the following command:
> -
> -  vchiq_test -f 1
> -
> -This should be fixed.
> -
>  4) Fix kernel module support

Now the numbering is out of order?

How about a first patch to remove the numbering and just replace it with
a list of items that are not numbered, and then remove the tasks that
are already done?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Ojaswin Mujoo <ojaswin98@gmail.com>
Cc: nsaenz@kernel.org, stefan.wahren@i2se.com,
	dan.carpenter@oracle.com, phil@raspberrypi.com,
	linux-arm-kernel@lists.infradead.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vchiq: Update TODO file
Date: Tue, 28 Sep 2021 09:10:44 +0200	[thread overview]
Message-ID: <YVK/9AIRQ5yzxpzb@kroah.com> (raw)
In-Reply-To: <20210927181323.10931-1-ojaswin98@gmail.com>

On Mon, Sep 27, 2021 at 11:43:23PM +0530, Ojaswin Mujoo wrote:
> Remove completed tasks from TODO and add some relevant details to task
> 14.
> 
> Signed-off-by: Ojaswin Mujoo <ojaswin98@gmail.com>
> ---
>  drivers/staging/vc04_services/interface/TODO | 43 ++++----------------
>  1 file changed, 7 insertions(+), 36 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO
> index 39810ce017cd..5a6b3fc2663a 100644
> --- a/drivers/staging/vc04_services/interface/TODO
> +++ b/drivers/staging/vc04_services/interface/TODO
> @@ -16,23 +16,6 @@ some of the ones we want:
>    to manage these buffers as dmabufs so that we can zero-copy import
>    camera images into vc4 for rendering/display.
>  
> -2) Garbage-collect unused code
> -
> -One of the reasons this driver wasn't upstreamed previously was that
> -there's a lot code that got built that's probably unnecessary these
> -days.  Once we have the set of VCHI-using drivers we want in tree, we
> -should be able to do a sweep of the code to see what's left that's
> -unused.
> -
> -3) Make driver more portable
> -
> -Building this driver with arm/multi_v7_defconfig or arm64/defconfig
> -leads to data corruption during the following command:
> -
> -  vchiq_test -f 1
> -
> -This should be fixed.
> -
>  4) Fix kernel module support

Now the numbering is out of order?

How about a first patch to remove the numbering and just replace it with
a list of items that are not numbered, and then remove the tasks that
are already done?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-28  7:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 18:13 [PATCH] staging: vchiq: Update TODO file Ojaswin Mujoo
2021-09-27 18:13 ` Ojaswin Mujoo
2021-09-28  7:10 ` Greg KH [this message]
2021-09-28  7:10   ` Greg KH
2021-09-30 16:49   ` Ojaswin Mujoo
2021-09-30 16:49     ` Ojaswin Mujoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVK/9AIRQ5yzxpzb@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nsaenz@kernel.org \
    --cc=ojaswin98@gmail.com \
    --cc=phil@raspberrypi.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.