From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: Claudiu Beznea <claudiu.beznea@microchip.com> Cc: nicolas.ferre@microchip.com, ludovic.desroches@microchip.com, linux@armlinux.org.uk, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: at91: pm: group constants and addresses loading Date: Tue, 28 Sep 2021 12:01:05 +0200 [thread overview] Message-ID: <YVLn4WScnmybTzy1@piout.net> (raw) In-Reply-To: <20210928084257.2188017-3-claudiu.beznea@microchip.com> Hello, On 28/09/2021 11:42:56+0300, Claudiu Beznea wrote: > Group constants and addresses loading. This commit prepares the field for > the next one. Added fixes tag on this commit as the next one will fail > to apply if backported alone to older kernels. The proper notation is to use Depends-on: on the next patch. > > Fixes: f0bbf17958e8 ("ARM: at91: pm: add self-refresh support for sama7g5") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > arch/arm/mach-at91/pm_suspend.S | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S > index cbd61a3bcab1..34f251fdb743 100644 > --- a/arch/arm/mach-at91/pm_suspend.S > +++ b/arch/arm/mach-at91/pm_suspend.S > @@ -1014,6 +1014,15 @@ ENTRY(at91_pm_suspend_in_sram) > mov tmp1, #0 > mcr p15, 0, tmp1, c7, c10, 4 > > + ldr tmp1, [r0, #PM_DATA_PMC_MCKR_OFFSET] > + str tmp1, .mckr_offset > + ldr tmp1, [r0, #PM_DATA_PMC_VERSION] > + str tmp1, .pmc_version > + ldr tmp1, [r0, #PM_DATA_MEMCTRL] > + str tmp1, .memtype > + ldr tmp1, [r0, #PM_DATA_MODE] > + str tmp1, .pm_mode > + > ldr tmp1, [r0, #PM_DATA_PMC] > str tmp1, .pmc_base > ldr tmp1, [r0, #PM_DATA_RAMC0] > @@ -1022,14 +1031,6 @@ ENTRY(at91_pm_suspend_in_sram) > str tmp1, .sramc1_base > ldr tmp1, [r0, #PM_DATA_RAMC_PHY] > str tmp1, .sramc_phy_base > - ldr tmp1, [r0, #PM_DATA_MEMCTRL] > - str tmp1, .memtype > - ldr tmp1, [r0, #PM_DATA_MODE] > - str tmp1, .pm_mode > - ldr tmp1, [r0, #PM_DATA_PMC_MCKR_OFFSET] > - str tmp1, .mckr_offset > - ldr tmp1, [r0, #PM_DATA_PMC_VERSION] > - str tmp1, .pmc_version > /* Both ldrne below are here to preload their address in the TLB */ > ldr tmp1, [r0, #PM_DATA_SHDWC] > str tmp1, .shdwc > -- > 2.25.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: Claudiu Beznea <claudiu.beznea@microchip.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, robh+dt@kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] ARM: at91: pm: group constants and addresses loading Date: Tue, 28 Sep 2021 12:01:05 +0200 [thread overview] Message-ID: <YVLn4WScnmybTzy1@piout.net> (raw) In-Reply-To: <20210928084257.2188017-3-claudiu.beznea@microchip.com> Hello, On 28/09/2021 11:42:56+0300, Claudiu Beznea wrote: > Group constants and addresses loading. This commit prepares the field for > the next one. Added fixes tag on this commit as the next one will fail > to apply if backported alone to older kernels. The proper notation is to use Depends-on: on the next patch. > > Fixes: f0bbf17958e8 ("ARM: at91: pm: add self-refresh support for sama7g5") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > arch/arm/mach-at91/pm_suspend.S | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S > index cbd61a3bcab1..34f251fdb743 100644 > --- a/arch/arm/mach-at91/pm_suspend.S > +++ b/arch/arm/mach-at91/pm_suspend.S > @@ -1014,6 +1014,15 @@ ENTRY(at91_pm_suspend_in_sram) > mov tmp1, #0 > mcr p15, 0, tmp1, c7, c10, 4 > > + ldr tmp1, [r0, #PM_DATA_PMC_MCKR_OFFSET] > + str tmp1, .mckr_offset > + ldr tmp1, [r0, #PM_DATA_PMC_VERSION] > + str tmp1, .pmc_version > + ldr tmp1, [r0, #PM_DATA_MEMCTRL] > + str tmp1, .memtype > + ldr tmp1, [r0, #PM_DATA_MODE] > + str tmp1, .pm_mode > + > ldr tmp1, [r0, #PM_DATA_PMC] > str tmp1, .pmc_base > ldr tmp1, [r0, #PM_DATA_RAMC0] > @@ -1022,14 +1031,6 @@ ENTRY(at91_pm_suspend_in_sram) > str tmp1, .sramc1_base > ldr tmp1, [r0, #PM_DATA_RAMC_PHY] > str tmp1, .sramc_phy_base > - ldr tmp1, [r0, #PM_DATA_MEMCTRL] > - str tmp1, .memtype > - ldr tmp1, [r0, #PM_DATA_MODE] > - str tmp1, .pm_mode > - ldr tmp1, [r0, #PM_DATA_PMC_MCKR_OFFSET] > - str tmp1, .mckr_offset > - ldr tmp1, [r0, #PM_DATA_PMC_VERSION] > - str tmp1, .pmc_version > /* Both ldrne below are here to preload their address in the TLB */ > ldr tmp1, [r0, #PM_DATA_SHDWC] > str tmp1, .shdwc > -- > 2.25.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-28 10:01 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-28 8:42 [PATCH 0/3] ARM: at91: pm: fixes Claudiu Beznea 2021-09-28 8:42 ` Claudiu Beznea 2021-09-28 8:42 ` [PATCH 1/3] ARM: dts: at91: sama7g5ek: add suspend voltage for ddr3l rail Claudiu Beznea 2021-09-28 8:42 ` Claudiu Beznea 2021-09-28 8:42 ` [PATCH 2/3] ARM: at91: pm: group constants and addresses loading Claudiu Beznea 2021-09-28 8:42 ` Claudiu Beznea 2021-09-28 10:01 ` Alexandre Belloni [this message] 2021-09-28 10:01 ` Alexandre Belloni 2021-09-30 10:16 ` Claudiu.Beznea 2021-09-30 10:16 ` Claudiu.Beznea 2021-10-04 10:11 ` Nicolas Ferre 2021-10-04 10:11 ` Nicolas Ferre 2021-09-28 8:42 ` [PATCH 3/3] ARM: at91: pm: preload base address of controllers in tlb Claudiu Beznea 2021-09-28 8:42 ` Claudiu Beznea 2021-09-28 10:01 ` Alexandre Belloni 2021-09-28 10:01 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YVLn4WScnmybTzy1@piout.net \ --to=alexandre.belloni@bootlin.com \ --cc=claudiu.beznea@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=ludovic.desroches@microchip.com \ --cc=nicolas.ferre@microchip.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.