From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>, Borislav Petkov <bp@alien8.de>, x86@kernel.org, Bjorn Helgaas <bhelgaas@google.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Andreas Noever <andreas.noever@gmail.com>, Michael Jamet <michael.jamet@intel.com>, Yehezkel Bernat <YehezkelShB@gmail.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Mika Westerberg <mika.westerberg@linux.intel.com>, Jonathan Corbet <corbet@lwn.net>, Jason Wang <jasowang@redhat.com>, Dan Williams <dan.j.williams@intel.com>, Andi Kleen <ak@linux.intel.com>, Kuppuswamy Sathyanarayanan <knsathya@kernel.org>, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 2/6] driver core: Add common support to skip probe for un-authorized devices Date: Thu, 30 Sep 2021 15:52:52 +0200 [thread overview] Message-ID: <YVXBNJ431YIWwZdQ@kroah.com> (raw) In-Reply-To: <20210930065807-mutt-send-email-mst@kernel.org> On Thu, Sep 30, 2021 at 06:59:36AM -0400, Michael S. Tsirkin wrote: > On Wed, Sep 29, 2021 at 06:05:07PM -0700, Kuppuswamy Sathyanarayanan wrote: > > While the common case for device-authorization is to skip probe of > > unauthorized devices, some buses may still want to emit a message on > > probe failure (Thunderbolt), or base probe failures on the > > authorization status of a related device like a parent (USB). So add > > an option (has_probe_authorization) in struct bus_type for the bus > > driver to own probe authorization policy. > > > > Reviewed-by: Dan Williams <dan.j.williams@intel.com> > > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > > > So what e.g. the PCI patch > https://lore.kernel.org/all/CACK8Z6E8pjVeC934oFgr=VB3pULx_GyT2NkzAogdRQJ9TKSX9A@mail.gmail.com/ > actually proposes is a list of > allowed drivers, not devices. Doing it at the device level > has disadvantages, for example some devices might have a legacy > unsafe driver, or an out of tree driver. It also does not > address drivers that poke at hardware during init. Doing it at a device level is the only sane way to do this. A user needs to say "this device is allowed to be controlled by this driver". This is the trust model that USB has had for over a decade and what thunderbolt also has. > Accordingly, I think the right thing to do is to skip > driver init for disallowed drivers, not skip probe > for specific devices. What do you mean by "driver init"? module_init()? No driver should be touching hardware in their module init call. They should only be touching it in the probe callback as that is the only time they are ever allowed to talk to hardware. Specifically the device that has been handed to them. If there are in-kernel PCI drivers that do not do this, they need to be fixed today. We don't care about out-of-tree drivers for obvious reasons that we have no control over them. thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: Jonathan Corbet <corbet@lwn.net>, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>, Andi Kleen <ak@linux.intel.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Michael Jamet <michael.jamet@intel.com>, linux-pci@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org, Yehezkel Bernat <YehezkelShB@gmail.com>, Kuppuswamy Sathyanarayanan <knsathya@kernel.org>, linux-kernel@vger.kernel.org, Andreas Noever <andreas.noever@gmail.com>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, Bjorn Helgaas <bhelgaas@google.com>, Thomas Gleixner <tglx@linutronix.de>, linux-usb@vger.kernel.org, Mika Westerberg <mika.westerberg@linux.intel.com>, Dan Williams <dan.j.williams@intel.com> Subject: Re: [PATCH v2 2/6] driver core: Add common support to skip probe for un-authorized devices Date: Thu, 30 Sep 2021 15:52:52 +0200 [thread overview] Message-ID: <YVXBNJ431YIWwZdQ@kroah.com> (raw) In-Reply-To: <20210930065807-mutt-send-email-mst@kernel.org> On Thu, Sep 30, 2021 at 06:59:36AM -0400, Michael S. Tsirkin wrote: > On Wed, Sep 29, 2021 at 06:05:07PM -0700, Kuppuswamy Sathyanarayanan wrote: > > While the common case for device-authorization is to skip probe of > > unauthorized devices, some buses may still want to emit a message on > > probe failure (Thunderbolt), or base probe failures on the > > authorization status of a related device like a parent (USB). So add > > an option (has_probe_authorization) in struct bus_type for the bus > > driver to own probe authorization policy. > > > > Reviewed-by: Dan Williams <dan.j.williams@intel.com> > > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > > > So what e.g. the PCI patch > https://lore.kernel.org/all/CACK8Z6E8pjVeC934oFgr=VB3pULx_GyT2NkzAogdRQJ9TKSX9A@mail.gmail.com/ > actually proposes is a list of > allowed drivers, not devices. Doing it at the device level > has disadvantages, for example some devices might have a legacy > unsafe driver, or an out of tree driver. It also does not > address drivers that poke at hardware during init. Doing it at a device level is the only sane way to do this. A user needs to say "this device is allowed to be controlled by this driver". This is the trust model that USB has had for over a decade and what thunderbolt also has. > Accordingly, I think the right thing to do is to skip > driver init for disallowed drivers, not skip probe > for specific devices. What do you mean by "driver init"? module_init()? No driver should be touching hardware in their module init call. They should only be touching it in the probe callback as that is the only time they are ever allowed to talk to hardware. Specifically the device that has been handed to them. If there are in-kernel PCI drivers that do not do this, they need to be fixed today. We don't care about out-of-tree drivers for obvious reasons that we have no control over them. thanks, greg k-h _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-09-30 13:52 UTC|newest] Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-30 1:05 [PATCH v2 0/6] Add device filter support Kuppuswamy Sathyanarayanan 2021-09-30 1:05 ` [PATCH v2 1/6] driver core: Move the "authorized" attribute from USB/Thunderbolt to core Kuppuswamy Sathyanarayanan 2021-09-30 1:42 ` Alan Stern 2021-09-30 1:42 ` Alan Stern 2021-09-30 1:55 ` Dan Williams 2021-09-30 1:55 ` Dan Williams 2021-09-30 2:38 ` Kuppuswamy, Sathyanarayanan 2021-09-30 4:59 ` Dan Williams 2021-09-30 4:59 ` Dan Williams 2021-09-30 9:05 ` Rafael J. Wysocki 2021-09-30 9:05 ` Rafael J. Wysocki 2021-09-30 14:59 ` Alan Stern 2021-09-30 14:59 ` Alan Stern 2021-09-30 15:25 ` Dan Williams 2021-09-30 15:25 ` Dan Williams 2021-09-30 11:19 ` Yehezkel Bernat 2021-09-30 15:28 ` Dan Williams 2021-09-30 15:28 ` Dan Williams 2021-09-30 18:25 ` Yehezkel Bernat 2021-09-30 19:04 ` Dan Williams 2021-09-30 19:04 ` Dan Williams 2021-09-30 19:50 ` Kuppuswamy, Sathyanarayanan 2021-09-30 20:23 ` Dan Williams 2021-09-30 20:23 ` Dan Williams 2021-09-30 1:05 ` [PATCH v2 2/6] driver core: Add common support to skip probe for un-authorized devices Kuppuswamy Sathyanarayanan 2021-09-30 10:59 ` Michael S. Tsirkin 2021-09-30 10:59 ` Michael S. Tsirkin 2021-09-30 13:52 ` Greg Kroah-Hartman [this message] 2021-09-30 13:52 ` Greg Kroah-Hartman 2021-09-30 14:38 ` Michael S. Tsirkin 2021-09-30 14:38 ` Michael S. Tsirkin 2021-09-30 14:49 ` Greg Kroah-Hartman 2021-09-30 14:49 ` Greg Kroah-Hartman 2021-09-30 15:00 ` Michael S. Tsirkin 2021-09-30 15:00 ` Michael S. Tsirkin 2021-09-30 15:22 ` Greg Kroah-Hartman 2021-09-30 15:22 ` Greg Kroah-Hartman 2021-09-30 17:17 ` Andi Kleen 2021-09-30 17:17 ` Andi Kleen 2021-09-30 17:23 ` Greg Kroah-Hartman 2021-09-30 17:23 ` Greg Kroah-Hartman 2021-09-30 19:15 ` Andi Kleen 2021-09-30 19:15 ` Andi Kleen 2021-10-01 6:29 ` Greg Kroah-Hartman 2021-10-01 6:29 ` Greg Kroah-Hartman 2021-10-01 15:51 ` Alan Stern 2021-10-01 15:51 ` Alan Stern 2021-10-01 15:56 ` Andi Kleen 2021-10-01 15:56 ` Andi Kleen 2021-09-30 14:43 ` Alan Stern 2021-09-30 14:43 ` Alan Stern 2021-09-30 14:48 ` Michael S. Tsirkin 2021-09-30 14:48 ` Michael S. Tsirkin 2021-09-30 15:32 ` Alan Stern 2021-09-30 15:32 ` Alan Stern 2021-09-30 15:52 ` Michael S. Tsirkin 2021-09-30 15:52 ` Michael S. Tsirkin 2021-09-30 14:58 ` Michael S. Tsirkin 2021-09-30 14:58 ` Michael S. Tsirkin 2021-09-30 15:35 ` Alan Stern 2021-09-30 15:35 ` Alan Stern 2021-09-30 15:59 ` Michael S. Tsirkin 2021-09-30 15:59 ` Michael S. Tsirkin 2021-09-30 19:23 ` Andi Kleen 2021-09-30 19:23 ` Andi Kleen 2021-09-30 20:44 ` Alan Stern 2021-09-30 20:44 ` Alan Stern 2021-09-30 20:52 ` Dan Williams 2021-09-30 20:52 ` Dan Williams 2021-10-01 1:41 ` Alan Stern 2021-10-01 1:41 ` Alan Stern 2021-10-01 2:20 ` Dan Williams 2021-10-01 2:20 ` Dan Williams 2021-09-30 21:12 ` Andi Kleen 2021-09-30 21:12 ` Andi Kleen 2021-09-30 1:05 ` [PATCH v2 3/6] driver core: Allow arch to initialize the authorized attribute Kuppuswamy Sathyanarayanan 2021-09-30 1:05 ` [PATCH v2 4/6] virtio: Initialize authorized attribute for confidential guest Kuppuswamy Sathyanarayanan 2021-09-30 11:03 ` Michael S. Tsirkin 2021-09-30 11:03 ` Michael S. Tsirkin 2021-09-30 13:36 ` Dan Williams 2021-09-30 13:36 ` Dan Williams 2021-09-30 13:49 ` Greg Kroah-Hartman 2021-09-30 13:49 ` Greg Kroah-Hartman 2021-09-30 15:18 ` Kuppuswamy, Sathyanarayanan 2021-09-30 15:20 ` Michael S. Tsirkin 2021-09-30 15:20 ` Michael S. Tsirkin 2021-09-30 15:23 ` Kuppuswamy, Sathyanarayanan 2021-09-30 15:23 ` Greg Kroah-Hartman 2021-09-30 15:23 ` Greg Kroah-Hartman 2021-09-30 19:04 ` Kuppuswamy, Sathyanarayanan 2021-09-30 19:16 ` Kuppuswamy, Sathyanarayanan 2021-09-30 19:30 ` Andi Kleen 2021-09-30 19:30 ` Andi Kleen 2021-09-30 19:40 ` Kuppuswamy, Sathyanarayanan 2021-10-01 7:03 ` Greg Kroah-Hartman 2021-10-01 7:03 ` Greg Kroah-Hartman 2021-10-01 15:49 ` Andi Kleen 2021-10-01 15:49 ` Andi Kleen 2021-10-02 11:04 ` Michael S. Tsirkin 2021-10-02 11:04 ` Michael S. Tsirkin 2021-10-02 11:14 ` Greg Kroah-Hartman 2021-10-02 11:14 ` Greg Kroah-Hartman 2021-10-02 14:20 ` Andi Kleen 2021-10-02 14:20 ` Andi Kleen 2021-10-02 14:44 ` Greg Kroah-Hartman 2021-10-02 14:44 ` Greg Kroah-Hartman 2021-10-02 18:40 ` Michael S. Tsirkin 2021-10-02 18:40 ` Michael S. Tsirkin 2021-10-03 6:40 ` Greg Kroah-Hartman 2021-10-03 6:40 ` Greg Kroah-Hartman 2021-10-04 21:04 ` Dan Williams 2021-10-04 21:04 ` Dan Williams 2021-10-01 16:13 ` Dan Williams 2021-10-01 16:13 ` Dan Williams 2021-10-01 16:45 ` Alan Stern 2021-10-01 16:45 ` Alan Stern 2021-10-01 18:09 ` Dan Williams 2021-10-01 18:09 ` Dan Williams 2021-10-01 19:00 ` Alan Stern 2021-10-01 19:00 ` Alan Stern 2021-10-01 19:45 ` Kuppuswamy, Sathyanarayanan 2021-10-01 19:57 ` Dan Williams 2021-10-01 19:57 ` Dan Williams 2021-10-04 5:16 ` Mika Westerberg 2021-10-05 22:33 ` Dan Williams 2021-10-05 22:33 ` Dan Williams 2021-10-06 5:45 ` Greg Kroah-Hartman 2021-10-06 5:45 ` Greg Kroah-Hartman 2021-09-30 19:25 ` Andi Kleen 2021-09-30 19:25 ` Andi Kleen 2021-09-30 1:05 ` [PATCH v2 5/6] x86/tdx: Add device filter support for x86 TDX guest platform Kuppuswamy Sathyanarayanan 2021-09-30 1:05 ` [PATCH v2 6/6] PCI: Initialize authorized attribute for confidential guest Kuppuswamy Sathyanarayanan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YVXBNJ431YIWwZdQ@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=YehezkelShB@gmail.com \ --cc=ak@linux.intel.com \ --cc=andreas.noever@gmail.com \ --cc=bhelgaas@google.com \ --cc=bp@alien8.de \ --cc=corbet@lwn.net \ --cc=dan.j.williams@intel.com \ --cc=jasowang@redhat.com \ --cc=knsathya@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=michael.jamet@intel.com \ --cc=mika.westerberg@linux.intel.com \ --cc=mingo@redhat.com \ --cc=mst@redhat.com \ --cc=rafael@kernel.org \ --cc=sathyanarayanan.kuppuswamy@linux.intel.com \ --cc=tglx@linutronix.de \ --cc=virtualization@lists.linux-foundation.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.