From: Krzysztof Adamski <krzysztof.adamski@nokia.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 04/11] hwmon: (tmp421) add support for defining labels from DT
Date: Mon, 4 Oct 2021 09:27:42 +0200 [thread overview]
Message-ID: <YVqs7iJs6T6KSSIP@localhost.localdomain> (raw)
In-Reply-To: <20211002140839.GB34532@roeck-us.net>
Dnia Sat, Oct 02, 2021 at 07:08:39AM -0700, Guenter Roeck napisał(a):
>> @@ -286,9 +299,53 @@ static int tmp421_detect(struct i2c_client *client,
>> return 0;
>> }
>>
>> +static int tmp421_probe_child_from_dt(struct i2c_client *client,
>> + struct device_node *child,
>> + struct tmp421_data *data)
>> +
>> +{
>> + struct device *dev = &client->dev;
>> + u32 i;
>> + int err;
>> +
>> + err = of_property_read_u32(child, "reg", &i);
>> + if (err) {
>> + dev_err(dev, "missing reg property of %pOFn\n", child);
>> + return err;
>> + }
>> +
>> + if (i > MAX_CHANNELS) {
>
>I think this needs to be >=. MAX_CHANNELS is 4, the array size
>is 4, and i == 4 will write after the end of the array.
You are absoluetly right here. Off by one error. I will fix this in v4.
Krzysztof
next prev parent reply other threads:[~2021-10-04 7:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 6:47 [PATCH v3 00/11] Add per channel properies support in tmp421 Krzysztof Adamski
2021-09-30 6:57 ` [PATCH v3 01/11] dt-bindings: hwmon: add missing tmp421 binding Krzysztof Adamski
2021-10-04 16:46 ` Rob Herring
2021-09-30 6:58 ` [PATCH v3 02/11] hwmon: (tmp421) introduce MAX_CHANNELS define Krzysztof Adamski
2021-09-30 6:58 ` [PATCH v3 03/11] hwmon: (tmp421) introduce a channel struct Krzysztof Adamski
2021-09-30 6:59 ` [PATCH v3 04/11] hwmon: (tmp421) add support for defining labels from DT Krzysztof Adamski
2021-10-02 14:08 ` Guenter Roeck
2021-10-04 7:27 ` Krzysztof Adamski [this message]
2021-09-30 7:05 ` [PATCH v3 05/11] hwmon: (tmp421) support disabling channels " Krzysztof Adamski
2021-09-30 7:08 ` [PATCH v3 06/11] hwmon: (tmp421) support specifying n-factor via DT Krzysztof Adamski
2021-09-30 7:09 ` [PATCH v3 07/11] hwmon: (tmp421) really disable channels Krzysztof Adamski
2021-09-30 7:15 ` [PATCH v3 08/11] hwmon: (tmp421) support HWMON_T_ENABLE Krzysztof Adamski
2021-09-30 7:16 ` [PATCH v3 09/11] hwmon: (tmp421) update documentation Krzysztof Adamski
2021-09-30 7:17 ` [PATCH v3 10/11] hwmon: (tmp421) ignore non input related DT nodes Krzysztof Adamski
2021-09-30 7:19 ` [PATCH v3 11/11] dt-bindings: hwmon: allow specifying channels for tmp421 Krzysztof Adamski
2021-10-02 14:22 ` Guenter Roeck
2021-10-04 7:36 ` Krzysztof Adamski
2021-10-05 14:14 ` Guenter Roeck
2021-10-06 8:31 ` Krzysztof Adamski
2021-10-06 20:55 ` Rob Herring
2021-10-07 7:51 ` Krzysztof Adamski
2021-10-08 14:33 ` Guenter Roeck
2021-10-08 19:18 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVqs7iJs6T6KSSIP@localhost.localdomain \
--to=krzysztof.adamski@nokia.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.