All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Golle <daniel@makrotopia.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-mediatek@lists.infradead.org,
	linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
	Ryder Lee <ryder.lee@mediatek.com>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
Date: Tue, 5 Oct 2021 17:08:05 +0100	[thread overview]
Message-ID: <YVx4ZaIZsfNQocT+@makrotopia.org> (raw)
In-Reply-To: <de40bcd3-d730-4d6b-27d0-50492fe18404@nbd.name>

On Fri, Sep 24, 2021 at 07:14:47PM +0200, Felix Fietkau wrote:
> 
> On 2021-08-25 03:33, Daniel Golle wrote:
> > EEPROM data for mt76 can be embedded into device-tree as an array.
> > 
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> >  .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > index 3e2c2e43175e5..1489d3c1cd6ec 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > @@ -47,6 +47,11 @@ properties:
> >  
> >    ieee80211-freq-limit: true
> >  
> > +  mediatek,eeprom-data:
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> Given that the driver patch simply uses memcpy on the data, shouldn't we
> use an uint8-array here?

When using the /incbin/('file.bin'); syntax the result is included as
what appears to be a uint32-array when decompiling again with dtc.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-mediatek@lists.infradead.org,
	linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
	Ryder Lee <ryder.lee@mediatek.com>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
Date: Tue, 5 Oct 2021 17:08:05 +0100	[thread overview]
Message-ID: <YVx4ZaIZsfNQocT+@makrotopia.org> (raw)
In-Reply-To: <de40bcd3-d730-4d6b-27d0-50492fe18404@nbd.name>

On Fri, Sep 24, 2021 at 07:14:47PM +0200, Felix Fietkau wrote:
> 
> On 2021-08-25 03:33, Daniel Golle wrote:
> > EEPROM data for mt76 can be embedded into device-tree as an array.
> > 
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> >  .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > index 3e2c2e43175e5..1489d3c1cd6ec 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > @@ -47,6 +47,11 @@ properties:
> >  
> >    ieee80211-freq-limit: true
> >  
> > +  mediatek,eeprom-data:
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> Given that the driver patch simply uses memcpy on the data, shouldn't we
> use an uint8-array here?

When using the /incbin/('file.bin'); syntax the result is included as
what appears to be a uint32-array when decompiling again with dtc.

  reply	other threads:[~2021-10-05 16:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  1:33 [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property Daniel Golle
2021-08-25  1:33 ` Daniel Golle
2021-08-31 19:28 ` Rob Herring
2021-08-31 19:28   ` Rob Herring
2021-09-24 17:14 ` Felix Fietkau
2021-09-24 17:14   ` Felix Fietkau
2021-10-05 16:08   ` Daniel Golle [this message]
2021-10-05 16:08     ` Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVx4ZaIZsfNQocT+@makrotopia.org \
    --to=daniel@makrotopia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.