* [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
@ 2021-08-25 1:33 ` Daniel Golle
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Golle @ 2021-08-25 1:33 UTC (permalink / raw)
To: linux-mediatek, linux-wireless, devicetree
Cc: Ryder Lee, Lorenzo Bianconi, Felix Fietkau, Matthias Brugger
EEPROM data for mt76 can be embedded into device-tree as an array.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
.../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 3e2c2e43175e5..1489d3c1cd6ec 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -47,6 +47,11 @@ properties:
ieee80211-freq-limit: true
+ mediatek,eeprom-data:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description:
+ EEPROM data embedded as array.
+
mediatek,mtd-eeprom:
$ref: /schemas/types.yaml#/definitions/phandle-array
description:
--
2.32.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
@ 2021-08-25 1:33 ` Daniel Golle
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Golle @ 2021-08-25 1:33 UTC (permalink / raw)
To: linux-mediatek, linux-wireless, devicetree
Cc: Ryder Lee, Lorenzo Bianconi, Felix Fietkau, Matthias Brugger
EEPROM data for mt76 can be embedded into device-tree as an array.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
.../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 3e2c2e43175e5..1489d3c1cd6ec 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -47,6 +47,11 @@ properties:
ieee80211-freq-limit: true
+ mediatek,eeprom-data:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description:
+ EEPROM data embedded as array.
+
mediatek,mtd-eeprom:
$ref: /schemas/types.yaml#/definitions/phandle-array
description:
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
2021-08-25 1:33 ` Daniel Golle
@ 2021-08-31 19:28 ` Rob Herring
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2021-08-31 19:28 UTC (permalink / raw)
To: Daniel Golle
Cc: Matthias Brugger, Ryder Lee, Felix Fietkau, linux-wireless,
linux-mediatek, devicetree, Lorenzo Bianconi
On Wed, 25 Aug 2021 02:33:23 +0100, Daniel Golle wrote:
> EEPROM data for mt76 can be embedded into device-tree as an array.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
@ 2021-08-31 19:28 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2021-08-31 19:28 UTC (permalink / raw)
To: Daniel Golle
Cc: Matthias Brugger, Ryder Lee, Felix Fietkau, linux-wireless,
linux-mediatek, devicetree, Lorenzo Bianconi
On Wed, 25 Aug 2021 02:33:23 +0100, Daniel Golle wrote:
> EEPROM data for mt76 can be embedded into device-tree as an array.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
2021-08-25 1:33 ` Daniel Golle
@ 2021-09-24 17:14 ` Felix Fietkau
-1 siblings, 0 replies; 8+ messages in thread
From: Felix Fietkau @ 2021-09-24 17:14 UTC (permalink / raw)
To: Daniel Golle, linux-mediatek, linux-wireless, devicetree
Cc: Ryder Lee, Lorenzo Bianconi, Matthias Brugger
On 2021-08-25 03:33, Daniel Golle wrote:
> EEPROM data for mt76 can be embedded into device-tree as an array.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 3e2c2e43175e5..1489d3c1cd6ec 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -47,6 +47,11 @@ properties:
>
> ieee80211-freq-limit: true
>
> + mediatek,eeprom-data:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
Given that the driver patch simply uses memcpy on the data, shouldn't we
use an uint8-array here?
- Felix
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
@ 2021-09-24 17:14 ` Felix Fietkau
0 siblings, 0 replies; 8+ messages in thread
From: Felix Fietkau @ 2021-09-24 17:14 UTC (permalink / raw)
To: Daniel Golle, linux-mediatek, linux-wireless, devicetree
Cc: Ryder Lee, Lorenzo Bianconi, Matthias Brugger
On 2021-08-25 03:33, Daniel Golle wrote:
> EEPROM data for mt76 can be embedded into device-tree as an array.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 3e2c2e43175e5..1489d3c1cd6ec 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -47,6 +47,11 @@ properties:
>
> ieee80211-freq-limit: true
>
> + mediatek,eeprom-data:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
Given that the driver patch simply uses memcpy on the data, shouldn't we
use an uint8-array here?
- Felix
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
2021-09-24 17:14 ` Felix Fietkau
@ 2021-10-05 16:08 ` Daniel Golle
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel Golle @ 2021-10-05 16:08 UTC (permalink / raw)
To: Felix Fietkau
Cc: linux-mediatek, linux-wireless, devicetree, Ryder Lee,
Lorenzo Bianconi, Matthias Brugger
On Fri, Sep 24, 2021 at 07:14:47PM +0200, Felix Fietkau wrote:
>
> On 2021-08-25 03:33, Daniel Golle wrote:
> > EEPROM data for mt76 can be embedded into device-tree as an array.
> >
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> > .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > index 3e2c2e43175e5..1489d3c1cd6ec 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > @@ -47,6 +47,11 @@ properties:
> >
> > ieee80211-freq-limit: true
> >
> > + mediatek,eeprom-data:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> Given that the driver patch simply uses memcpy on the data, shouldn't we
> use an uint8-array here?
When using the /incbin/('file.bin'); syntax the result is included as
what appears to be a uint32-array when decompiling again with dtc.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
@ 2021-10-05 16:08 ` Daniel Golle
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Golle @ 2021-10-05 16:08 UTC (permalink / raw)
To: Felix Fietkau
Cc: linux-mediatek, linux-wireless, devicetree, Ryder Lee,
Lorenzo Bianconi, Matthias Brugger
On Fri, Sep 24, 2021 at 07:14:47PM +0200, Felix Fietkau wrote:
>
> On 2021-08-25 03:33, Daniel Golle wrote:
> > EEPROM data for mt76 can be embedded into device-tree as an array.
> >
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> > .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > index 3e2c2e43175e5..1489d3c1cd6ec 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > @@ -47,6 +47,11 @@ properties:
> >
> > ieee80211-freq-limit: true
> >
> > + mediatek,eeprom-data:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> Given that the driver patch simply uses memcpy on the data, shouldn't we
> use an uint8-array here?
When using the /incbin/('file.bin'); syntax the result is included as
what appears to be a uint32-array when decompiling again with dtc.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-10-05 16:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 1:33 [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property Daniel Golle
2021-08-25 1:33 ` Daniel Golle
2021-08-31 19:28 ` Rob Herring
2021-08-31 19:28 ` Rob Herring
2021-09-24 17:14 ` Felix Fietkau
2021-09-24 17:14 ` Felix Fietkau
2021-10-05 16:08 ` Daniel Golle
2021-10-05 16:08 ` Daniel Golle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.