From: Andrew Lunn <andrew@lunn.ch> To: Marcel Ziswiler <marcel@ziswiler.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Frank Rowand <frowand.list@gmail.com>, Gregory Clement <gregory.clement@bootlin.com>, Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>, Russell King <linux@armlinux.org.uk>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, soc@kernel.org Subject: Re: [PATCH v1 4/4] ARM: dts: mvebu: add device tree for netgear gs110emx switch Date: Tue, 5 Oct 2021 15:05:17 +0200 [thread overview] Message-ID: <YVxNjc0LrYp4SXtP@lunn.ch> (raw) In-Reply-To: <20211005060334.203818-5-marcel@ziswiler.com> > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + switch0phy0: switch0phy0@1 { > + reg = <0x1>; > + }; > + > + port@1 { > + label = "lan1"; > + phy-handle = <&switch0phy0>; > + reg = <1>; > + }; You numbering of the phy labels is a bit confusing here. Both the port and the PHY use reg=<1>. So i would use the label switch0phy1: switch0phy1@1 Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch> To: Marcel Ziswiler <marcel@ziswiler.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Frank Rowand <frowand.list@gmail.com>, Gregory Clement <gregory.clement@bootlin.com>, Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>, Russell King <linux@armlinux.org.uk>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, soc@kernel.org Subject: Re: [PATCH v1 4/4] ARM: dts: mvebu: add device tree for netgear gs110emx switch Date: Tue, 5 Oct 2021 15:05:17 +0200 [thread overview] Message-ID: <YVxNjc0LrYp4SXtP@lunn.ch> (raw) Message-ID: <20211005130517.RpRSotMDSK5UsZI6P2Lgo5ONE5bAHD5qhXP_x0jXc34@z> (raw) In-Reply-To: <20211005060334.203818-5-marcel@ziswiler.com> > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + switch0phy0: switch0phy0@1 { > + reg = <0x1>; > + }; > + > + port@1 { > + label = "lan1"; > + phy-handle = <&switch0phy0>; > + reg = <1>; > + }; You numbering of the phy labels is a bit confusing here. Both the port and the PHY use reg=<1>. So i would use the label switch0phy1: switch0phy1@1 Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-05 13:05 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-05 6:03 [PATCH v1 0/4] ARM: prepare and add netgear gs110emx support Marcel Ziswiler 2021-10-05 6:03 ` Marcel Ziswiler 2021-10-05 6:03 ` [PATCH v1 1/4] dt-bindings: net: dsa: marvell: fix compatible in example Marcel Ziswiler 2021-10-05 6:03 ` Marcel Ziswiler 2021-10-05 12:48 ` Andrew Lunn 2021-10-05 12:48 ` Andrew Lunn 2021-10-05 12:54 ` Andrew Lunn 2021-10-05 12:54 ` Andrew Lunn 2021-10-05 6:03 ` [PATCH v1 2/4] ARM: mvebu_v7_defconfig: enable mtd physmap Marcel Ziswiler 2021-10-05 6:03 ` Marcel Ziswiler 2021-10-05 12:55 ` Andrew Lunn 2021-10-05 12:55 ` Andrew Lunn 2021-10-05 6:03 ` [PATCH v1 3/4] ARM: mvebu_v7_defconfig: rebuild default configuration Marcel Ziswiler 2021-10-05 6:03 ` Marcel Ziswiler 2021-10-05 12:56 ` Andrew Lunn 2021-10-05 12:56 ` Andrew Lunn 2021-10-05 6:03 ` [PATCH v1 4/4] ARM: dts: mvebu: add device tree for netgear gs110emx switch Marcel Ziswiler 2021-10-05 6:03 ` Marcel Ziswiler 2021-10-05 13:05 ` Andrew Lunn [this message] 2021-10-05 13:05 ` Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YVxNjc0LrYp4SXtP@lunn.ch \ --to=andrew@lunn.ch \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=gregory.clement@bootlin.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=marcel@ziswiler.com \ --cc=netdev@vger.kernel.org \ --cc=olof@lixom.net \ --cc=robh+dt@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=soc@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.