All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandru Elisei <alexandru.elisei@arm.com>
To: Punit Agrawal <punitagrawal@gmail.com>
Cc: davem@davemloft.net, michael.riesch@wolfvision.net,
	peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
	joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com,
	p.zabel@pengutronix.de, lgirdwood@gmail.com,
	Mark Brown <broonie@kernel.org>,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] Ethernet broken on rockpro64 by commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
Date: Fri, 8 Oct 2021 10:27:41 +0100	[thread overview]
Message-ID: <YWAO/gibeTDelPVq@monolith.localdoman> (raw)
In-Reply-To: <87zgrk19yb.fsf@stealth>

Hi Punit,

On Fri, Oct 08, 2021 at 12:17:48PM +0900, Punit Agrawal wrote:
> Alexandru Elisei <alexandru.elisei@arm.com> writes:
> 
> > (Sorry I'm sending this to the wrong person, this is what I got
> > scripts/get_maintainer.pl for the file touched by the commit)
> >
> > After commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced
> > pm_runtime_enable warnings"), the network card on my rockpro64-v2 was left unable
> > to get a DHCP lease from the network. The offending commit was found by bisecting
> > the kernel; I tried reverting the commit from current master (commit 0513e464f900
> > ("Merge tag 'perf-tools-fixes-for-v5.15-2021-09-27' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux")) and the network card
> > was working as expected.
> >
> > It goes without saying that I can help with testing the fix and
> > further diagnosing.
> 
> A fix was recently merged for this (see aec3f415f724 ("net: stmmac:
> dwmac-rk: Fix ethernet on rk3399 based devices") and should show up in
> the next rc. Please shout out if that doesn't fix the broken ethernet
> for you.

I can confirm that it's now working, many thanks.

Alex

> 
> Thanks,
> Punit
> 

WARNING: multiple messages have this Message-ID (diff)
From: Alexandru Elisei <alexandru.elisei@arm.com>
To: Punit Agrawal <punitagrawal@gmail.com>
Cc: davem@davemloft.net, michael.riesch@wolfvision.net,
	peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
	joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com,
	p.zabel@pengutronix.de, lgirdwood@gmail.com,
	Mark Brown <broonie@kernel.org>,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] Ethernet broken on rockpro64 by commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
Date: Fri, 8 Oct 2021 10:27:41 +0100	[thread overview]
Message-ID: <YWAO/gibeTDelPVq@monolith.localdoman> (raw)
In-Reply-To: <87zgrk19yb.fsf@stealth>

Hi Punit,

On Fri, Oct 08, 2021 at 12:17:48PM +0900, Punit Agrawal wrote:
> Alexandru Elisei <alexandru.elisei@arm.com> writes:
> 
> > (Sorry I'm sending this to the wrong person, this is what I got
> > scripts/get_maintainer.pl for the file touched by the commit)
> >
> > After commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced
> > pm_runtime_enable warnings"), the network card on my rockpro64-v2 was left unable
> > to get a DHCP lease from the network. The offending commit was found by bisecting
> > the kernel; I tried reverting the commit from current master (commit 0513e464f900
> > ("Merge tag 'perf-tools-fixes-for-v5.15-2021-09-27' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux")) and the network card
> > was working as expected.
> >
> > It goes without saying that I can help with testing the fix and
> > further diagnosing.
> 
> A fix was recently merged for this (see aec3f415f724 ("net: stmmac:
> dwmac-rk: Fix ethernet on rk3399 based devices") and should show up in
> the next rc. Please shout out if that doesn't fix the broken ethernet
> for you.

I can confirm that it's now working, many thanks.

Alex

> 
> Thanks,
> Punit
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-08  9:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  9:25 [BUG] Ethernet broken on rockpro64 by commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings") Alexandru Elisei
2021-10-08  3:17 ` Punit Agrawal
2021-10-08  3:17   ` Punit Agrawal
2021-10-08  9:27   ` Alexandru Elisei [this message]
2021-10-08  9:27     ` Alexandru Elisei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWAO/gibeTDelPVq@monolith.localdoman \
    --to=alexandru.elisei@arm.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=michael.riesch@wolfvision.net \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=peppe.cavallaro@st.com \
    --cc=punitagrawal@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.