* [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt @ 2021-10-12 22:17 ` Andi Shyti 0 siblings, 0 replies; 10+ messages in thread From: Andi Shyti @ 2021-10-12 22:17 UTC (permalink / raw) To: Intel GFX, DRI Devel Cc: Tvrtko Ursulin, Chris Wilson, Lucas De Marchi, Andi Shyti, Andi Shyti From: Andi Shyti <andi.shyti@linux.intel.com> The following interfaces: i915_wedged i915_forcewake_user are dependent on gt values. Put them inside gt/ and drop the "i915_" prefix name. This would be the new structure: dri/0/gt | +-- forcewake_user | \-- reset For backwards compatibility with existing igt (and the slight semantic difference between operating on the i915 abi entry points and the deep gt info): dri/0 | +-- i915_wedged | \-- i915_forcewake_user remain at the top level. Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 55 +++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_debugfs.h | 4 ++ drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 41 ++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h | 4 ++ drivers/gpu/drm/i915/i915_debugfs.c | 43 +++------------ 5 files changed, 111 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c index 1fe19ccd2794..f103664b71d4 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c @@ -13,6 +13,59 @@ #include "pxp/intel_pxp_debugfs.h" #include "uc/intel_uc_debugfs.h" +int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val) +{ + int ret = intel_gt_terminally_wedged(gt); + + switch (ret) { + case -EIO: + *val = 1; + return 0; + case 0: + *val = 0; + return 0; + default: + return ret; + } +} + +int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val) +{ + /* Flush any previous reset before applying for a new one */ + wait_event(gt->reset.queue, + !test_bit(I915_RESET_BACKOFF, >->reset.flags)); + + intel_gt_handle_error(gt, val, I915_ERROR_CAPTURE, + "Manually reset engine mask to %llx", val); + return 0; +} + +/* + * keep the interface clean where the first parameter + * is a 'struct intel_gt *' instead of 'void *' + */ +static int __intel_gt_debugfs_reset_show(void *data, u64 *val) +{ + return intel_gt_debugfs_reset_show(data, val); +} + +static int __intel_gt_debugfs_reset_store(void *data, u64 val) +{ + return intel_gt_debugfs_reset_store(data, val); +} + +DEFINE_SIMPLE_ATTRIBUTE(reset_fops, __intel_gt_debugfs_reset_show, + __intel_gt_debugfs_reset_store, "%llu\n"); + +static void gt_debugfs_register(struct intel_gt *gt, struct dentry *root) +{ + static const struct intel_gt_debugfs_file files[] = { + { "reset", &reset_fops, NULL }, + }; + + intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), gt); +} + void intel_gt_debugfs_register(struct intel_gt *gt) { struct dentry *root; @@ -24,6 +77,8 @@ void intel_gt_debugfs_register(struct intel_gt *gt) if (IS_ERR(root)) return; + gt_debugfs_register(gt, root); + intel_gt_engines_debugfs_register(gt, root); intel_gt_pm_debugfs_register(gt, root); intel_sseu_debugfs_register(gt, root); diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h index 8b6fca09897c..e307ceb99031 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h @@ -35,4 +35,8 @@ void intel_gt_debugfs_register_files(struct dentry *root, const struct intel_gt_debugfs_file *files, unsigned long count, void *data); +/* functions that need to be accessed by the upper level non-gt interfaces */ +int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val); +int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val); + #endif /* INTEL_GT_DEBUGFS_H */ diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c index 5f84ad602642..0bc1454f38dd 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c @@ -19,6 +19,46 @@ #include "intel_sideband.h" #include "intel_uncore.h" +int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt) +{ + atomic_inc(>->user_wakeref); + intel_gt_pm_get(gt); + if (GRAPHICS_VER(gt->i915) >= 6) + intel_uncore_forcewake_user_get(gt->uncore); + + return 0; +} + +int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt) +{ + if (GRAPHICS_VER(gt->i915) >= 6) + intel_uncore_forcewake_user_put(gt->uncore); + intel_gt_pm_put(gt); + atomic_dec(>->user_wakeref); + + return 0; +} + +static int forcewake_user_open(struct inode *inode, struct file *file) +{ + struct intel_gt *gt = inode->i_private; + + return intel_gt_pm_debugfs_forcewake_user_open(gt); +} + +static int forcewake_user_release(struct inode *inode, struct file *file) +{ + struct intel_gt *gt = inode->i_private; + + return intel_gt_pm_debugfs_forcewake_user_release(gt); +} + +static const struct file_operations forcewake_user_fops = { + .owner = THIS_MODULE, + .open = forcewake_user_open, + .release = forcewake_user_release, +}; + static int fw_domains_show(struct seq_file *m, void *data) { struct intel_gt *gt = m->private; @@ -627,6 +667,7 @@ void intel_gt_pm_debugfs_register(struct intel_gt *gt, struct dentry *root) { "drpc", &drpc_fops, NULL }, { "frequency", &frequency_fops, NULL }, { "forcewake", &fw_domains_fops, NULL }, + { "forcewake_user", &forcewake_user_fops, NULL}, { "llc", &llc_fops, llc_eval }, { "rps_boost", &rps_boost_fops, rps_eval }, }; diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h index 2b824289582b..a8457887ec65 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h @@ -13,4 +13,8 @@ struct drm_printer; void intel_gt_pm_debugfs_register(struct intel_gt *gt, struct dentry *root); void intel_gt_pm_frequency_dump(struct intel_gt *gt, struct drm_printer *m); +/* functions that need to be accessed by the upper level non-gt interfaces */ +int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt); +int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt); + #endif /* INTEL_GT_PM_DEBUGFS_H */ diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index fdbd46ff59e0..636cc3cf88be 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -35,6 +35,7 @@ #include "gt/intel_gt.h" #include "gt/intel_gt_buffer_pool.h" #include "gt/intel_gt_clock_utils.h" +#include "gt/intel_gt_debugfs.h" #include "gt/intel_gt_pm.h" #include "gt/intel_gt_pm_debugfs.h" #include "gt/intel_gt_requests.h" @@ -554,36 +555,18 @@ static int i915_wa_registers(struct seq_file *m, void *unused) return 0; } -static int -i915_wedged_get(void *data, u64 *val) +static int i915_wedged_get(void *data, u64 *val) { struct drm_i915_private *i915 = data; - int ret = intel_gt_terminally_wedged(&i915->gt); - switch (ret) { - case -EIO: - *val = 1; - return 0; - case 0: - *val = 0; - return 0; - default: - return ret; - } + return intel_gt_debugfs_reset_show(&i915->gt, val); } -static int -i915_wedged_set(void *data, u64 val) +static int i915_wedged_set(void *data, u64 val) { struct drm_i915_private *i915 = data; - /* Flush any previous reset before applying for a new one */ - wait_event(i915->gt.reset.queue, - !test_bit(I915_RESET_BACKOFF, &i915->gt.reset.flags)); - - intel_gt_handle_error(&i915->gt, val, I915_ERROR_CAPTURE, - "Manually set wedged engine mask = %llx", val); - return 0; + return intel_gt_debugfs_reset_store(&i915->gt, val); } DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops, @@ -728,27 +711,15 @@ static int i915_sseu_status(struct seq_file *m, void *unused) static int i915_forcewake_open(struct inode *inode, struct file *file) { struct drm_i915_private *i915 = inode->i_private; - struct intel_gt *gt = &i915->gt; - - atomic_inc(>->user_wakeref); - intel_gt_pm_get(gt); - if (GRAPHICS_VER(i915) >= 6) - intel_uncore_forcewake_user_get(gt->uncore); - return 0; + return intel_gt_pm_debugfs_forcewake_user_open(&i915->gt); } static int i915_forcewake_release(struct inode *inode, struct file *file) { struct drm_i915_private *i915 = inode->i_private; - struct intel_gt *gt = &i915->gt; - if (GRAPHICS_VER(i915) >= 6) - intel_uncore_forcewake_user_put(&i915->uncore); - intel_gt_pm_put(gt); - atomic_dec(>->user_wakeref); - - return 0; + return intel_gt_pm_debugfs_forcewake_user_release(&i915->gt); } static const struct file_operations i915_forcewake_fops = { -- 2.27.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt @ 2021-10-12 22:17 ` Andi Shyti 0 siblings, 0 replies; 10+ messages in thread From: Andi Shyti @ 2021-10-12 22:17 UTC (permalink / raw) To: Intel GFX, DRI Devel Cc: Tvrtko Ursulin, Chris Wilson, Lucas De Marchi, Andi Shyti, Andi Shyti From: Andi Shyti <andi.shyti@linux.intel.com> The following interfaces: i915_wedged i915_forcewake_user are dependent on gt values. Put them inside gt/ and drop the "i915_" prefix name. This would be the new structure: dri/0/gt | +-- forcewake_user | \-- reset For backwards compatibility with existing igt (and the slight semantic difference between operating on the i915 abi entry points and the deep gt info): dri/0 | +-- i915_wedged | \-- i915_forcewake_user remain at the top level. Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 55 +++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_debugfs.h | 4 ++ drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 41 ++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h | 4 ++ drivers/gpu/drm/i915/i915_debugfs.c | 43 +++------------ 5 files changed, 111 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c index 1fe19ccd2794..f103664b71d4 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c @@ -13,6 +13,59 @@ #include "pxp/intel_pxp_debugfs.h" #include "uc/intel_uc_debugfs.h" +int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val) +{ + int ret = intel_gt_terminally_wedged(gt); + + switch (ret) { + case -EIO: + *val = 1; + return 0; + case 0: + *val = 0; + return 0; + default: + return ret; + } +} + +int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val) +{ + /* Flush any previous reset before applying for a new one */ + wait_event(gt->reset.queue, + !test_bit(I915_RESET_BACKOFF, >->reset.flags)); + + intel_gt_handle_error(gt, val, I915_ERROR_CAPTURE, + "Manually reset engine mask to %llx", val); + return 0; +} + +/* + * keep the interface clean where the first parameter + * is a 'struct intel_gt *' instead of 'void *' + */ +static int __intel_gt_debugfs_reset_show(void *data, u64 *val) +{ + return intel_gt_debugfs_reset_show(data, val); +} + +static int __intel_gt_debugfs_reset_store(void *data, u64 val) +{ + return intel_gt_debugfs_reset_store(data, val); +} + +DEFINE_SIMPLE_ATTRIBUTE(reset_fops, __intel_gt_debugfs_reset_show, + __intel_gt_debugfs_reset_store, "%llu\n"); + +static void gt_debugfs_register(struct intel_gt *gt, struct dentry *root) +{ + static const struct intel_gt_debugfs_file files[] = { + { "reset", &reset_fops, NULL }, + }; + + intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), gt); +} + void intel_gt_debugfs_register(struct intel_gt *gt) { struct dentry *root; @@ -24,6 +77,8 @@ void intel_gt_debugfs_register(struct intel_gt *gt) if (IS_ERR(root)) return; + gt_debugfs_register(gt, root); + intel_gt_engines_debugfs_register(gt, root); intel_gt_pm_debugfs_register(gt, root); intel_sseu_debugfs_register(gt, root); diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h index 8b6fca09897c..e307ceb99031 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h @@ -35,4 +35,8 @@ void intel_gt_debugfs_register_files(struct dentry *root, const struct intel_gt_debugfs_file *files, unsigned long count, void *data); +/* functions that need to be accessed by the upper level non-gt interfaces */ +int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val); +int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val); + #endif /* INTEL_GT_DEBUGFS_H */ diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c index 5f84ad602642..0bc1454f38dd 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c @@ -19,6 +19,46 @@ #include "intel_sideband.h" #include "intel_uncore.h" +int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt) +{ + atomic_inc(>->user_wakeref); + intel_gt_pm_get(gt); + if (GRAPHICS_VER(gt->i915) >= 6) + intel_uncore_forcewake_user_get(gt->uncore); + + return 0; +} + +int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt) +{ + if (GRAPHICS_VER(gt->i915) >= 6) + intel_uncore_forcewake_user_put(gt->uncore); + intel_gt_pm_put(gt); + atomic_dec(>->user_wakeref); + + return 0; +} + +static int forcewake_user_open(struct inode *inode, struct file *file) +{ + struct intel_gt *gt = inode->i_private; + + return intel_gt_pm_debugfs_forcewake_user_open(gt); +} + +static int forcewake_user_release(struct inode *inode, struct file *file) +{ + struct intel_gt *gt = inode->i_private; + + return intel_gt_pm_debugfs_forcewake_user_release(gt); +} + +static const struct file_operations forcewake_user_fops = { + .owner = THIS_MODULE, + .open = forcewake_user_open, + .release = forcewake_user_release, +}; + static int fw_domains_show(struct seq_file *m, void *data) { struct intel_gt *gt = m->private; @@ -627,6 +667,7 @@ void intel_gt_pm_debugfs_register(struct intel_gt *gt, struct dentry *root) { "drpc", &drpc_fops, NULL }, { "frequency", &frequency_fops, NULL }, { "forcewake", &fw_domains_fops, NULL }, + { "forcewake_user", &forcewake_user_fops, NULL}, { "llc", &llc_fops, llc_eval }, { "rps_boost", &rps_boost_fops, rps_eval }, }; diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h index 2b824289582b..a8457887ec65 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h @@ -13,4 +13,8 @@ struct drm_printer; void intel_gt_pm_debugfs_register(struct intel_gt *gt, struct dentry *root); void intel_gt_pm_frequency_dump(struct intel_gt *gt, struct drm_printer *m); +/* functions that need to be accessed by the upper level non-gt interfaces */ +int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt); +int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt); + #endif /* INTEL_GT_PM_DEBUGFS_H */ diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index fdbd46ff59e0..636cc3cf88be 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -35,6 +35,7 @@ #include "gt/intel_gt.h" #include "gt/intel_gt_buffer_pool.h" #include "gt/intel_gt_clock_utils.h" +#include "gt/intel_gt_debugfs.h" #include "gt/intel_gt_pm.h" #include "gt/intel_gt_pm_debugfs.h" #include "gt/intel_gt_requests.h" @@ -554,36 +555,18 @@ static int i915_wa_registers(struct seq_file *m, void *unused) return 0; } -static int -i915_wedged_get(void *data, u64 *val) +static int i915_wedged_get(void *data, u64 *val) { struct drm_i915_private *i915 = data; - int ret = intel_gt_terminally_wedged(&i915->gt); - switch (ret) { - case -EIO: - *val = 1; - return 0; - case 0: - *val = 0; - return 0; - default: - return ret; - } + return intel_gt_debugfs_reset_show(&i915->gt, val); } -static int -i915_wedged_set(void *data, u64 val) +static int i915_wedged_set(void *data, u64 val) { struct drm_i915_private *i915 = data; - /* Flush any previous reset before applying for a new one */ - wait_event(i915->gt.reset.queue, - !test_bit(I915_RESET_BACKOFF, &i915->gt.reset.flags)); - - intel_gt_handle_error(&i915->gt, val, I915_ERROR_CAPTURE, - "Manually set wedged engine mask = %llx", val); - return 0; + return intel_gt_debugfs_reset_store(&i915->gt, val); } DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops, @@ -728,27 +711,15 @@ static int i915_sseu_status(struct seq_file *m, void *unused) static int i915_forcewake_open(struct inode *inode, struct file *file) { struct drm_i915_private *i915 = inode->i_private; - struct intel_gt *gt = &i915->gt; - - atomic_inc(>->user_wakeref); - intel_gt_pm_get(gt); - if (GRAPHICS_VER(i915) >= 6) - intel_uncore_forcewake_user_get(gt->uncore); - return 0; + return intel_gt_pm_debugfs_forcewake_user_open(&i915->gt); } static int i915_forcewake_release(struct inode *inode, struct file *file) { struct drm_i915_private *i915 = inode->i_private; - struct intel_gt *gt = &i915->gt; - if (GRAPHICS_VER(i915) >= 6) - intel_uncore_forcewake_user_put(&i915->uncore); - intel_gt_pm_put(gt); - atomic_dec(>->user_wakeref); - - return 0; + return intel_gt_pm_debugfs_forcewake_user_release(&i915->gt); } static const struct file_operations i915_forcewake_fops = { -- 2.27.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt 2021-10-12 22:17 ` Andi Shyti @ 2021-10-12 22:23 ` Andi Shyti -1 siblings, 0 replies; 10+ messages in thread From: Andi Shyti @ 2021-10-12 22:23 UTC (permalink / raw) To: Andi Shyti Cc: Intel GFX, DRI Devel, Tvrtko Ursulin, Chris Wilson, Lucas De Marchi, Andi Shyti Hi, sorry, just forgot to add the changelog On Wed, Oct 13, 2021 at 12:17:38AM +0200, Andi Shyti wrote: > From: Andi Shyti <andi.shyti@linux.intel.com> > > The following interfaces: > > i915_wedged > i915_forcewake_user > > are dependent on gt values. Put them inside gt/ and drop the > "i915_" prefix name. This would be the new structure: > > dri/0/gt > | > +-- forcewake_user > | > \-- reset > > For backwards compatibility with existing igt (and the slight > semantic difference between operating on the i915 abi entry > points and the deep gt info): > > dri/0 > | > +-- i915_wedged > | > \-- i915_forcewake_user > > remain at the top level. > > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> > --- Changelog: ---------- v4 -> v5: https://patchwork.freedesktop.org/patch/458293/ * rename static functions exposed to header files so that they can keep a coherent namespace (thanks Lucas!) * add Lucas r-b. v3 -> v4: https://patchwork.freedesktop.org/patch/458225/ * remove the unnecessary interrupt_info_show() information. They were already removed here by Chris: cf977e18610e6 ("drm/i915/gem: Spring clean debugfs") v2 -> v3: https://patchwork.freedesktop.org/patch/458108/ * keep the original interfaces as they were (thanks Chris) but implement the functionality inside the gt. The upper level files will call the gt functions (thanks Lucas). v1 -> v2: https://patchwork.freedesktop.org/patch/456652/ * keep the original interfaces intact (thanks Chris). Andi ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt @ 2021-10-12 22:23 ` Andi Shyti 0 siblings, 0 replies; 10+ messages in thread From: Andi Shyti @ 2021-10-12 22:23 UTC (permalink / raw) To: Andi Shyti Cc: Intel GFX, DRI Devel, Tvrtko Ursulin, Chris Wilson, Lucas De Marchi, Andi Shyti Hi, sorry, just forgot to add the changelog On Wed, Oct 13, 2021 at 12:17:38AM +0200, Andi Shyti wrote: > From: Andi Shyti <andi.shyti@linux.intel.com> > > The following interfaces: > > i915_wedged > i915_forcewake_user > > are dependent on gt values. Put them inside gt/ and drop the > "i915_" prefix name. This would be the new structure: > > dri/0/gt > | > +-- forcewake_user > | > \-- reset > > For backwards compatibility with existing igt (and the slight > semantic difference between operating on the i915 abi entry > points and the deep gt info): > > dri/0 > | > +-- i915_wedged > | > \-- i915_forcewake_user > > remain at the top level. > > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> > --- Changelog: ---------- v4 -> v5: https://patchwork.freedesktop.org/patch/458293/ * rename static functions exposed to header files so that they can keep a coherent namespace (thanks Lucas!) * add Lucas r-b. v3 -> v4: https://patchwork.freedesktop.org/patch/458225/ * remove the unnecessary interrupt_info_show() information. They were already removed here by Chris: cf977e18610e6 ("drm/i915/gem: Spring clean debugfs") v2 -> v3: https://patchwork.freedesktop.org/patch/458108/ * keep the original interfaces as they were (thanks Chris) but implement the functionality inside the gt. The upper level files will call the gt functions (thanks Lucas). v1 -> v2: https://patchwork.freedesktop.org/patch/456652/ * keep the original interfaces intact (thanks Chris). Andi ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: move remaining debugfs interfaces into gt (rev12) 2021-10-12 22:17 ` Andi Shyti (?) (?) @ 2021-10-13 0:40 ` Patchwork -1 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2021-10-13 0:40 UTC (permalink / raw) To: Andi Shyti; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 3081 bytes --] == Series Details == Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev12) URL : https://patchwork.freedesktop.org/series/75333/ State : success == Summary == CI Bug Log - changes from CI_DRM_10728 -> Patchwork_21322 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/index.html Known issues ------------ Here are the changes found in Patchwork_21322 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_frontbuffer_tracking@basic: - fi-cml-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#4269]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html - fi-cfl-8109u: [PASS][3] -> [FAIL][4] ([i915#2546]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html #### Possible fixes #### * igt@i915_selftest@live@hangcheck: - {fi-hsw-gt1}: [DMESG-WARN][5] ([i915#3303]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@perf: - {fi-tgl-dsi}: [DMESG-WARN][7] ([i915#2867]) -> [PASS][8] +9 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/fi-tgl-dsi/igt@i915_selftest@live@perf.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/fi-tgl-dsi/igt@i915_selftest@live@perf.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 [i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269 Participating hosts (41 -> 37) ------------------------------ Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-bsw-cyan fi-hsw-4200u Build changes ------------- * Linux: CI_DRM_10728 -> Patchwork_21322 CI-20190529: 20190529 CI_DRM_10728: 82a9f298afec66c882e710078138891826ce5e22 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6242: 721fd85ee95225ed5df322f7182bdfa9b86a3e68 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_21322: 2d8fe0d5ae991894e924613b34d8e9212d2bd889 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 2d8fe0d5ae99 drm/i915/gt: move remaining debugfs interfaces into gt == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/index.html [-- Attachment #2: Type: text/html, Size: 3779 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: move remaining debugfs interfaces into gt (rev12) 2021-10-12 22:17 ` Andi Shyti ` (2 preceding siblings ...) (?) @ 2021-10-13 8:25 ` Patchwork -1 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2021-10-13 8:25 UTC (permalink / raw) To: Andi Shyti; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 30285 bytes --] == Series Details == Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev12) URL : https://patchwork.freedesktop.org/series/75333/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10728_full -> Patchwork_21322_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_21322_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_21322_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_21322_full: ### IGT changes ### #### Possible regressions #### * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html Known issues ------------ Here are the changes found in Patchwork_21322_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@preservation-s3@bcs0: - shard-apl: NOTRUN -> [DMESG-WARN][3] ([i915#180]) +2 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl8/igt@gem_ctx_isolation@preservation-s3@bcs0.html * igt@gem_ctx_persistence@engines-mixed-process: - shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +3 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-snb6/igt@gem_ctx_persistence@engines-mixed-process.html * igt@gem_ctx_shared@q-in-order: - shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271]) +294 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-snb7/igt@gem_ctx_shared@q-in-order.html * igt@gem_eio@in-flight-suspend: - shard-kbl: [PASS][6] -> [DMESG-WARN][7] ([i915#180]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl4/igt@gem_eio@in-flight-suspend.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl7/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [PASS][8] -> [FAIL][9] ([i915#2846]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-glk9/igt@gem_exec_fair@basic-deadline.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-glk9/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-tglb: NOTRUN -> [FAIL][10] ([i915#2842]) +1 similar issue [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb1/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-glk5/igt@gem_exec_fair@basic-none-solo@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-glk6/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-iclb: NOTRUN -> [FAIL][13] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html - shard-tglb: [PASS][14] -> [FAIL][15] ([i915#2842]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb5/igt@gem_exec_fair@basic-pace@vcs1.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb2/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_schedule@u-submit-golden-slice@vecs0: - shard-skl: NOTRUN -> [INCOMPLETE][16] ([i915#3797]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl7/igt@gem_exec_schedule@u-submit-golden-slice@vecs0.html * igt@gem_exec_whisper@basic-fds-forked: - shard-glk: [PASS][17] -> [DMESG-WARN][18] ([i915#118]) +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-glk6/igt@gem_exec_whisper@basic-fds-forked.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-glk1/igt@gem_exec_whisper@basic-fds-forked.html * igt@gem_pxp@reject-modify-context-protection-off-2: - shard-tglb: NOTRUN -> [SKIP][19] ([i915#4270]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb8/igt@gem_pxp@reject-modify-context-protection-off-2.html * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled: - shard-kbl: NOTRUN -> [SKIP][20] ([fdo#109271]) +100 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl6/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html * igt@gem_userptr_blits@unsync-unmap-cycles: - shard-tglb: NOTRUN -> [SKIP][21] ([i915#3297]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb8/igt@gem_userptr_blits@unsync-unmap-cycles.html * igt@i915_pm_lpsp@screens-disabled: - shard-tglb: NOTRUN -> [SKIP][22] ([i915#1902]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb6/igt@i915_pm_lpsp@screens-disabled.html * igt@i915_query@query-topology-unsupported: - shard-tglb: NOTRUN -> [SKIP][23] ([fdo#109302]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb1/igt@i915_query@query-topology-unsupported.html * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][24] -> [DMESG-WARN][25] ([i915#180]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-apl3/igt@i915_suspend@sysfs-reader.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl3/igt@i915_suspend@sysfs-reader.html * igt@kms_big_fb@linear-8bpp-rotate-90: - shard-tglb: NOTRUN -> [SKIP][26] ([fdo#111614]) +1 similar issue [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb8/igt@kms_big_fb@linear-8bpp-rotate-90.html * igt@kms_big_fb@y-tiled-8bpp-rotate-180: - shard-skl: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl5/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl5/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip: - shard-skl: NOTRUN -> [FAIL][29] ([i915#3722]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl4/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip: - shard-tglb: NOTRUN -> [SKIP][30] ([fdo#111615]) +1 similar issue [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb1/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip.html * igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc: - shard-kbl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#3886]) +3 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl4/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc: - shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3886]) +10 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl3/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-bad-rotation-90-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][33] ([i915#3689]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb1/igt@kms_ccs@pipe-b-bad-rotation-90-yf_tiled_ccs.html * igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs: - shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl4/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs: - shard-tglb: NOTRUN -> [SKIP][35] ([i915#3689] / [i915#3886]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb6/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs.html * igt@kms_chamelium@dp-crc-multiple: - shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109284] / [fdo#111827]) +3 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb1/igt@kms_chamelium@dp-crc-multiple.html * igt@kms_chamelium@hdmi-hpd-with-enabled-mode: - shard-snb: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +12 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-snb7/igt@kms_chamelium@hdmi-hpd-with-enabled-mode.html * igt@kms_color_chamelium@pipe-b-degamma: - shard-kbl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +6 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl6/igt@kms_color_chamelium@pipe-b-degamma.html * igt@kms_color_chamelium@pipe-b-gamma: - shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +13 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl1/igt@kms_color_chamelium@pipe-b-gamma.html * igt@kms_color_chamelium@pipe-d-ctm-0-25: - shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +2 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl4/igt@kms_color_chamelium@pipe-d-ctm-0-25.html * igt@kms_concurrent@pipe-d: - shard-tglb: NOTRUN -> [FAIL][41] ([i915#1385]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb1/igt@kms_concurrent@pipe-d.html * igt@kms_content_protection@legacy: - shard-apl: NOTRUN -> [TIMEOUT][42] ([i915#1319]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl7/igt@kms_content_protection@legacy.html * igt@kms_content_protection@srm: - shard-tglb: NOTRUN -> [SKIP][43] ([fdo#111828]) +1 similar issue [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb8/igt@kms_content_protection@srm.html * igt@kms_cursor_crc@pipe-a-cursor-max-size-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][44] ([i915#3359]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-max-size-rapid-movement.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-tglb: [PASS][45] -> [INCOMPLETE][46] ([i915#456]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb8/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen: - shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109279] / [i915#3359]) +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb6/igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen.html * igt@kms_cursor_crc@pipe-d-cursor-suspend: - shard-tglb: [PASS][48] -> [INCOMPLETE][49] ([i915#2411] / [i915#4211]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-suspend.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-suspend.html * igt@kms_cursor_legacy@pipe-d-torture-move: - shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271]) +28 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl4/igt@kms_cursor_legacy@pipe-d-torture-move.html * igt@kms_draw_crc@draw-method-xrgb8888-render-untiled: - shard-snb: [PASS][51] -> [SKIP][52] ([fdo#109271]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-snb2/igt@kms_draw_crc@draw-method-xrgb8888-render-untiled.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-snb2/igt@kms_draw_crc@draw-method-xrgb8888-render-untiled.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [PASS][53] -> [INCOMPLETE][54] ([i915#180] / [i915#636]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-expired-vblank@b-edp1: - shard-skl: [PASS][55] -> [FAIL][56] ([i915#79]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html * igt@kms_flip@flip-vs-suspend@c-edp1: - shard-skl: [PASS][57] -> [INCOMPLETE][58] ([i915#198]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl4/igt@kms_flip@flip-vs-suspend@c-edp1.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl3/igt@kms_flip@flip-vs-suspend@c-edp1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1: - shard-skl: [PASS][59] -> [FAIL][60] ([i915#2122]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs: - shard-iclb: [PASS][61] -> [SKIP][62] ([i915#3701]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff: - shard-tglb: NOTRUN -> [SKIP][63] ([fdo#111825]) +12 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff.html * igt@kms_hdr@bpc-switch-suspend: - shard-tglb: [PASS][64] -> [INCOMPLETE][65] ([i915#1373] / [i915#2828]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb8/igt@kms_hdr@bpc-switch-suspend.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb7/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-d: - shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#533]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl3/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-a-alpha-basic: - shard-apl: NOTRUN -> [FAIL][67] ([fdo#108145] / [i915#265]) +2 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][68] ([i915#265]) +1 similar issue [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html - shard-kbl: NOTRUN -> [FAIL][69] ([i915#265]) +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl6/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2: - shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658]) +4 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html - shard-iclb: NOTRUN -> [SKIP][72] ([i915#658]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1: - shard-skl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#658]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html * igt@kms_psr@psr2_primary_blt: - shard-tglb: NOTRUN -> [FAIL][74] ([i915#132] / [i915#3467]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb1/igt@kms_psr@psr2_primary_blt.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [PASS][75] -> [SKIP][76] ([fdo#109441]) +1 similar issue [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [PASS][77] -> [DMESG-WARN][78] ([i915#180] / [i915#295]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_writeback@writeback-check-output: - shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#2437]) +1 similar issue [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl7/igt@kms_writeback@writeback-check-output.html - shard-tglb: NOTRUN -> [SKIP][80] ([i915#2437]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb6/igt@kms_writeback@writeback-check-output.html * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame: - shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271]) +178 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl3/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html * igt@nouveau_crc@pipe-c-source-outp-inactive: - shard-tglb: NOTRUN -> [SKIP][82] ([i915#2530]) +2 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb1/igt@nouveau_crc@pipe-c-source-outp-inactive.html * igt@perf@blocking: - shard-skl: [PASS][83] -> [FAIL][84] ([i915#1542]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl7/igt@perf@blocking.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl1/igt@perf@blocking.html * igt@sysfs_clients@fair-7: - shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2994]) +1 similar issue [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl6/igt@sysfs_clients@fair-7.html #### Possible fixes #### * igt@gem_eio@unwedge-stress: - shard-tglb: [TIMEOUT][86] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb3/igt@gem_eio@unwedge-stress.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb1/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [FAIL][88] ([i915#2842]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb5/igt@gem_exec_fair@basic-none-share@rcs0.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none@rcs0: - shard-glk: [FAIL][90] ([i915#2842]) -> [PASS][91] [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-glk7/igt@gem_exec_fair@basic-none@rcs0.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html * igt@gem_exec_fair@basic-none@vecs0: - shard-kbl: [FAIL][92] ([i915#2842]) -> [PASS][93] [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl3/igt@gem_exec_fair@basic-none@vecs0.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl3/igt@gem_exec_fair@basic-none@vecs0.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [FAIL][94] ([i915#454]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb6/igt@i915_pm_dc@dc6-psr.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb5/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_rpm@system-suspend-modeset: - shard-skl: [INCOMPLETE][96] ([i915#151]) -> [PASS][97] [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl1/igt@i915_pm_rpm@system-suspend-modeset.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl4/igt@i915_pm_rpm@system-suspend-modeset.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-tglb: [INCOMPLETE][98] ([i915#456] / [i915#750]) -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb1/igt@i915_suspend@fence-restore-tiled2untiled.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb8/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-skl: [FAIL][100] ([i915#2521]) -> [PASS][101] [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl5/igt@kms_async_flips@alternate-sync-async-flip.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl5/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_big_fb@x-tiled-32bpp-rotate-180: - shard-glk: [DMESG-WARN][102] ([i915#118]) -> [PASS][103] [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-glk1/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-glk7/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1: - shard-skl: [FAIL][104] ([i915#79]) -> [PASS][105] [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1: - shard-tglb: [INCOMPLETE][106] ([i915#2411] / [i915#456]) -> [PASS][107] +2 similar issues [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-tglb6/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-apl: [DMESG-WARN][108] ([i915#180]) -> [PASS][109] +2 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1: - shard-skl: [FAIL][110] ([i915#2122]) -> [PASS][111] [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile: - shard-iclb: [SKIP][112] ([i915#3701]) -> [PASS][113] [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [DMESG-WARN][114] ([i915#180]) -> [PASS][115] +4 similar issues [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [FAIL][116] ([fdo#108145] / [i915#265]) -> [PASS][117] [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [SKIP][118] ([fdo#109441]) -> [PASS][119] +2 similar issues [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb6/igt@kms_psr@psr2_cursor_blt.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html * igt@perf@polling-parameterized: - shard-glk: [FAIL][120] ([i915#1542]) -> [PASS][121] [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-glk2/igt@perf@polling-parameterized.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-glk3/igt@perf@polling-parameterized.html * igt@perf@polling-small-buf: - shard-skl: [FAIL][122] ([i915#1722]) -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl9/igt@perf@polling-small-buf.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl7/igt@perf@polling-small-buf.html #### Warnings #### * igt@i915_pm_dc@dc9-dpms: - shard-iclb: [FAIL][124] ([i915#4275]) -> [SKIP][125] ([i915#4281]) [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb2/igt@i915_pm_dc@dc9-dpms.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][126] ([i915#1804] / [i915#2684]) -> [WARN][127] ([i915#2684]) [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_frontbuffer_tracking@psr-suspend: - shard-skl: [INCOMPLETE][128] ([i915#123]) -> [INCOMPLETE][129] ([i915#123] / [i915#146]) [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl7/igt@kms_frontbuffer_tracking@psr-suspend.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-skl1/igt@kms_frontbuffer_tracking@psr-suspend.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2: - shard-iclb: [SKIP][130] ([i915#2920]) -> [SKIP][131] ([i915#658]) +1 similar issue [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3: - shard-iclb: [SKIP][132] ([i915#658]) -> [SKIP][133] ([i915#2920]) [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html * igt@runner@aborted: - shard-kbl: ([FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602] / [i915#92]) [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl3/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl3/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl1/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl1/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl7/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl6/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl7/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl7/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl3/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl1/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl2/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl1/igt@runner@aborted.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/shard-kbl3/igt == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21322/index.html [-- Attachment #2: Type: text/html, Size: 33888 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt 2021-10-12 22:17 ` Andi Shyti ` (3 preceding siblings ...) (?) @ 2021-10-14 0:04 ` Lucas De Marchi 2021-10-14 0:11 ` Andi Shyti -1 siblings, 1 reply; 10+ messages in thread From: Lucas De Marchi @ 2021-10-14 0:04 UTC (permalink / raw) To: Andi Shyti; +Cc: Intel GFX, DRI Devel, Tvrtko Ursulin, Chris Wilson, Andi Shyti On Wed, Oct 13, 2021 at 12:17:38AM +0200, Andi Shyti wrote: >From: Andi Shyti <andi.shyti@linux.intel.com> > >The following interfaces: > > i915_wedged > i915_forcewake_user > >are dependent on gt values. Put them inside gt/ and drop the >"i915_" prefix name. This would be the new structure: > > dri/0/gt > | > +-- forcewake_user > | > \-- reset > >For backwards compatibility with existing igt (and the slight >semantic difference between operating on the i915 abi entry >points and the deep gt info): > > dri/0 > | > +-- i915_wedged > | > \-- i915_forcewake_user > >remain at the top level. > >Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> >Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >Cc: Chris Wilson <chris@chris-wilson.co.uk> >Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> do you want me to push this? Lucas De Marchi ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt 2021-10-14 0:04 ` [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt Lucas De Marchi @ 2021-10-14 0:11 ` Andi Shyti 2021-10-15 4:54 ` Lucas De Marchi 0 siblings, 1 reply; 10+ messages in thread From: Andi Shyti @ 2021-10-14 0:11 UTC (permalink / raw) To: Lucas De Marchi Cc: Andi Shyti, Intel GFX, DRI Devel, Tvrtko Ursulin, Chris Wilson, Andi Shyti Hi Lucas, On Wed, Oct 13, 2021 at 05:04:27PM -0700, Lucas De Marchi wrote: > On Wed, Oct 13, 2021 at 12:17:38AM +0200, Andi Shyti wrote: > > From: Andi Shyti <andi.shyti@linux.intel.com> > > > > The following interfaces: > > > > i915_wedged > > i915_forcewake_user > > > > are dependent on gt values. Put them inside gt/ and drop the > > "i915_" prefix name. This would be the new structure: > > > > dri/0/gt > > | > > +-- forcewake_user > > | > > \-- reset > > > > For backwards compatibility with existing igt (and the slight > > semantic difference between operating on the i915 abi entry > > points and the deep gt info): > > > > dri/0 > > | > > +-- i915_wedged > > | > > \-- i915_forcewake_user > > > > remain at the top level. > > > > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> > > do you want me to push this? yes, please. Thanks, Andi ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt 2021-10-14 0:11 ` Andi Shyti @ 2021-10-15 4:54 ` Lucas De Marchi 2021-10-15 8:51 ` Andi Shyti 0 siblings, 1 reply; 10+ messages in thread From: Lucas De Marchi @ 2021-10-15 4:54 UTC (permalink / raw) To: Andi Shyti; +Cc: Andi Shyti, Intel GFX, DRI Devel, Tvrtko Ursulin, Chris Wilson On Thu, Oct 14, 2021 at 02:11:34AM +0200, Andi Shyti wrote: >Hi Lucas, > >On Wed, Oct 13, 2021 at 05:04:27PM -0700, Lucas De Marchi wrote: >> On Wed, Oct 13, 2021 at 12:17:38AM +0200, Andi Shyti wrote: >> > From: Andi Shyti <andi.shyti@linux.intel.com> >> > >> > The following interfaces: >> > >> > i915_wedged >> > i915_forcewake_user >> > >> > are dependent on gt values. Put them inside gt/ and drop the >> > "i915_" prefix name. This would be the new structure: >> > >> > dri/0/gt >> > | >> > +-- forcewake_user >> > | >> > \-- reset >> > >> > For backwards compatibility with existing igt (and the slight >> > semantic difference between operating on the i915 abi entry >> > points and the deep gt info): >> > >> > dri/0 >> > | >> > +-- i915_wedged >> > | >> > \-- i915_forcewake_user >> > >> > remain at the top level. >> > >> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> >> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> > Cc: Chris Wilson <chris@chris-wilson.co.uk> >> > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> >> >> do you want me to push this? > >yes, please. done, thanks. Now, about igt: eventually we need to update it to use the gt debugfs file. Is this something you have already or is it something we are waiting on multi-gt to land? Lucas De Marchi > >Thanks, >Andi ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt 2021-10-15 4:54 ` Lucas De Marchi @ 2021-10-15 8:51 ` Andi Shyti 0 siblings, 0 replies; 10+ messages in thread From: Andi Shyti @ 2021-10-15 8:51 UTC (permalink / raw) To: Lucas De Marchi Cc: Andi Shyti, Andi Shyti, Intel GFX, DRI Devel, Tvrtko Ursulin, Chris Wilson Hi Lucas, > > > > The following interfaces: > > > > > > > > i915_wedged > > > > i915_forcewake_user > > > > > > > > are dependent on gt values. Put them inside gt/ and drop the > > > > "i915_" prefix name. This would be the new structure: > > > > > > > > dri/0/gt > > > > | > > > > +-- forcewake_user > > > > | > > > > \-- reset > > > > > > > > For backwards compatibility with existing igt (and the slight > > > > semantic difference between operating on the i915 abi entry > > > > points and the deep gt info): > > > > > > > > dri/0 > > > > | > > > > +-- i915_wedged > > > > | > > > > \-- i915_forcewake_user > > > > > > > > remain at the top level. > > > > > > > > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> > > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > > > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> > > > > > > do you want me to push this? > > > > yes, please. > > done, thanks. Thanks! > Now, about igt: eventually we need to update it to use the gt > debugfs file. Is this something you have already or is it something > we are waiting on multi-gt to land? There is some work done in igt but it's all around multitile. I think it's better to wait for the multitile to land and then update igt. In any case, at the current state, igt shouldn't be affected. Thanks again, Andi ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-10-15 8:51 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-10-12 22:17 [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt Andi Shyti 2021-10-12 22:17 ` Andi Shyti 2021-10-12 22:23 ` Andi Shyti 2021-10-12 22:23 ` [Intel-gfx] " Andi Shyti 2021-10-13 0:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: move remaining debugfs interfaces into gt (rev12) Patchwork 2021-10-13 8:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-10-14 0:04 ` [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt Lucas De Marchi 2021-10-14 0:11 ` Andi Shyti 2021-10-15 4:54 ` Lucas De Marchi 2021-10-15 8:51 ` Andi Shyti
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.