From: Matthias Kaehlcke <mka@chromium.org> To: Doug Anderson <dianders@chromium.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Alan Stern <stern@rowland.harvard.edu>, Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Mathias Nyman <mathias.nyman@intel.com>, Felipe Balbi <balbi@kernel.org>, devicetree@vger.kernel.org, Peter Chen <peter.chen@kernel.org>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bastien Nocera <hadess@hadess.net>, Ravi Chandra Sadineni <ravisadineni@chromium.org>, Michal Simek <michal.simek@xilinx.com>, Roger Quadros <rogerq@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Stephen Boyd <swboyd@chromium.org>, Andrew Lunn <andrew@lunn.ch>, Aswath Govindraju <a-govindraju@ti.com>, Dmitry Osipenko <digetx@gmail.com>, Fabio Estevam <festevam@gmail.com>, Gregory Clement <gregory.clement@bootlin.com>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Pawel Laszczak <pawell@cadence.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Tony Lindgren <tony@atomide.com>, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v16 5/7] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' Date: Tue, 16 Nov 2021 10:07:14 -0800 [thread overview] Message-ID: <YZPzUmwWuuiwqJ2b@google.com> (raw) In-Reply-To: <CAD=FV=UFUFqojhws0MBqrq41gU9ww1h-T+OjzebFKVwzeC+LYQ@mail.gmail.com> On Thu, Nov 11, 2021 at 03:48:06PM -0800, Doug Anderson wrote: > Hi, > > On Fri, Aug 13, 2021 at 12:52 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > config USB_DWC3 > > tristate "DesignWare USB3 DRD Core Support" > > - depends on (USB || USB_GADGET) && HAS_DMA > > - select USB_XHCI_PLATFORM if USB_XHCI_HCD > > + depends on ((USB && USB_XHCI_PLATFORM) || USB_GADGET) && HAS_DMA > > Technically you don't need the "USB &&", right? Since > USB_XHCI_PLATFORM is defined in 'usb/host/Kconfig' and that's only > even included if USB is defined. So it can be just: > > depends on (USB_XHCI_PLATFORM || USB_GADGET) && HAS_DMA True, the dependency on USB isn't strictly needed. > That's not terribly important, though, so: > > Reviewed-by: Douglas Anderson <dianders@chromium.org> Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org> To: Doug Anderson <dianders@chromium.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Alan Stern <stern@rowland.harvard.edu>, Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Mathias Nyman <mathias.nyman@intel.com>, Felipe Balbi <balbi@kernel.org>, devicetree@vger.kernel.org, Peter Chen <peter.chen@kernel.org>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bastien Nocera <hadess@hadess.net>, Ravi Chandra Sadineni <ravisadineni@chromium.org>, Michal Simek <michal.simek@xilinx.com>, Roger Quadros <rogerq@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Stephen Boyd <swboyd@chromium.org>, Andrew Lunn <andrew@lunn.ch>, Aswath Govindraju <a-govindraju@ti.com>, Dmitry Osipenko <digetx@gmail.com>, Fabio Estevam <festevam@gmail.com>, Gregory Clement <gregory.clement@bootlin.com>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Pawel Laszczak <pawell@cadence.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Tony Lindgren <tony@atomide.com>, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v16 5/7] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' Date: Tue, 16 Nov 2021 10:07:14 -0800 [thread overview] Message-ID: <YZPzUmwWuuiwqJ2b@google.com> (raw) In-Reply-To: <CAD=FV=UFUFqojhws0MBqrq41gU9ww1h-T+OjzebFKVwzeC+LYQ@mail.gmail.com> On Thu, Nov 11, 2021 at 03:48:06PM -0800, Doug Anderson wrote: > Hi, > > On Fri, Aug 13, 2021 at 12:52 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > config USB_DWC3 > > tristate "DesignWare USB3 DRD Core Support" > > - depends on (USB || USB_GADGET) && HAS_DMA > > - select USB_XHCI_PLATFORM if USB_XHCI_HCD > > + depends on ((USB && USB_XHCI_PLATFORM) || USB_GADGET) && HAS_DMA > > Technically you don't need the "USB &&", right? Since > USB_XHCI_PLATFORM is defined in 'usb/host/Kconfig' and that's only > even included if USB is defined. So it can be just: > > depends on (USB_XHCI_PLATFORM || USB_GADGET) && HAS_DMA True, the dependency on USB isn't strictly needed. > That's not terribly important, though, so: > > Reviewed-by: Douglas Anderson <dianders@chromium.org> Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-16 18:07 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-13 19:52 [PATCH v16 0/7] usb: misc: Add onboard_usb_hub driver Matthias Kaehlcke 2021-08-13 19:52 ` [PATCH v16 1/7] " Matthias Kaehlcke 2021-11-11 23:31 ` Doug Anderson 2021-11-16 2:08 ` Matthias Kaehlcke 2021-08-13 19:52 ` [PATCH v16 2/7] of/platform: Add stubs for of_platform_device_create/destroy() Matthias Kaehlcke 2021-08-13 19:52 ` [PATCH v16 3/7] ARM: configs: Explicitly enable USB_XHCI_PLATFORM where needed Matthias Kaehlcke 2021-08-26 6:45 ` Roger Quadros 2021-08-26 7:56 ` Krzysztof Kozlowski 2021-08-13 19:52 ` [PATCH v16 4/7] arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM Matthias Kaehlcke 2021-08-13 19:52 ` Matthias Kaehlcke 2021-08-26 6:46 ` Roger Quadros 2021-08-26 6:46 ` Roger Quadros 2021-08-13 19:52 ` [PATCH v16 5/7] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' Matthias Kaehlcke 2021-08-13 19:52 ` Matthias Kaehlcke 2021-08-26 6:46 ` Roger Quadros 2021-08-26 6:46 ` Roger Quadros 2021-11-11 23:48 ` Doug Anderson 2021-11-11 23:48 ` Doug Anderson 2021-11-16 18:07 ` Matthias Kaehlcke [this message] 2021-11-16 18:07 ` Matthias Kaehlcke 2021-08-13 19:52 ` [PATCH v16 6/7] usb: host: xhci-plat: Create platform device for onboard hubs in probe() Matthias Kaehlcke 2021-10-20 13:05 ` Mathias Nyman 2021-10-20 20:27 ` Matthias Kaehlcke 2021-10-20 20:37 ` Alan Stern 2021-10-20 21:01 ` Matthias Kaehlcke 2021-10-20 21:57 ` Alan Stern 2021-08-13 19:52 ` [PATCH v16 7/7] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Matthias Kaehlcke 2021-09-21 17:08 ` [PATCH v16 0/7] usb: misc: Add onboard_usb_hub driver Matthias Kaehlcke 2021-10-14 21:38 ` Doug Anderson 2021-10-15 6:39 ` Greg Kroah-Hartman 2021-10-19 16:04 ` Fabrice Gasnier 2021-10-19 22:10 ` Matthias Kaehlcke 2021-10-20 6:21 ` Michal Simek 2021-10-20 17:41 ` Matthias Kaehlcke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YZPzUmwWuuiwqJ2b@google.com \ --to=mka@chromium.org \ --cc=a-govindraju@ti.com \ --cc=andrew@lunn.ch \ --cc=balbi@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=digetx@gmail.com \ --cc=festevam@gmail.com \ --cc=frowand.list@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=gregory.clement@bootlin.com \ --cc=hadess@hadess.net \ --cc=krzk@kernel.org \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@intel.com \ --cc=michal.simek@xilinx.com \ --cc=pawell@cadence.com \ --cc=peter.chen@kernel.org \ --cc=ravisadineni@chromium.org \ --cc=robh+dt@kernel.org \ --cc=rogerq@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=stern@rowland.harvard.edu \ --cc=swboyd@chromium.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.