All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marek Vasut <marex@denx.de>
Cc: dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Jonas Karlman <jonas@kwiboo.se>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>, Sam Ravnborg <sam@ravnborg.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: display: bridge: tc358867: Document DPI output support
Date: Tue, 7 Dec 2021 19:03:43 +0200	[thread overview]
Message-ID: <Ya+T7zPigqtBzdR+@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1a7967f0-ed4b-9cd2-28c8-eb9d181448ae@denx.de>

On Tue, Dec 07, 2021 at 05:47:29PM +0100, Marek Vasut wrote:
> On 12/7/21 17:43, Laurent Pinchart wrote:
> 
> [...]
> 
> >> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
> >> index f1541cc05297..5cfda6f2ba69 100644
> >> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
> >> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
> >> @@ -61,8 +61,8 @@ properties:
> >>         port@1:
> >>           $ref: /schemas/graph.yaml#/properties/port
> >>           description: |
> >> -            DPI input port. The remote endpoint phandle should be a
> >> -            reference to a valid DPI output endpoint node
> >> +            DPI input/output port. The remote endpoint phandle should be a
> >> +            reference to a valid DPI output or input endpoint node.
> > 
> > I assume the mode of operation (input or output) will be fixed for a
> > given hardware design. Isn't this something that should be recorded in
> > DT ? It would simplify configuration of the device in the driver.
> 
> Currently the configuration (DSI-to-DPI / DPI-to-eDP) is inferred from 
> the presence of DPI panel. If DPI panel present, DSI-to-DPI, else, 
> DPI-to-eDP.

I've had a look at the driver side, and it seems to complicate things
quite a bit. It seems that specifying the mode of operation explicitly
in DT could make software implementations quite a bit simpler.

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marek Vasut <marex@denx.de>
Cc: devicetree@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Rob Herring <robh+dt@kernel.org>, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 1/4] dt-bindings: display: bridge: tc358867: Document DPI output support
Date: Tue, 7 Dec 2021 19:03:43 +0200	[thread overview]
Message-ID: <Ya+T7zPigqtBzdR+@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1a7967f0-ed4b-9cd2-28c8-eb9d181448ae@denx.de>

On Tue, Dec 07, 2021 at 05:47:29PM +0100, Marek Vasut wrote:
> On 12/7/21 17:43, Laurent Pinchart wrote:
> 
> [...]
> 
> >> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
> >> index f1541cc05297..5cfda6f2ba69 100644
> >> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
> >> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml
> >> @@ -61,8 +61,8 @@ properties:
> >>         port@1:
> >>           $ref: /schemas/graph.yaml#/properties/port
> >>           description: |
> >> -            DPI input port. The remote endpoint phandle should be a
> >> -            reference to a valid DPI output endpoint node
> >> +            DPI input/output port. The remote endpoint phandle should be a
> >> +            reference to a valid DPI output or input endpoint node.
> > 
> > I assume the mode of operation (input or output) will be fixed for a
> > given hardware design. Isn't this something that should be recorded in
> > DT ? It would simplify configuration of the device in the driver.
> 
> Currently the configuration (DSI-to-DPI / DPI-to-eDP) is inferred from 
> the presence of DPI panel. If DPI panel present, DSI-to-DPI, else, 
> DPI-to-eDP.

I've had a look at the driver side, and it seems to complicate things
quite a bit. It seems that specifying the mode of operation explicitly
in DT could make software implementations quite a bit simpler.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2021-12-07 17:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-27  3:24 [PATCH 1/4] dt-bindings: display: bridge: tc358867: Document DPI output support Marek Vasut
2021-11-27  3:24 ` Marek Vasut
2021-11-27  3:24 ` [PATCH 2/4] drm/bridge: tc358767: Move hardware init to enable callback Marek Vasut
2021-12-06 18:01   ` Dave Stevenson
2021-12-06 20:24     ` Marek Vasut
2021-12-07 13:34       ` Dave Stevenson
2021-12-07 13:59         ` Marek Vasut
2021-12-07 16:28           ` Dave Stevenson
2021-12-07 16:43             ` Marek Vasut
2021-11-27  3:24 ` [PATCH 3/4] drm/bridge: tc358767: Move bridge endpoint parsing into dedicated function Marek Vasut
2021-11-27  3:24 ` [PATCH 4/4] drm/bridge: tc358767: Add DSI-to-DPI mode support Marek Vasut
2022-01-17  3:02   ` Marek Vasut
2022-02-03 12:26   ` Maxime Ripard
2021-12-07 16:43 ` [PATCH 1/4] dt-bindings: display: bridge: tc358867: Document DPI output support Laurent Pinchart
2021-12-07 16:43   ` Laurent Pinchart
2021-12-07 16:47   ` Marek Vasut
2021-12-07 16:47     ` Marek Vasut
2021-12-07 17:03     ` Laurent Pinchart [this message]
2021-12-07 17:03       ` Laurent Pinchart
2021-12-07 17:32       ` Marek Vasut
2021-12-07 17:32         ` Marek Vasut
2022-02-03 12:23         ` Maxime Ripard
2022-02-03 12:23           ` Maxime Ripard
2022-02-17 20:57           ` Marek Vasut
2022-02-17 20:57             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ya+T7zPigqtBzdR+@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=marex@denx.de \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.