From: Mark Brown <broonie@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kees Cook <keescook@chromium.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Harry Wentland <harry.wentland@amd.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maxime Ripard <maxime@cerno.tech>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Liam Girdwood <lgirdwood@gmail.com>,
Paul Boddie <paul@boddie.org.uk>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780
Date: Wed, 1 Dec 2021 13:39:01 +0000 [thread overview]
Message-ID: <Yad69aTXcGixXvy3@sirena.org.uk> (raw)
In-Reply-To: <LKTF3R.YREPOCHOSMQN2@crapouillou.net>
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
On Wed, Dec 01, 2021 at 01:02:45PM +0000, Paul Cercueil wrote:
> Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller
> > + regulator = devm_regulator_get_optional(&pdev->dev, "hdmi-5v");
> > + if (IS_ERR(regulator)) {
> > + ret = PTR_ERR(regulator);
Why is this using _optional()? This should only be done when the supply
can be physically absent (in which case I'd expect to see special
handling).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
Paul Boddie <paul@boddie.org.uk>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Sam Ravnborg <sam@ravnborg.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
devicetree@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Jonas Karlman <jonas@kwiboo.se>, Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime@cerno.tech>,
letux-kernel@openphoenux.org,
Ezequiel Garcia <ezequiel@collabora.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Robert Foss <robert.foss@linaro.org>,
linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780
Date: Wed, 1 Dec 2021 13:39:01 +0000 [thread overview]
Message-ID: <Yad69aTXcGixXvy3@sirena.org.uk> (raw)
In-Reply-To: <LKTF3R.YREPOCHOSMQN2@crapouillou.net>
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
On Wed, Dec 01, 2021 at 01:02:45PM +0000, Paul Cercueil wrote:
> Le mar., nov. 30 2021 at 22:26:37 +0100, H. Nikolaus Schaller
> > + regulator = devm_regulator_get_optional(&pdev->dev, "hdmi-5v");
> > + if (IS_ERR(regulator)) {
> > + ret = PTR_ERR(regulator);
Why is this using _optional()? This should only be done when the supply
can be physically absent (in which case I'd expect to see special
handling).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-12-01 13:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 21:26 [PATCH v10 0/8] MIPS: JZ4780 and CI20 HDMI H. Nikolaus Schaller
2021-11-30 21:26 ` H. Nikolaus Schaller
2021-11-30 21:26 ` [PATCH v10 1/8] drm/ingenic: prepare ingenic drm for later addition of JZ4780 H. Nikolaus Schaller
2021-11-30 21:26 ` H. Nikolaus Schaller
2021-11-30 21:26 ` [PATCH v10 2/8] drm/ingenic: Add support for JZ4780 and HDMI output H. Nikolaus Schaller
2021-11-30 21:26 ` H. Nikolaus Schaller
2021-11-30 21:26 ` [PATCH v10 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema H. Nikolaus Schaller
2021-11-30 21:26 ` [PATCH v10 3/8] dt-bindings: display: Add ingenic, jz4780-dw-hdmi " H. Nikolaus Schaller
2021-11-30 21:26 ` [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780 H. Nikolaus Schaller
2021-11-30 21:26 ` H. Nikolaus Schaller
2021-12-01 13:02 ` Paul Cercueil
2021-12-01 13:02 ` Paul Cercueil
2021-12-01 13:18 ` H. Nikolaus Schaller
2021-12-01 13:18 ` H. Nikolaus Schaller
2021-12-01 13:39 ` Mark Brown [this message]
2021-12-01 13:39 ` Mark Brown
2021-12-01 13:51 ` H. Nikolaus Schaller
2021-12-01 13:51 ` H. Nikolaus Schaller
2021-12-01 14:03 ` Paul Cercueil
2021-12-01 14:03 ` Paul Cercueil
2021-12-01 14:33 ` H. Nikolaus Schaller
2021-12-01 14:33 ` H. Nikolaus Schaller
2021-12-01 15:10 ` Mark Brown
2021-12-01 15:10 ` Mark Brown
2021-12-01 16:53 ` H. Nikolaus Schaller
2021-12-01 16:53 ` H. Nikolaus Schaller
2021-12-01 17:02 ` Mark Brown
2021-12-01 17:02 ` Mark Brown
2021-11-30 21:26 ` [PATCH v10 5/8] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers H. Nikolaus Schaller
2021-11-30 21:26 ` H. Nikolaus Schaller
2021-11-30 21:26 ` [PATCH v10 6/8] MIPS: DTS: CI20: Add DT nodes for HDMI setup H. Nikolaus Schaller
2021-11-30 21:26 ` H. Nikolaus Schaller
2021-11-30 21:26 ` [PATCH v10 7/8] MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780 H. Nikolaus Schaller
2021-11-30 21:26 ` H. Nikolaus Schaller
2021-11-30 21:26 ` [PATCH v10 8/8] [RFC] MIPS: DTS: Ingenic: adjust register size to available registers H. Nikolaus Schaller
2021-11-30 21:26 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yad69aTXcGixXvy3@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=ezequiel@collabora.com \
--cc=geert+renesas@glider.be \
--cc=harry.wentland@amd.com \
--cc=hns@goldelico.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=keescook@chromium.org \
--cc=letux-kernel@openphoenux.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=miquel.raynal@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.