From: "H. Nikolaus Schaller" <hns@goldelico.com> To: Paul Cercueil <paul@crapouillou.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, "H. Nikolaus Schaller" <hns@goldelico.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Kees Cook <keescook@chromium.org>, "Eric W. Biederman" <ebiederm@xmission.com>, Miquel Raynal <miquel.raynal@bootlin.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Neil Armstrong <narmstrong@baylibre.com>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jernej Skrabec <jernej.skrabec@gmail.com>, Harry Wentland <harry.wentland@amd.com>, Sam Ravnborg <sam@ravnborg.org>, Maxime Ripard <maxime@cerno.tech>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Paul Boddie <paul@boddie.org.uk> Cc: devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, Jonas Karlman <jonas@kwiboo.se>, dri-devel@lists.freedesktop.org Subject: [PATCH v10 1/8] drm/ingenic: prepare ingenic drm for later addition of JZ4780 Date: Tue, 30 Nov 2021 22:26:34 +0100 [thread overview] Message-ID: <ee65e70e91268b3963f8a6581c8aa6c3b643c53e.1638307601.git.hns@goldelico.com> (raw) In-Reply-To: <cover.1638307601.git.hns@goldelico.com> This changes the way the regmap is allocated to prepare for the later addition of the JZ4780 which has more registers and bits than the others. Therefore we make the regmap as big as the reg property in the device tree tells. Suggested-by: Paul Cercueil <paul@crapouillou.net> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index 462bc0f35f1bf..0bb590c3910d9 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -173,7 +173,6 @@ static const struct regmap_config ingenic_drm_regmap_config = { .val_bits = 32, .reg_stride = 4, - .max_register = JZ_REG_LCD_SIZE1, .writeable_reg = ingenic_drm_writeable_reg, }; @@ -1011,6 +1010,8 @@ static int ingenic_drm_bind(struct device *dev, bool has_components) struct ingenic_drm_bridge *ib; struct drm_device *drm; void __iomem *base; + struct resource *res; + struct regmap_config regmap_config; long parent_rate; unsigned int i, clone_mask = 0; int ret, irq; @@ -1056,14 +1057,16 @@ static int ingenic_drm_bind(struct device *dev, bool has_components) drm->mode_config.funcs = &ingenic_drm_mode_config_funcs; drm->mode_config.helper_private = &ingenic_drm_mode_config_helpers; - base = devm_platform_ioremap_resource(pdev, 0); + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(base)) { dev_err(dev, "Failed to get memory resource\n"); return PTR_ERR(base); } + regmap_config = ingenic_drm_regmap_config; + regmap_config.max_register = res->end - res->start; priv->map = devm_regmap_init_mmio(dev, base, - &ingenic_drm_regmap_config); + ®map_config); if (IS_ERR(priv->map)) { dev_err(dev, "Failed to create regmap\n"); return PTR_ERR(priv->map); -- 2.33.0
WARNING: multiple messages have this Message-ID (diff)
From: "H. Nikolaus Schaller" <hns@goldelico.com> To: Paul Cercueil <paul@crapouillou.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, "H. Nikolaus Schaller" <hns@goldelico.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Kees Cook <keescook@chromium.org>, "Eric W. Biederman" <ebiederm@xmission.com>, Miquel Raynal <miquel.raynal@bootlin.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Neil Armstrong <narmstrong@baylibre.com>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jernej Skrabec <jernej.skrabec@gmail.com>, Harry Wentland <harry.wentland@amd.com>, Sam Ravnborg <sam@ravnborg.org>, Maxime Ripard <maxime@cerno.tech>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Paul Boddie <paul@boddie.org.uk> Cc: devicetree@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org Subject: [PATCH v10 1/8] drm/ingenic: prepare ingenic drm for later addition of JZ4780 Date: Tue, 30 Nov 2021 22:26:34 +0100 [thread overview] Message-ID: <ee65e70e91268b3963f8a6581c8aa6c3b643c53e.1638307601.git.hns@goldelico.com> (raw) In-Reply-To: <cover.1638307601.git.hns@goldelico.com> This changes the way the regmap is allocated to prepare for the later addition of the JZ4780 which has more registers and bits than the others. Therefore we make the regmap as big as the reg property in the device tree tells. Suggested-by: Paul Cercueil <paul@crapouillou.net> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index 462bc0f35f1bf..0bb590c3910d9 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -173,7 +173,6 @@ static const struct regmap_config ingenic_drm_regmap_config = { .val_bits = 32, .reg_stride = 4, - .max_register = JZ_REG_LCD_SIZE1, .writeable_reg = ingenic_drm_writeable_reg, }; @@ -1011,6 +1010,8 @@ static int ingenic_drm_bind(struct device *dev, bool has_components) struct ingenic_drm_bridge *ib; struct drm_device *drm; void __iomem *base; + struct resource *res; + struct regmap_config regmap_config; long parent_rate; unsigned int i, clone_mask = 0; int ret, irq; @@ -1056,14 +1057,16 @@ static int ingenic_drm_bind(struct device *dev, bool has_components) drm->mode_config.funcs = &ingenic_drm_mode_config_funcs; drm->mode_config.helper_private = &ingenic_drm_mode_config_helpers; - base = devm_platform_ioremap_resource(pdev, 0); + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(base)) { dev_err(dev, "Failed to get memory resource\n"); return PTR_ERR(base); } + regmap_config = ingenic_drm_regmap_config; + regmap_config.max_register = res->end - res->start; priv->map = devm_regmap_init_mmio(dev, base, - &ingenic_drm_regmap_config); + ®map_config); if (IS_ERR(priv->map)) { dev_err(dev, "Failed to create regmap\n"); return PTR_ERR(priv->map); -- 2.33.0
next prev parent reply other threads:[~2021-11-30 21:27 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-30 21:26 [PATCH v10 0/8] MIPS: JZ4780 and CI20 HDMI H. Nikolaus Schaller 2021-11-30 21:26 ` H. Nikolaus Schaller 2021-11-30 21:26 ` H. Nikolaus Schaller [this message] 2021-11-30 21:26 ` [PATCH v10 1/8] drm/ingenic: prepare ingenic drm for later addition of JZ4780 H. Nikolaus Schaller 2021-11-30 21:26 ` [PATCH v10 2/8] drm/ingenic: Add support for JZ4780 and HDMI output H. Nikolaus Schaller 2021-11-30 21:26 ` H. Nikolaus Schaller 2021-11-30 21:26 ` [PATCH v10 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema H. Nikolaus Schaller 2021-11-30 21:26 ` [PATCH v10 3/8] dt-bindings: display: Add ingenic, jz4780-dw-hdmi " H. Nikolaus Schaller 2021-11-30 21:26 ` [PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780 H. Nikolaus Schaller 2021-11-30 21:26 ` H. Nikolaus Schaller 2021-12-01 13:02 ` Paul Cercueil 2021-12-01 13:02 ` Paul Cercueil 2021-12-01 13:18 ` H. Nikolaus Schaller 2021-12-01 13:18 ` H. Nikolaus Schaller 2021-12-01 13:39 ` Mark Brown 2021-12-01 13:39 ` Mark Brown 2021-12-01 13:51 ` H. Nikolaus Schaller 2021-12-01 13:51 ` H. Nikolaus Schaller 2021-12-01 14:03 ` Paul Cercueil 2021-12-01 14:03 ` Paul Cercueil 2021-12-01 14:33 ` H. Nikolaus Schaller 2021-12-01 14:33 ` H. Nikolaus Schaller 2021-12-01 15:10 ` Mark Brown 2021-12-01 15:10 ` Mark Brown 2021-12-01 16:53 ` H. Nikolaus Schaller 2021-12-01 16:53 ` H. Nikolaus Schaller 2021-12-01 17:02 ` Mark Brown 2021-12-01 17:02 ` Mark Brown 2021-11-30 21:26 ` [PATCH v10 5/8] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers H. Nikolaus Schaller 2021-11-30 21:26 ` H. Nikolaus Schaller 2021-11-30 21:26 ` [PATCH v10 6/8] MIPS: DTS: CI20: Add DT nodes for HDMI setup H. Nikolaus Schaller 2021-11-30 21:26 ` H. Nikolaus Schaller 2021-11-30 21:26 ` [PATCH v10 7/8] MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780 H. Nikolaus Schaller 2021-11-30 21:26 ` H. Nikolaus Schaller 2021-11-30 21:26 ` [PATCH v10 8/8] [RFC] MIPS: DTS: Ingenic: adjust register size to available registers H. Nikolaus Schaller 2021-11-30 21:26 ` H. Nikolaus Schaller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ee65e70e91268b3963f8a6581c8aa6c3b643c53e.1638307601.git.hns@goldelico.com \ --to=hns@goldelico.com \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=airlied@linux.ie \ --cc=broonie@kernel.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=ebiederm@xmission.com \ --cc=geert+renesas@glider.be \ --cc=harry.wentland@amd.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=keescook@chromium.org \ --cc=letux-kernel@openphoenux.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maxime@cerno.tech \ --cc=miquel.raynal@bootlin.com \ --cc=narmstrong@baylibre.com \ --cc=paul@boddie.org.uk \ --cc=paul@crapouillou.net \ --cc=robert.foss@linaro.org \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=tsbogend@alpha.franken.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.