From: Sean Christopherson <seanjc@google.com>
To: Anup Patel <anup.patel@wdc.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Atish Patra <atishp@atishpatra.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alistair Francis <Alistair.Francis@wdc.com>,
Anup Patel <anup@brainfault.org>,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 3/4] KVM: selftests: Add EXTRA_CFLAGS in top-level Makefile
Date: Mon, 20 Dec 2021 19:45:01 +0000 [thread overview]
Message-ID: <YcDdPUn9bAVnxb/2@google.com> (raw)
In-Reply-To: <20211129075451.418122-4-anup.patel@wdc.com>
On Mon, Nov 29, 2021, Anup Patel wrote:
> We add EXTRA_CFLAGS to the common CFLAGS of top-level Makefile
Nit, wrap closer to 75 chars.
> which will allow users to pass additional compile-time flags such
> as "-static".
In case there's any hesitation in applying this (Paolo asked if this was just for
debugging in v1), being able to pass "-static" is helpful for our environment as
our test systems have a funky and minimal configuration (no gcc, and the interpreter
is in a weird location). Running selftests either requires building them with
-static or creating a symbolic link for /lib64/ld-linux-x86-64.so.2. It's generally
easier to just tell people to compile with -static.
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
> ---
Reviewed-and-tested-by: Sean Christopherson <seanjc@google.com>
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Anup Patel <anup.patel@wdc.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Atish Patra <atishp@atishpatra.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alistair Francis <Alistair.Francis@wdc.com>,
Anup Patel <anup@brainfault.org>,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 3/4] KVM: selftests: Add EXTRA_CFLAGS in top-level Makefile
Date: Mon, 20 Dec 2021 19:45:01 +0000 [thread overview]
Message-ID: <YcDdPUn9bAVnxb/2@google.com> (raw)
In-Reply-To: <20211129075451.418122-4-anup.patel@wdc.com>
On Mon, Nov 29, 2021, Anup Patel wrote:
> We add EXTRA_CFLAGS to the common CFLAGS of top-level Makefile
Nit, wrap closer to 75 chars.
> which will allow users to pass additional compile-time flags such
> as "-static".
In case there's any hesitation in applying this (Paolo asked if this was just for
debugging in v1), being able to pass "-static" is helpful for our environment as
our test systems have a funky and minimal configuration (no gcc, and the interpreter
is in a weird location). Running selftests either requires building them with
-static or creating a symbolic link for /lib64/ld-linux-x86-64.so.2. It's generally
easier to just tell people to compile with -static.
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
> ---
Reviewed-and-tested-by: Sean Christopherson <seanjc@google.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-12-20 19:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 7:54 [PATCH v2 0/4] KVM RISC-V 64-bit selftests support Anup Patel
2021-11-29 7:54 ` Anup Patel
2021-11-29 7:54 ` [PATCH v2 1/4] RISC-V: KVM: Forward SBI experimental and vendor extensions Anup Patel
2021-11-29 7:54 ` Anup Patel
2021-12-17 5:42 ` Atish Patra
2021-12-17 5:42 ` Atish Patra
2021-11-29 7:54 ` [PATCH v2 2/4] RISC-V: KVM: Add VM capability to allow userspace get GPA bits Anup Patel
2021-11-29 7:54 ` Anup Patel
2021-12-17 5:47 ` Atish Patra
2021-12-17 5:47 ` Atish Patra
2021-12-17 6:08 ` Anup Patel
2021-12-17 6:08 ` Anup Patel
2021-12-17 8:28 ` Paolo Bonzini
2021-12-17 8:28 ` Paolo Bonzini
2021-11-29 7:54 ` [PATCH v2 3/4] KVM: selftests: Add EXTRA_CFLAGS in top-level Makefile Anup Patel
2021-11-29 7:54 ` Anup Patel
2021-12-17 5:50 ` Atish Patra
2021-12-17 5:50 ` Atish Patra
2021-12-20 19:45 ` Sean Christopherson [this message]
2021-12-20 19:45 ` Sean Christopherson
2021-12-21 9:18 ` Anup Patel
2021-12-21 9:18 ` Anup Patel
2021-11-29 7:54 ` [PATCH v2 4/4] KVM: selftests: Add initial support for RISC-V 64-bit Anup Patel
2021-11-29 7:54 ` Anup Patel
2021-12-22 8:48 ` Atish Patra
2021-12-22 8:48 ` Atish Patra
2021-12-11 3:41 ` [PATCH v2 0/4] KVM RISC-V 64-bit selftests support Anup Patel
2021-12-11 3:41 ` Anup Patel
2021-12-22 8:51 ` Atish Patra
2021-12-22 8:51 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcDdPUn9bAVnxb/2@google.com \
--to=seanjc@google.com \
--cc=Alistair.Francis@wdc.com \
--cc=anup.patel@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.