From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Nikita Yushchenko <nikita.yoush@cogentembedded.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Jacopo Mondi <jacopo+renesas@jmondi.org>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge_connector: enable HPD by default if supported Date: Thu, 30 Dec 2021 01:44:29 +0200 [thread overview] Message-ID: <Yczy3UYpU2UMFQ6N@pendragon.ideasonboard.com> (raw) In-Reply-To: <20211225063151.2110878-1-nikita.yoush@cogentembedded.com> Hi Nikita, Thank you for the patch. On Sat, Dec 25, 2021 at 09:31:51AM +0300, Nikita Yushchenko wrote: > Hotplug events reported by bridge drivers over drm_bridge_hpd_notify() > get ignored unless somebody calls drm_bridge_hpd_enable(). When the > connector for the bridge is bridge_connector, such a call is done from > drm_bridge_connector_enable_hpd(). > > However drm_bridge_connector_enable_hpd() is never called on init paths, > documentation suggests that it is intended for suspend/resume paths. Hmmmm... I'm in two minds about this. The problem description is correct, but I wonder if HPD should be enabled unconditionally here, or if this should be left to display drivers to control. drivers/gpu/drm/imx/dcss/dcss-kms.c enables HPD manually at init time, other drivers don't. It feels like this should be under control of the display controller driver, but I can't think of a use case for not enabling HPD at init time. Any second opinion from anyone ? > In result, once encoders are switched to bridge_connector, > bridge-detected HPD stops working. > > This patch adds a call to that API on init path. > > This fixes HDMI HPD with rcar-du + adv7513 case when adv7513 reports HPD > events via interrupts. > > Fixes: c24110a8fd09 ("drm: rcar-du: Use drm_bridge_connector_init() helper") > Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > --- > drivers/gpu/drm/drm_bridge_connector.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c > index 791379816837..4f20137ef21d 100644 > --- a/drivers/gpu/drm/drm_bridge_connector.c > +++ b/drivers/gpu/drm/drm_bridge_connector.c > @@ -369,8 +369,10 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm, > connector_type, ddc); > drm_connector_helper_add(connector, &drm_bridge_connector_helper_funcs); > > - if (bridge_connector->bridge_hpd) > + if (bridge_connector->bridge_hpd) { > connector->polled = DRM_CONNECTOR_POLL_HPD; > + drm_bridge_connector_enable_hpd(connector); > + } > else if (bridge_connector->bridge_detect) > connector->polled = DRM_CONNECTOR_POLL_CONNECT > | DRM_CONNECTOR_POLL_DISCONNECT; -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Nikita Yushchenko <nikita.yoush@cogentembedded.com> Cc: Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Jacopo Mondi <jacopo+renesas@jmondi.org>, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/bridge_connector: enable HPD by default if supported Date: Thu, 30 Dec 2021 01:44:29 +0200 [thread overview] Message-ID: <Yczy3UYpU2UMFQ6N@pendragon.ideasonboard.com> (raw) In-Reply-To: <20211225063151.2110878-1-nikita.yoush@cogentembedded.com> Hi Nikita, Thank you for the patch. On Sat, Dec 25, 2021 at 09:31:51AM +0300, Nikita Yushchenko wrote: > Hotplug events reported by bridge drivers over drm_bridge_hpd_notify() > get ignored unless somebody calls drm_bridge_hpd_enable(). When the > connector for the bridge is bridge_connector, such a call is done from > drm_bridge_connector_enable_hpd(). > > However drm_bridge_connector_enable_hpd() is never called on init paths, > documentation suggests that it is intended for suspend/resume paths. Hmmmm... I'm in two minds about this. The problem description is correct, but I wonder if HPD should be enabled unconditionally here, or if this should be left to display drivers to control. drivers/gpu/drm/imx/dcss/dcss-kms.c enables HPD manually at init time, other drivers don't. It feels like this should be under control of the display controller driver, but I can't think of a use case for not enabling HPD at init time. Any second opinion from anyone ? > In result, once encoders are switched to bridge_connector, > bridge-detected HPD stops working. > > This patch adds a call to that API on init path. > > This fixes HDMI HPD with rcar-du + adv7513 case when adv7513 reports HPD > events via interrupts. > > Fixes: c24110a8fd09 ("drm: rcar-du: Use drm_bridge_connector_init() helper") > Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > --- > drivers/gpu/drm/drm_bridge_connector.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c > index 791379816837..4f20137ef21d 100644 > --- a/drivers/gpu/drm/drm_bridge_connector.c > +++ b/drivers/gpu/drm/drm_bridge_connector.c > @@ -369,8 +369,10 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm, > connector_type, ddc); > drm_connector_helper_add(connector, &drm_bridge_connector_helper_funcs); > > - if (bridge_connector->bridge_hpd) > + if (bridge_connector->bridge_hpd) { > connector->polled = DRM_CONNECTOR_POLL_HPD; > + drm_bridge_connector_enable_hpd(connector); > + } > else if (bridge_connector->bridge_detect) > connector->polled = DRM_CONNECTOR_POLL_CONNECT > | DRM_CONNECTOR_POLL_DISCONNECT; -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2021-12-29 23:44 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-25 6:31 [PATCH] drm/bridge_connector: enable HPD by default if supported Nikita Yushchenko 2021-12-25 6:31 ` Nikita Yushchenko 2021-12-29 23:44 ` Laurent Pinchart [this message] 2021-12-29 23:44 ` Laurent Pinchart 2022-01-31 16:38 ` Nikita Yushchenko 2022-01-31 16:38 ` Nikita Yushchenko 2022-02-23 16:17 ` Kieran Bingham 2022-02-23 16:17 ` Kieran Bingham 2022-02-23 16:25 ` Laurent Pinchart 2022-02-23 16:25 ` Laurent Pinchart 2022-02-23 17:02 ` Kieran Bingham 2022-02-23 17:02 ` Kieran Bingham 2022-08-31 13:02 ` Tomi Valkeinen 2022-08-31 13:02 ` Tomi Valkeinen 2022-09-05 5:26 ` Tomi Valkeinen 2022-09-05 5:26 ` Tomi Valkeinen 2023-04-11 18:52 ` Yongqin Liu 2023-04-11 18:52 ` Yongqin Liu 2022-03-04 19:38 ` Paul Cercueil 2022-03-04 19:38 ` Paul Cercueil 2022-08-12 5:35 ` Yongqin Liu 2022-08-12 5:35 ` Yongqin Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yczy3UYpU2UMFQ6N@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=jacopo+renesas@jmondi.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=nikita.yoush@cogentembedded.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.