All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge_connector: enable HPD by default if supported
Date: Mon, 31 Jan 2022 19:38:13 +0300	[thread overview]
Message-ID: <a7d0b013-6114-07b3-0a7b-0d17db8a3982@cogentembedded.com> (raw)
In-Reply-To: <Yczy3UYpU2UMFQ6N@pendragon.ideasonboard.com>

>> Hotplug events reported by bridge drivers over drm_bridge_hpd_notify()
>> get ignored unless somebody calls drm_bridge_hpd_enable(). When the
>> connector for the bridge is bridge_connector, such a call is done from
>> drm_bridge_connector_enable_hpd().
>>
>> However drm_bridge_connector_enable_hpd() is never called on init paths,
>> documentation suggests that it is intended for suspend/resume paths.
> 
> Hmmmm... I'm in two minds about this. The problem description is
> correct, but I wonder if HPD should be enabled unconditionally here, or
> if this should be left to display drivers to control.
> drivers/gpu/drm/imx/dcss/dcss-kms.c enables HPD manually at init time,
> other drivers don't.
> 
> It feels like this should be under control of the display controller
> driver, but I can't think of a use case for not enabling HPD at init
> time. Any second opinion from anyone ?

Hi.

Can we somehow move forward here?..

WARNING: multiple messages have this Message-ID (diff)
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/bridge_connector: enable HPD by default if supported
Date: Mon, 31 Jan 2022 19:38:13 +0300	[thread overview]
Message-ID: <a7d0b013-6114-07b3-0a7b-0d17db8a3982@cogentembedded.com> (raw)
In-Reply-To: <Yczy3UYpU2UMFQ6N@pendragon.ideasonboard.com>

>> Hotplug events reported by bridge drivers over drm_bridge_hpd_notify()
>> get ignored unless somebody calls drm_bridge_hpd_enable(). When the
>> connector for the bridge is bridge_connector, such a call is done from
>> drm_bridge_connector_enable_hpd().
>>
>> However drm_bridge_connector_enable_hpd() is never called on init paths,
>> documentation suggests that it is intended for suspend/resume paths.
> 
> Hmmmm... I'm in two minds about this. The problem description is
> correct, but I wonder if HPD should be enabled unconditionally here, or
> if this should be left to display drivers to control.
> drivers/gpu/drm/imx/dcss/dcss-kms.c enables HPD manually at init time,
> other drivers don't.
> 
> It feels like this should be under control of the display controller
> driver, but I can't think of a use case for not enabling HPD at init
> time. Any second opinion from anyone ?

Hi.

Can we somehow move forward here?..

  reply	other threads:[~2022-01-31 16:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-25  6:31 [PATCH] drm/bridge_connector: enable HPD by default if supported Nikita Yushchenko
2021-12-25  6:31 ` Nikita Yushchenko
2021-12-29 23:44 ` Laurent Pinchart
2021-12-29 23:44   ` Laurent Pinchart
2022-01-31 16:38   ` Nikita Yushchenko [this message]
2022-01-31 16:38     ` Nikita Yushchenko
2022-02-23 16:17   ` Kieran Bingham
2022-02-23 16:17     ` Kieran Bingham
2022-02-23 16:25     ` Laurent Pinchart
2022-02-23 16:25       ` Laurent Pinchart
2022-02-23 17:02       ` Kieran Bingham
2022-02-23 17:02         ` Kieran Bingham
2022-08-31 13:02         ` Tomi Valkeinen
2022-08-31 13:02           ` Tomi Valkeinen
2022-09-05  5:26           ` Tomi Valkeinen
2022-09-05  5:26             ` Tomi Valkeinen
2023-04-11 18:52             ` Yongqin Liu
2023-04-11 18:52               ` Yongqin Liu
2022-03-04 19:38 ` Paul Cercueil
2022-03-04 19:38   ` Paul Cercueil
2022-08-12  5:35   ` Yongqin Liu
2022-08-12  5:35     ` Yongqin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7d0b013-6114-07b3-0a7b-0d17db8a3982@cogentembedded.com \
    --to=nikita.yoush@cogentembedded.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.