All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Robert Hancock <robert.hancock@calian.com>
Cc: netdev@vger.kernel.org, radhey.shyam.pandey@xilinx.com,
	davem@davemloft.net, kuba@kernel.org,
	linux-arm-kernel@lists.infradead.org, michal.simek@xilinx.com,
	ariane.keller@tik.ee.ethz.ch, daniel@iogearbox.net
Subject: Re: [PATCH net v2 3/9] net: axienet: reset core on initialization prior to MDIO access
Date: Wed, 12 Jan 2022 20:21:35 +0100	[thread overview]
Message-ID: <Yd8qP+guqHYQJVaO@lunn.ch> (raw)
In-Reply-To: <20220112173700.873002-4-robert.hancock@calian.com>

On Wed, Jan 12, 2022 at 11:36:54AM -0600, Robert Hancock wrote:
> In some cases where the Xilinx Ethernet core was used in 1000Base-X or
> SGMII modes, which use the internal PCS/PMA PHY, and the MGT
> transceiver clock source for the PCS was not running at the time the
> FPGA logic was loaded, the core would come up in a state where the
> PCS could not be found on the MDIO bus. To fix this, the Ethernet core
> (including the PCS) should be reset after enabling the clocks, prior to
> attempting to access the PCS using of_mdio_find_device.
> 
> Fixes: 1a02556086fc (net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode)
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Robert Hancock <robert.hancock@calian.com>
Cc: netdev@vger.kernel.org, radhey.shyam.pandey@xilinx.com,
	davem@davemloft.net, kuba@kernel.org,
	linux-arm-kernel@lists.infradead.org, michal.simek@xilinx.com,
	ariane.keller@tik.ee.ethz.ch, daniel@iogearbox.net
Subject: Re: [PATCH net v2 3/9] net: axienet: reset core on initialization prior to MDIO access
Date: Wed, 12 Jan 2022 20:21:35 +0100	[thread overview]
Message-ID: <Yd8qP+guqHYQJVaO@lunn.ch> (raw)
In-Reply-To: <20220112173700.873002-4-robert.hancock@calian.com>

On Wed, Jan 12, 2022 at 11:36:54AM -0600, Robert Hancock wrote:
> In some cases where the Xilinx Ethernet core was used in 1000Base-X or
> SGMII modes, which use the internal PCS/PMA PHY, and the MGT
> transceiver clock source for the PCS was not running at the time the
> FPGA logic was loaded, the core would come up in a state where the
> PCS could not be found on the MDIO bus. To fix this, the Ethernet core
> (including the PCS) should be reset after enabling the clocks, prior to
> attempting to access the PCS using of_mdio_find_device.
> 
> Fixes: 1a02556086fc (net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode)
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-12 19:22 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 17:36 [PATCH net v2 0/9] Xilinx axienet fixes Robert Hancock
2022-01-12 17:36 ` Robert Hancock
2022-01-12 17:36 ` [PATCH net v2 1/9] net: axienet: increase reset timeout Robert Hancock
2022-01-12 17:36   ` Robert Hancock
2022-01-12 19:11   ` Andrew Lunn
2022-01-12 19:11     ` Andrew Lunn
2022-01-12 17:36 ` [PATCH net v2 2/9] net: axienet: Wait for PhyRstCmplt after core reset Robert Hancock
2022-01-12 17:36   ` Robert Hancock
2022-01-12 19:15   ` Andrew Lunn
2022-01-12 19:15     ` Andrew Lunn
2022-01-12 19:25     ` Robert Hancock
2022-01-12 19:25       ` Robert Hancock
2022-01-12 19:44       ` Andrew Lunn
2022-01-12 19:44         ` Andrew Lunn
2022-01-13 11:53   ` Radhey Shyam Pandey
2022-01-13 11:53     ` Radhey Shyam Pandey
2022-01-13 16:27     ` Robert Hancock
2022-01-13 16:27       ` Robert Hancock
2022-01-12 17:36 ` [PATCH net v2 3/9] net: axienet: reset core on initialization prior to MDIO access Robert Hancock
2022-01-12 17:36   ` Robert Hancock
2022-01-12 19:21   ` Andrew Lunn [this message]
2022-01-12 19:21     ` Andrew Lunn
2022-01-12 17:36 ` [PATCH net v2 4/9] net: axienet: add missing memory barriers Robert Hancock
2022-01-12 17:36   ` Robert Hancock
2022-01-13 12:09   ` Radhey Shyam Pandey
2022-01-13 12:09     ` Radhey Shyam Pandey
2022-01-13 16:22     ` Robert Hancock
2022-01-13 16:22       ` Robert Hancock
2022-01-12 17:36 ` [PATCH net v2 5/9] net: axienet: limit minimum TX ring size Robert Hancock
2022-01-12 17:36   ` Robert Hancock
2022-01-12 17:36 ` [PATCH net v2 6/9] net: axienet: Fix TX ring slot available check Robert Hancock
2022-01-12 17:36   ` Robert Hancock
2022-01-12 17:36 ` [PATCH net v2 7/9] net: axienet: fix number of TX ring slots for " Robert Hancock
2022-01-12 17:36   ` Robert Hancock
2022-01-12 17:36 ` [PATCH net v2 8/9] net: axienet: fix for TX busy handling Robert Hancock
2022-01-12 17:36   ` Robert Hancock
2022-01-12 17:37 ` [PATCH net v2 9/9] net: axienet: increase default TX ring size to 128 Robert Hancock
2022-01-12 17:37   ` Robert Hancock
2022-01-18 20:45 ` [PATCH net v2 0/9] Xilinx axienet fixes Robert Hancock
2022-01-18 20:45   ` Robert Hancock
2022-01-18 21:00   ` Jakub Kicinski
2022-01-18 21:00     ` Jakub Kicinski
2022-01-18 21:04     ` Robert Hancock
2022-01-18 21:04       ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yd8qP+guqHYQJVaO@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=ariane.keller@tik.ee.ethz.ch \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=radhey.shyam.pandey@xilinx.com \
    --cc=robert.hancock@calian.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.