From: Mark Brown <broonie@kernel.org>
To: Curtis Malainey <cujomalainey@google.com>
Cc: V sujith kumar Reddy <vsujithkumar.reddy@amd.com>,
ALSA development <alsa-devel@alsa-project.org>,
Vijendar.Mukunda@amd.com, "Hiregoudar,
Basavaraj" <Basavaraj.Hiregoudar@amd.com>,
"Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>,
"Pandey, Ajit Kumar" <ajitkumar.pandey@amd.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd: acp: Set gpio_spkr_en to None for max speaker amplifer in machine driver
Date: Wed, 2 Feb 2022 13:25:02 +0000 [thread overview]
Message-ID: <YfqGLtmGBsD2WqtH@sirena.org.uk> (raw)
In-Reply-To: <CAOReqxiGW+8BR5VRVHDJuBXxkpB_oQ_4TTNBqm1tuK6shUKLpg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
On Tue, Feb 01, 2022 at 01:43:38PM -0800, Curtis Malainey wrote:
> Yes that is correct, this is the quick fix that will alleviate the
> gpio contention issue. But I think there is a better solution here.
> According to the sheet I have, the pin for the alc1019 is the same as
> the max98357a and its a shutdown pin for the amp.
OK, that sounds like it should be added to the driver then.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Curtis Malainey <cujomalainey@google.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
"Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>,
"Pandey, Ajit Kumar" <ajitkumar.pandey@amd.com>,
open list <linux-kernel@vger.kernel.org>,
"Hiregoudar, Basavaraj" <Basavaraj.Hiregoudar@amd.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Vijendar.Mukunda@amd.com,
V sujith kumar Reddy <vsujithkumar.reddy@amd.com>
Subject: Re: [PATCH] ASoC: amd: acp: Set gpio_spkr_en to None for max speaker amplifer in machine driver
Date: Wed, 2 Feb 2022 13:25:02 +0000 [thread overview]
Message-ID: <YfqGLtmGBsD2WqtH@sirena.org.uk> (raw)
In-Reply-To: <CAOReqxiGW+8BR5VRVHDJuBXxkpB_oQ_4TTNBqm1tuK6shUKLpg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
On Tue, Feb 01, 2022 at 01:43:38PM -0800, Curtis Malainey wrote:
> Yes that is correct, this is the quick fix that will alleviate the
> gpio contention issue. But I think there is a better solution here.
> According to the sheet I have, the pin for the alc1019 is the same as
> the max98357a and its a shutdown pin for the amp.
OK, that sounds like it should be added to the driver then.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-02 13:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 20:32 [PATCH] ASoC: amd: acp: Set gpio_spkr_en to None for max speaker amplifer in machine driver V sujith kumar Reddy
2022-01-31 20:32 ` V sujith kumar Reddy
2022-02-01 18:56 ` Mark Brown
2022-02-01 18:56 ` Mark Brown
2022-02-01 21:43 ` Curtis Malainey
2022-02-01 21:43 ` Curtis Malainey
2022-02-02 13:25 ` Mark Brown [this message]
2022-02-02 13:25 ` Mark Brown
2022-02-03 12:52 ` Mark Brown
2022-02-03 12:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfqGLtmGBsD2WqtH@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=ajitkumar.pandey@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=cujomalainey@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vsujithkumar.reddy@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.