All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Gabriel Krisman Bertazi <krisman@collabora.com>,
	Jan Kara <jack@suse.com>, Matthew Bobrowski <repnop@google.com>,
	Ext4 <linux-ext4@vger.kernel.org>,
	kernel@collabora.com, Khazhismel Kumykov <khazhy@google.com>,
	LTP List <ltp@lists.linux.it>
Subject: Re: [PATCH v4 0/9] Test the new fanotify FAN_FS_ERROR event
Date: Wed, 2 Feb 2022 15:22:32 +0100	[thread overview]
Message-ID: <YfqTqAjEPalXzOK7@pevik> (raw)
In-Reply-To: <CAOQ4uxia2NNMPUCQzjo6Gsnz8xr_9YKTeTqzOu-hgdsjfHHx0w@mail.gmail.com>

Hi Amir,

> On Mon, Jan 10, 2022 at 5:16 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi all,

> > v5.16 released => patchset merged.
> > Thanks!


> Guys,

> Looks like we have a regression.
> With kernel v5.17-rc1, test fanotify22 blocks on the first test case,
> because the expected ECORRUPTED event on remount,abort is never received.
> The multiple error test cases also fail for the same reason.

> Gabriel,

> Are you aware of any ext4 change that could explain this regression?

> In any case, Petr, I suggest adding a short timeout to the test
> instead of the default 5min.
> Test takes less than 1 second on my VM on v5.16, so...
We usually don't lower the default timeout, but here it's a good idea since here
it blocks. It's similar speed on my machine, but I'd be conservative and put
timeout 10 sec. Sending patch.

Kind regards,
Petr


> Thanks,
> Amir.

WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: kernel@collabora.com, Khazhismel Kumykov <khazhy@google.com>,
	Matthew Bobrowski <repnop@google.com>, Jan Kara <jack@suse.com>,
	Ext4 <linux-ext4@vger.kernel.org>,
	Gabriel Krisman Bertazi <krisman@collabora.com>,
	LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v4 0/9] Test the new fanotify FAN_FS_ERROR event
Date: Wed, 2 Feb 2022 15:22:32 +0100	[thread overview]
Message-ID: <YfqTqAjEPalXzOK7@pevik> (raw)
In-Reply-To: <CAOQ4uxia2NNMPUCQzjo6Gsnz8xr_9YKTeTqzOu-hgdsjfHHx0w@mail.gmail.com>

Hi Amir,

> On Mon, Jan 10, 2022 at 5:16 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi all,

> > v5.16 released => patchset merged.
> > Thanks!


> Guys,

> Looks like we have a regression.
> With kernel v5.17-rc1, test fanotify22 blocks on the first test case,
> because the expected ECORRUPTED event on remount,abort is never received.
> The multiple error test cases also fail for the same reason.

> Gabriel,

> Are you aware of any ext4 change that could explain this regression?

> In any case, Petr, I suggest adding a short timeout to the test
> instead of the default 5min.
> Test takes less than 1 second on my VM on v5.16, so...
We usually don't lower the default timeout, but here it's a good idea since here
it blocks. It's similar speed on my machine, but I'd be conservative and put
timeout 10 sec. Sending patch.

Kind regards,
Petr


> Thanks,
> Amir.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-02-02 14:22 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 23:57 [PATCH v4 0/9] Test the new fanotify FAN_FS_ERROR event Gabriel Krisman Bertazi
2021-11-18 23:57 ` [LTP] " Gabriel Krisman Bertazi
2021-11-18 23:57 ` [PATCH v4 1/9] syscalls: fanotify: Add macro to require specific mark types Gabriel Krisman Bertazi
2021-11-18 23:57   ` [LTP] " Gabriel Krisman Bertazi
2021-11-18 23:57 ` [PATCH v4 2/9] syscalls: fanotify: Add macro to require specific events Gabriel Krisman Bertazi
2021-11-18 23:57   ` [LTP] " Gabriel Krisman Bertazi
2021-11-18 23:57 ` [PATCH v4 3/9] syscalls/fanotify22: Introduce FAN_FS_ERROR test Gabriel Krisman Bertazi
2021-11-18 23:57   ` [LTP] " Gabriel Krisman Bertazi
2021-11-18 23:57 ` [PATCH v4 4/9] syscalls/fanotify22: Validate the generic error info Gabriel Krisman Bertazi
2021-11-18 23:57   ` [LTP] " Gabriel Krisman Bertazi
2021-11-19  5:38   ` Amir Goldstein
2021-11-19  5:38     ` [LTP] " Amir Goldstein
2021-11-19 19:29     ` Petr Vorel
2021-11-19 19:29       ` [LTP] " Petr Vorel
2021-11-19 22:39       ` Petr Vorel
2021-11-19 22:39         ` [LTP] " Petr Vorel
2021-11-18 23:57 ` [PATCH v4 5/9] syscalls/fanotify22: Validate incoming FID in FAN_FS_ERROR Gabriel Krisman Bertazi
2021-11-18 23:57   ` [LTP] " Gabriel Krisman Bertazi
2021-11-18 23:57 ` [PATCH v4 6/9] syscalls/fanotify22: Support submission of debugfs commands Gabriel Krisman Bertazi
2021-11-18 23:57   ` [LTP] " Gabriel Krisman Bertazi
2021-11-18 23:57 ` [PATCH v4 7/9] syscalls/fanotify22: Create a corrupted file Gabriel Krisman Bertazi
2021-11-18 23:57   ` [LTP] " Gabriel Krisman Bertazi
2021-11-18 23:57 ` [PATCH v4 8/9] syscalls/fanotify22: Test file event with broken inode Gabriel Krisman Bertazi
2021-11-18 23:57   ` [LTP] " Gabriel Krisman Bertazi
2021-11-18 23:57 ` [PATCH v4 9/9] syscalls/fanotify22: Test capture of multiple errors Gabriel Krisman Bertazi
2021-11-18 23:57   ` [LTP] " Gabriel Krisman Bertazi
2021-11-19  5:48 ` [PATCH v4 0/9] Test the new fanotify FAN_FS_ERROR event Amir Goldstein
2021-11-19  5:48   ` [LTP] " Amir Goldstein
2021-11-19 19:29   ` Gabriel Krisman Bertazi
2021-11-19 19:29     ` [LTP] " Gabriel Krisman Bertazi
2021-11-20 10:43     ` Amir Goldstein
2021-11-20 10:43       ` [LTP] " Amir Goldstein
2021-11-22  7:47     ` Petr Vorel
2021-11-22  7:47       ` [LTP] " Petr Vorel
2021-11-22 17:35       ` Gabriel Krisman Bertazi
2021-11-22 17:35         ` [LTP] " Gabriel Krisman Bertazi
2021-11-22 21:09         ` Petr Vorel
2021-11-22 21:09           ` [LTP] " Petr Vorel
2021-11-24 10:39       ` Petr Vorel
2021-11-24 10:39         ` Petr Vorel
2021-12-20 11:48         ` Amir Goldstein
2021-12-20 11:48           ` Amir Goldstein
2021-12-20 18:07           ` Petr Vorel
2021-12-20 18:07             ` Petr Vorel
2022-01-10 15:16 ` Petr Vorel
2022-01-10 15:16   ` [LTP] " Petr Vorel
2022-02-02 13:49   ` Amir Goldstein
2022-02-02 13:49     ` [LTP] " Amir Goldstein
2022-02-02 14:10     ` Jan Stancek
2022-02-02 14:10       ` Jan Stancek
2022-02-02 16:45       ` Gabriel Krisman Bertazi
2022-02-02 16:45         ` Gabriel Krisman Bertazi
2022-02-02 14:22     ` Petr Vorel [this message]
2022-02-02 14:22       ` Petr Vorel
2022-02-02 16:13       ` Cyril Hrubis
2022-02-02 16:13         ` Cyril Hrubis
2022-02-02 16:57         ` Petr Vorel
2022-02-02 16:57           ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfqTqAjEPalXzOK7@pevik \
    --to=pvorel@suse.cz \
    --cc=amir73il@gmail.com \
    --cc=jack@suse.com \
    --cc=kernel@collabora.com \
    --cc=khazhy@google.com \
    --cc=krisman@collabora.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=repnop@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.