From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
quic_srivasam@quicinc.com
Subject: Re: [PATCH 09/16] ASoC: codecs: wcd934x: fix return value of wcd934x_rx_hph_mode_put
Date: Tue, 22 Feb 2022 17:54:35 +0000 [thread overview]
Message-ID: <YhUjW6B8LmoEWLRx@sirena.org.uk> (raw)
In-Reply-To: <20220222115933.9114-10-srinivas.kandagatla@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Tue, Feb 22, 2022 at 11:59:26AM +0000, Srinivas Kandagatla wrote:
> wcd934x_rx_hph_mode_put currently returns zero eventhough it changes the value.
> Fix this, so that change notifications are sent correctly.
> - return 0;
> + return 1;
This now has the opposite issue where it will unconditionally flag a
change even if none occurred, that's less bad but still an issue. It
should check to see if the value written is different to that already
set and report that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
quic_srivasam@quicinc.com
Subject: Re: [PATCH 09/16] ASoC: codecs: wcd934x: fix return value of wcd934x_rx_hph_mode_put
Date: Tue, 22 Feb 2022 17:54:35 +0000 [thread overview]
Message-ID: <YhUjW6B8LmoEWLRx@sirena.org.uk> (raw)
In-Reply-To: <20220222115933.9114-10-srinivas.kandagatla@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Tue, Feb 22, 2022 at 11:59:26AM +0000, Srinivas Kandagatla wrote:
> wcd934x_rx_hph_mode_put currently returns zero eventhough it changes the value.
> Fix this, so that change notifications are sent correctly.
> - return 0;
> + return 1;
This now has the opposite issue where it will unconditionally flag a
change even if none occurred, that's less bad but still an issue. It
should check to see if the value written is different to that already
set and report that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-22 17:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 11:59 [PATCH 00/16] ASoC: codecs: qcom fix validation failures Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 01/16] ASoC: codecs: rx-macro: fix accessing compander for aux Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 02/16] ASoC: codecs: rx-macro: fix accessing array out of bounds for enum type Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 03/16] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 04/16] ASoC: codecs: va-macro: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 05/16] ASoC: codecs: wsa-macro: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 06/16] ASoC: codecs: wc938x: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 07/16] ASoC: codecs: wcd938x: fix kcontrol max values Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 08/16] ASoC: codecs: wcd934x: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 09/16] ASoC: codecs: wcd934x: fix return value of wcd934x_rx_hph_mode_put Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 17:54 ` Mark Brown [this message]
2022-02-22 17:54 ` Mark Brown
2022-02-22 18:22 ` Srinivas Kandagatla
2022-02-22 18:22 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 10/16] ASoC: codecs: rx-macro: fix tlv min max range Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 18:04 ` Mark Brown
2022-02-22 18:04 ` Mark Brown
2022-02-22 18:21 ` Srinivas Kandagatla
2022-02-22 18:21 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 11/16] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 12/16] ASoC: codecs: va-macro: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 13/16] ASoC: codecs: wsa-macro: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 14/16] ASoC: codecs: wcd938x: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 15/16] ASoC: codecs: wcd9335: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 16/16] ASoC: codecs: msm8916-wcd-digital: " Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-23 4:08 ` (subset) [PATCH 00/16] ASoC: codecs: qcom fix validation failures Mark Brown
2022-02-23 4:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhUjW6B8LmoEWLRx@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=quic_srivasam@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.