All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	pierre-louis.bossart@linux.intel.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	quic_srivasam@quicinc.com
Subject: Re: [PATCH 10/16] ASoC: codecs: rx-macro: fix tlv min max range
Date: Tue, 22 Feb 2022 18:04:53 +0000	[thread overview]
Message-ID: <YhUlxX461J9bskg3@sirena.org.uk> (raw)
In-Reply-To: <20220222115933.9114-11-srinivas.kandagatla@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

On Tue, Feb 22, 2022 at 11:59:27AM +0000, Srinivas Kandagatla wrote:
> on Qualcomm codecs gain tlv control specifies min max range as both
> negative to positive numbers like
> 
> SOC_SINGLE_S8_TLV("... Volume", ..,  -84, 40, gain)
> 
> However with recent boundary checks added in commit 817f7c9335ec0
> ("ASoC: ops: Reject out of bounds values in snd_soc_put_volsw())
> setting a value above 40 gain will fail.
> 
> So fix this min max range correctly to
> SOC_SINGLE_S8_TLV("... Volume", ..,  0, 124, gain)
> so that users can now set gain correctly

Are you sure this isn't a bug in the core?  -84..40 should be a valid
range for a signed control.  See Marek's fix in 9bdd10d57a ("ASoC: ops:
Shift tested values in snd_soc_put_volsw() by +min") though that only
kicks in for systems with a platform_max.  I can't immediately spot any
other issues for S8 but I could be missing something.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org,
	pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
	quic_srivasam@quicinc.com
Subject: Re: [PATCH 10/16] ASoC: codecs: rx-macro: fix tlv min max range
Date: Tue, 22 Feb 2022 18:04:53 +0000	[thread overview]
Message-ID: <YhUlxX461J9bskg3@sirena.org.uk> (raw)
In-Reply-To: <20220222115933.9114-11-srinivas.kandagatla@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

On Tue, Feb 22, 2022 at 11:59:27AM +0000, Srinivas Kandagatla wrote:
> on Qualcomm codecs gain tlv control specifies min max range as both
> negative to positive numbers like
> 
> SOC_SINGLE_S8_TLV("... Volume", ..,  -84, 40, gain)
> 
> However with recent boundary checks added in commit 817f7c9335ec0
> ("ASoC: ops: Reject out of bounds values in snd_soc_put_volsw())
> setting a value above 40 gain will fail.
> 
> So fix this min max range correctly to
> SOC_SINGLE_S8_TLV("... Volume", ..,  0, 124, gain)
> so that users can now set gain correctly

Are you sure this isn't a bug in the core?  -84..40 should be a valid
range for a signed control.  See Marek's fix in 9bdd10d57a ("ASoC: ops:
Shift tested values in snd_soc_put_volsw() by +min") though that only
kicks in for systems with a platform_max.  I can't immediately spot any
other issues for S8 but I could be missing something.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-02-22 18:05 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 11:59 [PATCH 00/16] ASoC: codecs: qcom fix validation failures Srinivas Kandagatla
2022-02-22 11:59 ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 01/16] ASoC: codecs: rx-macro: fix accessing compander for aux Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 02/16] ASoC: codecs: rx-macro: fix accessing array out of bounds for enum type Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 03/16] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 04/16] ASoC: codecs: va-macro: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 05/16] ASoC: codecs: wsa-macro: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 06/16] ASoC: codecs: wc938x: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 07/16] ASoC: codecs: wcd938x: fix kcontrol max values Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 08/16] ASoC: codecs: wcd934x: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 09/16] ASoC: codecs: wcd934x: fix return value of wcd934x_rx_hph_mode_put Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 17:54   ` Mark Brown
2022-02-22 17:54     ` Mark Brown
2022-02-22 18:22     ` Srinivas Kandagatla
2022-02-22 18:22       ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 10/16] ASoC: codecs: rx-macro: fix tlv min max range Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 18:04   ` Mark Brown [this message]
2022-02-22 18:04     ` Mark Brown
2022-02-22 18:21     ` Srinivas Kandagatla
2022-02-22 18:21       ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 11/16] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 12/16] ASoC: codecs: va-macro: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 13/16] ASoC: codecs: wsa-macro: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 14/16] ASoC: codecs: wcd938x: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 15/16] ASoC: codecs: wcd9335: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-22 11:59 ` [PATCH 16/16] ASoC: codecs: msm8916-wcd-digital: " Srinivas Kandagatla
2022-02-22 11:59   ` Srinivas Kandagatla
2022-02-23  4:08 ` (subset) [PATCH 00/16] ASoC: codecs: qcom fix validation failures Mark Brown
2022-02-23  4:08   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhUlxX461J9bskg3@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=quic_srivasam@quicinc.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.