From: Matthew Wilcox <willy@infradead.org>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-mm@kvack.org, "Dave Hansen" <dave.hansen@linux.intel.com>,
"Nathaniel McCallum" <nathaniel@profian.com>,
"Reinette Chatre" <reinette.chatre@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Matthew Auld" <matthew.auld@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Jason Ekstrand" <jason@jlekstrand.net>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>,
"Shakeel Butt" <shakeelb@google.com>,
"Vasily Averin" <vvs@virtuozzo.com>,
zhangyiru <zhangyiru3@huawei.com>,
"Alexander Mikhalitsyn" <alexander.mikhalitsyn@virtuozzo.com>,
"Alexey Gladkov" <legion@kernel.org>,
linux-mips@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, codalist@coda.cs.cmu.edu,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] mm: Add f_ops->populate()
Date: Sun, 6 Mar 2022 22:43:31 +0000 [thread overview]
Message-ID: <YiU5E6qqYAI+WPw9@casper.infradead.org> (raw)
In-Reply-To: <YiTpQTM+V6rlDy6G@iki.fi>
On Sun, Mar 06, 2022 at 07:02:57PM +0200, Jarkko Sakkinen wrote:
> So can I conclude from this that in general having populate available for
> device memory is something horrid, or just the implementation path?
You haven't even attempted to explain what the problem is you're trying
to solve. You've shown up with some terrible code and said "Hey, is
this a good idea". No, no, it's not.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: zhangyiru <zhangyiru3@huawei.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
dri-devel@lists.freedesktop.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
linux-mm@kvack.org, "Jason Ekstrand" <jason@jlekstrand.net>,
"Alexander Mikhalitsyn" <alexander.mikhalitsyn@virtuozzo.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
linux-unionfs@vger.kernel.org, codalist@coda.cs.cmu.edu,
"Matthew Auld" <matthew.auld@intel.com>,
"Vasily Averin" <vvs@virtuozzo.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org,
"Shakeel Butt" <shakeelb@google.com>,
"Reinette Chatre" <reinette.chatre@intel.com>,
linux-sgx@vger.kernel.org,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Nathaniel McCallum" <nathaniel@profian.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Alexey Gladkov" <legion@kernel.org>
Subject: Re: [PATCH RFC 1/3] mm: Add f_ops->populate()
Date: Sun, 6 Mar 2022 22:43:31 +0000 [thread overview]
Message-ID: <YiU5E6qqYAI+WPw9@casper.infradead.org> (raw)
In-Reply-To: <YiTpQTM+V6rlDy6G@iki.fi>
On Sun, Mar 06, 2022 at 07:02:57PM +0200, Jarkko Sakkinen wrote:
> So can I conclude from this that in general having populate available for
> device memory is something horrid, or just the implementation path?
You haven't even attempted to explain what the problem is you're trying
to solve. You've shown up with some terrible code and said "Hey, is
this a good idea". No, no, it's not.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: zhangyiru <zhangyiru3@huawei.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
dri-devel@lists.freedesktop.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
linux-mm@kvack.org,
"Alexander Mikhalitsyn" <alexander.mikhalitsyn@virtuozzo.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
linux-unionfs@vger.kernel.org, codalist@coda.cs.cmu.edu,
"Matthew Auld" <matthew.auld@intel.com>,
"Vasily Averin" <vvs@virtuozzo.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org,
"Shakeel Butt" <shakeelb@google.com>,
"Reinette Chatre" <reinette.chatre@intel.com>,
linux-sgx@vger.kernel.org,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Nathaniel McCallum" <nathaniel@profian.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Alexey Gladkov" <legion@kernel.org>
Subject: Re: [Intel-gfx] [PATCH RFC 1/3] mm: Add f_ops->populate()
Date: Sun, 6 Mar 2022 22:43:31 +0000 [thread overview]
Message-ID: <YiU5E6qqYAI+WPw9@casper.infradead.org> (raw)
In-Reply-To: <YiTpQTM+V6rlDy6G@iki.fi>
On Sun, Mar 06, 2022 at 07:02:57PM +0200, Jarkko Sakkinen wrote:
> So can I conclude from this that in general having populate available for
> device memory is something horrid, or just the implementation path?
You haven't even attempted to explain what the problem is you're trying
to solve. You've shown up with some terrible code and said "Hey, is
this a good idea". No, no, it's not.
next prev parent reply other threads:[~2022-03-06 22:44 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 5:32 [PATCH RFC 0/3] MAP_POPULATE for device memory Jarkko Sakkinen
2022-03-06 5:32 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-06 5:32 ` Jarkko Sakkinen
2022-03-06 5:32 ` [PATCH RFC 1/3] mm: Add f_ops->populate() Jarkko Sakkinen
2022-03-06 5:32 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-06 5:32 ` Jarkko Sakkinen
2022-03-06 10:01 ` Greg Kroah-Hartman
2022-03-06 10:01 ` [Intel-gfx] " Greg Kroah-Hartman
2022-03-06 10:01 ` Greg Kroah-Hartman
2022-03-06 17:02 ` Jarkko Sakkinen
2022-03-06 17:02 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-06 17:02 ` Jarkko Sakkinen
2022-03-06 17:03 ` Jarkko Sakkinen
2022-03-06 17:03 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-06 17:03 ` Jarkko Sakkinen
2022-03-06 22:43 ` Matthew Wilcox [this message]
2022-03-06 22:43 ` [Intel-gfx] " Matthew Wilcox
2022-03-06 22:43 ` Matthew Wilcox
2022-03-07 13:16 ` Jarkko Sakkinen
2022-03-07 13:16 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-07 13:16 ` Jarkko Sakkinen
2022-03-07 13:26 ` Jarkko Sakkinen
2022-03-07 13:26 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-07 13:26 ` Jarkko Sakkinen
2022-03-06 5:32 ` [PATCH RFC 2/3] x86/sgx: Export sgx_encl_page_alloc() Jarkko Sakkinen
2022-03-06 5:32 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-06 5:32 ` Jarkko Sakkinen
2022-03-06 5:32 ` [PATCH RFC 3/3] x86/sgx: Implement EAUG population with MAP_POPULATE Jarkko Sakkinen
2022-03-06 5:32 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-06 5:32 ` Jarkko Sakkinen
2022-03-06 8:30 ` [PATCH RFC 0/3] MAP_POPULATE for device memory David Laight
2022-03-06 8:30 ` [Intel-gfx] " David Laight
2022-03-06 8:30 ` David Laight
2022-03-06 16:52 ` 'Jarkko Sakkinen'
2022-03-06 16:52 ` [Intel-gfx] " 'Jarkko Sakkinen'
2022-03-06 16:52 ` 'Jarkko Sakkinen'
2022-03-06 11:33 ` Matthew Wilcox
2022-03-06 11:33 ` [Intel-gfx] " Matthew Wilcox
2022-03-06 11:33 ` Matthew Wilcox
2022-03-07 7:48 ` Christoph Hellwig
2022-03-07 7:48 ` [Intel-gfx] " Christoph Hellwig
2022-03-07 13:29 ` Jarkko Sakkinen
2022-03-07 13:29 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-07 13:29 ` Jarkko Sakkinen
2022-03-07 15:56 ` Christoph Hellwig
2022-03-07 15:56 ` [Intel-gfx] " Christoph Hellwig
2022-03-07 15:58 ` Jarkko Sakkinen
2022-03-07 15:58 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-07 15:58 ` Jarkko Sakkinen
2022-03-07 22:11 ` David Laight
2022-03-07 22:11 ` [Intel-gfx] " David Laight
2022-03-07 22:11 ` David Laight
2022-03-08 10:10 ` Jarkko Sakkinen
2022-03-08 10:10 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-08 10:10 ` Jarkko Sakkinen
2022-03-07 10:12 ` David Hildenbrand
2022-03-07 10:12 ` [Intel-gfx] " David Hildenbrand
2022-03-07 10:12 ` David Hildenbrand
2022-03-07 14:22 ` Jarkko Sakkinen
2022-03-07 14:22 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-07 14:22 ` Jarkko Sakkinen
2022-03-07 14:33 ` David Hildenbrand
2022-03-07 14:33 ` [Intel-gfx] " David Hildenbrand
2022-03-07 14:33 ` David Hildenbrand
2022-03-07 15:49 ` Jarkko Sakkinen
2022-03-07 15:49 ` [Intel-gfx] " Jarkko Sakkinen
2022-03-07 15:49 ` Jarkko Sakkinen
2022-03-07 14:23 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiU5E6qqYAI+WPw9@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.mikhalitsyn@virtuozzo.com \
--cc=chris@chris-wilson.co.uk \
--cc=codalist@coda.cs.cmu.edu \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jarkko@kernel.org \
--cc=jason@jlekstrand.net \
--cc=legion@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sgx@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.auld@intel.com \
--cc=nathaniel@profian.com \
--cc=reinette.chatre@intel.com \
--cc=shakeelb@google.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tsbogend@alpha.franken.de \
--cc=tvrtko.ursulin@intel.com \
--cc=vvs@virtuozzo.com \
--cc=zhangyiru3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.