From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
James Morse <james.morse@arm.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
patches@amperecomputing.com, scott@os.amperecomputing.com,
Darren Hart <darren@os.amperecomputing.com>
Subject: Re: [PATCH v6 1/2] ACPI: tables: Add AGDI to the list of known table signatures
Date: Thu, 10 Mar 2022 09:14:40 +0000 [thread overview]
Message-ID: <YinBgHvZT8T1EGtm@lpieralisi> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2203091234060.4508@ubuntu200401>
On Wed, Mar 09, 2022 at 12:41:27PM -0800, Ilkka Koskinen wrote:
>
> Hi Rafael,
>
> On Wed, 9 Mar 2022, Rafael J. Wysocki wrote:
> > On Wed, Mar 9, 2022 at 3:08 AM Ilkka Koskinen
> > <ilkka@os.amperecomputing.com> wrote:
> > >
> > > Add AGDI to the list of known ACPI table signatures to allow the
> > > kernel to recognize it when upgrading tables via initrd.
> > >
> > > Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> > > Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > > ---
> > > drivers/acpi/tables.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> > > index 369eb998c3d1..ceee808f7f2a 100644
> > > --- a/drivers/acpi/tables.c
> > > +++ b/drivers/acpi/tables.c
> > > @@ -545,7 +545,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
> > > ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
> > > ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> > > ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> > > - ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT };
> > > + ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
> > >
> > > #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
> >
> > I'm noticing that this depends on the linux-next-only commit
> > 783dedf41b79ac7a3a68b51cf6f88cbfd6dc3292, so it is probably better if
> > I apply it and the other patch in the series can be routed via ARM64.
>
> Sounds good to me, thanks. The other patch needs commit dc4e8c07e9e2 ("ACPI:
> APEI: explicit init of HEST and GHES in apci_init()") in your bleeding edge
> branch to work but it hasn't been acked yet anyway.
It is best for both patches to go via Rafael's tree, given the
dependency above. I acked patch (2).
Thanks,
Lorenzo
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
James Morse <james.morse@arm.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
patches@amperecomputing.com, scott@os.amperecomputing.com,
Darren Hart <darren@os.amperecomputing.com>
Subject: Re: [PATCH v6 1/2] ACPI: tables: Add AGDI to the list of known table signatures
Date: Thu, 10 Mar 2022 09:14:40 +0000 [thread overview]
Message-ID: <YinBgHvZT8T1EGtm@lpieralisi> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2203091234060.4508@ubuntu200401>
On Wed, Mar 09, 2022 at 12:41:27PM -0800, Ilkka Koskinen wrote:
>
> Hi Rafael,
>
> On Wed, 9 Mar 2022, Rafael J. Wysocki wrote:
> > On Wed, Mar 9, 2022 at 3:08 AM Ilkka Koskinen
> > <ilkka@os.amperecomputing.com> wrote:
> > >
> > > Add AGDI to the list of known ACPI table signatures to allow the
> > > kernel to recognize it when upgrading tables via initrd.
> > >
> > > Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> > > Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > > ---
> > > drivers/acpi/tables.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> > > index 369eb998c3d1..ceee808f7f2a 100644
> > > --- a/drivers/acpi/tables.c
> > > +++ b/drivers/acpi/tables.c
> > > @@ -545,7 +545,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
> > > ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
> > > ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> > > ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> > > - ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT };
> > > + ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
> > >
> > > #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
> >
> > I'm noticing that this depends on the linux-next-only commit
> > 783dedf41b79ac7a3a68b51cf6f88cbfd6dc3292, so it is probably better if
> > I apply it and the other patch in the series can be routed via ARM64.
>
> Sounds good to me, thanks. The other patch needs commit dc4e8c07e9e2 ("ACPI:
> APEI: explicit init of HEST and GHES in apci_init()") in your bleeding edge
> branch to work but it hasn't been acked yet anyway.
It is best for both patches to go via Rafael's tree, given the
dependency above. I acked patch (2).
Thanks,
Lorenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-10 9:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 2:07 [PATCH v6 0/2] ACPI: Arm Generic Diagnostic Dump and Reset device Ilkka Koskinen
2022-03-09 2:07 ` Ilkka Koskinen
2022-03-09 2:07 ` [PATCH v6 1/2] ACPI: tables: Add AGDI to the list of known table signatures Ilkka Koskinen
2022-03-09 2:07 ` Ilkka Koskinen
2022-03-09 18:45 ` Rafael J. Wysocki
2022-03-09 18:45 ` Rafael J. Wysocki
2022-03-09 20:41 ` Ilkka Koskinen
2022-03-09 20:41 ` Ilkka Koskinen
2022-03-10 9:14 ` Lorenzo Pieralisi [this message]
2022-03-10 9:14 ` Lorenzo Pieralisi
2022-03-09 2:07 ` [PATCH v6 2/2] ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device Ilkka Koskinen
2022-03-09 2:07 ` Ilkka Koskinen
2022-03-10 9:11 ` Lorenzo Pieralisi
2022-03-10 9:11 ` Lorenzo Pieralisi
2022-03-10 19:19 ` Rafael J. Wysocki
2022-03-10 19:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YinBgHvZT8T1EGtm@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=darren@os.amperecomputing.com \
--cc=guohanjun@huawei.com \
--cc=ilkka@os.amperecomputing.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=patches@amperecomputing.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=scott@os.amperecomputing.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.