All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Rui Miguel Silva <rui.silva@linaro.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/3] arm64: dts: arm: add corstone1000 device tree
Date: Wed, 6 Apr 2022 09:22:38 -0500	[thread overview]
Message-ID: <Yk2iLpsccuxFb5E1@robh.at.kernel.org> (raw)
In-Reply-To: <20220401105322.k7ob3w2t5stuhhay@bogus>

On Fri, Apr 01, 2022 at 11:53:22AM +0100, Sudeep Holla wrote:
> On Thu, Mar 31, 2022 at 12:24:14PM +0100, Rui Miguel Silva wrote:
> > On Thu, Mar 31, 2022 at 11:48:54AM +0100, Sudeep Holla wrote:
> > > On Wed, Mar 30, 2022 at 02:10:53PM +0100, Rui Miguel Silva wrote:
> > > > +
> > > > +		mhu_hse1: mailbox@1b820000 {
> > > > +			compatible = "arm,mhuv2-tx", "arm,primecell";
> > > > +			reg = <0x1b820000 0x1000>;
> > > > +			clocks = <&refclk100mhz>;
> > > > +			clock-names = "apb_pclk";
> > > > +			interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> > > > +			#mbox-cells = <2>;
> > > > +			arm,mhuv2-protocols = <0 0>;
> > > > +			secure-status = "okay";     /* secure-world-only */
> > > 
> > > Please drop the above. Though I see it is in the binding, no one uses
> > > it in the kernel and I prefer not to have this.
> > 
> > the secure partitions in secure world use this mailbox to
> > doorbell the secure enclave so, after talking with Rob he suggested to
> > use this bindings to make this clear. So, I will keep this ones.
> > 
> Hi Rob,
> 
> Since this is first user of this binding(which is there for a while, but
> no users in the kernel code base), are you fine with this ? 

The general rule is 'don't put status in examples'. I think the same 
should apply here as that is outside the scope of the binding.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Rui Miguel Silva <rui.silva@linaro.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/3] arm64: dts: arm: add corstone1000 device tree
Date: Wed, 6 Apr 2022 09:22:38 -0500	[thread overview]
Message-ID: <Yk2iLpsccuxFb5E1@robh.at.kernel.org> (raw)
In-Reply-To: <20220401105322.k7ob3w2t5stuhhay@bogus>

On Fri, Apr 01, 2022 at 11:53:22AM +0100, Sudeep Holla wrote:
> On Thu, Mar 31, 2022 at 12:24:14PM +0100, Rui Miguel Silva wrote:
> > On Thu, Mar 31, 2022 at 11:48:54AM +0100, Sudeep Holla wrote:
> > > On Wed, Mar 30, 2022 at 02:10:53PM +0100, Rui Miguel Silva wrote:
> > > > +
> > > > +		mhu_hse1: mailbox@1b820000 {
> > > > +			compatible = "arm,mhuv2-tx", "arm,primecell";
> > > > +			reg = <0x1b820000 0x1000>;
> > > > +			clocks = <&refclk100mhz>;
> > > > +			clock-names = "apb_pclk";
> > > > +			interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> > > > +			#mbox-cells = <2>;
> > > > +			arm,mhuv2-protocols = <0 0>;
> > > > +			secure-status = "okay";     /* secure-world-only */
> > > 
> > > Please drop the above. Though I see it is in the binding, no one uses
> > > it in the kernel and I prefer not to have this.
> > 
> > the secure partitions in secure world use this mailbox to
> > doorbell the secure enclave so, after talking with Rob he suggested to
> > use this bindings to make this clear. So, I will keep this ones.
> > 
> Hi Rob,
> 
> Since this is first user of this binding(which is there for a while, but
> no users in the kernel code base), are you fine with this ? 

The general rule is 'don't put status in examples'. I think the same 
should apply here as that is outside the scope of the binding.

Rob

  reply	other threads:[~2022-04-06 14:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30 13:10 [PATCH v3 0/3] arm64: dts: add corstone1000 device tree Rui Miguel Silva
2022-03-30 13:10 ` Rui Miguel Silva
2022-03-30 13:10 ` [PATCH v3 1/3] dt-bindings: net: smsc,lan91c111 convert to schema Rui Miguel Silva
2022-03-30 13:10   ` Rui Miguel Silva
2022-03-31 15:44   ` Andre Przywara
2022-03-31 15:44     ` Andre Przywara
2022-03-31 20:11     ` Rui Miguel Silva
2022-03-31 20:11       ` [PATCH v3 1/3] dt-bindings: net: smsc, lan91c111 " Rui Miguel Silva
2022-04-06 14:21       ` Rob Herring
2022-04-06 14:21         ` [PATCH v3 1/3] dt-bindings: net: smsc,lan91c111 " Rob Herring
2022-03-30 13:10 ` [PATCH v3 2/3] dt-bindings: arm: add corstone1000 platform Rui Miguel Silva
2022-03-30 13:10   ` Rui Miguel Silva
2022-03-30 13:10 ` [PATCH v3 3/3] arm64: dts: arm: add corstone1000 device tree Rui Miguel Silva
2022-03-30 13:10   ` Rui Miguel Silva
2022-03-31 10:48   ` Sudeep Holla
2022-03-31 10:48     ` Sudeep Holla
2022-03-31 11:24     ` Rui Miguel Silva
2022-03-31 11:24       ` Rui Miguel Silva
2022-04-01 10:53       ` Sudeep Holla
2022-04-01 10:53         ` Sudeep Holla
2022-04-06 14:22         ` Rob Herring [this message]
2022-04-06 14:22           ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yk2iLpsccuxFb5E1@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=rui.silva@linaro.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.