From: Sam Ravnborg <sam@ravnborg.org>
To: Christophe Branchereau <cbranchereau@gmail.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable
Date: Sun, 27 Mar 2022 21:45:11 +0200 [thread overview]
Message-ID: <YkC+x4m0BQFgu/n0@ravnborg.org> (raw)
In-Reply-To: <CAFsFa85P8V-yePR5LTLjn57GCoqJJYn5pX6WNdp+a+G23XEbSg@mail.gmail.com>
Hi Christophe,
On Mon, Mar 21, 2022 at 03:42:08PM +0100, Christophe Branchereau wrote:
> Sorry I meant "sleep out" not "sleep in" obviously
>
> On Mon, Mar 21, 2022 at 3:39 PM Christophe Branchereau
> <cbranchereau@gmail.com> wrote:
> >
> > Following the introduction of bridge_atomic_enable in the ingenic
> > drm driver, the crtc is enabled between .prepare and .enable, if
> > it exists. Add it so the backlight is only enabled after the crtc is, to
> > avoid graphical issues.
> >
> > As we're moving the "sleep in" command out of the init sequence
> > into .enable for the ABT, we need to switch the regmap cache
> > to REGCACHE_FLAT to be able to use regmap_set_bits, given this
> > panel registers are write-ony and read as 0.
> >
> > On Mon, Mar 21, 2022 at 3:21 PM Paul Cercueil <paul@crapouillou.net> wrote:
> > >
> > > Hi Christophe,
> > >
> > > Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau
> > > <cbranchereau@gmail.com> a écrit :
> > > > Following the introduction of bridge_atomic_enable in the ingenic
> > > > drm driver, the crtc is enabled between .prepare and .enable, if
> > > > it exists.
> > > >
> > > > Add it so the backlight is only enabled after the crtc is, to avoid
> > > > graphical issues.
> > > >
> > > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
> > >
> > > Didn't Sam acked it?
No, that was the new driver, already replied.
For these changes - with the updated changelog:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Christophe Branchereau <cbranchereau@gmail.com>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mips@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable
Date: Sun, 27 Mar 2022 21:45:11 +0200 [thread overview]
Message-ID: <YkC+x4m0BQFgu/n0@ravnborg.org> (raw)
In-Reply-To: <CAFsFa85P8V-yePR5LTLjn57GCoqJJYn5pX6WNdp+a+G23XEbSg@mail.gmail.com>
Hi Christophe,
On Mon, Mar 21, 2022 at 03:42:08PM +0100, Christophe Branchereau wrote:
> Sorry I meant "sleep out" not "sleep in" obviously
>
> On Mon, Mar 21, 2022 at 3:39 PM Christophe Branchereau
> <cbranchereau@gmail.com> wrote:
> >
> > Following the introduction of bridge_atomic_enable in the ingenic
> > drm driver, the crtc is enabled between .prepare and .enable, if
> > it exists. Add it so the backlight is only enabled after the crtc is, to
> > avoid graphical issues.
> >
> > As we're moving the "sleep in" command out of the init sequence
> > into .enable for the ABT, we need to switch the regmap cache
> > to REGCACHE_FLAT to be able to use regmap_set_bits, given this
> > panel registers are write-ony and read as 0.
> >
> > On Mon, Mar 21, 2022 at 3:21 PM Paul Cercueil <paul@crapouillou.net> wrote:
> > >
> > > Hi Christophe,
> > >
> > > Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau
> > > <cbranchereau@gmail.com> a écrit :
> > > > Following the introduction of bridge_atomic_enable in the ingenic
> > > > drm driver, the crtc is enabled between .prepare and .enable, if
> > > > it exists.
> > > >
> > > > Add it so the backlight is only enabled after the crtc is, to avoid
> > > > graphical issues.
> > > >
> > > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
> > >
> > > Didn't Sam acked it?
No, that was the new driver, already replied.
For these changes - with the updated changelog:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2022-03-27 19:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 13:36 [PATCH v5 0/3] Ingenic DRM bridge_atomic_enable proposal Christophe Branchereau
2022-03-21 13:36 ` Christophe Branchereau
2022-03-21 13:36 ` [PATCH v5 1/3] drm/ingenic : add ingenic_drm_bridge_atomic_enable and disable Christophe Branchereau
2022-03-21 13:36 ` Christophe Branchereau
2022-04-05 20:26 ` Artur Rojek
2022-04-05 20:26 ` Artur Rojek
2022-03-21 13:36 ` [PATCH v5 2/3] drm/panel: Add panel driver for NewVision NV3052C based LCDs Christophe Branchereau
2022-03-21 13:36 ` Christophe Branchereau
2022-03-27 19:38 ` Sam Ravnborg
2022-03-27 19:38 ` Sam Ravnborg
2022-03-21 13:36 ` [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable Christophe Branchereau
2022-03-21 13:36 ` Christophe Branchereau
2022-03-21 14:21 ` Paul Cercueil
2022-03-21 14:21 ` Paul Cercueil
2022-03-21 14:39 ` Christophe Branchereau
2022-03-21 14:39 ` Christophe Branchereau
2022-03-21 14:42 ` Christophe Branchereau
2022-03-21 14:42 ` Christophe Branchereau
2022-03-27 19:45 ` Sam Ravnborg [this message]
2022-03-27 19:45 ` Sam Ravnborg
2022-04-05 21:03 ` [PATCH v5 0/3] Ingenic DRM bridge_atomic_enable proposal Paul Cercueil
2022-04-05 21:03 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkC+x4m0BQFgu/n0@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=cbranchereau@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.