* [PATCH v5 0/3] Ingenic DRM bridge_atomic_enable proposal
@ 2022-03-21 13:36 ` Christophe Branchereau
0 siblings, 0 replies; 22+ messages in thread
From: Christophe Branchereau @ 2022-03-21 13:36 UTC (permalink / raw)
To: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding,
Sam Ravnborg, Rob Herring
Cc: linux-kernel, linux-mips, dri-devel, devicetree
Hello,
v5 :
- this set doesn't include the nv3052c bindings doc anymore,
as it's already applied
- nv3052c panel driver : removed empty lines, proceed to turn it off
even is sleeping in fails instead of stopping there
- abt panel : switched to REGCACHE_FLAT so we can disable sleep mode
in .enable with regmap_set_bits() instead of doing it at init time
- ingenic-drm-drv : added ingenic_drm_bridge_atomic_disable to balance
out ingenic_drm_bridge_atomic_enable
Tested working on the rg350m and rg280m
Christophe Branchereau (3):
drm/ingenic : add ingenic_drm_bridge_atomic_enable and disable
drm/panel: Add panel driver for NewVision NV3052C based LCDs
drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and
.disable
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +-
drivers/gpu/drm/panel/Kconfig | 9 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 +-
drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 +-
.../gpu/drm/panel/panel-newvision-nv3052c.c | 484 ++++++++++++++++++
6 files changed, 572 insertions(+), 18 deletions(-)
create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c
--
2.35.1
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH v5 0/3] Ingenic DRM bridge_atomic_enable proposal @ 2022-03-21 13:36 ` Christophe Branchereau 0 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 13:36 UTC (permalink / raw) To: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring Cc: devicetree, linux-kernel, dri-devel, linux-mips Hello, v5 : - this set doesn't include the nv3052c bindings doc anymore, as it's already applied - nv3052c panel driver : removed empty lines, proceed to turn it off even is sleeping in fails instead of stopping there - abt panel : switched to REGCACHE_FLAT so we can disable sleep mode in .enable with regmap_set_bits() instead of doing it at init time - ingenic-drm-drv : added ingenic_drm_bridge_atomic_disable to balance out ingenic_drm_bridge_atomic_enable Tested working on the rg350m and rg280m Christophe Branchereau (3): drm/ingenic : add ingenic_drm_bridge_atomic_enable and disable drm/panel: Add panel driver for NewVision NV3052C based LCDs drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 +- drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 +- .../gpu/drm/panel/panel-newvision-nv3052c.c | 484 ++++++++++++++++++ 6 files changed, 572 insertions(+), 18 deletions(-) create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c -- 2.35.1 ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5 1/3] drm/ingenic : add ingenic_drm_bridge_atomic_enable and disable 2022-03-21 13:36 ` Christophe Branchereau @ 2022-03-21 13:36 ` Christophe Branchereau -1 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 13:36 UTC (permalink / raw) To: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring Cc: linux-kernel, linux-mips, dri-devel, devicetree ingenic_drm_bridge_atomic_enable allows the CRTC to be enabled after panels have slept out, and before their display is turned on, solving a graphical bug on the newvision nv3502c. Also add ingenic_drm_bridge_atomic_disable to balance it out. Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +++++++++++++++-------- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index dcf44cb00821..2bbfd2e7fdab 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct notifier_block *nb, } } +static void ingenic_drm_bridge_atomic_enable(struct drm_bridge *bridge, + struct drm_bridge_state *old_bridge_state) +{ + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); + + regmap_write(priv->map, JZ_REG_LCD_STATE, 0); + + regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, + JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, + JZ_LCD_CTRL_ENABLE); +} + static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, struct drm_atomic_state *state) { @@ -237,28 +249,20 @@ static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, if (WARN_ON(IS_ERR(priv_state))) return; - regmap_write(priv->map, JZ_REG_LCD_STATE, 0); - /* Set addresses of our DMA descriptor chains */ next_id = priv_state->use_palette ? HWDESC_PALETTE : 0; regmap_write(priv->map, JZ_REG_LCD_DA0, dma_hwdesc_addr(priv, next_id)); regmap_write(priv->map, JZ_REG_LCD_DA1, dma_hwdesc_addr(priv, 1)); - regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, - JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, - JZ_LCD_CTRL_ENABLE); - drm_crtc_vblank_on(crtc); } -static void ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, - struct drm_atomic_state *state) +static void ingenic_drm_bridge_atomic_disable(struct drm_bridge *bridge, + struct drm_bridge_state *old_bridge_state) { - struct ingenic_drm *priv = drm_crtc_get_priv(crtc); + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); unsigned int var; - drm_crtc_vblank_off(crtc); - regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, JZ_LCD_CTRL_DISABLE, JZ_LCD_CTRL_DISABLE); @@ -267,6 +271,12 @@ static void ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, 1000, 0); } +static void ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + drm_crtc_vblank_off(crtc); +} + static void ingenic_drm_crtc_update_timings(struct ingenic_drm *priv, struct drm_display_mode *mode) { @@ -968,6 +978,8 @@ static const struct drm_encoder_helper_funcs ingenic_drm_encoder_helper_funcs = static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = { .attach = ingenic_drm_bridge_attach, + .atomic_enable = ingenic_drm_bridge_atomic_enable, + .atomic_disable = ingenic_drm_bridge_atomic_disable, .atomic_check = ingenic_drm_bridge_atomic_check, .atomic_reset = drm_atomic_helper_bridge_reset, .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, -- 2.35.1 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5 1/3] drm/ingenic : add ingenic_drm_bridge_atomic_enable and disable @ 2022-03-21 13:36 ` Christophe Branchereau 0 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 13:36 UTC (permalink / raw) To: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring Cc: devicetree, linux-kernel, dri-devel, linux-mips ingenic_drm_bridge_atomic_enable allows the CRTC to be enabled after panels have slept out, and before their display is turned on, solving a graphical bug on the newvision nv3502c. Also add ingenic_drm_bridge_atomic_disable to balance it out. Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +++++++++++++++-------- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index dcf44cb00821..2bbfd2e7fdab 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct notifier_block *nb, } } +static void ingenic_drm_bridge_atomic_enable(struct drm_bridge *bridge, + struct drm_bridge_state *old_bridge_state) +{ + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); + + regmap_write(priv->map, JZ_REG_LCD_STATE, 0); + + regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, + JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, + JZ_LCD_CTRL_ENABLE); +} + static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, struct drm_atomic_state *state) { @@ -237,28 +249,20 @@ static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, if (WARN_ON(IS_ERR(priv_state))) return; - regmap_write(priv->map, JZ_REG_LCD_STATE, 0); - /* Set addresses of our DMA descriptor chains */ next_id = priv_state->use_palette ? HWDESC_PALETTE : 0; regmap_write(priv->map, JZ_REG_LCD_DA0, dma_hwdesc_addr(priv, next_id)); regmap_write(priv->map, JZ_REG_LCD_DA1, dma_hwdesc_addr(priv, 1)); - regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, - JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, - JZ_LCD_CTRL_ENABLE); - drm_crtc_vblank_on(crtc); } -static void ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, - struct drm_atomic_state *state) +static void ingenic_drm_bridge_atomic_disable(struct drm_bridge *bridge, + struct drm_bridge_state *old_bridge_state) { - struct ingenic_drm *priv = drm_crtc_get_priv(crtc); + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); unsigned int var; - drm_crtc_vblank_off(crtc); - regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, JZ_LCD_CTRL_DISABLE, JZ_LCD_CTRL_DISABLE); @@ -267,6 +271,12 @@ static void ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, 1000, 0); } +static void ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + drm_crtc_vblank_off(crtc); +} + static void ingenic_drm_crtc_update_timings(struct ingenic_drm *priv, struct drm_display_mode *mode) { @@ -968,6 +978,8 @@ static const struct drm_encoder_helper_funcs ingenic_drm_encoder_helper_funcs = static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = { .attach = ingenic_drm_bridge_attach, + .atomic_enable = ingenic_drm_bridge_atomic_enable, + .atomic_disable = ingenic_drm_bridge_atomic_disable, .atomic_check = ingenic_drm_bridge_atomic_check, .atomic_reset = drm_atomic_helper_bridge_reset, .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, -- 2.35.1 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/3] drm/ingenic : add ingenic_drm_bridge_atomic_enable and disable 2022-03-21 13:36 ` Christophe Branchereau @ 2022-04-05 20:26 ` Artur Rojek -1 siblings, 0 replies; 22+ messages in thread From: Artur Rojek @ 2022-04-05 20:26 UTC (permalink / raw) To: Christophe Branchereau Cc: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring, devicetree, linux-kernel, dri-devel, linux-mips On 2022-03-21 14:36, Christophe Branchereau wrote: Hi Christophe, looks good to me. Cheers, Artur Acked-by: Artur Rojek <contact@artur-rojek.eu> > ingenic_drm_bridge_atomic_enable allows the CRTC to be enabled after > panels have slept out, and before their display is turned on, solving > a graphical bug on the newvision nv3502c. > > Also add ingenic_drm_bridge_atomic_disable to balance it out. > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > --- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +++++++++++++++-------- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index dcf44cb00821..2bbfd2e7fdab 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct > notifier_block *nb, > } > } > > +static void ingenic_drm_bridge_atomic_enable(struct drm_bridge > *bridge, > + struct drm_bridge_state *old_bridge_state) > +{ > + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); > + > + regmap_write(priv->map, JZ_REG_LCD_STATE, 0); > + > + regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > + JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, > + JZ_LCD_CTRL_ENABLE); > +} > + > static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, > struct drm_atomic_state *state) > { > @@ -237,28 +249,20 @@ static void > ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, > if (WARN_ON(IS_ERR(priv_state))) > return; > > - regmap_write(priv->map, JZ_REG_LCD_STATE, 0); > - > /* Set addresses of our DMA descriptor chains */ > next_id = priv_state->use_palette ? HWDESC_PALETTE : 0; > regmap_write(priv->map, JZ_REG_LCD_DA0, dma_hwdesc_addr(priv, > next_id)); > regmap_write(priv->map, JZ_REG_LCD_DA1, dma_hwdesc_addr(priv, 1)); > > - regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > - JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, > - JZ_LCD_CTRL_ENABLE); > - > drm_crtc_vblank_on(crtc); > } > > -static void ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, > - struct drm_atomic_state *state) > +static void ingenic_drm_bridge_atomic_disable(struct drm_bridge > *bridge, > + struct drm_bridge_state *old_bridge_state) > { > - struct ingenic_drm *priv = drm_crtc_get_priv(crtc); > + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); > unsigned int var; > > - drm_crtc_vblank_off(crtc); > - > regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > JZ_LCD_CTRL_DISABLE, JZ_LCD_CTRL_DISABLE); > > @@ -267,6 +271,12 @@ static void > ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, > 1000, 0); > } > > +static void ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, > + struct drm_atomic_state *state) > +{ > + drm_crtc_vblank_off(crtc); > +} > + > static void ingenic_drm_crtc_update_timings(struct ingenic_drm *priv, > struct drm_display_mode *mode) > { > @@ -968,6 +978,8 @@ static const struct drm_encoder_helper_funcs > ingenic_drm_encoder_helper_funcs = > > static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = { > .attach = ingenic_drm_bridge_attach, > + .atomic_enable = ingenic_drm_bridge_atomic_enable, > + .atomic_disable = ingenic_drm_bridge_atomic_disable, > .atomic_check = ingenic_drm_bridge_atomic_check, > .atomic_reset = drm_atomic_helper_bridge_reset, > .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/3] drm/ingenic : add ingenic_drm_bridge_atomic_enable and disable @ 2022-04-05 20:26 ` Artur Rojek 0 siblings, 0 replies; 22+ messages in thread From: Artur Rojek @ 2022-04-05 20:26 UTC (permalink / raw) To: Christophe Branchereau Cc: devicetree, David Airlie, linux-kernel, Rob Herring, linux-mips, Paul Cercueil, Thierry Reding, dri-devel, Sam Ravnborg On 2022-03-21 14:36, Christophe Branchereau wrote: Hi Christophe, looks good to me. Cheers, Artur Acked-by: Artur Rojek <contact@artur-rojek.eu> > ingenic_drm_bridge_atomic_enable allows the CRTC to be enabled after > panels have slept out, and before their display is turned on, solving > a graphical bug on the newvision nv3502c. > > Also add ingenic_drm_bridge_atomic_disable to balance it out. > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > --- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +++++++++++++++-------- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index dcf44cb00821..2bbfd2e7fdab 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct > notifier_block *nb, > } > } > > +static void ingenic_drm_bridge_atomic_enable(struct drm_bridge > *bridge, > + struct drm_bridge_state *old_bridge_state) > +{ > + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); > + > + regmap_write(priv->map, JZ_REG_LCD_STATE, 0); > + > + regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > + JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, > + JZ_LCD_CTRL_ENABLE); > +} > + > static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, > struct drm_atomic_state *state) > { > @@ -237,28 +249,20 @@ static void > ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, > if (WARN_ON(IS_ERR(priv_state))) > return; > > - regmap_write(priv->map, JZ_REG_LCD_STATE, 0); > - > /* Set addresses of our DMA descriptor chains */ > next_id = priv_state->use_palette ? HWDESC_PALETTE : 0; > regmap_write(priv->map, JZ_REG_LCD_DA0, dma_hwdesc_addr(priv, > next_id)); > regmap_write(priv->map, JZ_REG_LCD_DA1, dma_hwdesc_addr(priv, 1)); > > - regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > - JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, > - JZ_LCD_CTRL_ENABLE); > - > drm_crtc_vblank_on(crtc); > } > > -static void ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, > - struct drm_atomic_state *state) > +static void ingenic_drm_bridge_atomic_disable(struct drm_bridge > *bridge, > + struct drm_bridge_state *old_bridge_state) > { > - struct ingenic_drm *priv = drm_crtc_get_priv(crtc); > + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); > unsigned int var; > > - drm_crtc_vblank_off(crtc); > - > regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > JZ_LCD_CTRL_DISABLE, JZ_LCD_CTRL_DISABLE); > > @@ -267,6 +271,12 @@ static void > ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, > 1000, 0); > } > > +static void ingenic_drm_crtc_atomic_disable(struct drm_crtc *crtc, > + struct drm_atomic_state *state) > +{ > + drm_crtc_vblank_off(crtc); > +} > + > static void ingenic_drm_crtc_update_timings(struct ingenic_drm *priv, > struct drm_display_mode *mode) > { > @@ -968,6 +978,8 @@ static const struct drm_encoder_helper_funcs > ingenic_drm_encoder_helper_funcs = > > static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = { > .attach = ingenic_drm_bridge_attach, > + .atomic_enable = ingenic_drm_bridge_atomic_enable, > + .atomic_disable = ingenic_drm_bridge_atomic_disable, > .atomic_check = ingenic_drm_bridge_atomic_check, > .atomic_reset = drm_atomic_helper_bridge_reset, > .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5 2/3] drm/panel: Add panel driver for NewVision NV3052C based LCDs 2022-03-21 13:36 ` Christophe Branchereau @ 2022-03-21 13:36 ` Christophe Branchereau -1 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 13:36 UTC (permalink / raw) To: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring Cc: linux-kernel, linux-mips, dri-devel, devicetree This driver supports the NewVision NV3052C based LCDs. Right now, it only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which can be found in the Anbernic RG-350M handheld console. Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-newvision-nv3052c.c | 484 ++++++++++++++++++ 3 files changed, 494 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index bb2e47229c68..40084f709789 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -283,6 +283,15 @@ config DRM_PANEL_NEC_NL8048HL11 panel (found on the Zoom2/3/3630 SDP boards). To compile this driver as a module, choose M here. +config DRM_PANEL_NEWVISION_NV3052C + tristate "NewVision NV3052C RGB/SPI panel" + depends on OF && SPI + depends on BACKLIGHT_CLASS_DEVICE + select DRM_MIPI_DBI + help + Say Y here if you want to enable support for the panels built + around the NewVision NV3052C display controller. + config DRM_PANEL_NOVATEK_NT35510 tristate "Novatek NT35510 RGB panel driver" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 5740911f637c..42a7ab54234b 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) += panel-leadtek-ltk500hd1829.o obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o +obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3052C) += panel-newvision-nv3052c.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35950) += panel-novatek-nt35950.o diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c new file mode 100644 index 000000000000..7ad9d29839fc --- /dev/null +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c @@ -0,0 +1,484 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * NewVision NV3052C IPS LCD panel driver + * + * Copyright (C) 2020, Paul Cercueil <paul@crapouillou.net> + * Copyright (C) 2022, Christophe Branchereau <cbranchereau@gmail.com> + */ + +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/gpio/consumer.h> +#include <linux/media-bus-format.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/regulator/consumer.h> +#include <linux/spi/spi.h> +#include <video/mipi_display.h> +#include <drm/drm_mipi_dbi.h> +#include <drm/drm_modes.h> +#include <drm/drm_panel.h> + +struct nv3052c_panel_info { + const struct drm_display_mode *display_modes; + unsigned int num_modes; + u16 width_mm, height_mm; + u32 bus_format, bus_flags; +}; + +struct nv3052c { + struct device *dev; + struct drm_panel panel; + struct mipi_dbi dbi; + const struct nv3052c_panel_info *panel_info; + struct regulator *supply; + struct gpio_desc *reset_gpio; +}; + +struct nv3052c_reg { + u8 cmd; + u8 val; +}; + +static const struct nv3052c_reg nv3052c_panel_regs[] = { + { 0xff, 0x30 }, + { 0xff, 0x52 }, + { 0xff, 0x01 }, + { 0xe3, 0x00 }, + { 0x40, 0x00 }, + { 0x03, 0x40 }, + { 0x04, 0x00 }, + { 0x05, 0x03 }, + { 0x08, 0x00 }, + { 0x09, 0x07 }, + { 0x0a, 0x01 }, + { 0x0b, 0x32 }, + { 0x0c, 0x32 }, + { 0x0d, 0x0b }, + { 0x0e, 0x00 }, + { 0x23, 0xa0 }, + { 0x24, 0x0c }, + { 0x25, 0x06 }, + { 0x26, 0x14 }, + { 0x27, 0x14 }, + { 0x38, 0xcc }, + { 0x39, 0xd7 }, + { 0x3a, 0x4a }, + { 0x28, 0x40 }, + { 0x29, 0x01 }, + { 0x2a, 0xdf }, + { 0x49, 0x3c }, + { 0x91, 0x77 }, + { 0x92, 0x77 }, + { 0xa0, 0x55 }, + { 0xa1, 0x50 }, + { 0xa4, 0x9c }, + { 0xa7, 0x02 }, + { 0xa8, 0x01 }, + { 0xa9, 0x01 }, + { 0xaa, 0xfc }, + { 0xab, 0x28 }, + { 0xac, 0x06 }, + { 0xad, 0x06 }, + { 0xae, 0x06 }, + { 0xaf, 0x03 }, + { 0xb0, 0x08 }, + { 0xb1, 0x26 }, + { 0xb2, 0x28 }, + { 0xb3, 0x28 }, + { 0xb4, 0x33 }, + { 0xb5, 0x08 }, + { 0xb6, 0x26 }, + { 0xb7, 0x08 }, + { 0xb8, 0x26 }, + { 0xf0, 0x00 }, + { 0xf6, 0xc0 }, + { 0xff, 0x30 }, + { 0xff, 0x52 }, + { 0xff, 0x02 }, + { 0xb0, 0x0b }, + { 0xb1, 0x16 }, + { 0xb2, 0x17 }, + { 0xb3, 0x2c }, + { 0xb4, 0x32 }, + { 0xb5, 0x3b }, + { 0xb6, 0x29 }, + { 0xb7, 0x40 }, + { 0xb8, 0x0d }, + { 0xb9, 0x05 }, + { 0xba, 0x12 }, + { 0xbb, 0x10 }, + { 0xbc, 0x12 }, + { 0xbd, 0x15 }, + { 0xbe, 0x19 }, + { 0xbf, 0x0e }, + { 0xc0, 0x16 }, + { 0xc1, 0x0a }, + { 0xd0, 0x0c }, + { 0xd1, 0x17 }, + { 0xd2, 0x14 }, + { 0xd3, 0x2e }, + { 0xd4, 0x32 }, + { 0xd5, 0x3c }, + { 0xd6, 0x22 }, + { 0xd7, 0x3d }, + { 0xd8, 0x0d }, + { 0xd9, 0x07 }, + { 0xda, 0x13 }, + { 0xdb, 0x13 }, + { 0xdc, 0x11 }, + { 0xdd, 0x15 }, + { 0xde, 0x19 }, + { 0xdf, 0x10 }, + { 0xe0, 0x17 }, + { 0xe1, 0x0a }, + { 0xff, 0x30 }, + { 0xff, 0x52 }, + { 0xff, 0x03 }, + { 0x00, 0x2a }, + { 0x01, 0x2a }, + { 0x02, 0x2a }, + { 0x03, 0x2a }, + { 0x04, 0x61 }, + { 0x05, 0x80 }, + { 0x06, 0xc7 }, + { 0x07, 0x01 }, + { 0x08, 0x03 }, + { 0x09, 0x04 }, + { 0x70, 0x22 }, + { 0x71, 0x80 }, + { 0x30, 0x2a }, + { 0x31, 0x2a }, + { 0x32, 0x2a }, + { 0x33, 0x2a }, + { 0x34, 0x61 }, + { 0x35, 0xc5 }, + { 0x36, 0x80 }, + { 0x37, 0x23 }, + { 0x40, 0x03 }, + { 0x41, 0x04 }, + { 0x42, 0x05 }, + { 0x43, 0x06 }, + { 0x44, 0x11 }, + { 0x45, 0xe8 }, + { 0x46, 0xe9 }, + { 0x47, 0x11 }, + { 0x48, 0xea }, + { 0x49, 0xeb }, + { 0x50, 0x07 }, + { 0x51, 0x08 }, + { 0x52, 0x09 }, + { 0x53, 0x0a }, + { 0x54, 0x11 }, + { 0x55, 0xec }, + { 0x56, 0xed }, + { 0x57, 0x11 }, + { 0x58, 0xef }, + { 0x59, 0xf0 }, + { 0xb1, 0x01 }, + { 0xb4, 0x15 }, + { 0xb5, 0x16 }, + { 0xb6, 0x09 }, + { 0xb7, 0x0f }, + { 0xb8, 0x0d }, + { 0xb9, 0x0b }, + { 0xba, 0x00 }, + { 0xc7, 0x02 }, + { 0xca, 0x17 }, + { 0xcb, 0x18 }, + { 0xcc, 0x0a }, + { 0xcd, 0x10 }, + { 0xce, 0x0e }, + { 0xcf, 0x0c }, + { 0xd0, 0x00 }, + { 0x81, 0x00 }, + { 0x84, 0x15 }, + { 0x85, 0x16 }, + { 0x86, 0x10 }, + { 0x87, 0x0a }, + { 0x88, 0x0c }, + { 0x89, 0x0e }, + { 0x8a, 0x02 }, + { 0x97, 0x00 }, + { 0x9a, 0x17 }, + { 0x9b, 0x18 }, + { 0x9c, 0x0f }, + { 0x9d, 0x09 }, + { 0x9e, 0x0b }, + { 0x9f, 0x0d }, + { 0xa0, 0x01 }, + { 0xff, 0x30 }, + { 0xff, 0x52 }, + { 0xff, 0x02 }, + { 0x01, 0x01 }, + { 0x02, 0xda }, + { 0x03, 0xba }, + { 0x04, 0xa8 }, + { 0x05, 0x9a }, + { 0x06, 0x70 }, + { 0x07, 0xff }, + { 0x08, 0x91 }, + { 0x09, 0x90 }, + { 0x0a, 0xff }, + { 0x0b, 0x8f }, + { 0x0c, 0x60 }, + { 0x0d, 0x58 }, + { 0x0e, 0x48 }, + { 0x0f, 0x38 }, + { 0x10, 0x2b }, + { 0xff, 0x30 }, + { 0xff, 0x52 }, + { 0xff, 0x00 }, + { 0x36, 0x0a }, +}; + +static inline struct nv3052c *to_nv3052c(struct drm_panel *panel) +{ + return container_of(panel, struct nv3052c, panel); +} + +static int nv3052c_prepare(struct drm_panel *panel) +{ + struct nv3052c *priv = to_nv3052c(panel); + struct mipi_dbi *dbi = &priv->dbi; + unsigned int i; + int err; + + err = regulator_enable(priv->supply); + if (err) { + dev_err(priv->dev, "Failed to enable power supply: %d\n", err); + return err; + } + + /* Reset the chip */ + gpiod_set_value_cansleep(priv->reset_gpio, 1); + usleep_range(10, 1000); + gpiod_set_value_cansleep(priv->reset_gpio, 0); + msleep(5); + + for (i = 0; i < ARRAY_SIZE(nv3052c_panel_regs); i++) { + err = mipi_dbi_command(dbi, nv3052c_panel_regs[i].cmd, + nv3052c_panel_regs[i].val); + + if (err) { + dev_err(priv->dev, "Unable to set register: %d\n", err); + goto err_disable_regulator; + } + } + + err = mipi_dbi_command(dbi, MIPI_DCS_EXIT_SLEEP_MODE); + if (err) { + dev_err(priv->dev, "Unable to exit sleep mode: %d\n", err); + goto err_disable_regulator; + } + + return 0; + +err_disable_regulator: + regulator_disable(priv->supply); + return err; +} + +static int nv3052c_unprepare(struct drm_panel *panel) +{ + struct nv3052c *priv = to_nv3052c(panel); + struct mipi_dbi *dbi = &priv->dbi; + int err; + + err = mipi_dbi_command(dbi, MIPI_DCS_ENTER_SLEEP_MODE); + if (err) + dev_err(priv->dev, "Unable to enter sleep mode: %d\n", err); + + gpiod_set_value_cansleep(priv->reset_gpio, 1); + regulator_disable(priv->supply); + + return 0; +} + +static int nv3052c_enable(struct drm_panel *panel) +{ + struct nv3052c *priv = to_nv3052c(panel); + struct mipi_dbi *dbi = &priv->dbi; + int err; + + err = mipi_dbi_command(dbi, MIPI_DCS_SET_DISPLAY_ON); + if (err) { + dev_err(priv->dev, "Unable to enable display: %d\n", err); + return err; + } + + if (panel->backlight) { + /* Wait for the picture to be ready before enabling backlight */ + msleep(120); + } + + return 0; +} + +static int nv3052c_disable(struct drm_panel *panel) +{ + struct nv3052c *priv = to_nv3052c(panel); + struct mipi_dbi *dbi = &priv->dbi; + int err; + + err = mipi_dbi_command(dbi, MIPI_DCS_SET_DISPLAY_OFF); + if (err) { + dev_err(priv->dev, "Unable to disable display: %d\n", err); + return err; + } + + return 0; +} + +static int nv3052c_get_modes(struct drm_panel *panel, + struct drm_connector *connector) +{ + struct nv3052c *priv = to_nv3052c(panel); + const struct nv3052c_panel_info *panel_info = priv->panel_info; + struct drm_display_mode *mode; + unsigned int i; + + for (i = 0; i < panel_info->num_modes; i++) { + mode = drm_mode_duplicate(connector->dev, + &panel_info->display_modes[i]); + if (!mode) + return -ENOMEM; + + drm_mode_set_name(mode); + + mode->type = DRM_MODE_TYPE_DRIVER; + if (panel_info->num_modes == 1) + mode->type |= DRM_MODE_TYPE_PREFERRED; + + drm_mode_probed_add(connector, mode); + } + + connector->display_info.bpc = 8; + connector->display_info.width_mm = panel_info->width_mm; + connector->display_info.height_mm = panel_info->height_mm; + + drm_display_info_set_bus_formats(&connector->display_info, + &panel_info->bus_format, 1); + connector->display_info.bus_flags = panel_info->bus_flags; + + return panel_info->num_modes; +} + +static const struct drm_panel_funcs nv3052c_funcs = { + .prepare = nv3052c_prepare, + .unprepare = nv3052c_unprepare, + .enable = nv3052c_enable, + .disable = nv3052c_disable, + .get_modes = nv3052c_get_modes, +}; + +static int nv3052c_probe(struct spi_device *spi) +{ + struct device *dev = &spi->dev; + struct nv3052c *priv; + int err; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->dev = dev; + + priv->panel_info = of_device_get_match_data(dev); + if (!priv->panel_info) + return -EINVAL; + + priv->supply = devm_regulator_get(dev, "power"); + if (IS_ERR(priv->supply)) + return dev_err_probe(dev, PTR_ERR(priv->supply), "Failed to get power supply\n"); + + priv->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(priv->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(priv->reset_gpio), "Failed to get reset GPIO\n"); + + err = mipi_dbi_spi_init(spi, &priv->dbi, NULL); + if (err) + return dev_err_probe(dev, err, "MIPI DBI init failed\n"); + + priv->dbi.read_commands = NULL; + + spi_set_drvdata(spi, priv); + + drm_panel_init(&priv->panel, dev, &nv3052c_funcs, + DRM_MODE_CONNECTOR_DPI); + + err = drm_panel_of_backlight(&priv->panel); + if (err) + return dev_err_probe(dev, err, "Failed to attach backlight\n"); + + drm_panel_add(&priv->panel); + + return 0; +} + +static int nv3052c_remove(struct spi_device *spi) +{ + struct nv3052c *priv = spi_get_drvdata(spi); + + drm_panel_remove(&priv->panel); + drm_panel_disable(&priv->panel); + drm_panel_unprepare(&priv->panel); + + return 0; +} + +static const struct drm_display_mode ltk035c5444t_modes[] = { + { /* 60 Hz */ + .clock = 24000, + .hdisplay = 640, + .hsync_start = 640 + 96, + .hsync_end = 640 + 96 + 16, + .htotal = 640 + 96 + 16 + 48, + .vdisplay = 480, + .vsync_start = 480 + 5, + .vsync_end = 480 + 5 + 2, + .vtotal = 480 + 5 + 2 + 13, + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, + }, + { /* 50 Hz */ + .clock = 18000, + .hdisplay = 640, + .hsync_start = 640 + 39, + .hsync_end = 640 + 39 + 2, + .htotal = 640 + 39 + 2 + 39, + .vdisplay = 480, + .vsync_start = 480 + 5, + .vsync_end = 480 + 5 + 2, + .vtotal = 480 + 5 + 2 + 13, + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, + }, +}; + +static const struct nv3052c_panel_info ltk035c5444t_panel_info = { + .display_modes = ltk035c5444t_modes, + .num_modes = ARRAY_SIZE(ltk035c5444t_modes), + .width_mm = 77, + .height_mm = 64, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, +}; + +static const struct of_device_id nv3052c_of_match[] = { + { .compatible = "leadtek,ltk035c5444t", .data = <k035c5444t_panel_info }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, nv3052c_of_match); + +static struct spi_driver nv3052c_driver = { + .driver = { + .name = "nv3052c", + .of_match_table = nv3052c_of_match, + }, + .probe = nv3052c_probe, + .remove = nv3052c_remove, +}; +module_spi_driver(nv3052c_driver); + +MODULE_AUTHOR("Paul Cercueil <paul@crapouillou.net>"); +MODULE_AUTHOR("Christophe Branchereau <cbranchereau@gmail.com>"); +MODULE_LICENSE("GPL v2"); -- 2.35.1 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5 2/3] drm/panel: Add panel driver for NewVision NV3052C based LCDs @ 2022-03-21 13:36 ` Christophe Branchereau 0 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 13:36 UTC (permalink / raw) To: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring Cc: devicetree, linux-kernel, dri-devel, linux-mips This driver supports the NewVision NV3052C based LCDs. Right now, it only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which can be found in the Anbernic RG-350M handheld console. Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-newvision-nv3052c.c | 484 ++++++++++++++++++ 3 files changed, 494 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index bb2e47229c68..40084f709789 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -283,6 +283,15 @@ config DRM_PANEL_NEC_NL8048HL11 panel (found on the Zoom2/3/3630 SDP boards). To compile this driver as a module, choose M here. +config DRM_PANEL_NEWVISION_NV3052C + tristate "NewVision NV3052C RGB/SPI panel" + depends on OF && SPI + depends on BACKLIGHT_CLASS_DEVICE + select DRM_MIPI_DBI + help + Say Y here if you want to enable support for the panels built + around the NewVision NV3052C display controller. + config DRM_PANEL_NOVATEK_NT35510 tristate "Novatek NT35510 RGB panel driver" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 5740911f637c..42a7ab54234b 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) += panel-leadtek-ltk500hd1829.o obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o +obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3052C) += panel-newvision-nv3052c.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35950) += panel-novatek-nt35950.o diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c new file mode 100644 index 000000000000..7ad9d29839fc --- /dev/null +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c @@ -0,0 +1,484 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * NewVision NV3052C IPS LCD panel driver + * + * Copyright (C) 2020, Paul Cercueil <paul@crapouillou.net> + * Copyright (C) 2022, Christophe Branchereau <cbranchereau@gmail.com> + */ + +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/gpio/consumer.h> +#include <linux/media-bus-format.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/regulator/consumer.h> +#include <linux/spi/spi.h> +#include <video/mipi_display.h> +#include <drm/drm_mipi_dbi.h> +#include <drm/drm_modes.h> +#include <drm/drm_panel.h> + +struct nv3052c_panel_info { + const struct drm_display_mode *display_modes; + unsigned int num_modes; + u16 width_mm, height_mm; + u32 bus_format, bus_flags; +}; + +struct nv3052c { + struct device *dev; + struct drm_panel panel; + struct mipi_dbi dbi; + const struct nv3052c_panel_info *panel_info; + struct regulator *supply; + struct gpio_desc *reset_gpio; +}; + +struct nv3052c_reg { + u8 cmd; + u8 val; +}; + +static const struct nv3052c_reg nv3052c_panel_regs[] = { + { 0xff, 0x30 }, + { 0xff, 0x52 }, + { 0xff, 0x01 }, + { 0xe3, 0x00 }, + { 0x40, 0x00 }, + { 0x03, 0x40 }, + { 0x04, 0x00 }, + { 0x05, 0x03 }, + { 0x08, 0x00 }, + { 0x09, 0x07 }, + { 0x0a, 0x01 }, + { 0x0b, 0x32 }, + { 0x0c, 0x32 }, + { 0x0d, 0x0b }, + { 0x0e, 0x00 }, + { 0x23, 0xa0 }, + { 0x24, 0x0c }, + { 0x25, 0x06 }, + { 0x26, 0x14 }, + { 0x27, 0x14 }, + { 0x38, 0xcc }, + { 0x39, 0xd7 }, + { 0x3a, 0x4a }, + { 0x28, 0x40 }, + { 0x29, 0x01 }, + { 0x2a, 0xdf }, + { 0x49, 0x3c }, + { 0x91, 0x77 }, + { 0x92, 0x77 }, + { 0xa0, 0x55 }, + { 0xa1, 0x50 }, + { 0xa4, 0x9c }, + { 0xa7, 0x02 }, + { 0xa8, 0x01 }, + { 0xa9, 0x01 }, + { 0xaa, 0xfc }, + { 0xab, 0x28 }, + { 0xac, 0x06 }, + { 0xad, 0x06 }, + { 0xae, 0x06 }, + { 0xaf, 0x03 }, + { 0xb0, 0x08 }, + { 0xb1, 0x26 }, + { 0xb2, 0x28 }, + { 0xb3, 0x28 }, + { 0xb4, 0x33 }, + { 0xb5, 0x08 }, + { 0xb6, 0x26 }, + { 0xb7, 0x08 }, + { 0xb8, 0x26 }, + { 0xf0, 0x00 }, + { 0xf6, 0xc0 }, + { 0xff, 0x30 }, + { 0xff, 0x52 }, + { 0xff, 0x02 }, + { 0xb0, 0x0b }, + { 0xb1, 0x16 }, + { 0xb2, 0x17 }, + { 0xb3, 0x2c }, + { 0xb4, 0x32 }, + { 0xb5, 0x3b }, + { 0xb6, 0x29 }, + { 0xb7, 0x40 }, + { 0xb8, 0x0d }, + { 0xb9, 0x05 }, + { 0xba, 0x12 }, + { 0xbb, 0x10 }, + { 0xbc, 0x12 }, + { 0xbd, 0x15 }, + { 0xbe, 0x19 }, + { 0xbf, 0x0e }, + { 0xc0, 0x16 }, + { 0xc1, 0x0a }, + { 0xd0, 0x0c }, + { 0xd1, 0x17 }, + { 0xd2, 0x14 }, + { 0xd3, 0x2e }, + { 0xd4, 0x32 }, + { 0xd5, 0x3c }, + { 0xd6, 0x22 }, + { 0xd7, 0x3d }, + { 0xd8, 0x0d }, + { 0xd9, 0x07 }, + { 0xda, 0x13 }, + { 0xdb, 0x13 }, + { 0xdc, 0x11 }, + { 0xdd, 0x15 }, + { 0xde, 0x19 }, + { 0xdf, 0x10 }, + { 0xe0, 0x17 }, + { 0xe1, 0x0a }, + { 0xff, 0x30 }, + { 0xff, 0x52 }, + { 0xff, 0x03 }, + { 0x00, 0x2a }, + { 0x01, 0x2a }, + { 0x02, 0x2a }, + { 0x03, 0x2a }, + { 0x04, 0x61 }, + { 0x05, 0x80 }, + { 0x06, 0xc7 }, + { 0x07, 0x01 }, + { 0x08, 0x03 }, + { 0x09, 0x04 }, + { 0x70, 0x22 }, + { 0x71, 0x80 }, + { 0x30, 0x2a }, + { 0x31, 0x2a }, + { 0x32, 0x2a }, + { 0x33, 0x2a }, + { 0x34, 0x61 }, + { 0x35, 0xc5 }, + { 0x36, 0x80 }, + { 0x37, 0x23 }, + { 0x40, 0x03 }, + { 0x41, 0x04 }, + { 0x42, 0x05 }, + { 0x43, 0x06 }, + { 0x44, 0x11 }, + { 0x45, 0xe8 }, + { 0x46, 0xe9 }, + { 0x47, 0x11 }, + { 0x48, 0xea }, + { 0x49, 0xeb }, + { 0x50, 0x07 }, + { 0x51, 0x08 }, + { 0x52, 0x09 }, + { 0x53, 0x0a }, + { 0x54, 0x11 }, + { 0x55, 0xec }, + { 0x56, 0xed }, + { 0x57, 0x11 }, + { 0x58, 0xef }, + { 0x59, 0xf0 }, + { 0xb1, 0x01 }, + { 0xb4, 0x15 }, + { 0xb5, 0x16 }, + { 0xb6, 0x09 }, + { 0xb7, 0x0f }, + { 0xb8, 0x0d }, + { 0xb9, 0x0b }, + { 0xba, 0x00 }, + { 0xc7, 0x02 }, + { 0xca, 0x17 }, + { 0xcb, 0x18 }, + { 0xcc, 0x0a }, + { 0xcd, 0x10 }, + { 0xce, 0x0e }, + { 0xcf, 0x0c }, + { 0xd0, 0x00 }, + { 0x81, 0x00 }, + { 0x84, 0x15 }, + { 0x85, 0x16 }, + { 0x86, 0x10 }, + { 0x87, 0x0a }, + { 0x88, 0x0c }, + { 0x89, 0x0e }, + { 0x8a, 0x02 }, + { 0x97, 0x00 }, + { 0x9a, 0x17 }, + { 0x9b, 0x18 }, + { 0x9c, 0x0f }, + { 0x9d, 0x09 }, + { 0x9e, 0x0b }, + { 0x9f, 0x0d }, + { 0xa0, 0x01 }, + { 0xff, 0x30 }, + { 0xff, 0x52 }, + { 0xff, 0x02 }, + { 0x01, 0x01 }, + { 0x02, 0xda }, + { 0x03, 0xba }, + { 0x04, 0xa8 }, + { 0x05, 0x9a }, + { 0x06, 0x70 }, + { 0x07, 0xff }, + { 0x08, 0x91 }, + { 0x09, 0x90 }, + { 0x0a, 0xff }, + { 0x0b, 0x8f }, + { 0x0c, 0x60 }, + { 0x0d, 0x58 }, + { 0x0e, 0x48 }, + { 0x0f, 0x38 }, + { 0x10, 0x2b }, + { 0xff, 0x30 }, + { 0xff, 0x52 }, + { 0xff, 0x00 }, + { 0x36, 0x0a }, +}; + +static inline struct nv3052c *to_nv3052c(struct drm_panel *panel) +{ + return container_of(panel, struct nv3052c, panel); +} + +static int nv3052c_prepare(struct drm_panel *panel) +{ + struct nv3052c *priv = to_nv3052c(panel); + struct mipi_dbi *dbi = &priv->dbi; + unsigned int i; + int err; + + err = regulator_enable(priv->supply); + if (err) { + dev_err(priv->dev, "Failed to enable power supply: %d\n", err); + return err; + } + + /* Reset the chip */ + gpiod_set_value_cansleep(priv->reset_gpio, 1); + usleep_range(10, 1000); + gpiod_set_value_cansleep(priv->reset_gpio, 0); + msleep(5); + + for (i = 0; i < ARRAY_SIZE(nv3052c_panel_regs); i++) { + err = mipi_dbi_command(dbi, nv3052c_panel_regs[i].cmd, + nv3052c_panel_regs[i].val); + + if (err) { + dev_err(priv->dev, "Unable to set register: %d\n", err); + goto err_disable_regulator; + } + } + + err = mipi_dbi_command(dbi, MIPI_DCS_EXIT_SLEEP_MODE); + if (err) { + dev_err(priv->dev, "Unable to exit sleep mode: %d\n", err); + goto err_disable_regulator; + } + + return 0; + +err_disable_regulator: + regulator_disable(priv->supply); + return err; +} + +static int nv3052c_unprepare(struct drm_panel *panel) +{ + struct nv3052c *priv = to_nv3052c(panel); + struct mipi_dbi *dbi = &priv->dbi; + int err; + + err = mipi_dbi_command(dbi, MIPI_DCS_ENTER_SLEEP_MODE); + if (err) + dev_err(priv->dev, "Unable to enter sleep mode: %d\n", err); + + gpiod_set_value_cansleep(priv->reset_gpio, 1); + regulator_disable(priv->supply); + + return 0; +} + +static int nv3052c_enable(struct drm_panel *panel) +{ + struct nv3052c *priv = to_nv3052c(panel); + struct mipi_dbi *dbi = &priv->dbi; + int err; + + err = mipi_dbi_command(dbi, MIPI_DCS_SET_DISPLAY_ON); + if (err) { + dev_err(priv->dev, "Unable to enable display: %d\n", err); + return err; + } + + if (panel->backlight) { + /* Wait for the picture to be ready before enabling backlight */ + msleep(120); + } + + return 0; +} + +static int nv3052c_disable(struct drm_panel *panel) +{ + struct nv3052c *priv = to_nv3052c(panel); + struct mipi_dbi *dbi = &priv->dbi; + int err; + + err = mipi_dbi_command(dbi, MIPI_DCS_SET_DISPLAY_OFF); + if (err) { + dev_err(priv->dev, "Unable to disable display: %d\n", err); + return err; + } + + return 0; +} + +static int nv3052c_get_modes(struct drm_panel *panel, + struct drm_connector *connector) +{ + struct nv3052c *priv = to_nv3052c(panel); + const struct nv3052c_panel_info *panel_info = priv->panel_info; + struct drm_display_mode *mode; + unsigned int i; + + for (i = 0; i < panel_info->num_modes; i++) { + mode = drm_mode_duplicate(connector->dev, + &panel_info->display_modes[i]); + if (!mode) + return -ENOMEM; + + drm_mode_set_name(mode); + + mode->type = DRM_MODE_TYPE_DRIVER; + if (panel_info->num_modes == 1) + mode->type |= DRM_MODE_TYPE_PREFERRED; + + drm_mode_probed_add(connector, mode); + } + + connector->display_info.bpc = 8; + connector->display_info.width_mm = panel_info->width_mm; + connector->display_info.height_mm = panel_info->height_mm; + + drm_display_info_set_bus_formats(&connector->display_info, + &panel_info->bus_format, 1); + connector->display_info.bus_flags = panel_info->bus_flags; + + return panel_info->num_modes; +} + +static const struct drm_panel_funcs nv3052c_funcs = { + .prepare = nv3052c_prepare, + .unprepare = nv3052c_unprepare, + .enable = nv3052c_enable, + .disable = nv3052c_disable, + .get_modes = nv3052c_get_modes, +}; + +static int nv3052c_probe(struct spi_device *spi) +{ + struct device *dev = &spi->dev; + struct nv3052c *priv; + int err; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->dev = dev; + + priv->panel_info = of_device_get_match_data(dev); + if (!priv->panel_info) + return -EINVAL; + + priv->supply = devm_regulator_get(dev, "power"); + if (IS_ERR(priv->supply)) + return dev_err_probe(dev, PTR_ERR(priv->supply), "Failed to get power supply\n"); + + priv->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(priv->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(priv->reset_gpio), "Failed to get reset GPIO\n"); + + err = mipi_dbi_spi_init(spi, &priv->dbi, NULL); + if (err) + return dev_err_probe(dev, err, "MIPI DBI init failed\n"); + + priv->dbi.read_commands = NULL; + + spi_set_drvdata(spi, priv); + + drm_panel_init(&priv->panel, dev, &nv3052c_funcs, + DRM_MODE_CONNECTOR_DPI); + + err = drm_panel_of_backlight(&priv->panel); + if (err) + return dev_err_probe(dev, err, "Failed to attach backlight\n"); + + drm_panel_add(&priv->panel); + + return 0; +} + +static int nv3052c_remove(struct spi_device *spi) +{ + struct nv3052c *priv = spi_get_drvdata(spi); + + drm_panel_remove(&priv->panel); + drm_panel_disable(&priv->panel); + drm_panel_unprepare(&priv->panel); + + return 0; +} + +static const struct drm_display_mode ltk035c5444t_modes[] = { + { /* 60 Hz */ + .clock = 24000, + .hdisplay = 640, + .hsync_start = 640 + 96, + .hsync_end = 640 + 96 + 16, + .htotal = 640 + 96 + 16 + 48, + .vdisplay = 480, + .vsync_start = 480 + 5, + .vsync_end = 480 + 5 + 2, + .vtotal = 480 + 5 + 2 + 13, + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, + }, + { /* 50 Hz */ + .clock = 18000, + .hdisplay = 640, + .hsync_start = 640 + 39, + .hsync_end = 640 + 39 + 2, + .htotal = 640 + 39 + 2 + 39, + .vdisplay = 480, + .vsync_start = 480 + 5, + .vsync_end = 480 + 5 + 2, + .vtotal = 480 + 5 + 2 + 13, + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, + }, +}; + +static const struct nv3052c_panel_info ltk035c5444t_panel_info = { + .display_modes = ltk035c5444t_modes, + .num_modes = ARRAY_SIZE(ltk035c5444t_modes), + .width_mm = 77, + .height_mm = 64, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, +}; + +static const struct of_device_id nv3052c_of_match[] = { + { .compatible = "leadtek,ltk035c5444t", .data = <k035c5444t_panel_info }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, nv3052c_of_match); + +static struct spi_driver nv3052c_driver = { + .driver = { + .name = "nv3052c", + .of_match_table = nv3052c_of_match, + }, + .probe = nv3052c_probe, + .remove = nv3052c_remove, +}; +module_spi_driver(nv3052c_driver); + +MODULE_AUTHOR("Paul Cercueil <paul@crapouillou.net>"); +MODULE_AUTHOR("Christophe Branchereau <cbranchereau@gmail.com>"); +MODULE_LICENSE("GPL v2"); -- 2.35.1 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v5 2/3] drm/panel: Add panel driver for NewVision NV3052C based LCDs 2022-03-21 13:36 ` Christophe Branchereau @ 2022-03-27 19:38 ` Sam Ravnborg -1 siblings, 0 replies; 22+ messages in thread From: Sam Ravnborg @ 2022-03-27 19:38 UTC (permalink / raw) To: Christophe Branchereau Cc: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding, Rob Herring, linux-kernel, linux-mips, dri-devel, devicetree Hi Christophe On Mon, Mar 21, 2022 at 02:36:50PM +0100, Christophe Branchereau wrote: > This driver supports the NewVision NV3052C based LCDs. Right now, it > only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which > can be found in the Anbernic RG-350M handheld console. > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> Please add: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> from the previous review round. Sam ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 2/3] drm/panel: Add panel driver for NewVision NV3052C based LCDs @ 2022-03-27 19:38 ` Sam Ravnborg 0 siblings, 0 replies; 22+ messages in thread From: Sam Ravnborg @ 2022-03-27 19:38 UTC (permalink / raw) To: Christophe Branchereau Cc: devicetree, David Airlie, linux-kernel, Rob Herring, linux-mips, Paul Cercueil, Thierry Reding, dri-devel Hi Christophe On Mon, Mar 21, 2022 at 02:36:50PM +0100, Christophe Branchereau wrote: > This driver supports the NewVision NV3052C based LCDs. Right now, it > only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which > can be found in the Anbernic RG-350M handheld console. > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> Please add: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> from the previous review round. Sam ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable 2022-03-21 13:36 ` Christophe Branchereau @ 2022-03-21 13:36 ` Christophe Branchereau -1 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 13:36 UTC (permalink / raw) To: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring Cc: linux-kernel, linux-mips, dri-devel, devicetree Following the introduction of bridge_atomic_enable in the ingenic drm driver, the crtc is enabled between .prepare and .enable, if it exists. Add it so the backlight is only enabled after the crtc is, to avoid graphical issues. Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> --- drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 +++++++++++++++++-- drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 ++++++++++++++++--- 2 files changed, 55 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c index f043b484055b..ddfacaeac1d4 100644 --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c @@ -140,7 +140,7 @@ static const struct reg_sequence y030xx067a_init_sequence[] = { { 0x03, REG03_VPOSITION(0x0a) }, { 0x04, REG04_HPOSITION1(0xd2) }, { 0x05, REG05_CLIP | REG05_NVM_VREFRESH | REG05_SLBRCHARGE(0x2) }, - { 0x06, REG06_XPSAVE | REG06_NT }, + { 0x06, REG06_NT }, { 0x07, 0 }, { 0x08, REG08_PANEL(0x1) | REG08_CLOCK_DIV(0x2) }, { 0x09, REG09_SUB_BRIGHT_R(0x20) }, @@ -183,8 +183,6 @@ static int y030xx067a_prepare(struct drm_panel *panel) goto err_disable_regulator; } - msleep(120); - return 0; err_disable_regulator: @@ -202,6 +200,30 @@ static int y030xx067a_unprepare(struct drm_panel *panel) return 0; } +static int y030xx067a_enable(struct drm_panel *panel) +{ + + struct y030xx067a *priv = to_y030xx067a(panel); + + regmap_set_bits(priv->map, 0x06, REG06_XPSAVE); + + if (panel->backlight) { + /* Wait for the picture to be ready before enabling backlight */ + msleep(120); + } + + return 0; +} + +static int y030xx067a_disable(struct drm_panel *panel) +{ + struct y030xx067a *priv = to_y030xx067a(panel); + + regmap_clear_bits(priv->map, 0x06, REG06_XPSAVE); + + return 0; +} + static int y030xx067a_get_modes(struct drm_panel *panel, struct drm_connector *connector) { @@ -239,6 +261,8 @@ static int y030xx067a_get_modes(struct drm_panel *panel, static const struct drm_panel_funcs y030xx067a_funcs = { .prepare = y030xx067a_prepare, .unprepare = y030xx067a_unprepare, + .enable = y030xx067a_enable, + .disable = y030xx067a_disable, .get_modes = y030xx067a_get_modes, }; @@ -246,6 +270,7 @@ static const struct regmap_config y030xx067a_regmap_config = { .reg_bits = 8, .val_bits = 8, .max_register = 0x15, + .cache_type = REGCACHE_FLAT, }; static int y030xx067a_probe(struct spi_device *spi) diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c b/drivers/gpu/drm/panel/panel-innolux-ej030na.c index c558de3f99be..6de7370185cd 100644 --- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c +++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c @@ -80,8 +80,6 @@ static const struct reg_sequence ej030na_init_sequence[] = { { 0x47, 0x08 }, { 0x48, 0x0f }, { 0x49, 0x0f }, - - { 0x2b, 0x01 }, }; static int ej030na_prepare(struct drm_panel *panel) @@ -109,8 +107,6 @@ static int ej030na_prepare(struct drm_panel *panel) goto err_disable_regulator; } - msleep(120); - return 0; err_disable_regulator: @@ -128,6 +124,31 @@ static int ej030na_unprepare(struct drm_panel *panel) return 0; } +static int ej030na_enable(struct drm_panel *panel) +{ + struct ej030na *priv = to_ej030na(panel); + + /* standby off */ + regmap_write(priv->map, 0x2b, 0x01); + + if (panel->backlight) { + /* Wait for the picture to be ready before enabling backlight */ + msleep(120); + } + + return 0; +} + +static int ej030na_disable(struct drm_panel *panel) +{ + struct ej030na *priv = to_ej030na(panel); + + /* standby on */ + regmap_write(priv->map, 0x2b, 0x00); + + return 0; +} + static int ej030na_get_modes(struct drm_panel *panel, struct drm_connector *connector) { @@ -165,6 +186,8 @@ static int ej030na_get_modes(struct drm_panel *panel, static const struct drm_panel_funcs ej030na_funcs = { .prepare = ej030na_prepare, .unprepare = ej030na_unprepare, + .enable = ej030na_enable, + .disable = ej030na_disable, .get_modes = ej030na_get_modes, }; -- 2.35.1 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable @ 2022-03-21 13:36 ` Christophe Branchereau 0 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 13:36 UTC (permalink / raw) To: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring Cc: devicetree, linux-kernel, dri-devel, linux-mips Following the introduction of bridge_atomic_enable in the ingenic drm driver, the crtc is enabled between .prepare and .enable, if it exists. Add it so the backlight is only enabled after the crtc is, to avoid graphical issues. Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> --- drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 +++++++++++++++++-- drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 ++++++++++++++++--- 2 files changed, 55 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c index f043b484055b..ddfacaeac1d4 100644 --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c @@ -140,7 +140,7 @@ static const struct reg_sequence y030xx067a_init_sequence[] = { { 0x03, REG03_VPOSITION(0x0a) }, { 0x04, REG04_HPOSITION1(0xd2) }, { 0x05, REG05_CLIP | REG05_NVM_VREFRESH | REG05_SLBRCHARGE(0x2) }, - { 0x06, REG06_XPSAVE | REG06_NT }, + { 0x06, REG06_NT }, { 0x07, 0 }, { 0x08, REG08_PANEL(0x1) | REG08_CLOCK_DIV(0x2) }, { 0x09, REG09_SUB_BRIGHT_R(0x20) }, @@ -183,8 +183,6 @@ static int y030xx067a_prepare(struct drm_panel *panel) goto err_disable_regulator; } - msleep(120); - return 0; err_disable_regulator: @@ -202,6 +200,30 @@ static int y030xx067a_unprepare(struct drm_panel *panel) return 0; } +static int y030xx067a_enable(struct drm_panel *panel) +{ + + struct y030xx067a *priv = to_y030xx067a(panel); + + regmap_set_bits(priv->map, 0x06, REG06_XPSAVE); + + if (panel->backlight) { + /* Wait for the picture to be ready before enabling backlight */ + msleep(120); + } + + return 0; +} + +static int y030xx067a_disable(struct drm_panel *panel) +{ + struct y030xx067a *priv = to_y030xx067a(panel); + + regmap_clear_bits(priv->map, 0x06, REG06_XPSAVE); + + return 0; +} + static int y030xx067a_get_modes(struct drm_panel *panel, struct drm_connector *connector) { @@ -239,6 +261,8 @@ static int y030xx067a_get_modes(struct drm_panel *panel, static const struct drm_panel_funcs y030xx067a_funcs = { .prepare = y030xx067a_prepare, .unprepare = y030xx067a_unprepare, + .enable = y030xx067a_enable, + .disable = y030xx067a_disable, .get_modes = y030xx067a_get_modes, }; @@ -246,6 +270,7 @@ static const struct regmap_config y030xx067a_regmap_config = { .reg_bits = 8, .val_bits = 8, .max_register = 0x15, + .cache_type = REGCACHE_FLAT, }; static int y030xx067a_probe(struct spi_device *spi) diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c b/drivers/gpu/drm/panel/panel-innolux-ej030na.c index c558de3f99be..6de7370185cd 100644 --- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c +++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c @@ -80,8 +80,6 @@ static const struct reg_sequence ej030na_init_sequence[] = { { 0x47, 0x08 }, { 0x48, 0x0f }, { 0x49, 0x0f }, - - { 0x2b, 0x01 }, }; static int ej030na_prepare(struct drm_panel *panel) @@ -109,8 +107,6 @@ static int ej030na_prepare(struct drm_panel *panel) goto err_disable_regulator; } - msleep(120); - return 0; err_disable_regulator: @@ -128,6 +124,31 @@ static int ej030na_unprepare(struct drm_panel *panel) return 0; } +static int ej030na_enable(struct drm_panel *panel) +{ + struct ej030na *priv = to_ej030na(panel); + + /* standby off */ + regmap_write(priv->map, 0x2b, 0x01); + + if (panel->backlight) { + /* Wait for the picture to be ready before enabling backlight */ + msleep(120); + } + + return 0; +} + +static int ej030na_disable(struct drm_panel *panel) +{ + struct ej030na *priv = to_ej030na(panel); + + /* standby on */ + regmap_write(priv->map, 0x2b, 0x00); + + return 0; +} + static int ej030na_get_modes(struct drm_panel *panel, struct drm_connector *connector) { @@ -165,6 +186,8 @@ static int ej030na_get_modes(struct drm_panel *panel, static const struct drm_panel_funcs ej030na_funcs = { .prepare = ej030na_prepare, .unprepare = ej030na_unprepare, + .enable = ej030na_enable, + .disable = ej030na_disable, .get_modes = ej030na_get_modes, }; -- 2.35.1 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable 2022-03-21 13:36 ` Christophe Branchereau @ 2022-03-21 14:21 ` Paul Cercueil -1 siblings, 0 replies; 22+ messages in thread From: Paul Cercueil @ 2022-03-21 14:21 UTC (permalink / raw) To: Christophe Branchereau Cc: devicetree, David Airlie, linux-kernel, dri-devel, linux-mips, Rob Herring, Thierry Reding, Sam Ravnborg Hi Christophe, Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau <cbranchereau@gmail.com> a écrit : > Following the introduction of bridge_atomic_enable in the ingenic > drm driver, the crtc is enabled between .prepare and .enable, if > it exists. > > Add it so the backlight is only enabled after the crtc is, to avoid > graphical issues. > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> Didn't Sam acked it? > --- > drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 > +++++++++++++++++-- > drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 > ++++++++++++++++--- > 2 files changed, 55 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > index f043b484055b..ddfacaeac1d4 100644 > --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > @@ -140,7 +140,7 @@ static const struct reg_sequence > y030xx067a_init_sequence[] = { > { 0x03, REG03_VPOSITION(0x0a) }, > { 0x04, REG04_HPOSITION1(0xd2) }, > { 0x05, REG05_CLIP | REG05_NVM_VREFRESH | REG05_SLBRCHARGE(0x2) }, > - { 0x06, REG06_XPSAVE | REG06_NT }, > + { 0x06, REG06_NT }, > { 0x07, 0 }, > { 0x08, REG08_PANEL(0x1) | REG08_CLOCK_DIV(0x2) }, > { 0x09, REG09_SUB_BRIGHT_R(0x20) }, > @@ -183,8 +183,6 @@ static int y030xx067a_prepare(struct drm_panel > *panel) > goto err_disable_regulator; > } > > - msleep(120); > - > return 0; > > err_disable_regulator: > @@ -202,6 +200,30 @@ static int y030xx067a_unprepare(struct drm_panel > *panel) > return 0; > } > > +static int y030xx067a_enable(struct drm_panel *panel) > +{ > + > + struct y030xx067a *priv = to_y030xx067a(panel); > + > + regmap_set_bits(priv->map, 0x06, REG06_XPSAVE); > + > + if (panel->backlight) { > + /* Wait for the picture to be ready before enabling backlight */ > + msleep(120); > + } > + > + return 0; > +} > + > +static int y030xx067a_disable(struct drm_panel *panel) > +{ > + struct y030xx067a *priv = to_y030xx067a(panel); > + > + regmap_clear_bits(priv->map, 0x06, REG06_XPSAVE); > + > + return 0; > +} > + > static int y030xx067a_get_modes(struct drm_panel *panel, > struct drm_connector *connector) > { > @@ -239,6 +261,8 @@ static int y030xx067a_get_modes(struct drm_panel > *panel, > static const struct drm_panel_funcs y030xx067a_funcs = { > .prepare = y030xx067a_prepare, > .unprepare = y030xx067a_unprepare, > + .enable = y030xx067a_enable, > + .disable = y030xx067a_disable, > .get_modes = y030xx067a_get_modes, > }; > > @@ -246,6 +270,7 @@ static const struct regmap_config > y030xx067a_regmap_config = { > .reg_bits = 8, > .val_bits = 8, > .max_register = 0x15, > + .cache_type = REGCACHE_FLAT, I understand that this is added because the panel registers are write-only and read as zero, and it is needed for regmap_{clear,set}_bits to work. This information should definitely be added to the commit message. If you can add it inline here, and I'll update the commit message when applying the patch. Cheers, -Paul > }; > > static int y030xx067a_probe(struct spi_device *spi) > diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > index c558de3f99be..6de7370185cd 100644 > --- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > +++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > @@ -80,8 +80,6 @@ static const struct reg_sequence > ej030na_init_sequence[] = { > { 0x47, 0x08 }, > { 0x48, 0x0f }, > { 0x49, 0x0f }, > - > - { 0x2b, 0x01 }, > }; > > static int ej030na_prepare(struct drm_panel *panel) > @@ -109,8 +107,6 @@ static int ej030na_prepare(struct drm_panel > *panel) > goto err_disable_regulator; > } > > - msleep(120); > - > return 0; > > err_disable_regulator: > @@ -128,6 +124,31 @@ static int ej030na_unprepare(struct drm_panel > *panel) > return 0; > } > > +static int ej030na_enable(struct drm_panel *panel) > +{ > + struct ej030na *priv = to_ej030na(panel); > + > + /* standby off */ > + regmap_write(priv->map, 0x2b, 0x01); > + > + if (panel->backlight) { > + /* Wait for the picture to be ready before enabling backlight */ > + msleep(120); > + } > + > + return 0; > +} > + > +static int ej030na_disable(struct drm_panel *panel) > +{ > + struct ej030na *priv = to_ej030na(panel); > + > + /* standby on */ > + regmap_write(priv->map, 0x2b, 0x00); > + > + return 0; > +} > + > static int ej030na_get_modes(struct drm_panel *panel, > struct drm_connector *connector) > { > @@ -165,6 +186,8 @@ static int ej030na_get_modes(struct drm_panel > *panel, > static const struct drm_panel_funcs ej030na_funcs = { > .prepare = ej030na_prepare, > .unprepare = ej030na_unprepare, > + .enable = ej030na_enable, > + .disable = ej030na_disable, > .get_modes = ej030na_get_modes, > }; > > -- > 2.35.1 > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable @ 2022-03-21 14:21 ` Paul Cercueil 0 siblings, 0 replies; 22+ messages in thread From: Paul Cercueil @ 2022-03-21 14:21 UTC (permalink / raw) To: Christophe Branchereau Cc: David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring, linux-kernel, linux-mips, dri-devel, devicetree Hi Christophe, Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau <cbranchereau@gmail.com> a écrit : > Following the introduction of bridge_atomic_enable in the ingenic > drm driver, the crtc is enabled between .prepare and .enable, if > it exists. > > Add it so the backlight is only enabled after the crtc is, to avoid > graphical issues. > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> Didn't Sam acked it? > --- > drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 > +++++++++++++++++-- > drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 > ++++++++++++++++--- > 2 files changed, 55 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > index f043b484055b..ddfacaeac1d4 100644 > --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > @@ -140,7 +140,7 @@ static const struct reg_sequence > y030xx067a_init_sequence[] = { > { 0x03, REG03_VPOSITION(0x0a) }, > { 0x04, REG04_HPOSITION1(0xd2) }, > { 0x05, REG05_CLIP | REG05_NVM_VREFRESH | REG05_SLBRCHARGE(0x2) }, > - { 0x06, REG06_XPSAVE | REG06_NT }, > + { 0x06, REG06_NT }, > { 0x07, 0 }, > { 0x08, REG08_PANEL(0x1) | REG08_CLOCK_DIV(0x2) }, > { 0x09, REG09_SUB_BRIGHT_R(0x20) }, > @@ -183,8 +183,6 @@ static int y030xx067a_prepare(struct drm_panel > *panel) > goto err_disable_regulator; > } > > - msleep(120); > - > return 0; > > err_disable_regulator: > @@ -202,6 +200,30 @@ static int y030xx067a_unprepare(struct drm_panel > *panel) > return 0; > } > > +static int y030xx067a_enable(struct drm_panel *panel) > +{ > + > + struct y030xx067a *priv = to_y030xx067a(panel); > + > + regmap_set_bits(priv->map, 0x06, REG06_XPSAVE); > + > + if (panel->backlight) { > + /* Wait for the picture to be ready before enabling backlight */ > + msleep(120); > + } > + > + return 0; > +} > + > +static int y030xx067a_disable(struct drm_panel *panel) > +{ > + struct y030xx067a *priv = to_y030xx067a(panel); > + > + regmap_clear_bits(priv->map, 0x06, REG06_XPSAVE); > + > + return 0; > +} > + > static int y030xx067a_get_modes(struct drm_panel *panel, > struct drm_connector *connector) > { > @@ -239,6 +261,8 @@ static int y030xx067a_get_modes(struct drm_panel > *panel, > static const struct drm_panel_funcs y030xx067a_funcs = { > .prepare = y030xx067a_prepare, > .unprepare = y030xx067a_unprepare, > + .enable = y030xx067a_enable, > + .disable = y030xx067a_disable, > .get_modes = y030xx067a_get_modes, > }; > > @@ -246,6 +270,7 @@ static const struct regmap_config > y030xx067a_regmap_config = { > .reg_bits = 8, > .val_bits = 8, > .max_register = 0x15, > + .cache_type = REGCACHE_FLAT, I understand that this is added because the panel registers are write-only and read as zero, and it is needed for regmap_{clear,set}_bits to work. This information should definitely be added to the commit message. If you can add it inline here, and I'll update the commit message when applying the patch. Cheers, -Paul > }; > > static int y030xx067a_probe(struct spi_device *spi) > diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > index c558de3f99be..6de7370185cd 100644 > --- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > +++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > @@ -80,8 +80,6 @@ static const struct reg_sequence > ej030na_init_sequence[] = { > { 0x47, 0x08 }, > { 0x48, 0x0f }, > { 0x49, 0x0f }, > - > - { 0x2b, 0x01 }, > }; > > static int ej030na_prepare(struct drm_panel *panel) > @@ -109,8 +107,6 @@ static int ej030na_prepare(struct drm_panel > *panel) > goto err_disable_regulator; > } > > - msleep(120); > - > return 0; > > err_disable_regulator: > @@ -128,6 +124,31 @@ static int ej030na_unprepare(struct drm_panel > *panel) > return 0; > } > > +static int ej030na_enable(struct drm_panel *panel) > +{ > + struct ej030na *priv = to_ej030na(panel); > + > + /* standby off */ > + regmap_write(priv->map, 0x2b, 0x01); > + > + if (panel->backlight) { > + /* Wait for the picture to be ready before enabling backlight */ > + msleep(120); > + } > + > + return 0; > +} > + > +static int ej030na_disable(struct drm_panel *panel) > +{ > + struct ej030na *priv = to_ej030na(panel); > + > + /* standby on */ > + regmap_write(priv->map, 0x2b, 0x00); > + > + return 0; > +} > + > static int ej030na_get_modes(struct drm_panel *panel, > struct drm_connector *connector) > { > @@ -165,6 +186,8 @@ static int ej030na_get_modes(struct drm_panel > *panel, > static const struct drm_panel_funcs ej030na_funcs = { > .prepare = ej030na_prepare, > .unprepare = ej030na_unprepare, > + .enable = ej030na_enable, > + .disable = ej030na_disable, > .get_modes = ej030na_get_modes, > }; > > -- > 2.35.1 > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable 2022-03-21 14:21 ` Paul Cercueil @ 2022-03-21 14:39 ` Christophe Branchereau -1 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 14:39 UTC (permalink / raw) To: Paul Cercueil Cc: David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring, linux-kernel, linux-mips, dri-devel, devicetree Following the introduction of bridge_atomic_enable in the ingenic drm driver, the crtc is enabled between .prepare and .enable, if it exists. Add it so the backlight is only enabled after the crtc is, to avoid graphical issues. As we're moving the "sleep in" command out of the init sequence into .enable for the ABT, we need to switch the regmap cache to REGCACHE_FLAT to be able to use regmap_set_bits, given this panel registers are write-ony and read as 0. On Mon, Mar 21, 2022 at 3:21 PM Paul Cercueil <paul@crapouillou.net> wrote: > > Hi Christophe, > > Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau > <cbranchereau@gmail.com> a écrit : > > Following the introduction of bridge_atomic_enable in the ingenic > > drm driver, the crtc is enabled between .prepare and .enable, if > > it exists. > > > > Add it so the backlight is only enabled after the crtc is, to avoid > > graphical issues. > > > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > > Didn't Sam acked it? > > > --- > > drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 > > +++++++++++++++++-- > > drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 > > ++++++++++++++++--- > > 2 files changed, 55 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > index f043b484055b..ddfacaeac1d4 100644 > > --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > @@ -140,7 +140,7 @@ static const struct reg_sequence > > y030xx067a_init_sequence[] = { > > { 0x03, REG03_VPOSITION(0x0a) }, > > { 0x04, REG04_HPOSITION1(0xd2) }, > > { 0x05, REG05_CLIP | REG05_NVM_VREFRESH | REG05_SLBRCHARGE(0x2) }, > > - { 0x06, REG06_XPSAVE | REG06_NT }, > > + { 0x06, REG06_NT }, > > { 0x07, 0 }, > > { 0x08, REG08_PANEL(0x1) | REG08_CLOCK_DIV(0x2) }, > > { 0x09, REG09_SUB_BRIGHT_R(0x20) }, > > @@ -183,8 +183,6 @@ static int y030xx067a_prepare(struct drm_panel > > *panel) > > goto err_disable_regulator; > > } > > > > - msleep(120); > > - > > return 0; > > > > err_disable_regulator: > > @@ -202,6 +200,30 @@ static int y030xx067a_unprepare(struct drm_panel > > *panel) > > return 0; > > } > > > > +static int y030xx067a_enable(struct drm_panel *panel) > > +{ > > + > > + struct y030xx067a *priv = to_y030xx067a(panel); > > + > > + regmap_set_bits(priv->map, 0x06, REG06_XPSAVE); > > + > > + if (panel->backlight) { > > + /* Wait for the picture to be ready before enabling backlight */ > > + msleep(120); > > + } > > + > > + return 0; > > +} > > + > > +static int y030xx067a_disable(struct drm_panel *panel) > > +{ > > + struct y030xx067a *priv = to_y030xx067a(panel); > > + > > + regmap_clear_bits(priv->map, 0x06, REG06_XPSAVE); > > + > > + return 0; > > +} > > + > > static int y030xx067a_get_modes(struct drm_panel *panel, > > struct drm_connector *connector) > > { > > @@ -239,6 +261,8 @@ static int y030xx067a_get_modes(struct drm_panel > > *panel, > > static const struct drm_panel_funcs y030xx067a_funcs = { > > .prepare = y030xx067a_prepare, > > .unprepare = y030xx067a_unprepare, > > + .enable = y030xx067a_enable, > > + .disable = y030xx067a_disable, > > .get_modes = y030xx067a_get_modes, > > }; > > > > @@ -246,6 +270,7 @@ static const struct regmap_config > > y030xx067a_regmap_config = { > > .reg_bits = 8, > > .val_bits = 8, > > .max_register = 0x15, > > + .cache_type = REGCACHE_FLAT, > > I understand that this is added because the panel registers are > write-only and read as zero, and it is needed for > regmap_{clear,set}_bits to work. > > This information should definitely be added to the commit message. > > If you can add it inline here, and I'll update the commit message when > applying the patch. > > Cheers, > -Paul > > > }; > > > > static int y030xx067a_probe(struct spi_device *spi) > > diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > index c558de3f99be..6de7370185cd 100644 > > --- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > +++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > @@ -80,8 +80,6 @@ static const struct reg_sequence > > ej030na_init_sequence[] = { > > { 0x47, 0x08 }, > > { 0x48, 0x0f }, > > { 0x49, 0x0f }, > > - > > - { 0x2b, 0x01 }, > > }; > > > > static int ej030na_prepare(struct drm_panel *panel) > > @@ -109,8 +107,6 @@ static int ej030na_prepare(struct drm_panel > > *panel) > > goto err_disable_regulator; > > } > > > > - msleep(120); > > - > > return 0; > > > > err_disable_regulator: > > @@ -128,6 +124,31 @@ static int ej030na_unprepare(struct drm_panel > > *panel) > > return 0; > > } > > > > +static int ej030na_enable(struct drm_panel *panel) > > +{ > > + struct ej030na *priv = to_ej030na(panel); > > + > > + /* standby off */ > > + regmap_write(priv->map, 0x2b, 0x01); > > + > > + if (panel->backlight) { > > + /* Wait for the picture to be ready before enabling backlight */ > > + msleep(120); > > + } > > + > > + return 0; > > +} > > + > > +static int ej030na_disable(struct drm_panel *panel) > > +{ > > + struct ej030na *priv = to_ej030na(panel); > > + > > + /* standby on */ > > + regmap_write(priv->map, 0x2b, 0x00); > > + > > + return 0; > > +} > > + > > static int ej030na_get_modes(struct drm_panel *panel, > > struct drm_connector *connector) > > { > > @@ -165,6 +186,8 @@ static int ej030na_get_modes(struct drm_panel > > *panel, > > static const struct drm_panel_funcs ej030na_funcs = { > > .prepare = ej030na_prepare, > > .unprepare = ej030na_unprepare, > > + .enable = ej030na_enable, > > + .disable = ej030na_disable, > > .get_modes = ej030na_get_modes, > > }; > > > > -- > > 2.35.1 > > > > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable @ 2022-03-21 14:39 ` Christophe Branchereau 0 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 14:39 UTC (permalink / raw) To: Paul Cercueil Cc: devicetree, David Airlie, linux-kernel, dri-devel, linux-mips, Rob Herring, Thierry Reding, Sam Ravnborg Following the introduction of bridge_atomic_enable in the ingenic drm driver, the crtc is enabled between .prepare and .enable, if it exists. Add it so the backlight is only enabled after the crtc is, to avoid graphical issues. As we're moving the "sleep in" command out of the init sequence into .enable for the ABT, we need to switch the regmap cache to REGCACHE_FLAT to be able to use regmap_set_bits, given this panel registers are write-ony and read as 0. On Mon, Mar 21, 2022 at 3:21 PM Paul Cercueil <paul@crapouillou.net> wrote: > > Hi Christophe, > > Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau > <cbranchereau@gmail.com> a écrit : > > Following the introduction of bridge_atomic_enable in the ingenic > > drm driver, the crtc is enabled between .prepare and .enable, if > > it exists. > > > > Add it so the backlight is only enabled after the crtc is, to avoid > > graphical issues. > > > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > > Didn't Sam acked it? > > > --- > > drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 > > +++++++++++++++++-- > > drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 > > ++++++++++++++++--- > > 2 files changed, 55 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > index f043b484055b..ddfacaeac1d4 100644 > > --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > @@ -140,7 +140,7 @@ static const struct reg_sequence > > y030xx067a_init_sequence[] = { > > { 0x03, REG03_VPOSITION(0x0a) }, > > { 0x04, REG04_HPOSITION1(0xd2) }, > > { 0x05, REG05_CLIP | REG05_NVM_VREFRESH | REG05_SLBRCHARGE(0x2) }, > > - { 0x06, REG06_XPSAVE | REG06_NT }, > > + { 0x06, REG06_NT }, > > { 0x07, 0 }, > > { 0x08, REG08_PANEL(0x1) | REG08_CLOCK_DIV(0x2) }, > > { 0x09, REG09_SUB_BRIGHT_R(0x20) }, > > @@ -183,8 +183,6 @@ static int y030xx067a_prepare(struct drm_panel > > *panel) > > goto err_disable_regulator; > > } > > > > - msleep(120); > > - > > return 0; > > > > err_disable_regulator: > > @@ -202,6 +200,30 @@ static int y030xx067a_unprepare(struct drm_panel > > *panel) > > return 0; > > } > > > > +static int y030xx067a_enable(struct drm_panel *panel) > > +{ > > + > > + struct y030xx067a *priv = to_y030xx067a(panel); > > + > > + regmap_set_bits(priv->map, 0x06, REG06_XPSAVE); > > + > > + if (panel->backlight) { > > + /* Wait for the picture to be ready before enabling backlight */ > > + msleep(120); > > + } > > + > > + return 0; > > +} > > + > > +static int y030xx067a_disable(struct drm_panel *panel) > > +{ > > + struct y030xx067a *priv = to_y030xx067a(panel); > > + > > + regmap_clear_bits(priv->map, 0x06, REG06_XPSAVE); > > + > > + return 0; > > +} > > + > > static int y030xx067a_get_modes(struct drm_panel *panel, > > struct drm_connector *connector) > > { > > @@ -239,6 +261,8 @@ static int y030xx067a_get_modes(struct drm_panel > > *panel, > > static const struct drm_panel_funcs y030xx067a_funcs = { > > .prepare = y030xx067a_prepare, > > .unprepare = y030xx067a_unprepare, > > + .enable = y030xx067a_enable, > > + .disable = y030xx067a_disable, > > .get_modes = y030xx067a_get_modes, > > }; > > > > @@ -246,6 +270,7 @@ static const struct regmap_config > > y030xx067a_regmap_config = { > > .reg_bits = 8, > > .val_bits = 8, > > .max_register = 0x15, > > + .cache_type = REGCACHE_FLAT, > > I understand that this is added because the panel registers are > write-only and read as zero, and it is needed for > regmap_{clear,set}_bits to work. > > This information should definitely be added to the commit message. > > If you can add it inline here, and I'll update the commit message when > applying the patch. > > Cheers, > -Paul > > > }; > > > > static int y030xx067a_probe(struct spi_device *spi) > > diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > index c558de3f99be..6de7370185cd 100644 > > --- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > +++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > @@ -80,8 +80,6 @@ static const struct reg_sequence > > ej030na_init_sequence[] = { > > { 0x47, 0x08 }, > > { 0x48, 0x0f }, > > { 0x49, 0x0f }, > > - > > - { 0x2b, 0x01 }, > > }; > > > > static int ej030na_prepare(struct drm_panel *panel) > > @@ -109,8 +107,6 @@ static int ej030na_prepare(struct drm_panel > > *panel) > > goto err_disable_regulator; > > } > > > > - msleep(120); > > - > > return 0; > > > > err_disable_regulator: > > @@ -128,6 +124,31 @@ static int ej030na_unprepare(struct drm_panel > > *panel) > > return 0; > > } > > > > +static int ej030na_enable(struct drm_panel *panel) > > +{ > > + struct ej030na *priv = to_ej030na(panel); > > + > > + /* standby off */ > > + regmap_write(priv->map, 0x2b, 0x01); > > + > > + if (panel->backlight) { > > + /* Wait for the picture to be ready before enabling backlight */ > > + msleep(120); > > + } > > + > > + return 0; > > +} > > + > > +static int ej030na_disable(struct drm_panel *panel) > > +{ > > + struct ej030na *priv = to_ej030na(panel); > > + > > + /* standby on */ > > + regmap_write(priv->map, 0x2b, 0x00); > > + > > + return 0; > > +} > > + > > static int ej030na_get_modes(struct drm_panel *panel, > > struct drm_connector *connector) > > { > > @@ -165,6 +186,8 @@ static int ej030na_get_modes(struct drm_panel > > *panel, > > static const struct drm_panel_funcs ej030na_funcs = { > > .prepare = ej030na_prepare, > > .unprepare = ej030na_unprepare, > > + .enable = ej030na_enable, > > + .disable = ej030na_disable, > > .get_modes = ej030na_get_modes, > > }; > > > > -- > > 2.35.1 > > > > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable 2022-03-21 14:39 ` Christophe Branchereau @ 2022-03-21 14:42 ` Christophe Branchereau -1 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 14:42 UTC (permalink / raw) To: Paul Cercueil Cc: David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring, linux-kernel, linux-mips, dri-devel, devicetree Sorry I meant "sleep out" not "sleep in" obviously On Mon, Mar 21, 2022 at 3:39 PM Christophe Branchereau <cbranchereau@gmail.com> wrote: > > Following the introduction of bridge_atomic_enable in the ingenic > drm driver, the crtc is enabled between .prepare and .enable, if > it exists. Add it so the backlight is only enabled after the crtc is, to > avoid graphical issues. > > As we're moving the "sleep in" command out of the init sequence > into .enable for the ABT, we need to switch the regmap cache > to REGCACHE_FLAT to be able to use regmap_set_bits, given this > panel registers are write-ony and read as 0. > > On Mon, Mar 21, 2022 at 3:21 PM Paul Cercueil <paul@crapouillou.net> wrote: > > > > Hi Christophe, > > > > Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau > > <cbranchereau@gmail.com> a écrit : > > > Following the introduction of bridge_atomic_enable in the ingenic > > > drm driver, the crtc is enabled between .prepare and .enable, if > > > it exists. > > > > > > Add it so the backlight is only enabled after the crtc is, to avoid > > > graphical issues. > > > > > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > > > > Didn't Sam acked it? > > > > > --- > > > drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 > > > +++++++++++++++++-- > > > drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 > > > ++++++++++++++++--- > > > 2 files changed, 55 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > > b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > > index f043b484055b..ddfacaeac1d4 100644 > > > --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > > +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > > @@ -140,7 +140,7 @@ static const struct reg_sequence > > > y030xx067a_init_sequence[] = { > > > { 0x03, REG03_VPOSITION(0x0a) }, > > > { 0x04, REG04_HPOSITION1(0xd2) }, > > > { 0x05, REG05_CLIP | REG05_NVM_VREFRESH | REG05_SLBRCHARGE(0x2) }, > > > - { 0x06, REG06_XPSAVE | REG06_NT }, > > > + { 0x06, REG06_NT }, > > > { 0x07, 0 }, > > > { 0x08, REG08_PANEL(0x1) | REG08_CLOCK_DIV(0x2) }, > > > { 0x09, REG09_SUB_BRIGHT_R(0x20) }, > > > @@ -183,8 +183,6 @@ static int y030xx067a_prepare(struct drm_panel > > > *panel) > > > goto err_disable_regulator; > > > } > > > > > > - msleep(120); > > > - > > > return 0; > > > > > > err_disable_regulator: > > > @@ -202,6 +200,30 @@ static int y030xx067a_unprepare(struct drm_panel > > > *panel) > > > return 0; > > > } > > > > > > +static int y030xx067a_enable(struct drm_panel *panel) > > > +{ > > > + > > > + struct y030xx067a *priv = to_y030xx067a(panel); > > > + > > > + regmap_set_bits(priv->map, 0x06, REG06_XPSAVE); > > > + > > > + if (panel->backlight) { > > > + /* Wait for the picture to be ready before enabling backlight */ > > > + msleep(120); > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int y030xx067a_disable(struct drm_panel *panel) > > > +{ > > > + struct y030xx067a *priv = to_y030xx067a(panel); > > > + > > > + regmap_clear_bits(priv->map, 0x06, REG06_XPSAVE); > > > + > > > + return 0; > > > +} > > > + > > > static int y030xx067a_get_modes(struct drm_panel *panel, > > > struct drm_connector *connector) > > > { > > > @@ -239,6 +261,8 @@ static int y030xx067a_get_modes(struct drm_panel > > > *panel, > > > static const struct drm_panel_funcs y030xx067a_funcs = { > > > .prepare = y030xx067a_prepare, > > > .unprepare = y030xx067a_unprepare, > > > + .enable = y030xx067a_enable, > > > + .disable = y030xx067a_disable, > > > .get_modes = y030xx067a_get_modes, > > > }; > > > > > > @@ -246,6 +270,7 @@ static const struct regmap_config > > > y030xx067a_regmap_config = { > > > .reg_bits = 8, > > > .val_bits = 8, > > > .max_register = 0x15, > > > + .cache_type = REGCACHE_FLAT, > > > > I understand that this is added because the panel registers are > > write-only and read as zero, and it is needed for > > regmap_{clear,set}_bits to work. > > > > This information should definitely be added to the commit message. > > > > If you can add it inline here, and I'll update the commit message when > > applying the patch. > > > > Cheers, > > -Paul > > > > > }; > > > > > > static int y030xx067a_probe(struct spi_device *spi) > > > diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > > b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > > index c558de3f99be..6de7370185cd 100644 > > > --- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > > +++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > > @@ -80,8 +80,6 @@ static const struct reg_sequence > > > ej030na_init_sequence[] = { > > > { 0x47, 0x08 }, > > > { 0x48, 0x0f }, > > > { 0x49, 0x0f }, > > > - > > > - { 0x2b, 0x01 }, > > > }; > > > > > > static int ej030na_prepare(struct drm_panel *panel) > > > @@ -109,8 +107,6 @@ static int ej030na_prepare(struct drm_panel > > > *panel) > > > goto err_disable_regulator; > > > } > > > > > > - msleep(120); > > > - > > > return 0; > > > > > > err_disable_regulator: > > > @@ -128,6 +124,31 @@ static int ej030na_unprepare(struct drm_panel > > > *panel) > > > return 0; > > > } > > > > > > +static int ej030na_enable(struct drm_panel *panel) > > > +{ > > > + struct ej030na *priv = to_ej030na(panel); > > > + > > > + /* standby off */ > > > + regmap_write(priv->map, 0x2b, 0x01); > > > + > > > + if (panel->backlight) { > > > + /* Wait for the picture to be ready before enabling backlight */ > > > + msleep(120); > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int ej030na_disable(struct drm_panel *panel) > > > +{ > > > + struct ej030na *priv = to_ej030na(panel); > > > + > > > + /* standby on */ > > > + regmap_write(priv->map, 0x2b, 0x00); > > > + > > > + return 0; > > > +} > > > + > > > static int ej030na_get_modes(struct drm_panel *panel, > > > struct drm_connector *connector) > > > { > > > @@ -165,6 +186,8 @@ static int ej030na_get_modes(struct drm_panel > > > *panel, > > > static const struct drm_panel_funcs ej030na_funcs = { > > > .prepare = ej030na_prepare, > > > .unprepare = ej030na_unprepare, > > > + .enable = ej030na_enable, > > > + .disable = ej030na_disable, > > > .get_modes = ej030na_get_modes, > > > }; > > > > > > -- > > > 2.35.1 > > > > > > > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable @ 2022-03-21 14:42 ` Christophe Branchereau 0 siblings, 0 replies; 22+ messages in thread From: Christophe Branchereau @ 2022-03-21 14:42 UTC (permalink / raw) To: Paul Cercueil Cc: devicetree, David Airlie, linux-kernel, dri-devel, linux-mips, Rob Herring, Thierry Reding, Sam Ravnborg Sorry I meant "sleep out" not "sleep in" obviously On Mon, Mar 21, 2022 at 3:39 PM Christophe Branchereau <cbranchereau@gmail.com> wrote: > > Following the introduction of bridge_atomic_enable in the ingenic > drm driver, the crtc is enabled between .prepare and .enable, if > it exists. Add it so the backlight is only enabled after the crtc is, to > avoid graphical issues. > > As we're moving the "sleep in" command out of the init sequence > into .enable for the ABT, we need to switch the regmap cache > to REGCACHE_FLAT to be able to use regmap_set_bits, given this > panel registers are write-ony and read as 0. > > On Mon, Mar 21, 2022 at 3:21 PM Paul Cercueil <paul@crapouillou.net> wrote: > > > > Hi Christophe, > > > > Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau > > <cbranchereau@gmail.com> a écrit : > > > Following the introduction of bridge_atomic_enable in the ingenic > > > drm driver, the crtc is enabled between .prepare and .enable, if > > > it exists. > > > > > > Add it so the backlight is only enabled after the crtc is, to avoid > > > graphical issues. > > > > > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > > > > Didn't Sam acked it? > > > > > --- > > > drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 > > > +++++++++++++++++-- > > > drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 > > > ++++++++++++++++--- > > > 2 files changed, 55 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > > b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > > index f043b484055b..ddfacaeac1d4 100644 > > > --- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > > +++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c > > > @@ -140,7 +140,7 @@ static const struct reg_sequence > > > y030xx067a_init_sequence[] = { > > > { 0x03, REG03_VPOSITION(0x0a) }, > > > { 0x04, REG04_HPOSITION1(0xd2) }, > > > { 0x05, REG05_CLIP | REG05_NVM_VREFRESH | REG05_SLBRCHARGE(0x2) }, > > > - { 0x06, REG06_XPSAVE | REG06_NT }, > > > + { 0x06, REG06_NT }, > > > { 0x07, 0 }, > > > { 0x08, REG08_PANEL(0x1) | REG08_CLOCK_DIV(0x2) }, > > > { 0x09, REG09_SUB_BRIGHT_R(0x20) }, > > > @@ -183,8 +183,6 @@ static int y030xx067a_prepare(struct drm_panel > > > *panel) > > > goto err_disable_regulator; > > > } > > > > > > - msleep(120); > > > - > > > return 0; > > > > > > err_disable_regulator: > > > @@ -202,6 +200,30 @@ static int y030xx067a_unprepare(struct drm_panel > > > *panel) > > > return 0; > > > } > > > > > > +static int y030xx067a_enable(struct drm_panel *panel) > > > +{ > > > + > > > + struct y030xx067a *priv = to_y030xx067a(panel); > > > + > > > + regmap_set_bits(priv->map, 0x06, REG06_XPSAVE); > > > + > > > + if (panel->backlight) { > > > + /* Wait for the picture to be ready before enabling backlight */ > > > + msleep(120); > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int y030xx067a_disable(struct drm_panel *panel) > > > +{ > > > + struct y030xx067a *priv = to_y030xx067a(panel); > > > + > > > + regmap_clear_bits(priv->map, 0x06, REG06_XPSAVE); > > > + > > > + return 0; > > > +} > > > + > > > static int y030xx067a_get_modes(struct drm_panel *panel, > > > struct drm_connector *connector) > > > { > > > @@ -239,6 +261,8 @@ static int y030xx067a_get_modes(struct drm_panel > > > *panel, > > > static const struct drm_panel_funcs y030xx067a_funcs = { > > > .prepare = y030xx067a_prepare, > > > .unprepare = y030xx067a_unprepare, > > > + .enable = y030xx067a_enable, > > > + .disable = y030xx067a_disable, > > > .get_modes = y030xx067a_get_modes, > > > }; > > > > > > @@ -246,6 +270,7 @@ static const struct regmap_config > > > y030xx067a_regmap_config = { > > > .reg_bits = 8, > > > .val_bits = 8, > > > .max_register = 0x15, > > > + .cache_type = REGCACHE_FLAT, > > > > I understand that this is added because the panel registers are > > write-only and read as zero, and it is needed for > > regmap_{clear,set}_bits to work. > > > > This information should definitely be added to the commit message. > > > > If you can add it inline here, and I'll update the commit message when > > applying the patch. > > > > Cheers, > > -Paul > > > > > }; > > > > > > static int y030xx067a_probe(struct spi_device *spi) > > > diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > > b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > > index c558de3f99be..6de7370185cd 100644 > > > --- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > > +++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c > > > @@ -80,8 +80,6 @@ static const struct reg_sequence > > > ej030na_init_sequence[] = { > > > { 0x47, 0x08 }, > > > { 0x48, 0x0f }, > > > { 0x49, 0x0f }, > > > - > > > - { 0x2b, 0x01 }, > > > }; > > > > > > static int ej030na_prepare(struct drm_panel *panel) > > > @@ -109,8 +107,6 @@ static int ej030na_prepare(struct drm_panel > > > *panel) > > > goto err_disable_regulator; > > > } > > > > > > - msleep(120); > > > - > > > return 0; > > > > > > err_disable_regulator: > > > @@ -128,6 +124,31 @@ static int ej030na_unprepare(struct drm_panel > > > *panel) > > > return 0; > > > } > > > > > > +static int ej030na_enable(struct drm_panel *panel) > > > +{ > > > + struct ej030na *priv = to_ej030na(panel); > > > + > > > + /* standby off */ > > > + regmap_write(priv->map, 0x2b, 0x01); > > > + > > > + if (panel->backlight) { > > > + /* Wait for the picture to be ready before enabling backlight */ > > > + msleep(120); > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int ej030na_disable(struct drm_panel *panel) > > > +{ > > > + struct ej030na *priv = to_ej030na(panel); > > > + > > > + /* standby on */ > > > + regmap_write(priv->map, 0x2b, 0x00); > > > + > > > + return 0; > > > +} > > > + > > > static int ej030na_get_modes(struct drm_panel *panel, > > > struct drm_connector *connector) > > > { > > > @@ -165,6 +186,8 @@ static int ej030na_get_modes(struct drm_panel > > > *panel, > > > static const struct drm_panel_funcs ej030na_funcs = { > > > .prepare = ej030na_prepare, > > > .unprepare = ej030na_unprepare, > > > + .enable = ej030na_enable, > > > + .disable = ej030na_disable, > > > .get_modes = ej030na_get_modes, > > > }; > > > > > > -- > > > 2.35.1 > > > > > > > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable 2022-03-21 14:42 ` Christophe Branchereau @ 2022-03-27 19:45 ` Sam Ravnborg -1 siblings, 0 replies; 22+ messages in thread From: Sam Ravnborg @ 2022-03-27 19:45 UTC (permalink / raw) To: Christophe Branchereau Cc: Paul Cercueil, David Airlie, Daniel Vetter, Thierry Reding, Rob Herring, linux-kernel, linux-mips, dri-devel, devicetree Hi Christophe, On Mon, Mar 21, 2022 at 03:42:08PM +0100, Christophe Branchereau wrote: > Sorry I meant "sleep out" not "sleep in" obviously > > On Mon, Mar 21, 2022 at 3:39 PM Christophe Branchereau > <cbranchereau@gmail.com> wrote: > > > > Following the introduction of bridge_atomic_enable in the ingenic > > drm driver, the crtc is enabled between .prepare and .enable, if > > it exists. Add it so the backlight is only enabled after the crtc is, to > > avoid graphical issues. > > > > As we're moving the "sleep in" command out of the init sequence > > into .enable for the ABT, we need to switch the regmap cache > > to REGCACHE_FLAT to be able to use regmap_set_bits, given this > > panel registers are write-ony and read as 0. > > > > On Mon, Mar 21, 2022 at 3:21 PM Paul Cercueil <paul@crapouillou.net> wrote: > > > > > > Hi Christophe, > > > > > > Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau > > > <cbranchereau@gmail.com> a écrit : > > > > Following the introduction of bridge_atomic_enable in the ingenic > > > > drm driver, the crtc is enabled between .prepare and .enable, if > > > > it exists. > > > > > > > > Add it so the backlight is only enabled after the crtc is, to avoid > > > > graphical issues. > > > > > > > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > > > > > > Didn't Sam acked it? No, that was the new driver, already replied. For these changes - with the updated changelog: Acked-by: Sam Ravnborg <sam@ravnborg.org> ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable @ 2022-03-27 19:45 ` Sam Ravnborg 0 siblings, 0 replies; 22+ messages in thread From: Sam Ravnborg @ 2022-03-27 19:45 UTC (permalink / raw) To: Christophe Branchereau Cc: devicetree, David Airlie, linux-kernel, Rob Herring, linux-mips, Paul Cercueil, Thierry Reding, dri-devel Hi Christophe, On Mon, Mar 21, 2022 at 03:42:08PM +0100, Christophe Branchereau wrote: > Sorry I meant "sleep out" not "sleep in" obviously > > On Mon, Mar 21, 2022 at 3:39 PM Christophe Branchereau > <cbranchereau@gmail.com> wrote: > > > > Following the introduction of bridge_atomic_enable in the ingenic > > drm driver, the crtc is enabled between .prepare and .enable, if > > it exists. Add it so the backlight is only enabled after the crtc is, to > > avoid graphical issues. > > > > As we're moving the "sleep in" command out of the init sequence > > into .enable for the ABT, we need to switch the regmap cache > > to REGCACHE_FLAT to be able to use regmap_set_bits, given this > > panel registers are write-ony and read as 0. > > > > On Mon, Mar 21, 2022 at 3:21 PM Paul Cercueil <paul@crapouillou.net> wrote: > > > > > > Hi Christophe, > > > > > > Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau > > > <cbranchereau@gmail.com> a écrit : > > > > Following the introduction of bridge_atomic_enable in the ingenic > > > > drm driver, the crtc is enabled between .prepare and .enable, if > > > > it exists. > > > > > > > > Add it so the backlight is only enabled after the crtc is, to avoid > > > > graphical issues. > > > > > > > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > > > > > > Didn't Sam acked it? No, that was the new driver, already replied. For these changes - with the updated changelog: Acked-by: Sam Ravnborg <sam@ravnborg.org> ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 0/3] Ingenic DRM bridge_atomic_enable proposal 2022-03-21 13:36 ` Christophe Branchereau @ 2022-04-05 21:03 ` Paul Cercueil -1 siblings, 0 replies; 22+ messages in thread From: Paul Cercueil @ 2022-04-05 21:03 UTC (permalink / raw) To: Christophe Branchereau Cc: devicetree, David Airlie, linux-kernel, dri-devel, linux-mips, Rob Herring, Thierry Reding, Sam Ravnborg Hi Christophe, Merged to drm-misc-next. Thanks, -Paul Le lun., mars 21 2022 at 14:36:48 +0100, Christophe Branchereau <cbranchereau@gmail.com> a écrit : > Hello, > > v5 : > > - this set doesn't include the nv3052c bindings doc anymore, > as it's already applied > > - nv3052c panel driver : removed empty lines, proceed to turn it off > even is sleeping in fails instead of stopping there > > - abt panel : switched to REGCACHE_FLAT so we can disable sleep mode > in .enable with regmap_set_bits() instead of doing it at init time > > - ingenic-drm-drv : added ingenic_drm_bridge_atomic_disable to balance > out ingenic_drm_bridge_atomic_enable > > Tested working on the rg350m and rg280m > > Christophe Branchereau (3): > drm/ingenic : add ingenic_drm_bridge_atomic_enable and disable > drm/panel: Add panel driver for NewVision NV3052C based LCDs > drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and > .disable > > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +- > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 +- > drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 +- > .../gpu/drm/panel/panel-newvision-nv3052c.c | 484 > ++++++++++++++++++ > 6 files changed, 572 insertions(+), 18 deletions(-) > create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c > > -- > 2.35.1 > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 0/3] Ingenic DRM bridge_atomic_enable proposal @ 2022-04-05 21:03 ` Paul Cercueil 0 siblings, 0 replies; 22+ messages in thread From: Paul Cercueil @ 2022-04-05 21:03 UTC (permalink / raw) To: Christophe Branchereau Cc: David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg, Rob Herring, linux-kernel, linux-mips, dri-devel, devicetree Hi Christophe, Merged to drm-misc-next. Thanks, -Paul Le lun., mars 21 2022 at 14:36:48 +0100, Christophe Branchereau <cbranchereau@gmail.com> a écrit : > Hello, > > v5 : > > - this set doesn't include the nv3052c bindings doc anymore, > as it's already applied > > - nv3052c panel driver : removed empty lines, proceed to turn it off > even is sleeping in fails instead of stopping there > > - abt panel : switched to REGCACHE_FLAT so we can disable sleep mode > in .enable with regmap_set_bits() instead of doing it at init time > > - ingenic-drm-drv : added ingenic_drm_bridge_atomic_disable to balance > out ingenic_drm_bridge_atomic_enable > > Tested working on the rg350m and rg280m > > Christophe Branchereau (3): > drm/ingenic : add ingenic_drm_bridge_atomic_enable and disable > drm/panel: Add panel driver for NewVision NV3052C based LCDs > drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and > .disable > > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +- > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 31 +- > drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 +- > .../gpu/drm/panel/panel-newvision-nv3052c.c | 484 > ++++++++++++++++++ > 6 files changed, 572 insertions(+), 18 deletions(-) > create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c > > -- > 2.35.1 > ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2022-04-06 8:00 UTC | newest] Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-03-21 13:36 [PATCH v5 0/3] Ingenic DRM bridge_atomic_enable proposal Christophe Branchereau 2022-03-21 13:36 ` Christophe Branchereau 2022-03-21 13:36 ` [PATCH v5 1/3] drm/ingenic : add ingenic_drm_bridge_atomic_enable and disable Christophe Branchereau 2022-03-21 13:36 ` Christophe Branchereau 2022-04-05 20:26 ` Artur Rojek 2022-04-05 20:26 ` Artur Rojek 2022-03-21 13:36 ` [PATCH v5 2/3] drm/panel: Add panel driver for NewVision NV3052C based LCDs Christophe Branchereau 2022-03-21 13:36 ` Christophe Branchereau 2022-03-27 19:38 ` Sam Ravnborg 2022-03-27 19:38 ` Sam Ravnborg 2022-03-21 13:36 ` [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable Christophe Branchereau 2022-03-21 13:36 ` Christophe Branchereau 2022-03-21 14:21 ` Paul Cercueil 2022-03-21 14:21 ` Paul Cercueil 2022-03-21 14:39 ` Christophe Branchereau 2022-03-21 14:39 ` Christophe Branchereau 2022-03-21 14:42 ` Christophe Branchereau 2022-03-21 14:42 ` Christophe Branchereau 2022-03-27 19:45 ` Sam Ravnborg 2022-03-27 19:45 ` Sam Ravnborg 2022-04-05 21:03 ` [PATCH v5 0/3] Ingenic DRM bridge_atomic_enable proposal Paul Cercueil 2022-04-05 21:03 ` Paul Cercueil
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.