Re: [Intel-gfx] [PATCH v3 02/12] drm/edid: fix reduced blanking support check

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 02/12] drm/edid: fix reduced blanking support check
Date: Mon, 28 Mar 2022 20:27:17 +0300	[thread overview]
Message-ID: <YkHv9dC7NOKo37yu@intel.com> (raw)
In-Reply-To: <5dea5ee24065450716bbc177dd6850d3193dbeec.1648477901.git.jani.nikula@intel.com>

On Mon, Mar 28, 2022 at 05:34:23PM +0300, Jani Nikula wrote:
> The reduced blanking bit is valid only for CVT, indicated by display
> range limits flags 0x04.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Let's repeat here in so it doesn't get lost.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/drm_edid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 1b552fe54f38..13d05062d68c 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -2408,7 +2408,7 @@ is_rb(struct detailed_timing *t, void *data)
>  	if (!is_display_descriptor(r, EDID_DETAIL_MONITOR_RANGE))
>  		return;
>  
> -	if (r[15] & 0x10)
> +	if (r[10] == DRM_EDID_CVT_SUPPORT_FLAG && r[15] & 0x10)
>  		*(bool *)data = true;
>  }
>  
> -- 
> 2.30.2

-- 
Ville Syrjälä
Intel

WARNING: multiple messages have this Message-ID (diff)

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 02/12] drm/edid: fix reduced blanking support check
Date: Mon, 28 Mar 2022 20:27:17 +0300	[thread overview]
Message-ID: <YkHv9dC7NOKo37yu@intel.com> (raw)
In-Reply-To: <5dea5ee24065450716bbc177dd6850d3193dbeec.1648477901.git.jani.nikula@intel.com>

On Mon, Mar 28, 2022 at 05:34:23PM +0300, Jani Nikula wrote:
> The reduced blanking bit is valid only for CVT, indicated by display
> range limits flags 0x04.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Let's repeat here in so it doesn't get lost.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/drm_edid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 1b552fe54f38..13d05062d68c 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -2408,7 +2408,7 @@ is_rb(struct detailed_timing *t, void *data)
>  	if (!is_display_descriptor(r, EDID_DETAIL_MONITOR_RANGE))
>  		return;
>  
> -	if (r[15] & 0x10)
> +	if (r[10] == DRM_EDID_CVT_SUPPORT_FLAG && r[15] & 0x10)
>  		*(bool *)data = true;
>  }
>  
> -- 
> 2.30.2

-- 
Ville Syrjälä
Intel

next prev parent reply	other threads:[~2022-03-28 17:27 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 14:34 [PATCH v3 00/12] drm/edid: constify EDID parsing, with fixes Jani Nikula
2022-03-28 14:34 ` [Intel-gfx] " Jani Nikula
2022-03-28 14:34 ` [PATCH v3 01/12] drm/edid: don't modify EDID while parsing Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 14:34 ` [PATCH v3 02/12] drm/edid: fix reduced blanking support check Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:27   ` Ville Syrjälä [this message]
2022-03-28 17:27     ` Ville Syrjälä
2022-03-28 14:34 ` [PATCH v3 03/12] drm/edid: pass a timing pointer to is_display_descriptor() Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:28   ` Ville Syrjälä
2022-03-28 17:28     ` [Intel-gfx] " Ville Syrjälä
2022-03-28 14:34 ` [PATCH v3 04/12] drm/edid: pass a timing pointer to is_detailed_timing_descriptor() Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:29   ` Ville Syrjälä
2022-03-28 17:29     ` Ville Syrjälä
2022-03-28 14:34 ` [PATCH v3 05/12] drm/edid: use struct detailed_timing member access in is_rb() Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:29   ` Ville Syrjälä
2022-03-28 17:29     ` [Intel-gfx] " Ville Syrjälä
2022-03-28 14:34 ` [PATCH v3 06/12] drm/edid: use struct detailed_timing member access in gtf2 functions Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:34   ` Ville Syrjälä
2022-03-28 17:34     ` [Intel-gfx] " Ville Syrjälä
2022-03-28 14:34 ` [PATCH v3 07/12] drm/edid: constify struct detailed_timing in lower level parsing Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:35   ` Ville Syrjälä
2022-03-28 17:35     ` [Intel-gfx] " Ville Syrjälä
2022-03-28 14:34 ` [PATCH v3 08/12] drm/edid: constify struct detailed_timing in parsing callbacks Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:37   ` Ville Syrjälä
2022-03-28 17:37     ` Ville Syrjälä
2022-03-28 14:34 ` [PATCH v3 09/12] drm/edid: constify struct edid passed to detailed blocks Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:39   ` Ville Syrjälä
2022-03-28 17:39     ` [Intel-gfx] " Ville Syrjälä
2022-03-28 14:34 ` [PATCH v3 10/12] drm/edid: constify struct edid passed around in callbacks and closure Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:40   ` Ville Syrjälä
2022-03-28 17:40     ` Ville Syrjälä
2022-03-28 14:34 ` [PATCH v3 11/12] drm/edid: add more general struct edid constness in the interfaces Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:41   ` Ville Syrjälä
2022-03-28 17:41     ` [Intel-gfx] " Ville Syrjälä
2022-03-28 14:34 ` [PATCH v3 12/12] drm/edid: split drm_add_edid_modes() to two Jani Nikula
2022-03-28 14:34   ` [Intel-gfx] " Jani Nikula
2022-03-28 17:48   ` Ville Syrjälä
2022-03-28 17:48     ` Ville Syrjälä
2022-03-28 18:35     ` Jani Nikula
2022-03-28 18:35       ` [Intel-gfx] " Jani Nikula
2022-03-28 18:00 ` [PATCH v3 00/12] drm/edid: constify EDID parsing, with fixes Emil Velikov
2022-03-28 18:00   ` [Intel-gfx] " Emil Velikov
2022-03-28 18:36   ` Jani Nikula
2022-03-28 18:36     ` [Intel-gfx] " Jani Nikula
2022-03-29  1:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: constify EDID parsing, with fixes (rev2) Patchwork
2022-03-29  1:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-03-29  1:34 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2022-03-29  1:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-29  4:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-03-29  9:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: constify EDID parsing, with fixes (rev3) Patchwork
2022-03-29  9:23 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-03-29  9:27 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2022-03-29  9:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-29 12:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkHv9dC7NOKo37yu@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.