From: "Ville Syrjälä" <ville.syrjala@linux.intel.com> To: Jani Nikula <jani.nikula@intel.com> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 08/12] drm/edid: use a better variable name for EDID block read retries Date: Thu, 31 Mar 2022 17:55:16 +0300 [thread overview] Message-ID: <YkXA1CmIpW/DnRsy@intel.com> (raw) In-Reply-To: <5debef4cc1415504067e4fd69cd7be96f7077e06.1648578814.git.jani.nikula@intel.com> On Tue, Mar 29, 2022 at 09:42:15PM +0300, Jani Nikula wrote: > Just i is a bit terse, clarify what it's about. > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/drm_edid.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 04eb6949c9c8..235d3cde2e97 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -1971,25 +1971,25 @@ static struct edid *drm_do_get_edid_base_block(struct drm_connector *connector, > int *null_edid_counter = connector ? &connector->null_edid_counter : NULL; > bool *edid_corrupt = connector ? &connector->edid_corrupt : NULL; > void *edid; > - int i; > + int try; > > edid = kmalloc(EDID_LENGTH, GFP_KERNEL); > if (edid == NULL) > return NULL; > > /* base block fetch */ > - for (i = 0; i < 4; i++) { > + for (try = 0; try < 4; try++) { > if (get_edid_block(data, edid, 0, EDID_LENGTH)) > goto out; > if (drm_edid_block_valid(edid, 0, false, edid_corrupt)) > break; > - if (i == 0 && edid_is_zero(edid, EDID_LENGTH)) { > + if (try == 0 && edid_is_zero(edid, EDID_LENGTH)) { > if (null_edid_counter) > (*null_edid_counter)++; > goto carp; > } > } > - if (i == 4) > + if (try == 4) > goto carp; > > return edid; > @@ -2027,7 +2027,7 @@ struct edid *drm_do_get_edid(struct drm_connector *connector, > size_t len), > void *data) > { > - int i, j = 0, valid_extensions = 0; > + int j, valid_extensions = 0; > struct edid *edid, *new, *override; > > override = drm_get_override_edid(connector); > @@ -2050,20 +2050,22 @@ struct edid *drm_do_get_edid(struct drm_connector *connector, > > for (j = 1; j <= edid->extensions; j++) { > void *block = edid + j; > + int try; > > - for (i = 0; i < 4; i++) { > + for (try = 0; try < 4; try++) { > if (get_edid_block(data, block, j, EDID_LENGTH)) > goto out; > if (drm_edid_block_valid(block, j, false, NULL)) > break; > } > > - if (i == 4) > + if (try == 4) > valid_extensions--; > } > > if (valid_extensions != edid->extensions) { > struct edid *base; > + int i; > > connector_bad_edid(connector, (u8 *)edid, edid->extensions + 1); > > -- > 2.30.2 -- Ville Syrjälä Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com> To: Jani Nikula <jani.nikula@intel.com> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 08/12] drm/edid: use a better variable name for EDID block read retries Date: Thu, 31 Mar 2022 17:55:16 +0300 [thread overview] Message-ID: <YkXA1CmIpW/DnRsy@intel.com> (raw) In-Reply-To: <5debef4cc1415504067e4fd69cd7be96f7077e06.1648578814.git.jani.nikula@intel.com> On Tue, Mar 29, 2022 at 09:42:15PM +0300, Jani Nikula wrote: > Just i is a bit terse, clarify what it's about. > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/drm_edid.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 04eb6949c9c8..235d3cde2e97 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -1971,25 +1971,25 @@ static struct edid *drm_do_get_edid_base_block(struct drm_connector *connector, > int *null_edid_counter = connector ? &connector->null_edid_counter : NULL; > bool *edid_corrupt = connector ? &connector->edid_corrupt : NULL; > void *edid; > - int i; > + int try; > > edid = kmalloc(EDID_LENGTH, GFP_KERNEL); > if (edid == NULL) > return NULL; > > /* base block fetch */ > - for (i = 0; i < 4; i++) { > + for (try = 0; try < 4; try++) { > if (get_edid_block(data, edid, 0, EDID_LENGTH)) > goto out; > if (drm_edid_block_valid(edid, 0, false, edid_corrupt)) > break; > - if (i == 0 && edid_is_zero(edid, EDID_LENGTH)) { > + if (try == 0 && edid_is_zero(edid, EDID_LENGTH)) { > if (null_edid_counter) > (*null_edid_counter)++; > goto carp; > } > } > - if (i == 4) > + if (try == 4) > goto carp; > > return edid; > @@ -2027,7 +2027,7 @@ struct edid *drm_do_get_edid(struct drm_connector *connector, > size_t len), > void *data) > { > - int i, j = 0, valid_extensions = 0; > + int j, valid_extensions = 0; > struct edid *edid, *new, *override; > > override = drm_get_override_edid(connector); > @@ -2050,20 +2050,22 @@ struct edid *drm_do_get_edid(struct drm_connector *connector, > > for (j = 1; j <= edid->extensions; j++) { > void *block = edid + j; > + int try; > > - for (i = 0; i < 4; i++) { > + for (try = 0; try < 4; try++) { > if (get_edid_block(data, block, j, EDID_LENGTH)) > goto out; > if (drm_edid_block_valid(block, j, false, NULL)) > break; > } > > - if (i == 4) > + if (try == 4) > valid_extensions--; > } > > if (valid_extensions != edid->extensions) { > struct edid *base; > + int i; > > connector_bad_edid(connector, (u8 *)edid, edid->extensions + 1); > > -- > 2.30.2 -- Ville Syrjälä Intel
next prev parent reply other threads:[~2022-03-31 14:55 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-29 18:42 [PATCH 00/12] drm/edid: cleanup and refactoring around validity checks Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-29 18:42 ` [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid() Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-30 13:05 ` Ville Syrjälä 2022-03-30 13:05 ` [Intel-gfx] " Ville Syrjälä 2022-03-30 15:16 ` Jani Nikula 2022-03-30 15:16 ` [Intel-gfx] " Jani Nikula 2022-03-30 15:39 ` Ville Syrjälä 2022-03-30 15:39 ` [Intel-gfx] " Ville Syrjälä 2022-03-30 16:28 ` Jani Nikula 2022-03-30 16:28 ` [Intel-gfx] " Jani Nikula 2022-03-30 16:50 ` Ville Syrjälä 2022-03-30 16:50 ` [Intel-gfx] " Ville Syrjälä 2022-03-30 17:09 ` Jani Nikula 2022-03-30 21:01 ` Jani Nikula 2022-03-30 21:01 ` [Intel-gfx] " Jani Nikula 2022-03-31 18:46 ` Jani Nikula 2022-03-31 18:46 ` [Intel-gfx] " Jani Nikula 2022-03-29 18:42 ` [PATCH 02/12] drm/edid: clean up EDID block checksum functions Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-29 18:42 ` [PATCH 03/12] drm/edid: add edid_block_tag() helper to get the EDID extension tag Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-29 18:42 ` [PATCH 04/12] drm/edid: make drm_edid_header_is_valid() accept void pointer Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-29 18:42 ` [PATCH 05/12] drm/edid: clean up edid_is_zero() Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-29 18:42 ` [PATCH 06/12] drm/edid: split out edid_header_fix() Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-29 18:42 ` [PATCH 07/12] drm/edid: split drm_edid_block_valid() to check and act parts Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-31 14:54 ` Ville Syrjälä 2022-03-31 14:54 ` [Intel-gfx] " Ville Syrjälä 2022-03-31 15:54 ` Jani Nikula 2022-03-31 15:54 ` [Intel-gfx] " Jani Nikula 2022-03-31 16:49 ` Jani Nikula 2022-03-31 16:49 ` [Intel-gfx] " Jani Nikula 2022-03-31 16:58 ` Ville Syrjälä 2022-03-31 16:58 ` [Intel-gfx] " Ville Syrjälä 2022-03-29 18:42 ` [PATCH 08/12] drm/edid: use a better variable name for EDID block read retries Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-31 14:55 ` Ville Syrjälä [this message] 2022-03-31 14:55 ` Ville Syrjälä 2022-03-29 18:42 ` [PATCH 09/12] drm/edid: simplify block check when filtering invalid blocks Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-29 18:42 ` [PATCH 10/12] drm/edid: split out invalid block filtering to a separate function Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-29 18:42 ` [PATCH 11/12] drm/edid: track invalid blocks in drm_do_get_edid() Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-29 18:42 ` [PATCH 12/12] drm/edid: reduce magic when updating the EDID block checksum Jani Nikula 2022-03-29 18:42 ` [Intel-gfx] " Jani Nikula 2022-03-31 14:59 ` Ville Syrjälä 2022-03-31 14:59 ` [Intel-gfx] " Ville Syrjälä 2022-03-29 19:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: cleanup and refactoring around validity checks Patchwork 2022-03-29 19:37 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2022-03-29 20:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-03-29 21:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2022-03-31 17:07 ` [PATCH 00/12] " Ville Syrjälä 2022-03-31 17:07 ` [Intel-gfx] " Ville Syrjälä
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YkXA1CmIpW/DnRsy@intel.com \ --to=ville.syrjala@linux.intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.