From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Xiyu Yang <xiyuyang19@fudan.edu.cn>, Guenter Roeck <linux@roeck-us.net>, Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>, Daniel Vetter <daniel.vetter@ffwll.ch>, deller@gmx.de, Zheyu Ma <zheyuma97@gmail.com>, javierm@redhat.com, Matthew Wilcox <willy@infradead.org>, hdegoede@redhat.com, stable@vger.kernel.org, Zhen Lei <thunder.leizhen@huawei.com>, Alex Deucher <alexander.deucher@amd.com>, sam@ravnborg.org Subject: Re: fbdev: Fix unregistering of framebuffers without device Date: Tue, 5 Apr 2022 14:05:46 +0100 [thread overview] Message-ID: <Ykw+qlW+bjWcy4BR@debian> (raw) In-Reply-To: <20220404194402.29974-1-tzimmermann@suse.de> On Mon, Apr 04, 2022 at 09:44:02PM +0200, Thomas Zimmermann wrote: > OF framebuffers do not have an underlying device in the Linux > device hierarchy. Do a regular unregister call instead of hot > unplugging such a non-existing device. Fixes a NULL dereference. > An example error message on ppc64le is shown below. > <snip> > > Tested with 5.17 on qemu ppc64le emulation. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: 27599aacbaef ("fbdev: Hot-unplug firmware fb devices on forced removal") > Reported-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > Cc: Zack Rusin <zackr@vmware.com> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: stable@vger.kernel.org # v5.11+ > Cc: Helge Deller <deller@gmx.de> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Zheyu Ma <zheyuma97@gmail.com> > Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn> > Cc: Zhen Lei <thunder.leizhen@huawei.com> > Cc: Matthew Wilcox <willy@infradead.org> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Link: https://lore.kernel.org/all/YkHXO6LGHAN0p1pq@debian/ # [1] > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> -- Regards Sudip
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: daniel@ffwll.ch, deller@gmx.de, sam@ravnborg.org, javierm@redhat.com, zackr@vmware.com, hdegoede@redhat.com, linux-fbdev@vger.kernel.org, Matthew Wilcox <willy@infradead.org>, Xiyu Yang <xiyuyang19@fudan.edu.cn>, Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>, Daniel Vetter <daniel.vetter@ffwll.ch>, Zheyu Ma <zheyuma97@gmail.com>, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Zhen Lei <thunder.leizhen@huawei.com>, Alex Deucher <alexander.deucher@amd.com>, Guenter Roeck <linux@roeck-us.net> Subject: Re: fbdev: Fix unregistering of framebuffers without device Date: Tue, 5 Apr 2022 14:05:46 +0100 [thread overview] Message-ID: <Ykw+qlW+bjWcy4BR@debian> (raw) In-Reply-To: <20220404194402.29974-1-tzimmermann@suse.de> On Mon, Apr 04, 2022 at 09:44:02PM +0200, Thomas Zimmermann wrote: > OF framebuffers do not have an underlying device in the Linux > device hierarchy. Do a regular unregister call instead of hot > unplugging such a non-existing device. Fixes a NULL dereference. > An example error message on ppc64le is shown below. > <snip> > > Tested with 5.17 on qemu ppc64le emulation. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: 27599aacbaef ("fbdev: Hot-unplug firmware fb devices on forced removal") > Reported-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > Cc: Zack Rusin <zackr@vmware.com> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: stable@vger.kernel.org # v5.11+ > Cc: Helge Deller <deller@gmx.de> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Zheyu Ma <zheyuma97@gmail.com> > Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn> > Cc: Zhen Lei <thunder.leizhen@huawei.com> > Cc: Matthew Wilcox <willy@infradead.org> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Link: https://lore.kernel.org/all/YkHXO6LGHAN0p1pq@debian/ # [1] > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> -- Regards Sudip
next prev parent reply other threads:[~2022-04-05 13:05 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-04 19:44 [PATCH] fbdev: Fix unregistering of framebuffers without device Thomas Zimmermann 2022-04-04 19:44 ` Thomas Zimmermann 2022-04-05 9:01 ` Daniel Vetter 2022-04-05 9:01 ` Daniel Vetter 2022-04-05 18:24 ` Thomas Zimmermann 2022-04-05 18:24 ` Thomas Zimmermann 2022-04-05 13:05 ` Sudip Mukherjee [this message] 2022-04-05 13:05 ` Sudip Mukherjee 2022-04-05 14:08 ` [PATCH] " Javier Martinez Canillas 2022-04-05 14:08 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Ykw+qlW+bjWcy4BR@debian \ --to=sudipm.mukherjee@gmail.com \ --cc=alexander.deucher@amd.com \ --cc=daniel.vetter@ffwll.ch \ --cc=deller@gmx.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=hdegoede@redhat.com \ --cc=javierm@redhat.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=penguin-kernel@i-love.sakura.ne.jp \ --cc=sam@ravnborg.org \ --cc=stable@vger.kernel.org \ --cc=thunder.leizhen@huawei.com \ --cc=tzimmermann@suse.de \ --cc=willy@infradead.org \ --cc=xiyuyang19@fudan.edu.cn \ --cc=zheyuma97@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.