All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
  2022-04-21 15:23 [linux-next:master 4441/5346] drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94 kernel test robot
@ 2022-04-21 15:09   ` kernel test robot
  0 siblings, 0 replies; 12+ messages in thread
From: kernel test robot @ 2022-04-21 15:09 UTC (permalink / raw)
  To: Sandor Yu
  Cc: kbuild-all, Linux Memory Management List, Robert Foss,
	Shengjiu Wang, Neil Armstrong, Andrzej Hajda, Laurent Pinchart,
	Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
	dri-devel, linux-kernel

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: Sandor Yu <Sandor.yu@nxp.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
:::::: branch date: 8 hours ago
:::::: commit date: 2 days ago

 drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
@@ -77,7 +77,6 @@ static int audio_hw_params(struct device
 			   struct hdmi_codec_params *params)
 {
 	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
-	int ret = 0;
 	u8 ca;
 
 	dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
@@ -91,7 +90,7 @@ static int audio_hw_params(struct device
 				   params->iec.status[0] & IEC958_AES0_NONAUDIO);
 	dw_hdmi_set_sample_width(dw->data.hdmi, params->sample_width);
 
-	return ret;
+	return 0;
 }
 
 static void audio_shutdown(struct device *dev, void *data)
@@ -102,14 +101,13 @@ static int audio_mute_stream(struct devi
 			     bool enable, int direction)
 {
 	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
-	int ret = 0;
 
 	if (!enable)
 		dw_hdmi_audio_enable(dw->data.hdmi);
 	else
 		dw_hdmi_audio_disable(dw->data.hdmi);
 
-	return ret;
+	return 0;
 }
 
 static int audio_get_eld(struct device *dev, void *data,

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
@ 2022-04-21 15:09   ` kernel test robot
  0 siblings, 0 replies; 12+ messages in thread
From: kernel test robot @ 2022-04-21 15:09 UTC (permalink / raw)
  To: Sandor Yu
  Cc: dri-devel, Jernej Skrabec, kbuild-all, Neil Armstrong,
	David Airlie, Shengjiu Wang, Jonas Karlman, linux-kernel,
	Robert Foss, Linux Memory Management List, Laurent Pinchart,
	Andrzej Hajda

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: Sandor Yu <Sandor.yu@nxp.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
:::::: branch date: 8 hours ago
:::::: commit date: 2 days ago

 drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
@@ -77,7 +77,6 @@ static int audio_hw_params(struct device
 			   struct hdmi_codec_params *params)
 {
 	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
-	int ret = 0;
 	u8 ca;
 
 	dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
@@ -91,7 +90,7 @@ static int audio_hw_params(struct device
 				   params->iec.status[0] & IEC958_AES0_NONAUDIO);
 	dw_hdmi_set_sample_width(dw->data.hdmi, params->sample_width);
 
-	return ret;
+	return 0;
 }
 
 static void audio_shutdown(struct device *dev, void *data)
@@ -102,14 +101,13 @@ static int audio_mute_stream(struct devi
 			     bool enable, int direction)
 {
 	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
-	int ret = 0;
 
 	if (!enable)
 		dw_hdmi_audio_enable(dw->data.hdmi);
 	else
 		dw_hdmi_audio_disable(dw->data.hdmi);
 
-	return ret;
+	return 0;
 }
 
 static int audio_get_eld(struct device *dev, void *data,

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [linux-next:master 4441/5346] drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
@ 2022-04-21 15:23 kernel test robot
  2022-04-21 15:09   ` kernel test robot
  0 siblings, 1 reply; 12+ messages in thread
From: kernel test robot @ 2022-04-21 15:23 UTC (permalink / raw)
  To: Sandor Yu
  Cc: kbuild-all, Linux Memory Management List, Robert Foss,
	Shengjiu Wang, Neil Armstrong

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
config: xtensa-randconfig-c024-20220421 (https://download.01.org/0day-ci/archive/20220421/202204212311.TnfpcTGm-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
   drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112

Please review and possibly fold the followup patch.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
  2022-04-21 15:09   ` kernel test robot
  (?)
@ 2022-04-21 16:47     ` Neil Armstrong
  -1 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2022-04-21 16:47 UTC (permalink / raw)
  To: kernel test robot, Sandor Yu
  Cc: kbuild-all, Linux Memory Management List, Robert Foss,
	Shengjiu Wang, Andrzej Hajda, Laurent Pinchart, Jonas Karlman,
	Jernej Skrabec, David Airlie, Daniel Vetter, dri-devel,
	linux-kernel

On 21/04/2022 17:09, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112
> 
> 
>   Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Sandor Yu <Sandor.yu@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
> commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
> :::::: branch date: 8 hours ago
> :::::: commit date: 2 days ago
> 
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c |    6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> @@ -77,7 +77,6 @@ static int audio_hw_params(struct device
>   			   struct hdmi_codec_params *params)
>   {
>   	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -	int ret = 0;
>   	u8 ca;
>   
>   	dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
> @@ -91,7 +90,7 @@ static int audio_hw_params(struct device
>   				   params->iec.status[0] & IEC958_AES0_NONAUDIO);
>   	dw_hdmi_set_sample_width(dw->data.hdmi, params->sample_width);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static void audio_shutdown(struct device *dev, void *data)
> @@ -102,14 +101,13 @@ static int audio_mute_stream(struct devi
>   			     bool enable, int direction)
>   {
>   	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -	int ret = 0;
>   
>   	if (!enable)
>   		dw_hdmi_audio_enable(dw->data.hdmi);
>   	else
>   		dw_hdmi_audio_disable(dw->data.hdmi);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static int audio_get_eld(struct device *dev, void *data,

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
@ 2022-04-21 16:47     ` Neil Armstrong
  0 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2022-04-21 16:47 UTC (permalink / raw)
  To: kernel test robot, Sandor Yu
  Cc: dri-devel, Jernej Skrabec, kbuild-all, Jonas Karlman,
	David Airlie, Shengjiu Wang, linux-kernel, Robert Foss,
	Linux Memory Management List, Laurent Pinchart, Andrzej Hajda

On 21/04/2022 17:09, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112
> 
> 
>   Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Sandor Yu <Sandor.yu@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
> commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
> :::::: branch date: 8 hours ago
> :::::: commit date: 2 days ago
> 
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c |    6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> @@ -77,7 +77,6 @@ static int audio_hw_params(struct device
>   			   struct hdmi_codec_params *params)
>   {
>   	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -	int ret = 0;
>   	u8 ca;
>   
>   	dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
> @@ -91,7 +90,7 @@ static int audio_hw_params(struct device
>   				   params->iec.status[0] & IEC958_AES0_NONAUDIO);
>   	dw_hdmi_set_sample_width(dw->data.hdmi, params->sample_width);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static void audio_shutdown(struct device *dev, void *data)
> @@ -102,14 +101,13 @@ static int audio_mute_stream(struct devi
>   			     bool enable, int direction)
>   {
>   	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -	int ret = 0;
>   
>   	if (!enable)
>   		dw_hdmi_audio_enable(dw->data.hdmi);
>   	else
>   		dw_hdmi_audio_disable(dw->data.hdmi);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static int audio_get_eld(struct device *dev, void *data,

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
@ 2022-04-21 16:47     ` Neil Armstrong
  0 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2022-04-21 16:47 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2242 bytes --]

On 21/04/2022 17:09, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112
> 
> 
>   Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Sandor Yu <Sandor.yu@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
> commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
> :::::: branch date: 8 hours ago
> :::::: commit date: 2 days ago
> 
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c |    6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> @@ -77,7 +77,6 @@ static int audio_hw_params(struct device
>   			   struct hdmi_codec_params *params)
>   {
>   	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -	int ret = 0;
>   	u8 ca;
>   
>   	dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
> @@ -91,7 +90,7 @@ static int audio_hw_params(struct device
>   				   params->iec.status[0] & IEC958_AES0_NONAUDIO);
>   	dw_hdmi_set_sample_width(dw->data.hdmi, params->sample_width);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static void audio_shutdown(struct device *dev, void *data)
> @@ -102,14 +101,13 @@ static int audio_mute_stream(struct devi
>   			     bool enable, int direction)
>   {
>   	struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -	int ret = 0;
>   
>   	if (!enable)
>   		dw_hdmi_audio_enable(dw->data.hdmi);
>   	else
>   		dw_hdmi_audio_disable(dw->data.hdmi);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static int audio_get_eld(struct device *dev, void *data,

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* RE: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
  2022-04-21 15:09   ` kernel test robot
@ 2022-04-22  0:15     ` Sandor Yu
  -1 siblings, 0 replies; 12+ messages in thread
From: Sandor Yu @ 2022-04-22  0:15 UTC (permalink / raw)
  To: kernel test robot
  Cc: kbuild-all, Linux Memory Management List, Robert Foss, S.J. Wang,
	Neil Armstrong, Andrzej Hajda, Laurent Pinchart, Jonas Karlman,
	Jernej Skrabec, David Airlie, Daniel Vetter, dri-devel,
	linux-kernel



> -----Original Message-----
> From: kernel test robot <lkp@intel.com>
> Sent: 2022年4月21日 23:10
> To: Sandor Yu <sandor.yu@nxp.com>
> Cc: kbuild-all@lists.01.org; Linux Memory Management List
> <linux-mm@kvack.org>; Robert Foss <robert.foss@linaro.org>; S.J. Wang
> <shengjiu.wang@nxp.com>; Neil Armstrong <narmstrong@baylibre.com>;
> Andrzej Hajda <andrzej.hajda@intel.com>; Laurent Pinchart
> <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>;
> Jernej Skrabec <jernej.skrabec@gmail.com>; David Airlie <airlied@linux.ie>;
> Daniel Vetter <daniel@ffwll.ch>; dri-devel@lists.freedesktop.org;
> linux-kernel@vger.kernel.org
> Subject: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci
> warnings
> 
> Caution: EXT Email
> 
> From: kernel test robot <lkp@intel.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded
> variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded
> variable: "ret". Return "0" on line 112
> 
> 
>  Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Sandor Yu <Sandor.yu@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> tree:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker
> nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git&a
> mp;data=05%7C01%7CSandor.yu%40nxp.com%7C7028c89ce23940ff081408d
> a23a911c8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637861
> 506299960569%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ
> QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&am
> p;sdata=P1pum2Ur3I8occ5f1WAnVhnIIGB0Q1HXc2GsRbUx8p0%3D&amp;res
> erved=0 master
> head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
> commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm:
> bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
> :::::: branch date: 8 hours ago
> :::::: commit date: 2 days ago
> 
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> @@ -77,7 +77,6 @@ static int audio_hw_params(struct device
>                            struct hdmi_codec_params *params)  {
>         struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -       int ret = 0;
>         u8 ca;
> 
>         dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
> @@ -91,7 +90,7 @@ static int audio_hw_params(struct device
>                                    params->iec.status[0] &
> IEC958_AES0_NONAUDIO);
>         dw_hdmi_set_sample_width(dw->data.hdmi,
> params->sample_width);
> 
> -       return ret;
> +       return 0;
>  }
> 
>  static void audio_shutdown(struct device *dev, void *data) @@ -102,14
> +101,13 @@ static int audio_mute_stream(struct devi
>                              bool enable, int direction)  {
>         struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -       int ret = 0;
> 
>         if (!enable)
>                 dw_hdmi_audio_enable(dw->data.hdmi);
>         else
>                 dw_hdmi_audio_disable(dw->data.hdmi);
> 
> -       return ret;
> +       return 0;
>  }
> 
>  static int audio_get_eld(struct device *dev, void *data,

Reviewed-by: Sandor Yu <Sandor.yu@nxp.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* RE: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
@ 2022-04-22  0:15     ` Sandor Yu
  0 siblings, 0 replies; 12+ messages in thread
From: Sandor Yu @ 2022-04-22  0:15 UTC (permalink / raw)
  To: kernel test robot
  Cc: dri-devel, Jernej Skrabec, kbuild-all, Neil Armstrong,
	David Airlie, S.J. Wang, Jonas Karlman, linux-kernel,
	Robert Foss, Linux Memory Management List, Laurent Pinchart,
	Andrzej Hajda



> -----Original Message-----
> From: kernel test robot <lkp@intel.com>
> Sent: 2022年4月21日 23:10
> To: Sandor Yu <sandor.yu@nxp.com>
> Cc: kbuild-all@lists.01.org; Linux Memory Management List
> <linux-mm@kvack.org>; Robert Foss <robert.foss@linaro.org>; S.J. Wang
> <shengjiu.wang@nxp.com>; Neil Armstrong <narmstrong@baylibre.com>;
> Andrzej Hajda <andrzej.hajda@intel.com>; Laurent Pinchart
> <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>;
> Jernej Skrabec <jernej.skrabec@gmail.com>; David Airlie <airlied@linux.ie>;
> Daniel Vetter <daniel@ffwll.ch>; dri-devel@lists.freedesktop.org;
> linux-kernel@vger.kernel.org
> Subject: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci
> warnings
> 
> Caution: EXT Email
> 
> From: kernel test robot <lkp@intel.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded
> variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded
> variable: "ret". Return "0" on line 112
> 
> 
>  Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Sandor Yu <Sandor.yu@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> tree:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker
> nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git&a
> mp;data=05%7C01%7CSandor.yu%40nxp.com%7C7028c89ce23940ff081408d
> a23a911c8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637861
> 506299960569%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ
> QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&am
> p;sdata=P1pum2Ur3I8occ5f1WAnVhnIIGB0Q1HXc2GsRbUx8p0%3D&amp;res
> erved=0 master
> head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
> commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm:
> bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
> :::::: branch date: 8 hours ago
> :::::: commit date: 2 days ago
> 
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> @@ -77,7 +77,6 @@ static int audio_hw_params(struct device
>                            struct hdmi_codec_params *params)  {
>         struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -       int ret = 0;
>         u8 ca;
> 
>         dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
> @@ -91,7 +90,7 @@ static int audio_hw_params(struct device
>                                    params->iec.status[0] &
> IEC958_AES0_NONAUDIO);
>         dw_hdmi_set_sample_width(dw->data.hdmi,
> params->sample_width);
> 
> -       return ret;
> +       return 0;
>  }
> 
>  static void audio_shutdown(struct device *dev, void *data) @@ -102,14
> +101,13 @@ static int audio_mute_stream(struct devi
>                              bool enable, int direction)  {
>         struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -       int ret = 0;
> 
>         if (!enable)
>                 dw_hdmi_audio_enable(dw->data.hdmi);
>         else
>                 dw_hdmi_audio_disable(dw->data.hdmi);
> 
> -       return ret;
> +       return 0;
>  }
> 
>  static int audio_get_eld(struct device *dev, void *data,

Reviewed-by: Sandor Yu <Sandor.yu@nxp.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
  2022-04-21 15:09   ` kernel test robot
  (?)
  (?)
@ 2022-04-22  0:15   ` Sandor Yu
  -1 siblings, 0 replies; 12+ messages in thread
From: Sandor Yu @ 2022-04-22  0:15 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3538 bytes --]



> -----Original Message-----
> From: kernel test robot <lkp@intel.com>
> Sent: 2022年4月21日 23:10
> To: Sandor Yu <sandor.yu@nxp.com>
> Cc: kbuild-all(a)lists.01.org; Linux Memory Management List
> <linux-mm@kvack.org>; Robert Foss <robert.foss@linaro.org>; S.J. Wang
> <shengjiu.wang@nxp.com>; Neil Armstrong <narmstrong@baylibre.com>;
> Andrzej Hajda <andrzej.hajda@intel.com>; Laurent Pinchart
> <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>;
> Jernej Skrabec <jernej.skrabec@gmail.com>; David Airlie <airlied@linux.ie>;
> Daniel Vetter <daniel@ffwll.ch>; dri-devel(a)lists.freedesktop.org;
> linux-kernel(a)vger.kernel.org
> Subject: [EXT] [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci
> warnings
> 
> Caution: EXT Email
> 
> From: kernel test robot <lkp@intel.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded
> variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded
> variable: "ret". Return "0" on line 112
> 
> 
>  Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Sandor Yu <Sandor.yu@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> tree:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker
> nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git&a
> mp;data=05%7C01%7CSandor.yu%40nxp.com%7C7028c89ce23940ff081408d
> a23a911c8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637861
> 506299960569%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ
> QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&am
> p;sdata=P1pum2Ur3I8occ5f1WAnVhnIIGB0Q1HXc2GsRbUx8p0%3D&amp;res
> erved=0 master
> head:   65eb92e4c9f0a962656f131521f4fbc0d24c9d4c
> commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm:
> bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
> :::::: branch date: 8 hours ago
> :::::: commit date: 2 days ago
> 
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c
> @@ -77,7 +77,6 @@ static int audio_hw_params(struct device
>                            struct hdmi_codec_params *params)  {
>         struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -       int ret = 0;
>         u8 ca;
> 
>         dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate);
> @@ -91,7 +90,7 @@ static int audio_hw_params(struct device
>                                    params->iec.status[0] &
> IEC958_AES0_NONAUDIO);
>         dw_hdmi_set_sample_width(dw->data.hdmi,
> params->sample_width);
> 
> -       return ret;
> +       return 0;
>  }
> 
>  static void audio_shutdown(struct device *dev, void *data) @@ -102,14
> +101,13 @@ static int audio_mute_stream(struct devi
>                              bool enable, int direction)  {
>         struct snd_dw_hdmi *dw = dev_get_drvdata(dev);
> -       int ret = 0;
> 
>         if (!enable)
>                 dw_hdmi_audio_enable(dw->data.hdmi);
>         else
>                 dw_hdmi_audio_disable(dw->data.hdmi);
> 
> -       return ret;
> +       return 0;
>  }
> 
>  static int audio_get_eld(struct device *dev, void *data,

Reviewed-by: Sandor Yu <Sandor.yu@nxp.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
  2022-04-21 15:09   ` kernel test robot
  (?)
@ 2022-04-22  8:44     ` Neil Armstrong
  -1 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2022-04-22  8:44 UTC (permalink / raw)
  To: kernel test robot, Sandor Yu
  Cc: Neil Armstrong, Robert Foss, linux-kernel, Andrzej Hajda,
	Daniel Vetter, Jernej Skrabec, Laurent Pinchart,
	Linux Memory Management List, Shengjiu Wang, dri-devel,
	David Airlie, Jonas Karlman, kbuild-all

Hi,

On Thu, 21 Apr 2022 23:09:46 +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112
> 
> 
>  Remove unneeded variable used to store return value.
> 
> [...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=0e48711f602064705bf81eebe6f627ee1bc11d3b

-- 
Neil

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
@ 2022-04-22  8:44     ` Neil Armstrong
  0 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2022-04-22  8:44 UTC (permalink / raw)
  To: kernel test robot, Sandor Yu
  Cc: dri-devel, kbuild-all, Andrzej Hajda, Neil Armstrong,
	David Airlie, Shengjiu Wang, Jonas Karlman, linux-kernel,
	Jernej Skrabec, Linux Memory Management List, Robert Foss,
	Laurent Pinchart

Hi,

On Thu, 21 Apr 2022 23:09:46 +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112
> 
> 
>  Remove unneeded variable used to store return value.
> 
> [...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=0e48711f602064705bf81eebe6f627ee1bc11d3b

-- 
Neil

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
@ 2022-04-22  8:44     ` Neil Armstrong
  0 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2022-04-22  8:44 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Hi,

On Thu, 21 Apr 2022 23:09:46 +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112
> 
> 
>  Remove unneeded variable used to store return value.
> 
> [...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=0e48711f602064705bf81eebe6f627ee1bc11d3b

-- 
Neil

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-04-22  8:44 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 15:23 [linux-next:master 4441/5346] drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94 kernel test robot
2022-04-21 15:09 ` [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings kernel test robot
2022-04-21 15:09   ` kernel test robot
2022-04-21 16:47   ` Neil Armstrong
2022-04-21 16:47     ` Neil Armstrong
2022-04-21 16:47     ` Neil Armstrong
2022-04-22  0:15   ` [EXT] " Sandor Yu
2022-04-22  0:15   ` Sandor Yu
2022-04-22  0:15     ` Sandor Yu
2022-04-22  8:44   ` Neil Armstrong
2022-04-22  8:44     ` Neil Armstrong
2022-04-22  8:44     ` Neil Armstrong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.