From: "Russell King (Oracle)" <linux@armlinux.org.uk> To: Maxime Chevallier <maxime.chevallier@bootlin.com> Cc: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>, linux-arm-kernel@lists.infradead.org, Vladimir Oltean <vladimir.oltean@nxp.com>, Luka Perkov <luka.perkov@sartura.hr>, Robert Marko <robert.marko@sartura.hr> Subject: Re: [PATCH net-next v2 1/5] net: ipqess: introduce the Qualcomm IPQESS driver Date: Sat, 14 May 2022 18:18:17 +0100 [thread overview] Message-ID: <Yn/kWG7X1YCPk17F@shell.armlinux.org.uk> (raw) In-Reply-To: <20220514150656.122108-2-maxime.chevallier@bootlin.com> On Sat, May 14, 2022 at 05:06:52PM +0200, Maxime Chevallier wrote: > +static int ipqess_do_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) > +{ > + struct ipqess *ess = netdev_priv(netdev); > + > + switch (cmd) { > + case SIOCGMIIPHY: > + case SIOCGMIIREG: > + case SIOCSMIIREG: > + return phylink_mii_ioctl(ess->phylink, ifr, cmd); > + default: > + break; > + } > + > + return -EOPNOTSUPP; > +} Is there a reason this isn't just: return phylink_mii_ioctl(ess->phylink, ifr, cmd); ? > +static int ipqess_axi_probe(struct platform_device *pdev) > +{ > + struct device_node *np = pdev->dev.of_node; > + struct net_device *netdev; > + phy_interface_t phy_mode; > + struct resource *res; > + struct ipqess *ess; > + int i, err = 0; > + > + netdev = devm_alloc_etherdev_mqs(&pdev->dev, sizeof(struct ipqess), > + IPQESS_NETDEV_QUEUES, > + IPQESS_NETDEV_QUEUES); > + if (!netdev) > + return -ENOMEM; > + > + ess = netdev_priv(netdev); > + ess->netdev = netdev; > + ess->pdev = pdev; > + spin_lock_init(&ess->stats_lock); > + SET_NETDEV_DEV(netdev, &pdev->dev); > + platform_set_drvdata(pdev, netdev); > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + ess->hw_addr = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(ess->hw_addr)) > + return PTR_ERR(ess->hw_addr); > + > + err = of_get_phy_mode(np, &phy_mode); > + if (err) { > + dev_err(&pdev->dev, "incorrect phy-mode\n"); > + return err; > + } > + > + ess->ess_clk = devm_clk_get(&pdev->dev, "ess"); > + if (!IS_ERR(ess->ess_clk)) > + clk_prepare_enable(ess->ess_clk); > + > + ess->ess_rst = devm_reset_control_get(&pdev->dev, "ess"); > + if (IS_ERR(ess->ess_rst)) > + goto err_clk; > + > + ipqess_reset(ess); > + > + ess->phylink_config.dev = &netdev->dev; > + ess->phylink_config.type = PHYLINK_NETDEV; > + > + __set_bit(PHY_INTERFACE_MODE_INTERNAL, > + ess->phylink_config.supported_interfaces); No mac capabilities? > + > + ess->phylink = phylink_create(&ess->phylink_config, > + of_fwnode_handle(np), phy_mode, > + &ipqess_phylink_mac_ops); -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk> To: Maxime Chevallier <maxime.chevallier@bootlin.com> Cc: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>, linux-arm-kernel@lists.infradead.org, Vladimir Oltean <vladimir.oltean@nxp.com>, Luka Perkov <luka.perkov@sartura.hr>, Robert Marko <robert.marko@sartura.hr> Subject: Re: [PATCH net-next v2 1/5] net: ipqess: introduce the Qualcomm IPQESS driver Date: Sat, 14 May 2022 18:18:17 +0100 [thread overview] Message-ID: <Yn/kWG7X1YCPk17F@shell.armlinux.org.uk> (raw) In-Reply-To: <20220514150656.122108-2-maxime.chevallier@bootlin.com> On Sat, May 14, 2022 at 05:06:52PM +0200, Maxime Chevallier wrote: > +static int ipqess_do_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) > +{ > + struct ipqess *ess = netdev_priv(netdev); > + > + switch (cmd) { > + case SIOCGMIIPHY: > + case SIOCGMIIREG: > + case SIOCSMIIREG: > + return phylink_mii_ioctl(ess->phylink, ifr, cmd); > + default: > + break; > + } > + > + return -EOPNOTSUPP; > +} Is there a reason this isn't just: return phylink_mii_ioctl(ess->phylink, ifr, cmd); ? > +static int ipqess_axi_probe(struct platform_device *pdev) > +{ > + struct device_node *np = pdev->dev.of_node; > + struct net_device *netdev; > + phy_interface_t phy_mode; > + struct resource *res; > + struct ipqess *ess; > + int i, err = 0; > + > + netdev = devm_alloc_etherdev_mqs(&pdev->dev, sizeof(struct ipqess), > + IPQESS_NETDEV_QUEUES, > + IPQESS_NETDEV_QUEUES); > + if (!netdev) > + return -ENOMEM; > + > + ess = netdev_priv(netdev); > + ess->netdev = netdev; > + ess->pdev = pdev; > + spin_lock_init(&ess->stats_lock); > + SET_NETDEV_DEV(netdev, &pdev->dev); > + platform_set_drvdata(pdev, netdev); > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + ess->hw_addr = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(ess->hw_addr)) > + return PTR_ERR(ess->hw_addr); > + > + err = of_get_phy_mode(np, &phy_mode); > + if (err) { > + dev_err(&pdev->dev, "incorrect phy-mode\n"); > + return err; > + } > + > + ess->ess_clk = devm_clk_get(&pdev->dev, "ess"); > + if (!IS_ERR(ess->ess_clk)) > + clk_prepare_enable(ess->ess_clk); > + > + ess->ess_rst = devm_reset_control_get(&pdev->dev, "ess"); > + if (IS_ERR(ess->ess_rst)) > + goto err_clk; > + > + ipqess_reset(ess); > + > + ess->phylink_config.dev = &netdev->dev; > + ess->phylink_config.type = PHYLINK_NETDEV; > + > + __set_bit(PHY_INTERFACE_MODE_INTERNAL, > + ess->phylink_config.supported_interfaces); No mac capabilities? > + > + ess->phylink = phylink_create(&ess->phylink_config, > + of_fwnode_handle(np), phy_mode, > + &ipqess_phylink_mac_ops); -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-14 17:18 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-14 15:06 [PATCH net-next v2 0/5] net: ipqess: introduce Qualcomm IPQESS driver Maxime Chevallier 2022-05-14 15:06 ` Maxime Chevallier 2022-05-14 15:06 ` [PATCH net-next v2 1/5] net: ipqess: introduce the " Maxime Chevallier 2022-05-14 15:06 ` Maxime Chevallier 2022-05-14 17:18 ` Russell King (Oracle) [this message] 2022-05-14 17:18 ` Russell King (Oracle) 2022-05-17 7:09 ` Maxime Chevallier 2022-05-17 7:09 ` Maxime Chevallier 2022-05-14 20:44 ` Vladimir Oltean 2022-05-14 20:44 ` Vladimir Oltean 2022-05-17 7:11 ` Maxime Chevallier 2022-05-17 7:11 ` Maxime Chevallier 2022-05-16 2:51 ` Andrew Lunn 2022-05-16 2:51 ` Andrew Lunn 2022-05-17 7:13 ` Maxime Chevallier 2022-05-17 7:13 ` Maxime Chevallier 2022-05-17 21:03 ` Christophe JAILLET 2022-05-17 21:03 ` Christophe JAILLET 2022-05-14 15:06 ` [PATCH net-next v2 2/5] net: dsa: add out-of-band tagging protocol Maxime Chevallier 2022-05-14 15:06 ` Maxime Chevallier 2022-05-14 16:33 ` Florian Fainelli 2022-05-14 16:33 ` Florian Fainelli 2022-05-17 7:06 ` Maxime Chevallier 2022-05-17 7:06 ` Maxime Chevallier 2022-05-14 22:40 ` Vladimir Oltean 2022-05-14 22:40 ` Vladimir Oltean 2022-05-17 7:01 ` Maxime Chevallier 2022-05-17 7:01 ` Maxime Chevallier 2022-05-19 14:52 ` Vladimir Oltean 2022-05-19 14:52 ` Vladimir Oltean 2022-05-19 17:11 ` Florian Fainelli 2022-05-19 17:11 ` Florian Fainelli 2022-05-19 17:34 ` Vladimir Oltean 2022-05-19 17:34 ` Vladimir Oltean 2022-05-16 19:20 ` Jakub Kicinski 2022-05-16 19:20 ` Jakub Kicinski 2022-05-17 6:53 ` Maxime Chevallier 2022-05-17 6:53 ` Maxime Chevallier 2022-05-17 20:58 ` Jakub Kicinski 2022-05-17 20:58 ` Jakub Kicinski 2022-05-14 15:06 ` [PATCH net-next v2 3/5] net: ipqess: Add out-of-band DSA tagging support Maxime Chevallier 2022-05-14 15:06 ` Maxime Chevallier 2022-05-14 15:06 ` [PATCH net-next v2 4/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Maxime Chevallier 2022-05-14 15:06 ` Maxime Chevallier 2022-05-18 0:52 ` Rob Herring 2022-05-18 0:52 ` Rob Herring 2022-05-14 15:06 ` [PATCH net-next v2 5/5] ARM: dts: qcom: ipq4019: Add description for the " Maxime Chevallier 2022-05-14 15:06 ` Maxime Chevallier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yn/kWG7X1YCPk17F@shell.armlinux.org.uk \ --to=linux@armlinux.org.uk \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=hkallweit1@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luka.perkov@sartura.hr \ --cc=maxime.chevallier@bootlin.com \ --cc=netdev@vger.kernel.org \ --cc=robert.marko@sartura.hr \ --cc=robh+dt@kernel.org \ --cc=thomas.petazzoni@bootlin.com \ --cc=vladimir.oltean@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.