All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liviu Dudau <liviu.dudau@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Carsten Haitzler <carsten.haitzler@foss.arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	carsten.haitzler@arm.com, soc@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] arm64: defconfig: Enable modules for arm displays
Date: Tue, 10 May 2022 21:06:52 +0100	[thread overview]
Message-ID: <YnrF3Nc7NbcX6v3b@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <YnqTTy7P5IEC6no/@sirena.org.uk>

On Tue, May 10, 2022 at 05:31:11PM +0100, Mark Brown wrote:
> On Tue, May 10, 2022 at 05:19:04PM +0100, Liviu Dudau wrote:
> > On Tue, May 10, 2022 at 03:05:21PM +0100, Carsten Haitzler wrote:
> 
> > > is it the:
> 
> > > [    7.471809] tda9950 0-0034: driver requires an interrupt
> 
> > > that you're talking about Liviu?
> 
> > Yes, that is the warning.
> 
> That doesn't look too worrying TBH, if it's causing confusion we should
> just either fix the tda998x driver to not instantiate the tda9950 unless
> it has an interrupt or lower the severity of the log message in the
> tda9950 code.  It's certanly not something that should block use in a
> defconfig.
> 
> Ideally we'd not be using the wildcard compatible in the tda998x and
> would know if the CEC functionality was there but I think that ship has
> disappeared over the horizon at this point, and in any case someone
> might just not want to support CEC for some reason.

The quickest way is to harmonise the treatment of IRQs between tda998x and tda9950.
The former treats the IRQ as optional, the later as mandatory. Given that (according
to comments in the code) TDA998X is actually a TDA9989+TDA9950, it makes sense to
treat the lack of IRQ the same way (make it optional, IMHO).

I agree that that should not block adding the two config options to the defconfig.
It's just that using Juno as an argument for doing so when tda9950 returns ENXIO on
that platform can confuse people.

Best regards,
Liviu

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

WARNING: multiple messages have this Message-ID (diff)
From: Liviu Dudau <liviu.dudau@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Carsten Haitzler <carsten.haitzler@foss.arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	carsten.haitzler@arm.com, soc@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] arm64: defconfig: Enable modules for arm displays
Date: Tue, 10 May 2022 21:06:52 +0100	[thread overview]
Message-ID: <YnrF3Nc7NbcX6v3b@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <YnqTTy7P5IEC6no/@sirena.org.uk>

On Tue, May 10, 2022 at 05:31:11PM +0100, Mark Brown wrote:
> On Tue, May 10, 2022 at 05:19:04PM +0100, Liviu Dudau wrote:
> > On Tue, May 10, 2022 at 03:05:21PM +0100, Carsten Haitzler wrote:
> 
> > > is it the:
> 
> > > [    7.471809] tda9950 0-0034: driver requires an interrupt
> 
> > > that you're talking about Liviu?
> 
> > Yes, that is the warning.
> 
> That doesn't look too worrying TBH, if it's causing confusion we should
> just either fix the tda998x driver to not instantiate the tda9950 unless
> it has an interrupt or lower the severity of the log message in the
> tda9950 code.  It's certanly not something that should block use in a
> defconfig.
> 
> Ideally we'd not be using the wildcard compatible in the tda998x and
> would know if the CEC functionality was there but I think that ship has
> disappeared over the horizon at this point, and in any case someone
> might just not want to support CEC for some reason.

The quickest way is to harmonise the treatment of IRQs between tda998x and tda9950.
The former treats the IRQ as optional, the later as mandatory. Given that (according
to comments in the code) TDA998X is actually a TDA9989+TDA9950, it makes sense to
treat the lack of IRQ the same way (make it optional, IMHO).

I agree that that should not block adding the two config options to the defconfig.
It's just that using Juno as an argument for doing so when tda9950 returns ENXIO on
that platform can confuse people.

Best regards,
Liviu

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-10 20:07 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 12:55 [PATCH] arm64: defconfig: Enable modules for arm displays carsten.haitzler
2022-05-09 12:55 ` carsten.haitzler
2022-05-10 11:15 ` Sudeep Holla
2022-05-10 11:15   ` Sudeep Holla
2022-05-10 11:27   ` Mark Brown
2022-05-10 11:27     ` Mark Brown
2022-05-10 11:56     ` Robin Murphy
2022-05-10 11:56       ` Robin Murphy
2022-05-10 12:01       ` Sudeep Holla
2022-05-10 12:01         ` Sudeep Holla
2022-05-10 12:07     ` Sudeep Holla
2022-05-10 12:07       ` Sudeep Holla
2022-05-10 12:34       ` Carsten Haitzler
2022-05-10 12:34         ` Carsten Haitzler
2022-05-10 14:51         ` Sudeep Holla
2022-05-10 14:51           ` Sudeep Holla
2022-05-10 14:53           ` Carsten Haitzler
2022-05-10 14:53             ` Carsten Haitzler
2022-05-10 12:55   ` Liviu Dudau
2022-05-10 12:55     ` Liviu Dudau
2022-05-10 13:05     ` Mark Brown
2022-05-10 13:05       ` Mark Brown
2022-05-10 14:05       ` Carsten Haitzler
2022-05-10 14:05         ` Carsten Haitzler
2022-05-10 16:19         ` Liviu Dudau
2022-05-10 16:19           ` Liviu Dudau
2022-05-10 16:31           ` Mark Brown
2022-05-10 16:31             ` Mark Brown
2022-05-10 20:06             ` Liviu Dudau [this message]
2022-05-10 20:06               ` Liviu Dudau
2022-05-11 13:13               ` Mark Brown
2022-05-11 13:13                 ` Mark Brown
2022-05-11 13:15                 ` Carsten Haitzler
2022-05-11 13:15                   ` Carsten Haitzler
2022-05-11 11:00             ` Carsten Haitzler
2022-05-11 11:00               ` Carsten Haitzler
  -- strict thread matches above, loose matches on Subject: below --
2022-04-27 11:42 carsten.haitzler
2022-04-27 11:42 ` carsten.haitzler
2022-05-09 14:34 ` Arnd Bergmann
2022-05-09 14:34   ` Arnd Bergmann
2022-05-10 12:42   ` Carsten Haitzler
2022-05-10 12:42     ` Carsten Haitzler
2022-01-28 10:07 carsten.haitzler
2022-01-28 10:07 ` carsten.haitzler
2022-04-21 12:09 ` Carsten Haitzler
2022-04-21 12:09   ` Carsten Haitzler
2022-04-21 12:18   ` Krzysztof Kozlowski
2022-04-21 12:18     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnrF3Nc7NbcX6v3b@e110455-lin.cambridge.arm.com \
    --to=liviu.dudau@arm.com \
    --cc=broonie@kernel.org \
    --cc=carsten.haitzler@arm.com \
    --cc=carsten.haitzler@foss.arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=soc@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.